aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-ndmp.c
AgeCommit message (Collapse)AuthorFilesLines
2007-03-27Fix a warning in packet-bittorrent.c I didn't fix right the first time and ↵Stephen Fisher1-1/+1
try to get the Win32 buildbot going again in packet-ndmp.c. svn path=/trunk/; revision=21238
2007-03-11Fix bug 552:Jeff Morriss1-34/+34
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=552 by enforcing that header fields have names of length > 0. This should fix the display of those fields and also make them filterable (which was the subject of the bug). Abbreviations are (still) optional: if they are empty then the field is not filterable. Update README.developer with this information. Add header field names in several dissectors where they were missing. In packet-arp.c give "packet-storm-detected" a name (as above) but also set it as _GENERATED. Also remove trailing white space from all the files checked in. svn path=/trunk/; revision=21018
2006-10-31change the signature for the get_pdu_len() function pointer passed to ↵Ronnie Sahlberg1-1/+1
tcp_dissect_pdus() to also include a packet_info pointer. there are many reasons why some protocols actually need to be able to access the pinfo structure while determining the pdu size svn path=/trunk/; revision=19751
2006-10-14set both read/write flags in ndmp scsi and also always set the expected ↵Ronnie Sahlberg1-0/+6
length to whatever length is transported inside the ndmp pdu this fixes a regression caused by the recent scsi data in/out reassembly code which made the scsi dissector fail to dissect data in/out over ndmp correctly if scsi reassembly was enabled svn path=/trunk/; revision=19525
2006-10-13pass the relative data offset of data in/out pdu's to the scsi data in/out ↵Ronnie Sahlberg1-1/+3
dissector (dissect_scsi_payload) so that we can later add reassembly of data pdu's and also (if reassembly is disabled) only dissect the initial (offset==0) data pdu. dissect_scsi_payload() does not yet use this parameter. now that we have both data offset and expected data length/bidir expected data length and also the read/write flags availabe we have what we need to reassemble data in/out pdus (modulo overflow/underflow but those are so rare we can worry about them later). ndmp: ndmp conceptually always has a data in and a data out phase and never fragment the data into smaller pdu's os that dissector always report offset as 0. svn path=/trunk/; revision=19511
2006-10-12wireshark does not yet consume enough memory for me to be happyRonnie Sahlberg1-0/+3
pass conversation form the transports up to the scsi layer add tracking of conversation specific info to scsi osd add tracking of conversation+lun specific info to scsi osd for scsi osd add tracking of PARTITIONS and display in which frame they were created/removed svn path=/trunk/; revision=19505
2006-10-11add a task_flags bitmap and two lengths (data and bidirectional data)Ronnie Sahlberg1-0/+3
so that the two scsi transports FCP and ISCSI can provide the expected data transfer lengths to SCSI to allow SCSI reassembly. NDMP does not really need these hints since for NDMP (and also iscsi-lite) there is conceptually always both data in and data out phases and there is never any fragmentation. svn path=/trunk/; revision=19493
2006-10-11move the ITL and the ITLQ structure to packet-scsi.h where it belongsRonnie Sahlberg1-1/+0
svn path=/trunk/; revision=19492
2006-09-30add an extra_data pointer to the itlq structure where specific ↵Ronnie Sahlberg1-0/+1
commandsets/cdbs can hang additional data that are unique to that commandset/cdb make the scsi osd service action and getsetattributetype use this facility furhter enhancements to scsi osd svn path=/trunk/; revision=19374
2006-08-14rename some structures and defines from the se_tree to the emem_tree prefixRonnie Sahlberg1-4/+4
svn path=/trunk/; revision=18894
2006-07-10Two more bugs from Ilja van Sprundel.Gerald Combs1-11/+11
packet-ndmp.c: Fix our payload length check. packet-nfs.c: Check for a maximum bitmap length. Fix up whitespace. svn path=/trunk/; revision=18699
2006-06-30from aaron christensenRonnie Sahlberg1-1/+14
fix dissection of get_auth_attr svn path=/trunk/; revision=18619
2006-06-17allocate the correct size of buffer to store the itlq structure for scsiRonnie Sahlberg1-1/+1
we used the wrong size which caused emem to complain that the canary value had been stomped upon. another win for the canary feature. thanks gerald svn path=/trunk/; revision=18491
2006-06-17make ndmp track itl structuresRonnie Sahlberg1-6/+32
everytime a ndmp_[scsi|tape]_open is seen create a new itl we need an itl structure to be able to know what commandset a certain device is using. svn path=/trunk/; revision=18490
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=18196
2006-05-09Make top_tree static. This allows ethereal to be built on Mac OS X.Michael Tüxen1-1/+1
svn path=/trunk/; revision=18113
2006-05-08use request/response tracking structure from NDMP and hang a scsi itlq nexus ↵Ronnie Sahlberg1-32/+35
off it so that cdb/datain/dataout/response tracking for scsi forks also for the ndmp transport. svn path=/trunk/; revision=18105
2006-05-08add tracking of request/response and responsetime to ndmpRonnie Sahlberg1-0/+69
we need this in order to be able to provide proper itlq structures to the scsi dissector so that response data from scsi is dissected properly. svn path=/trunk/; revision=18104
2006-04-26add tracking of ndmp conversations and use this to track the version used if ↵Ronnie Sahlberg1-45/+64
we have seen the CONNECT_OPEN request. rename the preference to DEFAULT protocol version to indicate it is only used for those conversation where we have not automatically detected the version used. svn path=/trunk/; revision=18003
2006-04-26 NOTIFY_[DATA|MOVER]_HALTED requests no longer take an XDR string containing ↵Ronnie Sahlberg1-4/+29
the reason for version 4 of ndmp and forward. svn path=/trunk/; revision=18002
2006-04-24change the signature for dissect_scsi_snsinfo() to take itlq and itl structuresRonnie Sahlberg1-1/+11
update the comment in packet-scsi.c to reflect that it is the transport now that is responsible to track itl and itlq data make scsi tapable svn path=/trunk/; revision=17974
2006-04-22the scsi transports (fc/fcp and iscsi) now track both itl and itlqRonnie Sahlberg1-13/+0
structures for scsi. we no longer need the scsi_task_id structure passed by pinfo->private_data so get rid of it. we no longer need the (broken by design) scsi_task_data hash table since this has been replaced byt hte itl and itlq structures and tracking svn path=/trunk/; revision=17952
2006-04-21remover the lun parameter from dissect_scsi_cdb/payload since this is now ↵Ronnie Sahlberg1-2/+21
part of the exchange data in itlq remove the two fields opcode and devtype from the scsi_task_data structure since these are also part of the itlq and itl structures svn path=/trunk/; revision=17949
2006-04-21updates to get the fc and scsi dissectorsRonnie Sahlberg1-2/+2
and get rid of some breakage in the design let the scsi transport keep track of itl (initiator, target, lun) matching and let it pass a itl structure to scsi that is persistent across packets. let scsi use this itl structure to track device type for a specific itl instead of the (must have been) broken hashtable. update both iscsi and fc to track the itl structure for scsi and schange the scsi signature to accept itl as a parameter. more to come. svn path=/trunk/; revision=17942
2006-04-07make dissect_scsi_rsp() take an exchange structure as parameter instead of ↵Ronnie Sahlberg1-0/+1
just a lun. this finally allows us to have scsi.time for scsi transactions but we need to cleanup and refactor the other three scsi entrypoints before we should implement scsi srt to make the other three also take an exchange data structure as parameter from their transports (and get rid of the pinfo->private_data ) svn path=/trunk/; revision=17838
2006-03-20waste a couple of bytes per tcp conversation and make the tree for ↵Ronnie Sahlberg1-0/+1
acked_packets (i.e. packets that have interesting tcp properties such as being retransmissions etc) hang off the per conversation tcpd struct instead of being global. while this should improve performance by unmeasurably little it does have the sideeffect that once we finish the rewrite tcp analysis might actually work and work well even for tcp over tcp tunnelling. this also means that if you include packet-tcp.h you also need to include emem.h . svn path=/trunk/; revision=17681
2005-09-28fix #480: Change defaults for all reassembling settings to ONUlf Lamping1-1/+1
I've changed all settings I could find to TRUE. It might be reasonable to change some protocol settings back to FALSE, if reassembling fails very often. svn path=/trunk/; revision=16048
2005-09-17Move some headers for stuff defined by a dissector into epan/dissectorsGuy Harris1-9/+7
- and rename smb.h to packet-smb.h, as it's packet-smb.c's header file. svn path=/trunk/; revision=15845
2005-09-17Move a pile of protocol-related headers from the top-level sourceGuy Harris1-1/+1
directory to the epan directory. Some of them should perhaps ultimately be moved to epan/dissectors, if they pertain only to stuff exported by a particular dissector. Fix Gerald's e-mail address in files we're moving. svn path=/trunk/; revision=15844
2005-08-05More char -> const char warning fixesJörg Mayer1-1/+1
svn path=/trunk/; revision=15218
2005-05-29remove offset and len from the signature of dissect_scsi_payload()Ronnie Sahlberg1-2/+13
svn path=/trunk/; revision=14473
2005-05-29make all callers of dissect_scsi_cdb() first create a new subset tvbRonnie Sahlberg1-1/+11
change the signature for dissect_scsi_cdb since we no longer need to pass offset over. svn path=/trunk/; revision=14472
2005-05-12Fix a routine to return the value it's supposed to return.Guy Harris1-0/+1
svn path=/trunk/; revision=14354
2005-04-29add the missing MODE field in mover_get_state that was introduced in version 4.Ronnie Sahlberg1-5/+13
also change bytes_left_to_read to be a INT64 and not a UINT64. It iss supposed to be an UINT64 but some implementations are buggy and it is easier to make sense of this field one for those buggy clients if it is printed as an INT64. This change/violation will not affect any correct/valid NDMP implementation or how ethereal decodes its output unless your entire backup is > 2**63 bytes in size. svn path=/trunk/; revision=14228
2005-04-14fix bug in parsing of NDMP_DATA_CONNECT messages, it is a ndmp_address ↵Ronnie Sahlberg1-1/+10
passed to this function not an ndmp_address_type. svn path=/trunk/; revision=14071
2005-04-04the definition of tcp address structure changed between version 3 and version 4Ronnie Sahlberg1-6/+66
make version 4 dissect tcp addr structure properly svn path=/trunk/; revision=14012
2005-02-23fix printout of length of ndmp pduRonnie Sahlberg1-1/+1
svn path=/trunk/; revision=13478
2005-02-17pass lun (and status) to scsi subdissector so we can filterRonnie Sahlberg1-3/+6
on scsi.lun and prettify the summary line a bit. ndmp still needs some work to track luns between commands and fcp needs verification it works for volumesetaddressing. svn path=/trunk/; revision=13420
2005-02-09Move the following files from /trunk to /trunk/epan:Lars Roland1-1/+1
asn1.[ch] follow.[ch] ptvcursor.[ch] reassemble.[ch] xmlstub.[ch] fix #include statements accordingly. svn path=/trunk/; revision=13366
2005-02-02From Jon Ringle:Anders Broman1-3/+3
1) Added a setup_frame parameter to conversation_t 2) Used the conversation_t next to maintain a list of conversations with the same src/dest tuple but different setup_frame number. 3) Changed the signature of find_conversation() and conversation_new() to pass in the frame number. 4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image are present, and T.38 conversation if only m=image is present. I expect that RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 packets. svn path=/trunk/; revision=13243
2004-12-18make ndmp use tcp_dissect_pdus()Ronnie Sahlberg1-63/+101
so that it will track pdu boundaries properly not tracking pdu boundaries caused pain since it would miss too many commands svn path=/trunk/; revision=12769
2004-10-06Properly reject packets that don't look like NDMP packets.Guy Harris1-4/+9
svn path=/trunk/; revision=12216
2004-09-27Move prefs.c and prefs.h into the epan subdirectory.Guy Harris1-1/+1
svn path=/trunk/; revision=12115
2004-08-21Prevent the word "desegmentation" at the GUI, but use reassembling at that ↵Ulf Lamping1-4/+5
places, as we also use "defragmentation" and "reassembling". Use reassembling as the general term for such actions. I (hopefully) didn't changed any protocol fields or preference file names, but only the GUI labels appearing in the protocol display and the protocol preferences. Also added a note to the protocol preferences (where appropriate), that you have to enable "Allow subdissectors to reassemble TCP streams" at the corresponding protocol settings for TCP reassembling to take effect. If you encounter any mistakes I've made here, please let me know... svn path=/trunk/; revision=11784
2004-07-18Move dissectors to epan/dissectors directory.Gilbert Ramirez1-0/+3493
Also move ncp222.py, x11-fields, process-x11-fields.pl, make-reg-dotc, and make-reg-dotc.py. Adjust #include lines in files that include packet-*.h files. svn path=/trunk/; revision=11410