aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-mswsp.c
AgeCommit message (Collapse)AuthorFilesLines
2023-08-28Fix some spelling errorsMartin Mathieson1-1/+1
2023-08-22Do some more value_string checksMartin Mathieson1-2/+2
2023-05-21More tools/check_typed_item_calls.py fussingMartin Mathieson1-1/+1
2021-12-19Replace g_strdup_printf() with ws_strdup_printf()João Valverde1-1/+1
Use macros from inttypes.h.
2021-12-19Fix dissector -Wrestrict warningsJoão Valverde1-1/+3
[31/254] Building C object epan/dissectors/CMakeFiles/dissectors.dir/packet-bssgp.c.o /home/jpv/code/wireshark/wireshark/epan/dissectors/packet-bssgp.c: In function ‘de_bssgp_cell_id’: /home/jpv/code/wireshark/wireshark/epan/dissectors/packet-bssgp.c:859:9: warning: ‘snprintf’ argument 4 overlaps destination object ‘add_string’ [-Wrestrict] 859 | snprintf(add_string, string_len, "%s, CI %u", add_string, ci); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/jpv/code/wireshark/wireshark/epan/dissectors/packet-bssgp.c: In function ‘de_bssgp_rim_routing_inf’: /home/jpv/code/wireshark/wireshark/epan/dissectors/packet-bssgp.c:2313:17: warning: ‘snprintf’ argument 4 overlaps destination object ‘add_string’ [-Wrestrict] 2313 | snprintf(add_string, string_len, " %s, RNC-ID %u", add_string, rnc_id); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/jpv/code/wireshark/wireshark/epan/dissectors/packet-bssgp.c: In function ‘de_bssgp_rnc_identifier’: /home/jpv/code/wireshark/wireshark/epan/dissectors/packet-bssgp.c:2767:9: warning: ‘snprintf’ argument 4 overlaps destination object ‘add_string’ [-Wrestrict] 2767 | snprintf(add_string, string_len, " %s, RNC-ID %u", add_string, rnc_id); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [85/254] Building C object epan/dissectors/CMakeFiles/dissectors.dir/packet-gsm_a_bssmap.c.o /home/jpv/code/wireshark/wireshark/epan/dissectors/packet-gsm_a_bssmap.c: In function ‘be_cell_id_type’: /home/jpv/code/wireshark/wireshark/epan/dissectors/packet-gsm_a_bssmap.c:1842:21: warning: ‘snprintf’ argument 4 overlaps destination object ‘add_string’ [-Wrestrict] 1842 | snprintf(add_string, string_len, "%s/RNC-ID (%u)", add_string, value); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/jpv/code/wireshark/wireshark/epan/dissectors/packet-gsm_a_bssmap.c:1869:17: warning: ‘snprintf’ argument 4 overlaps destination object ‘add_string’ [-Wrestrict] 1869 | snprintf(add_string, string_len, "%s/CI (%u)", add_string, value); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [137/254] Building C object epan/dissectors/CMakeFiles/dissectors.dir/packet-mswsp.c.o /home/jpv/code/wireshark/wireshark/epan/dissectors/packet-mswsp.c: In function ‘get_name_from_fullpropspec’: /home/jpv/code/wireshark/wireshark/epan/dissectors/packet-mswsp.c:2975:25: warning: ‘snprintf’ argument 4 overlaps destination object ‘dest’ [-Wrestrict] 2975 | snprintf(dest, bufsize, "%s <INVALID>", dest); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2021-12-19Replace g_snprintf() with snprintf() (dissectors)João Valverde1-9/+9
Use macros from inttypes.h with format strings.
2021-09-28guids: wmem-scope lookupsEvan Huus1-3/+3
Avoids the use of the global unprotected packet memory pool and lets the compiler enforce scoping.
2021-07-29wsutil: rename bytestring_to_str() -> bytes_to_str_punct()João Valverde1-1/+1
2021-07-11More mask checks and some fixes.Martin Mathieson1-1/+1
2021-04-20MS-WSP: Don't allocate huge amounts of memory.Gerald Combs1-9/+9
Add a couple of memory allocation sanity checks, one of which fixes #17331.
2020-12-22Detect and replace bad allocation patternsMoshe Kaplan1-1/+1
Adds a pre-commit hook for detecting and replacing occurrences of `g_malloc()` and `wmem_alloc()` with `g_new()` and `wmem_new()`, to improve the readability of Wireshark's code, and occurrences of `g_malloc(sizeof(struct myobj) * foo)` with `g_new(struct myobj, foo)` to prevent integer overflows Also fixes all existing occurrences across the codebase.
2020-10-05Only parse CRangeCategSpec record for CATEGORIZE_UNIQUE typeNoel Power1-1/+8
parse_CCategSpec was incorrectly always parsing the CRangeCategSpec record, this record however is optional depending on the value of CategType. (see MS-WSP 2.2.1.21) Signed-off-by: Noel Power <noel.power@suse.com>
2020-09-28Fix some more wrong filter names.Martin Mathieson1-3/+3
These are duplicates detected seen by running check_typed_item_calls.py --consecutive. There are still quite a few more to go.
2020-09-13More dissector string spelling fixes.Martin Mathieson1-2/+2
Finally, it is becoming difficult to find more.
2020-08-31More spelling fixes, part 2 of 2nd pass of dissectors.Martin Mathieson1-1/+1
There will likely be one for for this pass. Further improvements to the script are possible, i.e. filtering out (usually filter) strings such as 'onetwothree' - may not be worth it though.
2020-08-29Fix more spelling errors in dissector strings.Martin Mathieson1-3/+3
A second batch of spelling errors, detected using a script that uses pyspellcheck and a Wireshark-specific dictionary file. I will take at least one more pass through the dissectors, as further improvements are made to the script.
2020-06-19Fix the type of arrays of pointers to hf_ values for bitfield routines.Guy Harris1-1/+1
The static arrays are supposed to be arrays of const pointers to int, not arrays of non-const pointers to const int. Fixing that means some bugs (scribbling on what's *supposed* to be a const array) will be caught (see packet-ieee80211-radiotap.c for examples, the first of which inspired this change and the second of which was discovered while testing compiles with this change), and removes the need for some annoying casts. Also make some of those arrays static while we're at it. Update documentation and dissector-generator tools. Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc Reviewed-on: https://code.wireshark.org/review/37517 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-05-07Replace instances of wmem_alloc with wmem_newMoshe Kaplan1-1/+1
This commit replaces instances of (myobj *)wmem_alloc(wmem_file_scope(), sizeof(myobj)) and replaces them with: wmem_new(wmem_file_scope(), myobj) to improve the readability of Wireshark's code. The replacement locations were identified with grep and replaced with the Python script below. grep command: egrep "wmem_alloc0?\(wmem_file_scope\(\), sizeof\([a-z_]+\)\)" . -R -l python script: import re import sys import fileinput pattern = r'\(([^\s]+) ?\*\) ?wmem_alloc(0?)\((wmem_[a-z]+_scope\(\)), sizeof\(\1\)\)' replacewith = r'wmem_new\2(\3, \1)' fname = sys.argv[1] for line in fileinput.input(fname, inplace=1, mode='rb'): output = re.sub(pattern, replacewith, line) sys.stdout.write(output) Change-Id: Ieac246c104bf01e32cbc6e11e53e81c7f639d870 Reviewed-on: https://code.wireshark.org/review/37158 Petri-Dish: Pascal Quantin <pascal@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>
2019-08-18mswsp: check pipe name in case insensitive mannerJiajun Wang1-1/+1
Change-Id: I33cde794a3a7314247b46b6e8fded6ee528450cc Reviewed-on: https://code.wireshark.org/review/34304 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-27HTTPS In Still More Places, update more URLs.Guy Harris1-1/+4
Microsoft reshuffled their documentation - almost all of it moved from msdn.microsoft.com to docs.microsoft.com. Some blogs moved to devblogs.microsoft.com; the comments *didn't* move, so in one case we go to the Wayback Machine - the link isn't dead, but it formats horribly, at least on my browser, but the archived version formats OK. Use the Wayback Machine for some URLs, and update others. Update the sections for MS-ADTS. Point to the HTML versions of some RFCs and I-Ds. Change-Id: I344b20f880de63f1ae2a4e3f9ff98af78a7fe139 Reviewed-on: https://code.wireshark.org/review/34101 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-05-18mswsp: fix typoAlexis La Goutte1-1/+1
unknow -> unknown Change-Id: Idd858b7dc321f255fa56fdec955662f6c2cd1cb4 Reviewed-on: https://code.wireshark.org/review/33249 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-09-23mswsp: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+0
Change-Id: Id521ecbdbaa1818b6480d9fcd4257104dc3699bb Reviewed-on: https://code.wireshark.org/review/29774 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-09Fix handling of invalid type values.Guy Harris1-185/+99
If vType_get_type() returns NULL, that means that the packet is bad, not that the dissector is bad. Report it as such. Bug: 15119 Change-Id: I8e66fcece2b526ef9edbf948862f8fc5bea25d74 Reviewed-on: https://code.wireshark.org/review/29511 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-10mswsp: Align parse_CAggregSpec function with MS-WSP specification.Noel Power1-27/+70
Fix some errors in the parsing of the CAggregSpec structure, see 2.2.1.24 in the MS-WSP specification. Change-Id: Ib281c10ab897e5c0282aa1b0d304df97a2fd14a3 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-on: https://code.wireshark.org/review/20036 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-10mswsp: Numerous bugfixesNoel Power1-20/+11
1. Fix display of CTableColumn.StatusUsed & CTableColumn.LengthUsed Both StatusUsed and LenghtUsed members were displayed as 2 byte length values instead of single byte values. 2. Fix minor spelling mistake 3. display correct address(s) for array of address values 4. Use correct minimum CTableColumn size This is followup patch for patch already provided for bug 13299. The previous minimum value neglated to take into account the CFullPropSpec structure (which is on the wire) but is represtented as a string in the internal CTableColumn structure. Note: this doesn't make any difference to the effectiveness of the previous patch but should avoid confusion if someone later actually investigates the correct minimum size. 5. Fix CPMCREATEQUERY message parsing Following a query and subsequent clarification from dochelp@microsoft.com the MS-WSP specification document was found to be incorrect. CPMCreateQueryIn | ---> CSortSet should instead eventually point to CSortSet via the following msg structure CPMCreateQueryIn | ---> CInGroupSortAggregSets | ---> CInGroupSortAggregSet | ---> CSortSet Change-Id: I7da6c7db817113f5542f25f078626030ad30d737 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-on: https://code.wireshark.org/review/20031 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-07Make column size sanity check more sensible.Noel Power1-1/+3
The existing sanity check on column_size makes incorrect assumptions about the size of the CTableColumn structure (which is an internal dissector structure that contains optional data). The sanity check test *always* fails. This change uses the minimum size of CTableColumn structure instead which should prevent excessive allocation during fuzz testing. Bug: 13299 Change-Id: Id9fcbc15a4df4c74bb7576c6fdca1000890947fd Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-on: https://code.wireshark.org/review/19566 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-21Add proto_tree_add_checksum.Michael Mann1-2/+1
This is an attempt to standardize display/handling of checksum fields for all dissectors. The main target is for dissectors that do validation, but dissectors that just report the checksum were also included just to make them easier to find in the future. Bug: 10620 Bug: 12058 Ping-Bug: 8859 Change-Id: Ia8abd86e42eaf8ed50de6b173409e914b17993bf Reviewed-on: https://code.wireshark.org/review/16380 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-20Convert some g_ APIs to wmem.Michael Mann1-28/+3
Change-Id: I7fb0b60fc54004326680f07298fe43e8c48e9b39 Reviewed-on: https://code.wireshark.org/review/16550 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-06-27tvb_get_string_enc + proto_tree_add_item = proto_tree_add_item_ret_stringMichael Mann1-18/+13
Also some other tricks to remove unnecessary tvb_get_string_enc calls. Change-Id: I2f40d9175b6c0bb0b1364b4089bfaa287edf0914 Reviewed-on: https://code.wireshark.org/review/16158 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-17mswsp: Remove null check (CID1355407)João Valverde1-10/+1
value->type is already asserted as not null (and probably shouldn't be). Change-Id: I574d3e7e0d5c636e6b731c1c817f2e457447afc1 Reviewed-on: https://code.wireshark.org/review/15990 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-05-17tvb_get_ptr + wmem_alloc = tvb_memdupMichael Mann1-2/+1
Change-Id: Iee33c59d5b032f3c99ba16338195c050e8078329 Reviewed-on: https://code.wireshark.org/review/15472 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-04-15Check first, then allocate.Guy Harris1-5/+32
While we're at it, the MS-WSP spec says that the array size is unsigned, and sizeof is always unsigned, so do unsigned arithmetic when doing the multiplication, so we don't have to worry about overflowing the maximum int size. Bug: 12341 Change-Id: Ic68d35bc75330571ef1daa244e8c94cb955955ca Reviewed-on: https://code.wireshark.org/review/14935 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-22Fix some hf_ field datatype conflicts.Michael Mann1-3/+3
'ieee17221.clock_source_id' exists multiple times with NOT compatible types: FT_UINT16 and FT_UINT64 'ieee17221.stream_format' exists multiple times with NOT compatible types: FT_NONE and FT_UINT64 'afp.unknown' exists multiple times with NOT compatible types: FT_UINT16 and FT_BYTES 'afp.toc_offset' exists multiple times with NOT compatible types: FT_NONE and FT_UINT64 'bootp.client_id.iaid' exists multiple times with NOT compatible types: FT_UINT32 and FT_STRING 'bthfp.chld.mode' exists multiple times with NOT compatible types: FT_STRING and FT_UINT8 'canopen.pdo.data' exists multiple times with NOT compatible types: FT_STRINGZ and FT_BYTES 'canopen.sdo.data' exists multiple times with NOT compatible types: FT_UINT32 and FT_BYTES 'ceph.msg.' exists multiple times with NOT compatible types: FT_UINT32 and FT_UINT64 'ceph.version' exists multiple times with NOT compatible types: FT_UINT16 and FT_UINT64 'cip.linkaddress' exists multiple times with NOT compatible types: FT_STRING and FT_UINT8 'dnp3.al.ana' exists multiple times with NOT compatible types: FT_FLOAT and FT_INT32 'dnp3.al.anaout' exists multiple times with NOT compatible types: FT_FLOAT and FT_INT32 'dtls.handshake.cert_url.url_hash_len' exists multiple times with NOT compatible types: FT_STRING and FT_UINT16 'ssl.handshake.cert_url.url_hash_len' exists multiple times with NOT compatible types: FT_STRING and FT_UINT16 'dvb-s2_gse.label' exists multiple times with NOT compatible types: FT_UINT24 and FT_ETHER 'fcdns.rply.fc4type' exists multiple times with NOT compatible types: FT_NONE and FT_UINT8 'fcdns.req.fc4type' exists multiple times with NOT compatible types: FT_NONE and FT_UINT8 'icmp.int_info.name' exists multiple times with NOT compatible types: FT_STRING and FT_BOOLEAN 'icmpv6.ilnp.nb_locs' exists multiple times with NOT compatible types: FT_UINT64 and FT_UINT8 'icmpv6.ilnp.nb_locs' exists multiple times with NOT compatible types: FT_UINT32 and FT_UINT64 'mausb.clear_transfers.status' exists multiple times with NOT compatible types: FT_BOOLEAN and FT_NONE 'mikey.v' exists multiple times with NOT compatible types: FT_BOOLEAN and FT_NONE 'mswsp.rangeboundry.ultype' exists multiple times with NOT compatible types: FT_STRING and FT_UINT32 'mswsp.arrayvector.address64' exists multiple times with NOT compatible types: FT_UINT32 and FT_UINT64 'nlm.lock.l_offset' exists multiple times with NOT compatible types: FT_UINT32 and FT_UINT64 'nlm.lock.l_len' exists multiple times with NOT compatible types: FT_UINT32 and FT_UINT64 'pflog.saddr' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 'pflog.daddr' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 'pflog.saddr' exists multiple times with NOT compatible types: FT_BYTES and FT_IPv6 'pflog.daddr' exists multiple times with NOT compatible types: FT_BYTES and FT_IPv6 'pgm.spm.path' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 'pgm.nak.src' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 'pgm.nak.grp' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 'pgm.poll.path' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 'pgm.opts.ccdata.acker' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 'pgm.opts.ccdata.acker' exists multiple times with NOT compatible types: FT_IPv4 and FT_IPv6 'pgm.opts.ccdata.acker' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 'pgm.opts.redirect.dlr' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 Change-Id: Iaf694699d108a12db172da8dd9fbab211adb329d Reviewed-on: https://code.wireshark.org/review/14070 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-25Move the proto data stuff out of frame_data.[ch].Guy Harris1-0/+1
It's not tied to the frame_data structure any more, so it belongs by itself. Clean up some #includes while we're at it; in particular, frame_data.h doesn't use anything related to tvbuffs, so don't have it gratuitiously include tvbuff.h. Change-Id: Ic32922d4a3840bac47007c5d4c546b8842245e0c Reviewed-on: https://code.wireshark.org/review/13518 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-24Add the packet number to the packet_info structure, and use it.Guy Harris1-3/+3
That removes most of the uses of the frame number field in the frame_data structure. Change-Id: Ie22e4533e87f8360d7c0a61ca6ffb796cc233f22 Reviewed-on: https://code.wireshark.org/review/13509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-26Sanity check column size to prevent allocating an unrealistic amount of memory.Michael Mann1-2/+14
Bug: 11931 Change-Id: I19fa2937a649382b3a2eda2c8192246e3e9d9e28 Reviewed-on: https://code.wireshark.org/review/12874 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-10packet-smb2: provide reassembling support for Named Pipe subdissectors (e.g. ↵Stefan Metzmacher1-1/+1
DCERPC) Change-Id: Ie6f28fd749219ddadc53820f94866e91cca297cb Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-on: https://code.wireshark.org/review/11596 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-08-18Init values set (found by American Fuzzy Lop).Dario Lombardo1-2/+2
Change-Id: Iddd2b4a0ceb409db1afb1a412339134634de631c Reviewed-on: https://code.wireshark.org/review/10104 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-08-01MS-WSP: fix some Coverity warningsPascal Quantin1-7/+6
- prevent some NULL pointer deference pointer - remove DISSECTOR_ASSERT calls: it should be used only for dissector bugs - replace g_slist_next macro calls as the NULL pointer checks are already performed in the for loop Change-Id: If4efd5bb055c7806107ec9646e9864c7e345246d Reviewed-on: https://code.wireshark.org/review/9843 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-07-31MSWSP: Fix clang warnings and handle gracefully needed missing messagesNoel Power1-21/+40
In addition to fixing some clang warnings code now handles the scenario where some needed messages may be missing in the capture, instead of silently ignoring now tell how many bytes we can't dissect and why. Change-Id: Ia6fd70d204d279799bc02209865c7f1da35d8191 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-on: https://code.wireshark.org/review/9824 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-07-28MSWSP: Enhance dissectorAlexis La Goutte1-280/+164
* Use a value_string for display OS version * Remove unused pref modules * Remove boiteplate comment * Use boolean for TRUE/FALSE * Replace parseBoolean by proto_tree_add_bitmask * Remove unneed #include * Fix indent * ... Change-Id: I007dc2a92e8c8f8a9a921c2c091e6c9276f1873b Reviewed-on: https://code.wireshark.org/review/9806 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-07-26MSWSP: Remove usage of stdbool.hAlexis La Goutte1-21/+20
For fix build on Solaris "/usr/include/stdbool.h", line 42: #error: "Use of <stdbool.h> is valid only in a c99 compilation environment." Replace bool -> gboolean Replace true -> TRUE, false -> FALSE (for fix Wcompat error..) Change-Id: Ia3f39bfbbaf7cf35a916eb37edfc6745ea50ad36 Reviewed-on: https://code.wireshark.org/review/9793 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2015-07-26MSWSP: Try to fix Mac OS X BuildbotAlexis La Goutte1-3/+3
Change-Id: I0c7bd3ea3900630ce4516cb00e6400cca353b672 Reviewed-on: https://code.wireshark.org/review/9794 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2015-07-25MSWSP: Initial implementation of MS-WSP (windows search protocol) dissectorGregor Beck1-0/+8211
This changeset is a forward port of Gregors ms-wsp branch from his repo http://repo.or.cz/w/wireshark-wip.git. Most of the messages of the MS-WSP protocol are implemented here and as such consists of the majority of the changes for the dissector. In addition to the forward porting Gregors work I added some extra bits 1) cater for SMB2 Read Response and Write Request msgs that can also contain MSWSP messages 2) update property specifications with info extracted from MS-WSP protocol doc 3) store some basic data about previously seen messages that are needed for dissecting CPMGetRows request 4) expand/update dissect_CPMSetBindings & parse_CTableColumn routines 5) parse and store CTableColumn & CPMSetBindingsIn structures in conversation related data for use later. 6) fully dissect/parse SeekDesciption of CPMGetRowsOut 7) dissect CPMGetRows out message specifically the Rows & Columns 8) flesh out the boolean properties of uBooleanOptions field 9) flesh out various other dissectors: CPMRatioFinished CPMRestartPosition CPMCompareBmkIn/CPMCompareBmkOut CPMGetApproximatePosition CPMGetSendNotifyOut FindIndicesIn/Out FetchValue Bug: 11321 Change-Id: I68b5c2f3e63874c1dbb271feab89b2b8aa65ac39 Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-on: https://code.wireshark.org/review/9440 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-08 13:52:29 +0000