Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a
Reviewed-on: https://code.wireshark.org/review/25756
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Several calls to proto_tree_add_uint_format_value could be better served
using BASE_UNIT_STRING with a "unit string" in hf_ field. There also
a few cases where proto_tree_add_uint_format_value could just be
proto_tree_add_uint.
Added a few more "common" unit string values to unit_strings.[ch]
Change-Id: Iaedff82c515269c9c31ab9100dff19f5563c932d
Reviewed-on: https://code.wireshark.org/review/19242
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Change-Id: If3970fbc25d4085037fb975498de02449e2c25c1
Reviewed-on: https://code.wireshark.org/review/16317
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Found by checkhf.pl
Change-Id: If985d04f24a188ac402bc11cf61d29aa418ad242
Reviewed-on: https://code.wireshark.org/review/16314
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Change-Id: I9ec492c90e22813f6336130a875b9bca7179af6a
Reviewed-on: https://code.wireshark.org/review/14580
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|
|
Base it on the DEC specification, not on whatever the Linux DECNET
people managed to reverse-engineer.
Change-Id: I60586f52e35f9f61e4aed93f315bfaceebe68cce
Reviewed-on: https://code.wireshark.org/review/14579
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|
|
This saves many dissectors the need to find the data dissector and store a handle to it.
There were also some that were finding it, but not using it.
For others this was the only reason for their handoff function, so it could be eliminated.
Change-Id: I5d3f951ee1daa3d30c060d21bd12bbc881a8027b
Reviewed-on: https://code.wireshark.org/review/14530
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Change-Id: I3e2fad7f0307e599802c37040b34c899efb0e603
Reviewed-on: https://code.wireshark.org/review/13328
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
[-Wmissing-prototypes]
Change-Id: Ifac7943f909fdb73395824f7bb6925476edc8cff
Reviewed-on: https://code.wireshark.org/review/13181
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
(If it turns out that there is a need, I'll fix the code to remove the
need.)
Use BASE_NONE for string fields, and reformat the hf[] array a bit.
Change-Id: I62805e3054266589c3fa25a0047ea3e7114484d6
Reviewed-on: https://code.wireshark.org/review/13141
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
|
|
Change-Id: Ic9104ddba17797a3e541cebd4326035e874b27de
Reviewed-on: https://code.wireshark.org/review/13143
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|
|
proto_item_get_len() is *not* guaranteed to return a correct value.
Even if there's a non-null tree item, it might be pointing to a "faked"
item; it really shouldn't be used.
So add proto_tree_add_item_ret_length() and
proto_tree_add_item_new_ret_length(), which calculate the real length
themselves and return it through a pointer.
Fix as many places as we straightforwardly can to use them rather than
to use proto_item_get_len(). (There's a Lua API for
proto_item_get_len(), so we keep it around, but we should add Lua APIs
for the new routines, and deprecate the old API.)
Fix ptvcursor_add() to do the same thing that
proto_tree_add_item_ret_length() and
proto_tree_add_item_new_ret_length() do.
Split the TRY_TO_FAKE_THIS_ITEM macros into a macro to check for the
tree being null and to try to fake the item. We don't always use the
former macro, as we might need to do more than just return NULL if the
incoming tree is null (for example, calculating the item's real length
and using it...).
new_field_info() never returns NULL; remove checks for it. The check
for a null tree is done before the calls to new_field_info().
Change-Id: I002a218d1f810c73e0de837e0ac6ebcde21bacec
Reviewed-on: https://code.wireshark.org/review/13139
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|
|
Change-Id: Id8acd15334650ce07de9991fadf3a0c8c09cddcc
Reviewed-on: https://code.wireshark.org/review/13126
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
Change-Id: I693eabbba3f9140bccb9a5e490633ba139f13193
Reviewed-on: https://code.wireshark.org/review/13129
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|
|
Change-Id: I938152dc6f3ee8b17e4c1463249d326efd29266f
Reviewed-on: https://code.wireshark.org/review/13127
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|
|
Change-Id: Ic6086d0dcbda425aee362d31b1b939d50ed85011
Reviewed-on: https://code.wireshark.org/review/13123
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|
|
More to dissect, if somebody has the time and energy.
Change-Id: I27eca69f141ec391b48d03398f54a8c4b6ecf39f
Reviewed-on: https://code.wireshark.org/review/13122
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|
|
As I said, 15 years. :-)
Change-Id: Iaca3805547b0a822d160b87cb2b8ff453839db00
Reviewed-on: https://code.wireshark.org/review/13120
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|
|
Change-Id: Ic115862d4bf9f2847c768cd539d83883e32eeed2
Reviewed-on: https://code.wireshark.org/review/13119
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|
|
Only 15 years later:
https://www.wireshark.org/lists/ethereal-dev/200010/msg00070.html
as I clean up stuff I've had lying around for a while.
LAT spec found at bitsavers.org; further work can use that.
Change-Id: I486e4ab1ffb74d6e0b323202514cc352d63e9eef
Reviewed-on: https://code.wireshark.org/review/13118
Reviewed-by: Guy Harris <guy@alum.mit.edu>
|