Age | Commit message (Collapse) | Author | Files | Lines |
|
svn path=/trunk/; revision=53741
|
|
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470)
I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do.
The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As.
All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data.
svn path=/trunk/; revision=53520
|
|
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster.
- same for replace col_append_fstr and col_append_str
- remove col_clear() when it's redundant:
+ before a col_set/col_add if the dissector can't throw an exception.
- replace col_append() after a col_clear() with faster col_add... or col_set
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344
svn path=/trunk/; revision=52948
|
|
svn path=/trunk/; revision=52591
|
|
svn path=/trunk/; revision=52055
|
|
hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly.
The script didn't catch as many as I would have liked, but it's a start.
The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum.
svn path=/trunk/; revision=52045
|
|
svn path=/trunk/; revision=51852
|
|
proto_tree_add_expert_format, where applicable.
svn path=/trunk/; revision=50377
|
|
svn path=/trunk/; revision=49938
|
|
svn path=/trunk/; revision=49596
|
|
svn path=/trunk/; revision=49259
|
|
makes the TDMoE dissector call the LAPD bitstream dissector on the D-Channel. As a result, LAPD calls Q.931, and you can actually see call setup and tear down, instead of just a hex dump.
It adds a preference for which channel the D-Channel is.
It patches the LAPD code to fix a few bugs, not pass the checksum to Q.931 (who isn't expecting it), to register the lapd-bitstream dissector, and to mark packets with aborts or resets.
also storing more data on the lapd_byte_state_t.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8374
svn path=/trunk/; revision=48743
|
|
remove C++ incompatibilities
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416
svn path=/trunk/; revision=48425
|
|
Take negative value into account, avoid all casting in the process.
svn path=/trunk/; revision=47223
|
|
svn path=/trunk/; revision=45984
|
|
svn path=/trunk/; revision=45017
|
|
svn path=/trunk/; revision=44664
|
|
(COPYING will be updated in next commit)
svn path=/trunk/; revision=43536
|
|
multiple times.
svn path=/trunk/; revision=40444
|
|
Also: remove trailing whitespace for a number of files.
svn path=/trunk/; revision=39503
|
|
This time keep the tvb routines in epan.
Now we can use common crc routines outside epan.
svn path=/trunk/; revision=38810
|
|
svn path=/trunk/; revision=38803
|
|
This way we can use the crc routines in wiretap.
svn path=/trunk/; revision=38800
|
|
svn path=/trunk/; revision=37716
|
|
svn path=/trunk/; revision=35779
|
|
Add support for LAPD data link type.
svn path=/trunk/; revision=35771
|
|
keys to have _uint in their names, to match the routines that handle
dissector tables with string keys. (Using _port can confuse people into
thinking they're intended solely for use with TCP/UDP/etc. ports when,
in fact, they work better for things such as Ethernet types, where the
binding of particular values to particular protocols are a lot
stronger.)
svn path=/trunk/; revision=35224
|
|
svn path=/trunk/; revision=34227
|
|
svn path=/trunk/; revision=32367
|
|
svn path=/trunk/; revision=31559
|
|
check_col.diff
Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394
svn path=/trunk/; revision=31519
|
|
svn path=/trunk/; revision=29446
|
|
svn path=/trunk/; revision=29344
|
|
svn path=/trunk/; revision=29340
|
|
svn path=/trunk/; revision=28989
|
|
http://wiki.wireshark.org/Development/Optimization
svn path=/trunk/; revision=28356
|
|
svn path=/trunk/; revision=27996
|
|
Also: whiule we're at it:
- fix hf[] blurbs as appropriate to use NULL;
- fix some indentation
svn path=/trunk/; revision=27890
|
|
DLT_LINUX_LAPD.
Clean up white space.
svn path=/trunk/; revision=27216
|
|
svn path=/trunk/; revision=27157
|
|
svn path=/trunk/; revision=26307
|
|
epan/dissectors/packet-ncp2222.inc is a bit hard to fix, so we're not
ready to enable that warning by default yet.
Throw in some casts to handle GLib routines that take arbitrary
non-const pointers (they can later return the pointers, and some
callers might want to modify or free up those pointers in cases where
they're known to be writable or allocated).
Use ep_tvb_memdup() rather than a combination of ep_alloc() and
tvb_memcpy().
Clean up some indentation.
svn path=/trunk/; revision=25601
|
|
The attached patch extends LAPD dissector to handle LAPD frames sent as RTP payload.
svn path=/trunk/; revision=25381
|
|
svn path=/trunk/; revision=23462
|
|
svn path=/trunk/; revision=22912
|
|
svn path=/trunk/; revision=22845
|
|
packet-lapd.c change on 2006-03-02 (17452) by etxrab swaps SRC/DST for the default case
And added a comment to Q.931
svn path=/trunk/; revision=19275
|
|
Fix some C++ comments in C source files and fixes some non-constant initializations.
svn path=/trunk/; revision=18521
|
|
svn path=/trunk/; revision=18196
|
|
libpcap. The support has already been included in libpcap.
The patch adds a new wiretap encapsulation, the necessary glue to decode
SLL-encapsulated frames, and some minor change in the LAPD dissector in order
to support the remote-to-remote frames captured on the ISDN E-Channel.
Please apply ethereal-encap-table.diff before, as it fixes a misalignment in
the encapsulation names table.
svn path=/trunk/; revision=17452
|