aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-lapd.c
AgeCommit message (Collapse)AuthorFilesLines
2013-12-03Try to fix [-Wmissing-prototypes]Anders Broman1-0/+2
svn path=/trunk/; revision=53741
2013-11-23Create the ability to have packet scoped "proto" data. Bug 9470 ↵Michael Mann1-3/+3
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470) I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do. The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As. All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data. svn path=/trunk/; revision=53520
2013-10-29From didier gautheron: remove redundant or use faster col_xxx functionsBill Meier1-1/+1
- when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster. - same for replace col_append_fstr and col_append_str - remove col_clear() when it's redundant: + before a col_set/col_add if the dissector can't throw an exception. - replace col_append() after a col_clear() with faster col_add... or col_set https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344 svn path=/trunk/; revision=52948
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-1/+1
svn path=/trunk/; revision=52591
2013-09-15More wmem conversion (leaving uat related functions aside)Pascal Quantin1-4/+5
svn path=/trunk/; revision=52055
2013-09-15Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if ↵Michael Mann1-2/+2
hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly. The script didn't catch as many as I would have liked, but it's a start. The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum. svn path=/trunk/; revision=52045
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-1/+1
svn path=/trunk/; revision=51852
2013-07-03expert_add_info_format_text + proto_tree_add_text = ↵Michael Mann1-13/+4
proto_tree_add_expert_format, where applicable. svn path=/trunk/; revision=50377
2013-06-14Removed check_col() and the occasional tree.Michael Mann1-2/+1
svn path=/trunk/; revision=49938
2013-05-27Batch of filterable expert infosMichael Mann1-5/+15
svn path=/trunk/; revision=49596
2013-05-12Add the posibillity to use a key for per-packet-data.Anders Broman1-3/+3
svn path=/trunk/; revision=49259
2013-04-05From Tim Ringenbach:Anders Broman1-23/+65
makes the TDMoE dissector call the LAPD bitstream dissector on the D-Channel. As a result, LAPD calls Q.931, and you can actually see call setup and tear down, instead of just a hex dump. It adds a preference for which channel the D-Channel is. It patches the LAPD code to fix a few bugs, not pass the checksum to Q.931 (who isn't expecting it), to register the lapd-bitstream dissector, and to mark packets with aborts or resets. also storing more data on the lapd_byte_state_t. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8374 svn path=/trunk/; revision=48743
2013-03-19From beroset:Anders Broman1-5/+5
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48425
2013-01-23Fix for CID 280286:Jaap Keuter1-1/+1
Take negative value into account, avoid all casting in the process. svn path=/trunk/; revision=47223
2012-11-09Append TEI to info field.Anders Broman1-0/+8
svn path=/trunk/; revision=45984
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-08-25cleanup g_malloc memory leaksMichael Mann1-4/+4
svn path=/trunk/; revision=44664
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-01-12Don't do fcn calls in arg of g_?to??(); Macro may very well eval args ↵Bill Meier1-1/+2
multiple times. svn path=/trunk/; revision=40444
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-08-31Second try to move crc routines to libwsutil.Stig Bjørlykke1-1/+1
This time keep the tvb routines in epan. Now we can use common crc routines outside epan. svn path=/trunk/; revision=38810
2011-08-30Revert r38800, as the crc routines contains some tvb functions.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=38803
2011-08-30Move all crc routines to libwsutil.Stig Bjørlykke1-1/+1
This way we can use the crc routines in wiretap. svn path=/trunk/; revision=38800
2011-06-19Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.Bill Meier1-2/+1
svn path=/trunk/; revision=37716
2011-02-03Get rid of extra blank line at the end of the file.Guy Harris1-1/+0
svn path=/trunk/; revision=35779
2011-02-02From njohnkev:Jaap Keuter1-0/+1
Add support for LAPD data link type. svn path=/trunk/; revision=35771
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-5/+5
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-09-23Replace blurbs that match the name (case insensitive) with NULL.Jeff Morriss1-18/+18
svn path=/trunk/; revision=34227
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
2010-01-18Fix some gcc -Wshadow warnings ....Bill Meier1-13/+13
svn path=/trunk/; revision=31559
2010-01-13From Didier Gautheron:Anders Broman1-4/+2
check_col.diff Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394 svn path=/trunk/; revision=31519
2009-08-16Switch a bunch of dissectors over to using tvb_new_subset_remaining()Kovarththanan Rajaratnam1-1/+1
svn path=/trunk/; revision=29446
2009-08-09Don't guard col_clear with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29344
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-07-07Changed flags_set_truth -> tfs_set_notsetStig Bjørlykke1-4/+4
svn path=/trunk/; revision=28989
2009-05-13Apply some of the patches from:Anders Broman1-2/+1
http://wiki.wireshark.org/Development/Optimization svn path=/trunk/; revision=28356
2009-04-08(Trivial) Fix some spelling & etc in commentsBill Meier1-1/+1
svn path=/trunk/; revision=27996
2009-03-29Define certain fcns as static (if not used externally).Bill Meier1-39/+44
Also: whiule we're at it: - fix hf[] blurbs as appropriate to use NULL; - fix some indentation svn path=/trunk/; revision=27890
2009-01-13Don't display the direction if it's unknown, and set the direction forGuy Harris1-27/+39
DLT_LINUX_LAPD. Clean up white space. svn path=/trunk/; revision=27216
2009-01-05Remove duplicate definitions found in lapd_sapi.hJaap Keuter1-5/+0
svn path=/trunk/; revision=27157
2008-09-30Minor cleanup related to proto_register, proto_reg_handoffBill Meier1-18/+16
svn path=/trunk/; revision=26307
2008-06-25Constify a bunch of stuff, to squelch -Wwrite-strings warnings. Guy Harris1-2/+2
epan/dissectors/packet-ncp2222.inc is a bit hard to fix, so we're not ready to enable that warning by default yet. Throw in some casts to handle GLib routines that take arbitrary non-const pointers (they can later return the pointers, and some callers might want to modify or free up those pointers in cases where they're known to be writable or allocated). Use ep_tvb_memdup() rather than a combination of ep_alloc() and tvb_memcpy(). Clean up some indentation. svn path=/trunk/; revision=25601
2008-05-26From Balint Reczey:Jaap Keuter1-21/+320
The attached patch extends LAPD dissector to handle LAPD frames sent as RTP payload. svn path=/trunk/; revision=25381
2007-11-15Add a generated lapd.direction field/filter.Martin Mathieson1-0/+18
svn path=/trunk/; revision=23462
2007-09-19Make it possible to use GSM SAPI:sAnders Broman1-19/+68
svn path=/trunk/; revision=22912
2007-09-11Update valuestrings and comments.Anders Broman1-3/+4
svn path=/trunk/; revision=22845
2006-09-21Fix for bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1106Anders Broman1-2/+2
packet-lapd.c change on 2006-03-02 (17452) by etxrab swaps SRC/DST for the default case And added a comment to Q.931 svn path=/trunk/; revision=19275
2006-06-20From Albert Chin:Anders Broman1-2/+2
Fix some C++ comments in C source files and fixes some non-constant initializations. svn path=/trunk/; revision=18521
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=18196
2006-03-02The attached patch adds support for LAPD frames captured using vISDN thru Anders Broman1-14/+59
libpcap. The support has already been included in libpcap. The patch adds a new wiretap encapsulation, the necessary glue to decode SLL-encapsulated frames, and some minor change in the LAPD dissector in order to support the remote-to-remote frames captured on the ISDN E-Channel. Please apply ethereal-encap-table.diff before, as it fixes a misalignment in the encapsulation names table. svn path=/trunk/; revision=17452