aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-jxta.c
AgeCommit message (Collapse)AuthorFilesLines
2011-11-09Fix a number of proto_tree_add_item() encoding args.wmeier1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39774 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵wmeier1-19/+19
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39426 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-10Fix a benign bug in proto_tree_add_item() 'encoding' arg.wmeier1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39341 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-10 Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵wmeier1-5/+5
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39328 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵wmeier1-4/+4
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39288 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵wmeier1-4/+4
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39260 f5534014-38df-0310-8fa8-9805f1628bb7
2011-04-12Don't assign to a proto_item * if the value won't be used: Coverity 954 & 955;wmeier1-14/+9
Remove some unneeded #includes; Minor whitespace cleanup. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36589 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-08If the lack of a peer conversation is a bug, use one of theguy1-9/+7
dissector-bug macros. If it's just that we're missing some packets, we should handle that as best we can and, if there's stuff we can't do, maybe put something into the protocol summary or tree saying "not enough information". Don't just spit out a warning message which the user might not even see. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35426 f5534014-38df-0310-8fa8-9805f1628bb7
2010-05-13As suggested in ↵morriss1-10/+1
http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html (as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 : Write a new convenience routine for finding a conversation and, if it is not found, create it. The frame number and addresses are taken from pinfo (as is the common case). Use this function in a bunch of dissectors. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32790 f5534014-38df-0310-8fa8-9805f1628bb7
2010-04-03Remove unneeded #include <stdio.h>wmeier1-1/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32367 f5534014-38df-0310-8fa8-9805f1628bb7
2009-10-09From Didier Gautheron:etxrab1-3/+3
Dissectors using call_dissector() function inside a 'if (tree) {}' block. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4107 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30415 f5534014-38df-0310-8fa8-9805f1628bb7
2009-09-06Rename address_to_str() to ep_address_to_str() because:krj1-12/+12
1) This indicates that the string has ephemeral lifetime 2) More consistent with its existing seasonal counterpart, se_address_to_str(). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29747 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-16Switch a bunch of dissectors over to using tvb_new_subset_remaining()krj1-8/+8
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29446 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-09Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_checkkrj1-12/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29345 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-07Changed flags_set_truth -> tfs_set_notsetstig1-11/+11
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28989 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-07From Kovarththanan Rajaratnam:stig1-220/+220
Move hf/ett into proto_register_jxta() and do some field cleanup git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28984 f5534014-38df-0310-8fa8-9805f1628bb7
2009-06-24From Kovarththanan Rajaratnam:stig1-2/+2
More hf_register_info related cleanup. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28832 f5534014-38df-0310-8fa8-9805f1628bb7
2009-05-14Apply some of the patches from:etxrab1-2/+1
http://wiki.wireshark.org/Development/Optimization git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28363 f5534014-38df-0310-8fa8-9805f1628bb7
2009-04-06Fix compiler warning/errorssfisher1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27969 f5534014-38df-0310-8fa8-9805f1628bb7
2009-04-06More size_t casts/fixes, and string buffers.gerald1-40/+35
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27968 f5534014-38df-0310-8fa8-9805f1628bb7
2009-01-17Use ascii_strdown_inplace instead of g_ascii_strdown in a few places.wmeier1-5/+3
This also fixes a few cases where memory was not freed after g_ascii_strdown. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27254 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-27Minor rework related to proto_reg_handoffwmeier1-9/+6
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26588 f5534014-38df-0310-8fa8-9805f1628bb7
2008-06-25Constify a bunch of stuff, to squelch -Wwrite-strings warnings. guy1-1/+1
epan/dissectors/packet-ncp2222.inc is a bit hard to fix, so we're not ready to enable that warning by default yet. Throw in some casts to handle GLib routines that take arbitrary non-const pointers (they can later return the pointers, and some callers might want to modify or free up those pointers in cases where they're known to be writable or allocated). Use ep_tvb_memdup() rather than a combination of ep_alloc() and tvb_memcpy(). Clean up some indentation. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25601 f5534014-38df-0310-8fa8-9805f1628bb7
2008-04-07- Remove GLIB1 codesfisher1-5/+0
- Change ugly GLIB version checking statements to GLIB_CHECK_VERSION - Remove ws_strsplit files because we no longer need to borrow GLIB2's g_strsplit code for the no longer supported GLIB1 builds git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24829 f5534014-38df-0310-8fa8-9805f1628bb7
2008-03-02Added missing array for hf_jxta_element2_encodingid.stig1-0/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24530 f5534014-38df-0310-8fa8-9805f1628bb7
2008-01-29cleanup initial comment. fix urls and email addresses.bondolo1-6/+7
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24224 f5534014-38df-0310-8fa8-9805f1628bb7
2007-12-05git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23758 ↵bondolo1-12/+1
f5534014-38df-0310-8fa8-9805f1628bb7
2007-11-26Get rid of C++/C99 style comments--not all compilers support themmorriss1-37/+37
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23608 f5534014-38df-0310-8fa8-9805f1628bb7
2007-10-23Apply the small performance enhancment patches for:etxrab1-1/+1
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster. Replace - col_append_fstr() with faster col_append_str() - col_add_str() with col_set_str() when it's safe git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23252 f5534014-38df-0310-8fa8-9805f1628bb7
2007-10-02coverity 263 check if variable is null before dereferencing itsahlberg1-2/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23046 f5534014-38df-0310-8fa8-9805f1628bb7
2007-09-29"pinfo->match_string" is a "const char *"; save it into a variable ofguy1-1/+1
the same type - that makes compilers much happier. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23029 f5534014-38df-0310-8fa8-9805f1628bb7
2007-09-28Improves dissection of JXTA traffic from http connections. bondolo1-282/+360
Improved address display in packet summary panes. more options for jxta pdu filtering by addresses. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23019 f5534014-38df-0310-8fa8-9805f1628bb7
2007-08-21Fix a known- and marked-by-a-comment memory leak: replace g_strdup() with ↵morriss1-2/+1
se_strdup(). (The address in question is stored in a conversation structure so it's "seasonal".) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22579 f5534014-38df-0310-8fa8-9805f1628bb7
2007-08-21Change COPY_ADDRESS to SE_COPY_ADDRESS: all of these appear to have ↵morriss1-7/+7
"seasonal" scope (e.g., they are used in conversations or similar). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22573 f5534014-38df-0310-8fa8-9805f1628bb7
2007-04-14fix MacOSX gcc-3.3 warnings about unused tfs/value_string variablesstandel1-4/+0
most have been tagged unused (few have been deleted if dissector has not been modified since a long time) move packet-ssl-utils.c to DISSECTOR_SRC git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21431 f5534014-38df-0310-8fa8-9805f1628bb7
2007-04-03From Mike Duigou:richardv1-7/+7
The enclosed patch corrects a problem where jxta elements were being added to the protocol tree for segments that did not contain complete jxta frames. This patch ensures that the jxta proto elements are only added those the segments that end a complete, assembled jxta frame. The patch has been fuzz tested with a broad selection of jxta captures and ran successfully overnight for over 4000 iterations. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21305 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-28Remove almost all of the casts I committed recently and in place ofsfisher1-12/+12
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21253 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-27Fix about 100 simple to fix warnings from gcc 4.0 in epan/dissectors sfisher1-12/+12
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21233 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-24Clean up some more warnings: unused variables, unitialized variables, wrong ↵morriss1-24/+31
format (%ld instead of %d) in packet-sccp.c git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21167 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-23fix a lot more warningsulfl1-4/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21142 f5534014-38df-0310-8fa8-9805f1628bb7
2007-02-18From Mike Duigou:sfisher1-67/+572
Adds support for dissecting the new version 2 binary wire format messages. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20836 f5534014-38df-0310-8fa8-9805f1628bb7
2007-02-13From Sebastien Tandel:sfisher1-0/+1
Create two new files (ws_strsplit.[ch]) that use GTK2 code to override the buggy g_strsplit() function when compiling for GTK1. Include this work-around function (ws_strsplit) in libwireshark.def. Add notes on usage to README.developer. Include epan/ws_strsplit.h in all files that use g_strsplit(). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20804 f5534014-38df-0310-8fa8-9805f1628bb7
2007-01-29Fix potential buffer overruns in address_to_str_buf() found by Andrej gerald1-41/+41
Mikus. Add a buf_len parameter to ip_to_str_buf(), and make sure it's enforced. Copy the release notes over from the 0.99.5 trunk and add a note about the ISUP dissector (which is affected by the overrun). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20607 f5534014-38df-0310-8fa8-9805f1628bb7
2006-06-23coverity 172sahlberg1-1/+1
remove a dead code condition git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18565 f5534014-38df-0310-8fa8-9805f1628bb7
2006-05-21change a whole bunch of ethereal into wiresharksahlberg1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18196 f5534014-38df-0310-8fa8-9805f1628bb7
2006-05-01UDP and SCTP aren't byte-stream protocols, so they don't offer TCP-styleguy1-3/+106
reassembly. UDP has no notion of reassembly - that's done at the IP layer - and SCTP has its own notions of reassembly which it currently doesn't provide. As such, TCP-style reassembly isn't possible for JXTA-over-UDP or JXTA-over-SCTP. As for TCP, a heuristic dissector for a TCP-based protocol can't request more data if it's rejecting a packet; make it not do so. That should fix the recent buildbot crash, although there are still some reassembly problems with that capture (c05-http-reply-r1.pcap.gz in the menagerie and on the SampleCaptures page of the Wiki) that aren't fixed yet. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18049 f5534014-38df-0310-8fa8-9805f1628bb7
2006-03-23From Mike Duigou:etxrab1-19/+26
> I have improved the heuristics and the display tree building code in > dissect_jxta_udp() and dissect_jxta_stream() to avoid this problem. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17709 f5534014-38df-0310-8fa8-9805f1628bb7
2006-03-09don't use g_message() inside dissector codeulfl1-12/+12
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17557 f5534014-38df-0310-8fa8-9805f1628bb7
2006-03-08fix bug 772: and again, don't pass a NULL pointer to a printf like function ↵ulfl1-1/+1
on WIN32 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17535 f5534014-38df-0310-8fa8-9805f1628bb7
2006-02-13From Mike Duigou:etxrab1-124/+278
- Improves ability of dissector to find conversations without seeing whole stream. - Fixes some issues with dissection of data which requires reassembly. - Adds the ability to dissect jxta conversations from SCTP streams. - Better handling of welcome message. - Adds direct dissection of compressed SRDI data. - Has been run through extensive fuzz testing. - Fixes compiler warnings with previous patch 17141 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17282 f5534014-38df-0310-8fa8-9805f1628bb7
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-05 07:06:50 +0000