aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-jxta.c
AgeCommit message (Collapse)AuthorFilesLines
2009-07-07Changed flags_set_truth -> tfs_set_notsetstig1-11/+11
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28989 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-07From Kovarththanan Rajaratnam:stig1-220/+220
Move hf/ett into proto_register_jxta() and do some field cleanup git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28984 f5534014-38df-0310-8fa8-9805f1628bb7
2009-06-24From Kovarththanan Rajaratnam:stig1-2/+2
More hf_register_info related cleanup. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28832 f5534014-38df-0310-8fa8-9805f1628bb7
2009-05-14Apply some of the patches from:etxrab1-2/+1
http://wiki.wireshark.org/Development/Optimization git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28363 f5534014-38df-0310-8fa8-9805f1628bb7
2009-04-06Fix compiler warning/errorssfisher1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27969 f5534014-38df-0310-8fa8-9805f1628bb7
2009-04-06More size_t casts/fixes, and string buffers.gerald1-40/+35
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27968 f5534014-38df-0310-8fa8-9805f1628bb7
2009-01-17Use ascii_strdown_inplace instead of g_ascii_strdown in a few places.wmeier1-5/+3
This also fixes a few cases where memory was not freed after g_ascii_strdown. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27254 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-27Minor rework related to proto_reg_handoffwmeier1-9/+6
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26588 f5534014-38df-0310-8fa8-9805f1628bb7
2008-06-25Constify a bunch of stuff, to squelch -Wwrite-strings warnings. guy1-1/+1
epan/dissectors/packet-ncp2222.inc is a bit hard to fix, so we're not ready to enable that warning by default yet. Throw in some casts to handle GLib routines that take arbitrary non-const pointers (they can later return the pointers, and some callers might want to modify or free up those pointers in cases where they're known to be writable or allocated). Use ep_tvb_memdup() rather than a combination of ep_alloc() and tvb_memcpy(). Clean up some indentation. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25601 f5534014-38df-0310-8fa8-9805f1628bb7
2008-04-07- Remove GLIB1 codesfisher1-5/+0
- Change ugly GLIB version checking statements to GLIB_CHECK_VERSION - Remove ws_strsplit files because we no longer need to borrow GLIB2's g_strsplit code for the no longer supported GLIB1 builds git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24829 f5534014-38df-0310-8fa8-9805f1628bb7
2008-03-02Added missing array for hf_jxta_element2_encodingid.stig1-0/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24530 f5534014-38df-0310-8fa8-9805f1628bb7
2008-01-29cleanup initial comment. fix urls and email addresses.bondolo1-6/+7
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24224 f5534014-38df-0310-8fa8-9805f1628bb7
2007-12-05git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23758 ↵bondolo1-12/+1
f5534014-38df-0310-8fa8-9805f1628bb7
2007-11-26Get rid of C++/C99 style comments--not all compilers support themmorriss1-37/+37
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23608 f5534014-38df-0310-8fa8-9805f1628bb7
2007-10-23Apply the small performance enhancment patches for:etxrab1-1/+1
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster. Replace - col_append_fstr() with faster col_append_str() - col_add_str() with col_set_str() when it's safe git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23252 f5534014-38df-0310-8fa8-9805f1628bb7
2007-10-02coverity 263 check if variable is null before dereferencing itsahlberg1-2/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23046 f5534014-38df-0310-8fa8-9805f1628bb7
2007-09-29"pinfo->match_string" is a "const char *"; save it into a variable ofguy1-1/+1
the same type - that makes compilers much happier. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23029 f5534014-38df-0310-8fa8-9805f1628bb7
2007-09-28Improves dissection of JXTA traffic from http connections. bondolo1-282/+360
Improved address display in packet summary panes. more options for jxta pdu filtering by addresses. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23019 f5534014-38df-0310-8fa8-9805f1628bb7
2007-08-21Fix a known- and marked-by-a-comment memory leak: replace g_strdup() with ↵morriss1-2/+1
se_strdup(). (The address in question is stored in a conversation structure so it's "seasonal".) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22579 f5534014-38df-0310-8fa8-9805f1628bb7
2007-08-21Change COPY_ADDRESS to SE_COPY_ADDRESS: all of these appear to have ↵morriss1-7/+7
"seasonal" scope (e.g., they are used in conversations or similar). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22573 f5534014-38df-0310-8fa8-9805f1628bb7
2007-04-14fix MacOSX gcc-3.3 warnings about unused tfs/value_string variablesstandel1-4/+0
most have been tagged unused (few have been deleted if dissector has not been modified since a long time) move packet-ssl-utils.c to DISSECTOR_SRC git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21431 f5534014-38df-0310-8fa8-9805f1628bb7
2007-04-03From Mike Duigou:richardv1-7/+7
The enclosed patch corrects a problem where jxta elements were being added to the protocol tree for segments that did not contain complete jxta frames. This patch ensures that the jxta proto elements are only added those the segments that end a complete, assembled jxta frame. The patch has been fuzz tested with a broad selection of jxta captures and ran successfully overnight for over 4000 iterations. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21305 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-28Remove almost all of the casts I committed recently and in place ofsfisher1-12/+12
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21253 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-27Fix about 100 simple to fix warnings from gcc 4.0 in epan/dissectors sfisher1-12/+12
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21233 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-24Clean up some more warnings: unused variables, unitialized variables, wrong ↵morriss1-24/+31
format (%ld instead of %d) in packet-sccp.c git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21167 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-23fix a lot more warningsulfl1-4/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21142 f5534014-38df-0310-8fa8-9805f1628bb7
2007-02-18From Mike Duigou:sfisher1-67/+572
Adds support for dissecting the new version 2 binary wire format messages. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20836 f5534014-38df-0310-8fa8-9805f1628bb7
2007-02-13From Sebastien Tandel:sfisher1-0/+1
Create two new files (ws_strsplit.[ch]) that use GTK2 code to override the buggy g_strsplit() function when compiling for GTK1. Include this work-around function (ws_strsplit) in libwireshark.def. Add notes on usage to README.developer. Include epan/ws_strsplit.h in all files that use g_strsplit(). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20804 f5534014-38df-0310-8fa8-9805f1628bb7
2007-01-29Fix potential buffer overruns in address_to_str_buf() found by Andrej gerald1-41/+41
Mikus. Add a buf_len parameter to ip_to_str_buf(), and make sure it's enforced. Copy the release notes over from the 0.99.5 trunk and add a note about the ISUP dissector (which is affected by the overrun). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20607 f5534014-38df-0310-8fa8-9805f1628bb7
2006-06-23coverity 172sahlberg1-1/+1
remove a dead code condition git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18565 f5534014-38df-0310-8fa8-9805f1628bb7
2006-05-21change a whole bunch of ethereal into wiresharksahlberg1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18196 f5534014-38df-0310-8fa8-9805f1628bb7
2006-05-01UDP and SCTP aren't byte-stream protocols, so they don't offer TCP-styleguy1-3/+106
reassembly. UDP has no notion of reassembly - that's done at the IP layer - and SCTP has its own notions of reassembly which it currently doesn't provide. As such, TCP-style reassembly isn't possible for JXTA-over-UDP or JXTA-over-SCTP. As for TCP, a heuristic dissector for a TCP-based protocol can't request more data if it's rejecting a packet; make it not do so. That should fix the recent buildbot crash, although there are still some reassembly problems with that capture (c05-http-reply-r1.pcap.gz in the menagerie and on the SampleCaptures page of the Wiki) that aren't fixed yet. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18049 f5534014-38df-0310-8fa8-9805f1628bb7
2006-03-23From Mike Duigou:etxrab1-19/+26
> I have improved the heuristics and the display tree building code in > dissect_jxta_udp() and dissect_jxta_stream() to avoid this problem. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17709 f5534014-38df-0310-8fa8-9805f1628bb7
2006-03-09don't use g_message() inside dissector codeulfl1-12/+12
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17557 f5534014-38df-0310-8fa8-9805f1628bb7
2006-03-08fix bug 772: and again, don't pass a NULL pointer to a printf like function ↵ulfl1-1/+1
on WIN32 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17535 f5534014-38df-0310-8fa8-9805f1628bb7
2006-02-13From Mike Duigou:etxrab1-124/+278
- Improves ability of dissector to find conversations without seeing whole stream. - Fixes some issues with dissection of data which requires reassembly. - Adds the ability to dissect jxta conversations from SCTP streams. - Better handling of welcome message. - Adds direct dissection of compressed SRDI data. - Has been run through extensive fuzz testing. - Fixes compiler warnings with previous patch 17141 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17282 f5534014-38df-0310-8fa8-9805f1628bb7
2005-09-29From Mike Duigouetxrab1-18/+22
A patch to allow the JXTA dissector to pass fuzz testing. It also removes a couple of unused things and optimizes handling of the raw data dissector. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@16051 f5534014-38df-0310-8fa8-9805f1628bb7
2005-08-21From Mike Duigou:etxrab1-214/+286
A patch to the JXTA dissector. It's purpose is to improve the behaviour of the dissector when dissecting captures that do not include the whole conversation. The dissector is now more capable of isolating a conversation without seeing the beginning of the conversation. It's still not always able to pick up all conversations (suggestions, patches and hints welcome). improved some of the doxygen docs and comments. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15500 f5534014-38df-0310-8fa8-9805f1628bb7
2005-08-13some more gmemchunk -> se_alloc() updatessahlberg1-31/+2
there are only 5 gmemchunks left but they have different litetime for their allocations than the 100+ ones that have been removed. The remaining 5 should be converted some other way. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15328 f5534014-38df-0310-8fa8-9805f1628bb7
2005-08-10rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the ↵sahlberg1-4/+4
documentation in README.developer git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15270 f5534014-38df-0310-8fa8-9805f1628bb7
2005-08-08various code cleanup:ulfl1-4/+4
-use g_snprintf instead of sprintf and snprintf -use g_strdup_printf where appropriate -remove #include "snprintf.h" (as only g_snprintf should be used) -replace some more alloc/realloc/calloc/free with their glib pendants git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15264 f5534014-38df-0310-8fa8-9805f1628bb7
2005-07-29Include <epan/emem.h> to declare ep_alloc().guy1-0/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15136 f5534014-38df-0310-8fa8-9805f1628bb7
2005-07-28ememify some more tvb_get_string() callssahlberg1-17/+6
one memleak in vnc related to tvb_get_string() closed. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15130 f5534014-38df-0310-8fa8-9805f1628bb7
2005-06-20From Mike Duigou:etxrab1-178/+202
In order to get filtering of conversations and > endpoints to work from the endpoints and conversations windows I found > it necessary to add a new AT_URI address type and a SAT_JXTA. This also > necessitated a change to to_str.c to avoid a buffer overflow problem. > Please review these changes carefully. > > Also includes some changes to the jxta dissector to fix filtering on > generated fields and some changes to the types used for ints/unsigned ints. > > Fixes a bug with the processing of messages containing namespaces. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14716 f5534014-38df-0310-8fa8-9805f1628bb7
2005-06-16From Peter Kovar: fix an incorrect assignment that caused a compilationguy1-1/+1
error with GCC 4. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14660 f5534014-38df-0310-8fa8-9805f1628bb7
2005-06-16Squelch some unitialized variable warnings.guy1-3/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14652 f5534014-38df-0310-8fa8-9805f1628bb7
2005-06-10just to get things straight: a dissector should *never* do any g_assert() calls!ulfl1-5/+5
in a simple approach, I've replaced all g_assert() and g_assert_not_reached() calls by their exception throwing counterparts DISSECTOR_ASSERT() and DISSECTOR_ASSERT_NOT_REACHED() this will replace application crash by showing a dissector bug, which is the desired behaviour there were some g_assert calls in the protocol registering functions, which might not be acting as expected now, but to be able to simply search for g_assert in the future I've replaced that calls too one g_assert remained, the one when someone throws an unknown exception "into" packet_frame.c, but IMHO this one should remain. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14608 f5534014-38df-0310-8fa8-9805f1628bb7
2005-06-06From Mike Duigou:etxrab1-135/+185
a patch which adds support for displaying jxta conversations and endpoints from the 'Statistics' menu. Also adds : - a generated field to Welcome messages to indicate whether this welcome is from the initiator or the receiver. You can filter on this field with 'jxta.welcome.initiator==[0|1]' - Marks the source and destination fields of message added in the last patch as generated fields. (Saw it being done for some other protocol). - Cleans up dissection of Message which used to assume it would dissected more than one set of hdr/message per tvbuff. Now it only attempts to dissect one. - Uses GMemChunk for tap info and for conversation data rather than g_malloc() There's still a major leakage of g_malloc()ed the c-strings which are used in jxta addresses. Any suggestions for how these can be allocated such that they can be freed re-init is called would be appreciated. For address objects whose data ptr doesn't point into a tvbuff it's not clear what the lifecyle of an address object is. - Fixes a bug with filling in the of the transport layer conversation data. >= vs. > git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14558 f5534014-38df-0310-8fa8-9805f1628bb7
2005-06-03From Mike Duigou:etxrab1-31/+313
Extends the jxta dissector to add higher level conversation tracking, improved display, tapping and fixes a bug which caused some conversations to get lost. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14534 f5534014-38df-0310-8fa8-9805f1628bb7
2005-03-25jxta updatessahlberg1-9/+10
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13904 f5534014-38df-0310-8fa8-9805f1628bb7
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-02 01:59:39 +0000