aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-isobus-vt.c
AgeCommit message (Collapse)AuthorFilesLines
2021-08-27Some spelling fixes.Martin Mathieson1-2/+2
2021-08-27Isobus-VT: Fix description of auxiliary input status enable messageJeroen Sack1-2/+10
Show if message indicates that auxiliary input was enabled or disabled
2021-08-27Isobus: Change email addressJeroen Sack1-1/+1
Used my work email previously, but have not been working for them for a long time already.
2021-07-21First pass pinfo->pool conversion, part 2Evan Huus1-9/+9
Automated find/replace of wmem_packet_scope() with pinfo->pool in all files where it didn't cause a build failure.
2020-06-12More cppcheck fixes, using top-of-tree cppcheck.Martin Mathieson1-3/+1
Mostly redundant tests, but for bthci dissectors, avoid using a key that points to out-of-scope variables. Change-Id: I2785690b8487d45c4e2daff0b6e03cd8747ed410 Reviewed-on: https://code.wireshark.org/review/37467 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2020-05-16isobus-vt: update with information from the spec.Guy Harris1-1/+1
It's ISO 11783-6, and the spec agrees with the previous change. Change-Id: Iac8dd83a7844c59bcc1b74cd0712bc5f38b3ae43 Reviewed-on: https://code.wireshark.org/review/37218 Reviewed-by: Guy Harris <gharris@sonic.net>
2020-05-09More PVS-Studio issues flagged by Valerii Zapodovnikov.Martin Mathieson1-1/+2
/opt/SourceCode/wireshark/epan/dissectors/packet-frame.c 818 warn V547 Expression 'fi' is always true. /opt/SourceCode/wireshark/epan/dissectors/packet-gsm_sms.c 2692 warn V547 Expression 'length <= (offset - saved_offset)' is always false. /opt/SourceCode/wireshark/epan/dissectors/packet-isup.c 4688 warn V1037 Two or more case-branches perform the same actions. Check lines: 4688, 4697 /opt/SourceCode/wireshark/extcap/androiddump.c 1237 warn V560 A part of conditional expression is always true: data_str. /opt/SourceCode/wireshark/extcap/androiddump.c 1603 warn V547 Expression is always true. /opt/SourceCode/wireshark/ui/qt/models/packet_list_model.cpp 497 warn V560 A part of conditional expression is always true: ok_r1. For the voip_calls.c change, I preferred to initailize along with every other field, rather than set to actual value it gets set to later. For the isobus-vt change, I could not find a spec but followed the pattern from other error bit fields. Bug: 16335 Change-Id: Ie55082222b582f6fff4e8c7a992d863acee6cf15 Reviewed-on: https://code.wireshark.org/review/37160 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-05-26*Always* pair ENC_UTF_16 and ENC_UCS_2 with a byte order.Guy Harris1-3/+3
Big-endian and little-endian UTF-16 and UCS-2 aren't the same; always associate them with a byte order ENC_ flag, to clarify what byte order is being used. Yes, for big-endian, omitting the ENC_ flag, or using ENC_NA, *happens* to work, because ENC_BIG_ENDIAN and ENC_NA *happen* to be 0, but omitting ENC_BIG_ENDIAN doesn't make it sufficiently clear that it's UTF-16BE or UCS-2BE. Change-Id: Iecf7375763ce4922bd1b0676c9dc5a01731c2fec Reviewed-on: https://code.wireshark.org/review/33374 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-05-20isobus-vt: fix typoAlexis La Goutte1-2/+2
successfull -> successful Change-Id: I1617a087ababcaeb5ae5e5063354083260995496 Reviewed-on: https://code.wireshark.org/review/33272 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-04epan: Convert our PROTO_ITEM_ macros to inline functions.Gerald Combs1-75/+75
Convert our various PROTO_ITEM_ macros to inline functions and document them. Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c Reviewed-on: https://code.wireshark.org/review/32706 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-05Fix some spelling errors found by Lintian.Gerald Combs1-1/+1
Change-Id: If6fc3aab7ad4fc634567121f7b9541bc6f6c5766 Reviewed-on: https://code.wireshark.org/review/30926 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-17isobus-vt: fix issue found by PVS Studio (V523)Alexis La Goutte1-10/+2
The 'then' statement is equivalent to the 'else' statement. Change-Id: I49c50208933c00be8bc16b5b8de15ab85e8094f5 Reviewed-on: https://code.wireshark.org/review/27601 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-07isobus-vt: make sure to close the id file (CID-1413873)Jaap Keuter1-0/+2
Part of dissector init is reading the object ID file. This file should be closed afterwards to not leak the resource. Change-Id: Icf5e229315a2c1c61a169e576ec51d38a1c350a1 Reviewed-on: https://code.wireshark.org/review/24275 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
2017-09-10ISObus VT: fix a memory leak when using g_strsplitPascal Quantin1-0/+1
Change-Id: I8cfbca97b9b5915f0fe38eda1d73f5483481aca7 Reviewed-on: https://code.wireshark.org/review/23466 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-13Fix isobus-vt warning when compiling using checkhf-conflicts.Jeroen Sack1-1/+1
Bug: 13772 Change-Id: I9690b88096bbd4a3dc8f082f9f485166e517a4a6 Reviewed-on: https://code.wireshark.org/review/22111 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-12Add isobus dissectorJeroen Sack1-0/+6040
Bug: 13772 Change-Id: If7ddb10bfc8a1756e8ed00baaa8a28a7e2840a37 Reviewed-on: https://code.wireshark.org/review/21594 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-15 01:53:28 +0000