aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-isis-lsp.c
AgeCommit message (Collapse)AuthorFilesLines
2014-12-28Replace ip6_to_str and ip6_guint8_to_str with address_to_str and tvb_ip_to_str.Michael Mann1-1/+3
Change-Id: I1d258923a7a63539ec8456d3e306bca5016a1e4b Reviewed-on: https://code.wireshark.org/review/6060 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-26Replace ip_to_str with [ep_]address_to_str and tvb_ip_to_str.Michael Mann1-5/+5
Change-Id: I40d0c8253743183aecef252040b7dd6742ae5c71 Reviewed-on: https://code.wireshark.org/review/5934 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-2/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-19ISIS: Fix warning: '@return' command used in a comment that is attached to a ↵Alexis La Goutte1-1/+0
function returning void [-Wdocumentation] Change-Id: I7f20311125e369cc90df808772323e8e98f8c94e Reviewed-on: https://code.wireshark.org/review/5850 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-16ISIS LSP: Add Segment Routing Algorithm Sub TLV dissectionYann Lejeune1-1/+29
This commit implements a part of draft-ietf-isis-segment-routing-extensions: - 3.2. SR-Algorithm Sub-TLV Change-Id: Ibb419de234bf5a199f8067989b1321064fa93983 Ping-Bug: 10520 Reviewed-on: https://code.wireshark.org/review/5742 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-12-16ISIS LSP: Add Segment Routing Capabilities Sub-TLV dissectionYann Lejeune1-5/+101
This commit implements a part of draft-ietf-isis-segment-routing-extensions: - 3.1 Routing Capabilities Sub-TLV - 2.3 SID/Label Sub-TLV Change-Id: I3ee5e6d949cc6add412da761ffc55ef3101ddb97 Ping-Bug: 10520 Reviewed-on: https://code.wireshark.org/review/5739 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-12-13Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...Bill Meier1-21/+21
(for some dissectors which fetch all other integral fields using ENC_BIG_ENDIAN). Change-Id: Ic18e3172aad76af12b12d6732c88497be22aed56 Reviewed-on: https://code.wireshark.org/review/5748 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-09Eliminate proto_tree_add_text from some dissectors.Michael Mann1-21/+50
Change-Id: I44cc6b70ec4dfc565934da499f46fca60a4ded93 Reviewed-on: https://code.wireshark.org/review/5524 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-02Add dissection of IS-IS Router CAPABILITY TLV.AndersBroman1-7/+90
Bug 10520. Change-Id: I8d8d56e36d90088af3cd7d2490f95c5f87c75423 Reviewed-on: https://code.wireshark.org/review/4420 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-09-19Do encoding-arg changes (all benign)Bill Meier1-1/+1
For: - FT_BYTES: Always use just ENC_NA - integral/floating (other than FT_[U]INT8): Do ENC_NA --> ENC_BIG_ENDIAN Also: - FT_UINT... --> FT_UINT8 in a few cases (to match proto_tree_add_item...) - Change one case of incorrect '||' to '|' Change-Id: I427e0e61618ff8faf55691c8a695930f67d455b0 Reviewed-on: https://code.wireshark.org/review/4184 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-18Fix encoding-arg mostly for FT_UINT_STRING; Also: Do misc as needed.Bill Meier1-2/+2
Misc: (as needed) - Add editor modelines; - Adjust whitespace. Change-Id: I0e5d877a2a6273842ad8e771ac0c0acbfcb83200 Reviewed-on: https://code.wireshark.org/review/4173 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-08-25TRILL ISIS: SubTLVs of Router Capability TLV are valid for MT-Capability TLV ↵Marian Ďurkovič1-264/+161
as well Change-Id: Idf466c021b1b188d9c6d55ba73a25257ba352412 Reviewed-on: https://code.wireshark.org/review/3803 Petri-Dish: Evan Huus <eapache@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-08-22Parse Capabilities & Flags section of TRILL Version Sub-TLVMarian Ďurkovič1-1/+30
Change-Id: Ic82a2368c865031eaeee291055b6a4f176cde759 Reviewed-on: https://code.wireshark.org/review/3792 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-08-22TRILL ISIS: Fix incorrectly equal ett variables for different subtreesMarian Ďurkovič1-10/+24
Change-Id: I38d886d50d74d75a900274df8bc24114e84926e7 Reviewed-on: https://code.wireshark.org/review/3744 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-08-19TRILL ISIS: Unify MTID presentation in all casesMarian Ďurkovič1-36/+20
Change-Id: I66eb683d6b1f9dccae3e566ad4dd4cfd18b81ddb Reviewed-on: https://code.wireshark.org/review/3713 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-08-19TRILL ISIS: Implement Group IPv4/IPv6 Address Sub-TLVsMarian Ďurkovič1-68/+260
Change-Id: If75925224fc487f583635d9a4346fa900cb0d1d1 Reviewed-on: https://code.wireshark.org/review/3703 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-08-18TRILL TREE Sub-TLV fixesMarian Ďurkovič1-5/+5
1) Fix starting tree number 2) Display Nicknames both in hex and dec Change-Id: If58d034e98429019d769ebe7be635a296e8ef18d Reviewed-on: https://code.wireshark.org/review/3687 Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-08-18Fix TRILL LSP display issuesMarian Ďurkovič1-8/+8
1) Sub-TLVs unknown to wireshark are not necessarily invalid 2) Properly show Root Bridge ID 3) Unify Nickname format to HEX_DEC Change-Id: Ib62f2e2a23f27221b303eaf544868746f56ff6df Reviewed-on: https://code.wireshark.org/review/3686 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-08-18BGP ISIS: Add TLV 14 (Originating LSP Buffer Size)Alexis La Goutte1-1/+54
Need more work for TLV 149 Ping-Bug: 10304 Change-Id: I3953b8d1fdee33253601aa7b443edd37417046e4 Reviewed-on: https://code.wireshark.org/review/3336 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-08-17Fix TRILL LSP dissectorMarian Durkovic1-28/+17
- correctly compute length/offset in all SubTLVs - initialize variable before while() loop - fix VLAN_GROUP SubTLV according to RFC7176 sec. 2.3.7 Change-Id: Ib5cc4ce82f63ad39e83c8b1f4a630708f8a8aa88 Reviewed-on: https://code.wireshark.org/review/3667 Petri-Dish: Evan Huus <eapache@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-08-17Fix uninitialized variable and print VLAN numbers in decimalMarian Durkovic1-2/+4
Change-Id: Icf3b3ea4968d1ed94a11ce8eb4b4fdd09ed69012 Reviewed-on: https://code.wireshark.org/review/3660 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-08-17Fix incorrect SubTLV values and properly handle both old and newMarian Durkovic1-9/+8
variant of TRILL Version SubTLV Note that the SubTLV values have not changed in RFC7176. Bug: 10387 Change-Id: I452debb7165e70f31f1a3a19a44c488c5bbdb959 Reviewed-on: https://code.wireshark.org/review/3661 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-08-16ISIS:LSP : fix indent (remove last tab) and reindent hfAlexis La Goutte1-274/+610
Change-Id: I615e777b4b6af073c174fe0c3554ed0e33f5e68e Reviewed-on: https://code.wireshark.org/review/3645 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-08-08ISIS: Fix reachability IPv4 Interface/Neighbor (wrong length)Alexis La Goutte1-2/+2
Change-Id: I8903a097a59bf9bf1ec62b59e57cdc60e382bdb5 Reviewed-on: https://code.wireshark.org/review/3490 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-08-08ISIS: Add type and length to CLVAlexis La Goutte1-1/+13
Change-Id: If6dc8e3a9328571ccdb106b0aabc617889c434c7 Reviewed-on: https://code.wireshark.org/review/3465 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-08-06Add Modelines and fix indentAlexis La Goutte1-0/+13
Change-Id: I7abb415bccff4de846ab273eed3e3b2a434d94b7 Reviewed-on: https://code.wireshark.org/review/3455 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-08-01Fixing indentation with tabs in isis dissectorMatthieu Texier1-1862/+1960
Change-Id: I4f6296f1cb988dca8c94ca5089ff6aa03439da32 Reviewed-on: https://code.wireshark.org/review/3333 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-06-29proto_tree_add_subtree[_format]Michael Mann1-64/+45
Change-Id: I7e016f10fcfdc0523bf2fe8c11295c0334f7c332 Reviewed-on: https://code.wireshark.org/review/2694 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-3/+3
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-3/+3
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-14Put the system ID in the top-level items for neighbors.Guy Harris1-1/+3
Add a tvb_print_system_id() routine, and use that in various ISIS dissectors, while we're at it. Change-Id: I31b6b9ea8faf2b4849f974ec7ed27fbdd14b91ef Reviewed-on: https://code.wireshark.org/review/1145 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-04-14Call each item in the Extended IS Reachability CLV an "IS Neighbor".Guy Harris1-11/+9
This makes it a bit more like the (un-extended) Reachability CLVs. Also, just make the top-level items just a text field, just like the top-level items for neighbors in the (un-extended) Reachability CLVs. Rename the system IDs to be "... neighbor ID", not just "neighbor"; the top-level items hold all the information for the neighbor, and the system ID for the neighbor is just one of those pieces of information. Change-Id: I72182dea496f8cfa6048cff3b0d2474df8f31282 Reviewed-on: https://code.wireshark.org/review/1144 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-04-14You can't use proto_item_set_len() to make an item unknown-length.Guy Harris1-3/+7
You also shouldn't use an item for one *element* of a structure to represent the entire structure. Fix both of those. Change-Id: Id1711238ebec02f135c404ac001aa51d783b3c69 Reviewed-on: https://code.wireshark.org/review/1142 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-03-05Fix some code remove by 296591399f90a9d89be958d91047aa724a77ee6dAlexis La Goutte1-0/+1
(Copyright or info about file...) Change-Id: I90ba8b1c3ec8406b0c3365a69a8555837fc4bbb1 Reviewed-on: https://code.wireshark.org/review/515 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-25Remove trailing whitespace.Bill Meier1-1/+1
Change-Id: Ia03a1cd4590aceda30ead4aa93ad413d90c6aea6 Reviewed-on: https://code.wireshark.org/review/372 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-01-01Fix [-Wmissing-prototypes]Anders Broman1-0/+2
svn path=/trunk/; revision=54528
2013-12-23Add FT_SYSTEM_ID type and convert the dissectors that use print_system_id ↵Michael Mann1-24/+15
with FT_BYTES to now use FT_SYSTEM_ID type. svn path=/trunk/; revision=54383
2013-12-22Try to pacify buildbotsPascal Quantin1-8/+3
svn path=/trunk/; revision=54369
2013-12-22Overhaul the ISIS dissectorsMichael Mann1-928/+937
1. Make real dissectors and call dissector_try_uint_new for each "isis.type" 2. Use make_register script for dissector initialization 3. Replace isis_dissect_unknown() with real expert info 4. Use convert_proto_tree_add_text.pl to make many more filterable items and gets some files off of the checkAPIs.pl naughty list. 5. Remove (now unnecessary) dissector specific header files 6. Do some reordering of functions to eliminate the need for function declarations. Additional whitespace formatting and modelines should probably be applied to all of these dissectors. Used capture files from bug 5354 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5354) and bug 1792 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1792) for fuzztesting. svn path=/trunk/; revision=54367
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-1/+1
svn path=/trunk/; revision=52591
2013-09-30Convert some proto_tree_add_string_format calls to something more appropriate.Michael Mann1-2/+2
There seem to be several cases of proto_tree_add_string_format where a "string" value/filter doesn't really make sense because it's always empty, and is just being used as a "filterable subtree header (placeholder)". They appear to be more for "presense" than "value" and should probably be FT_NONE, although I'd almost argue for removing the filter in favor of proto_tree_add_text. svn path=/trunk/; revision=52296
2013-09-15Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if ↵Michael Mann1-6/+6
hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly. The script didn't catch as many as I would have liked, but it's a start. The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum. svn path=/trunk/; revision=52045
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-9/+6
svn path=/trunk/; revision=49920
2013-05-26Batch of filterable expert infos.Michael Mann1-1/+11
svn path=/trunk/; revision=49584
2013-01-28From Gyanesh:Jaap Keuter1-1/+82
Add SPBV MAC address sub-TLV support (802.1aq). svn path=/trunk/; revision=47321
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-05-21Fix indentationpascal1-637/+633
svn path=/trunk/; revision=42760
2012-05-21From gyanesh via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7267 :pascal1-2/+71
Add dissector function for SPB link metric sub tlv (type 29) svn path=/trunk/; revision=42759