aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-isis-lsp.c
AgeCommit message (Collapse)AuthorFilesLines
2022-02-15Tools: Fix fix-encoding-args.pl ASCII string validationJoão Valverde1-1/+1
Do not require a useless ENC_NA parameter for string encodings. FT_STRING and FT_STRINGZ types don't have any ndianness. Follow-up to 6ec429622c9258eefd388caf21ce92ab5b9f54b4.
2021-10-07to_str: scope tvb_ip_to_strEvan Huus1-2/+2
2021-09-30IS-IS LSP: extended IP reachability prefix SID dissection changeJaap Keuter1-2/+11
The flags were used to identify the SID format, without regard for the available size. Also in case of error in the flags the SID would not be shown. Convert, like elsewhere, SID format identification based on size and add flag validity checks, based on RFC 8667 section 2.1.1. Closes #17610
2021-09-14osi: avoid global memory scopesEvan Huus1-4/+4
Add scope arguments to the OSI helper methods which allocate buffers to avoid the use of the global wmem_packet_scope().
2021-08-25ISIS: Fix Flexible Algorithm issuesTaisuke Sasaki1-3/+3
- Fix "Priority" field name in FAD TLV (draft-ietf-lsr-flex-algo-16) - Fix SABM/UDABM length in ASLA TLV (rfc8919)
2021-07-21First pass pinfo->pool conversion, part 2Evan Huus1-6/+6
Automated find/replace of wmem_packet_scope() with pinfo->pool in all files where it didn't cause a build failure.
2021-07-14ISIS-LSP: Fix spelling of "algorithm"Martin Mathieson1-6/+6
2021-07-13ISIS: Add Flexible Algorithm (draft-ietf-lsr-flex-algo-16)Taisuke Sasaki1-59/+300
- Add Flexible Algorithm Definition Sub-TLV - Add IS-IS Application-Specific Link Attributes (rfc8919) - Add Extended Administrative Groups Sub-TLV (rfc7308)
2021-04-16ISIS: Add TE Metric extensions (rfc8570)Taisuke Sasaki1-1/+136
2021-04-05Clean up some cppcheck warnings.Martin Mathieson1-2/+2
2021-04-01isis: Fix tlv 184 decoding errorJoerg Mayer1-22/+28
2021-03-30isis: TLV 147 is not proprietary, it's MAC Reachablity from RFC 6165Joerg Mayer1-23/+69
2021-03-30isis: Updates to Avaya proprietary TLV 184 decodingJoerg Mayer1-1/+16
- Add TLV 184 sub TLV 1: IPv4 Metric Type - Fix hexpane length of unknown sub TLVs
2021-03-28ISIS-LSP: Fix length of a field.Martin Mathieson1-1/+1
SID/Label Binding TLV Range field is 2 bytes.
2021-03-25isis: Support for proprietary Avaya/Extremenetworks Fabric TLVs/NLIPDJoerg Mayer1-10/+280
- TLV 129 NLPID decoding cleanup with multiple NLPIDs - NLPID 0x8f added (Avaya proprietary) - TLV 147 decoding added (Avaya proprietary) - TLV 184 Avaya prorietary IPVPN decoding added - TLV Types 185-186 Avaya proprietary IPVPN MC added without decoding
2020-11-02ISIS: Add Purge Originator ID TLV (rfc6232)Taisuke Sasaki1-0/+86
2020-10-03Fix more filter field strings.Martin Mathieson1-1/+1
These appear to be copy/paste errors detected by running ./tools/check_typed_item_calls.py --consecutive Quite a few issues still remain after this batch.
2020-08-31More spelling fixes, part 2 of 2nd pass of dissectors.Martin Mathieson1-1/+1
2020-08-07Find and fix dissectors that should be using a default tfs.Martin Mathieson1-7/+4
Found using tools/check_tfs.py, included in this commit. Here are the reports that were fixed here: Examining: All dissector modules epan/dissectors/packet-assa_r3.c tfs_mortisepins_flags - could have used tfs_high_low from tfs.c instead: {High,Low} epan/dissectors/packet-btle.c tfs_present_bit - could have used tfs_present_not_present from tfs.c instead: {Present,Not Present} epan/dissectors/packet-dhcp.c tfs_fqdn_s - could have used tfs_server_client from tfs.c instead: {Server,Client} epan/dissectors/packet-docsis-macmgmt.c mdd_tfs_on_off - could have used tfs_on_off from tfs.c instead: {On,Off} epan/dissectors/packet-docsis-macmgmt.c mdd_tfs_en_dis - could have used tfs_enabled_disabled from tfs.c instead: {Enabled,Disabled} epan/dissectors/packet-docsis-macmgmt.c req_not_req_tfs - could have used tfs_requested_not_requested from tfs.c instead: {Requested,Not Requested} epan/dissectors/packet-docsis-tlv.c on_off_tfs - could have used tfs_on_off from tfs.c instead: {On,Off} epan/dissectors/packet-docsis-tlv.c activation_tfs - could have used tfs_active_inactive from tfs.c instead: {Active,Inactive} epan/dissectors/packet-docsis.c ena_dis_tfs - could have used tfs_enabled_disabled from tfs.c instead: {Enabled,Disabled} epan/dissectors/packet-ecmp.c tfs_not_expected_expected - could have used tfs_odd_even from tfs.c instead: {Odd,Even} epan/dissectors/packet-erf.c erf_link_status_tfs - could have used tfs_up_down from tfs.c instead: {Up,Down} epan/dissectors/packet-h263.c on_off_flg - could have used tfs_on_off from tfs.c instead: {On,Off} epan/dissectors/packet-h263.c cpm_flg - could have used tfs_on_off from tfs.c instead: {On,Off} epan/dissectors/packet-interlink.c flags_set_notset - could have used tfs_set_notset from tfs.c instead: {Set,Not set} epan/dissectors/packet-ip.c tos_set_low - could have used tfs_low_normal from tfs.c instead: {Low,Normal} epan/dissectors/packet-ip.c tos_set_high - could have used tfs_high_normal from tfs.c instead: {High,Normal} epan/dissectors/packet-isakmp.c flag_r - could have used tfs_response_request from tfs.c instead: {Response,Request} epan/dissectors/packet-isis-lsp.c tfs_metric_supported_not_supported - could have used tfs_no_yes from tfs.c instead: {No,Yes} epan/dissectors/packet-kerberos.c supported_tfs - could have used tfs_supported_not_supported from tfs.c instead: {Supported,Not supported} epan/dissectors/packet-kerberos.c set_tfs - could have used tfs_set_notset from tfs.c instead: {Set,Not set} epan/dissectors/packet-mac-lte.c mac_lte_scell_status_vals - could have used tfs_activated_deactivated from tfs.c instead: {Activated,Deactivated} epan/dissectors/packet-p_mul.c no_yes - could have used tfs_no_yes from tfs.c instead: {No,Yes} epan/dissectors/packet-pgm.c opts_present - could have used tfs_present_not_present from tfs.c instead: {Present,Not Present} epan/dissectors/packet-rsl.c rsl_ms_fpc_epc_mode_vals - could have used tfs_inuse_not_inuse from tfs.c instead: {In use,Not in use} epan/dissectors/packet-sita.c tfs_sita_on_off - could have used tfs_on_off from tfs.c instead: {On,Off} epan/dissectors/packet-vines.c tfs_vine_rtp_no_yes - could have used tfs_no_yes from tfs.c instead: {No,Yes} epan/dissectors/packet-vnc.c button_mask_tfs - could have used tfs_pressed_not_pressed from tfs.c instead: {Pressed,Not pressed} 27 issues found Change-Id: I7e53b491f20289955c9e9caa8357197d9010a5aa Reviewed-on: https://code.wireshark.org/review/38087 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-06-19Fix the type of arrays of pointers to hf_ values for bitfield routines.Guy Harris1-12/+12
The static arrays are supposed to be arrays of const pointers to int, not arrays of non-const pointers to const int. Fixing that means some bugs (scribbling on what's *supposed* to be a const array) will be caught (see packet-ieee80211-radiotap.c for examples, the first of which inspired this change and the second of which was discovered while testing compiles with this change), and removes the need for some annoying casts. Also make some of those arrays static while we're at it. Update documentation and dissector-generator tools. Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc Reviewed-on: https://code.wireshark.org/review/37517 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-04-14wsutil: use ws_in4_addr in tvb_get_ipv4_addr_with_prefix_len.Dario Lombardo1-20/+17
Instead of guint8* the used type looks more precise. Moreover there is no need to use local unions in the dissectors to switch between the actual address and address bytes. bgp, eigrp and isis-lsp dissectors have been updated accordingly. Change-Id: I7785fe4c12913a09bd31cd6ef26e53027646d35c Reviewed-on: https://code.wireshark.org/review/36836 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <gharris@sonic.net>
2020-04-12Fix up some broken links to specs from dissectors.Martin Mathieson1-3/+3
check_dissector_urls.py was written and used to find URLs within epan/dissectors/*.c and try to fetch them using 'requests'. Will be commmitted separately. Most of the changes were to adapt to reorganisation of IETF or 3gpp2 links, but many of the broken links are for websites or companies that no longer exist. Change-Id: Ie9afdb95099218402a61626a0cd5193c6f781b96 Reviewed-on: https://code.wireshark.org/review/36769 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2020-04-03Clean up a number of things.Guy Harris1-114/+188
Pass to the routines that handle particular ISIS PDU types a tvbuff for the *full* PDU; some PDU types may have a checksum CLV type that checksums the *entire* PDU. Pass an isis_data_t * around to various routines, rather than passing some individual bits of information around. Add to that structure: the PDU length from the common-to-all-PDU-types part of the ISIS header; a proto_item * for the header length field; an expert_field * for a "the header length is bad" error. Use the PDU length from that structure when handling the aforementioned checksum CLV. When dissecting the PDU-type-specific part of the ISIS header, check to make sure we're not going past the header length and, if we are, report it with an expert info, using the header length field proto_item * and expert_field * from that structure. Show the type field in sub-TLVs of the Group Address TLV (RFC 7176 section 2.1) and, if the type is unknown, add a top-level item with the type and length fields under it. This fixes some bugs. Bug: 16477 Change-Id: I875306d9d4fd8f65a60b7a6d3be7e356afabe851 Reviewed-on: https://code.wireshark.org/review/36671 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <gharris@sonic.net>
2020-03-25fix typo found by lintian (Uknown => Unknown)Alexis La Goutte1-1/+1
Change-Id: I50ae0d1595cc42b3432f4611009c9c48b4cdde70 Reviewed-on: https://code.wireshark.org/review/36567 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-09-30IS-IS: add missing TLV 138 dissection for l1 LSPYann Lejeune1-0/+6
Bug: 16012 Dissector call-back function was initially added only for L2 LSP while it's needed for both. Change-Id: I9191da6c3ee6ac27daa698bddf0a2d2d99ea8f08 Reviewed-on: https://code.wireshark.org/review/34648 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-05-12Clean up some things.Guy Harris1-55/+65
Have separate expert info items for the PDU length field being too short, the PDU length field being too long, a CLV being too short, and a CLV being too long. Do the PDU length checks when we add the PDU length field, and add the expert infos to the length item; remember the results of the checks for future use. Use DISSECTOR_ASSERT for the tests in osi_check_and_get_checksum() that make sure the checksum field is contained within the data to be checksummed, so that's reported as a dissector bug to the user. That means that osi_check_and_get_checksum() only returns FALSE if we don't have all the data available to checksum; that already gets reported as an indication that the checksum is unverified, so we don't need to put confusing and misleading expert infos about the PDU length - whatever PDU length errors need to be reported have already been reported, as per the above. Make expert info names more consistent, and fix one expert info variable name. Make the length argument to isis_dissect_clvs() unsigned. Clean up white space. Change-Id: I0ce799c766dc427602d155c5b48099df8bf51c67 Reviewed-on: https://code.wireshark.org/review/33179 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-04-02ISIS LSP: Add a length check.Gerald Combs1-2/+8
Make sure we've fetched an address before using it. Bug: 15642 Change-Id: I94dba50254dfd06f014810a9e779bda3c46352dd Reviewed-on: https://code.wireshark.org/review/32680 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-16ISIS: Add SRv6 dissection (draft-bashandy-isis-srv6-extensions-04)Taisuke Sasaki1-4/+463
Here is the list of new TLVs: - SRv6 Capabilities sub-TLV - Node MSD sub-TLV (rfc8491) - IPv6 TE Router-ID (rfc5316) - SRv6 Locator TLV - SRv6 End SID sub-TLV - SRv6 End.X SID sub-TLV - SRv6 LAN End.X SID sub-TLV Change-Id: I49c09852d18d28ed7ef678c7e87b8eeef00da602 Reviewed-on: https://code.wireshark.org/review/32040 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2019-01-17IS-IS: support for dissecting IS-IS BIER Info Sub-TLV (RFC 8401)Rohan Saini1-18/+226
Added support for dissecting IS-IS BIER Info Sub-TLV and BIER MPLS Encapsulation Sub-sub-TLV, as per RFC 8401 Bug: 15421 Change-Id: Iec5e275f3afef7cb64d474634bd0a89b42a1b480 Reviewed-on: https://code.wireshark.org/review/31551 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Uli Heilmeier <openid@heilmeier.eu> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-06ISIS(-lsp): Fix Dead Store (Dead assignement/Dead increment) Warning found ↵Alexis La Goutte1-2/+0
by Clang Change-Id: Ic9851860e4b6e2f55efa5de6553c71ed84012c55 Reviewed-on: https://code.wireshark.org/review/31415 Reviewed-by: Taisuke Sasaki <taisasak@cisco.com> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2018-12-19ISIS: Add Prefix Attribute Flags TLV (rfc7794)Taisuke Sasaki1-32/+33
Fix according to review 31069 Change-Id: I03552eaba434597386d8bf386117a3366f2c3446 Reviewed-on: https://code.wireshark.org/review/31101 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-17ISIS: Add Prefix Attribute Flags TLV (rfc7794)Taisuke Sasaki1-29/+153
Also add the below minor fixes/enhancements: - Fix O-bit in MT TLV (rfc5120) - Add IPv4/IPv6 prefix string in a parent subtree - Modify the IPv6 Reachability TLV dissector so that it would dissect in TLV format order - Add a new SR Local Block TLV dissector (draft-ietf-isis-segment-routing-extensions-21) - Fix offset in SID/Label sub-TLV Change-Id: Ie317f094ff8f2ed3352e844c212eb59a677e18c6 Reviewed-on: https://code.wireshark.org/review/31069 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-11ISIS: add dissection of Node/Link MSD (rfc8491)Taisuke Sasaki1-1/+1
Revert a wording Sub-TLV back to SubCLV according to review 30985. Change-Id: I1f7a2a586d45fe8548c1589baa2803616cf5bd20 Reviewed-on: https://code.wireshark.org/review/31008 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-10ISIS: add dissection of Node/Link MSD (rfc8491)Taisuke Sasaki1-2/+58
Also add Strict SPF in SR-Algorithm Sub-TLV (draft-ietf-isis-segment-routing-extensions-21) Change-Id: Icc564f093075d2d6edf5b25ac90e41c987ea71e8 Reviewed-on: https://code.wireshark.org/review/30985 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-03ISIS (LSP/HELLO): Add RFC 6119 (IPv6 Traffic Engineering in IS-IS)Alexis La Goutte1-1/+66
Add new TLV 140 (IPv6 TE Router ID) and 233 (IPv6 Global Interface Address) Add new sub TLV (for TLV 22, 141, 222) : 12 (IPv6 Global Interface) and 13 (IPv6 Neighbor Address) Missing add new TLV 139 (IPv6 SRLG) Ping-Bug: 15015 Change-Id: Ie106e56717d3698cd8608c3b0626854d462268d9 Reviewed-on: https://code.wireshark.org/review/29397 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-21Remove an unused true_false_string.Guy Harris1-2/+0
The field that used it was removed in I5092d19b99fc6b9b5c870cafec2990dd67012ab1. Change-Id: Ia358f475b8fbfeaf1fe10df79e9094ac837e3dd2 Reviewed-on: https://code.wireshark.org/review/29212 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-08-21ISIS(LSP): Add sub tlv Prefix SID from TLV 149Alexis La Goutte1-5/+100
from draft-ietf-isis-segment-routing-extensions-19 Bug: 15015 Change-Id: Ib64f716b60d40735553b91fd601a7e27edf64335 Reviewed-on: https://code.wireshark.org/review/29207 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-21ISIS(lsp): Remove not longer supported sub-TLV (from TLV 149)Alexis La Goutte1-147/+0
Next patch will add new supported TLV Bug: 15015 Change-Id: I5092d19b99fc6b9b5c870cafec2990dd67012ab1 Reviewed-on: https://code.wireshark.org/review/29206 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-21ISIS(lsp): Enhance Flag of TLV 149Alexis La Goutte1-2/+30
Add missing flag from TLV 149 (from draft-ietf-isis-segment-routing-extensions-19#section-2.4.1) Bug: 15015 Change-Id: Icf1fe3ef3d8b82b9451d9aed40c552bc854c5c01 Reviewed-on: https://code.wireshark.org/review/29205 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-26Add a ws_in6_addr typedef for struct e_in6_addr.Guy Harris1-1/+1
That allows a parallel typedef of ws_in4_addr for guint32. Change-Id: I03b230247065e0e3840eb87635315a8e523ef562 Reviewed-on: https://code.wireshark.org/review/24073 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-07-09tfs: Add up downAlexis La Goutte1-1/+0
Change-Id: Ifb7354bbbc639b4191f611c7840094f16e1f6819 Reviewed-on: https://code.wireshark.org/review/22566 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-21ISIS LSP: fix wrong bitmask for SPVIDAlexis La Goutte1-1/+1
Issue reported by Bo-Han Liao Bug: 13821 Change-Id: I74641bef723e747bfe5fa87e946b7f4f74b94bf6 Reviewed-on: https://code.wireshark.org/review/22299 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-19IS-IS: Add support for CRYPTO_AUTH authentication typeDhiru Kholia1-1/+1
CRYPTO_AUTH (generic cryptographic authentication) is documented in RFC 5310, https://tools.ietf.org/html/rfc5310. Sample IS-IS .pcap files using CRYPTO_AUTH (HMAC-SHA1/HMAC-SHA256) can be found at https://c0decafe.de/svn/codename_loki/test/. Bug: 13727 Change-Id: If25edc5985e13de56ab6bade570f06e0e9db276c Reviewed-on: https://code.wireshark.org/review/21697 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-04-01Improve the display of metrics.Guy Harris1-33/+45
Give the value and the "supported" bit names that reflect what they are. Show both the "supported" bit and the value as bitfields, because that's what they are. Show the "supported" bit before the value. Show the metric value as decimal; there's nothing particularly hexadecimal about it. The "supported" bit is 1 if it's *not* supported and 0 if it *is* supported. Fetch the byte for the metric within dissect_metric(), rather than in the call to dissect_metric(). Change-Id: Ief3bb74b273df06e07066ccdede38a2eeedc6db2 Reviewed-on: https://code.wireshark.org/review/20836 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-03-31Fix some dissection errors.Guy Harris1-7/+10
"XXX supported" for a metric type is a Boolean, not an int; add it as such. Add the value of the item without the extra bits. The length of an address prefix is in semi-octets (nibbles/hex digits), not in octets. Change-Id: I642f0dab5030f7609e89f45cf2cff15cd74dfbda Reviewed-on: https://code.wireshark.org/review/20819 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-08-15ISIS LSP: fix checksum verificationPascal Quantin1-3/+3
Regression introduced in gad6fc87 Bug: 12745 Change-Id: I46f8364651c5774544007d9e74ce479904a52e05 Reviewed-on: https://code.wireshark.org/review/17059 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-07-21Add proto_tree_add_checksum.Michael Mann1-51/+19
This is an attempt to standardize display/handling of checksum fields for all dissectors. The main target is for dissectors that do validation, but dissectors that just report the checksum were also included just to make them easier to find in the future. Bug: 10620 Bug: 12058 Ping-Bug: 8859 Change-Id: Ia8abd86e42eaf8ed50de6b173409e914b17993bf Reviewed-on: https://code.wireshark.org/review/16380 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-07-16ISIS (LSP): Fix Malformed packetAlexis La Goutte1-6/+24
Coming from fetch too longer bytes... Rework the display for add some missing field (SubTLV indicator, prefix len) and for prefix IPv4 use the same code like BGP Issue reported by Garri Djavadyan Bug:12617 Change-Id: Ib40f1badf8e03fadacfbb0aff1ebd3eab8ca342b Reviewed-on: https://code.wireshark.org/review/16436 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-28 17:08:41 +0000