aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-infiniband.c
AgeCommit message (Collapse)AuthorFilesLines
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-06-13register_decode_as_next_proto: remove the "title" parameterMartin Kaiser1-1/+1
Remove the "title" parameter from the register_decode_as_next_proto() function. This parameter is no longer required since decode_as_t does not have a title any more. Change-Id: I300c755bd465453aa91703b53ce9adc954e38c00 Reviewed-on: https://code.wireshark.org/review/33579 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-27Try to squeeze some bytes out of the frame_data structure.Guy Harris1-2/+2
Make the time stamp precision a 4-bit bitfield, so, when combined with the other bitfields, we have 32 bits. That means we put the flags at the same structure level as the time stamp precision, so they can be combined; that gets rid of an extra "flags." for references to the flags. Put the two pointers next to each other, and after a multiple of 8 bytes worth of other fields, so that there's no padding before or between them. It's still not down to 64 bytes, which is the next lower power of 2, so there's more work to do. Change-Id: I6f3e9d9f6f48137bbee8f100c152d2c42adb8fbe Reviewed-on: https://code.wireshark.org/review/31213 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-13Fix the "pointer to function that generates a label" values.Guy Harris1-1/+1
build_label_func is a pointer type, pointing to a function that can be used to generate a label for a "Decode As" entry. There's no need to have pointers to those pointers; have register_decode_as_next_proto() take a build_label_func, not a build_label_func *, as its last argument, assign that value rather than dereferencing it, get rid of unnecessary casts, and fix the comment in epan/decode_as.h for that argument. Change-Id: Idc3cf18204c543a2191b122c8129b362562c0ecd Reviewed-on: https://code.wireshark.org/review/25773 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-28Infiniband: Decode AETH syndrome byteUli Heilmeier1-1/+118
Used reference: Book "InfiniBand Network Architecture" by Tom Shanley; page 369 ff Bug: 14359 Change-Id: I77e64ca16ccc5f193eac34b304165f722ffb0748 Reviewed-on: https://code.wireshark.org/review/25489 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-12-20Infiniband: Fix number of bytes exported if ip_cm_sidNathaniel Clark1-1/+3
If parse_CM_Req parses a IP_CM_Req_Msg, export just the payload, instead of the ip_cm_sid and the payload. Change-Id: I67258d2f6d240885e48ea537906d2769eafe3bae Signed-off-by: Nathaniel Clark <nathaniel.l.clark@intel.com> Reviewed-on: https://code.wireshark.org/review/24796 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-05packet-infiniband: Proper parsing of ClassPortInfo attributeHal Rosenstock1-1/+198
ClassPortInfo is a common attribute for general service (GS) management classes. SA ClassPortInfo is currently parsed as PortInfo although these are different attributes. Also, added support for PerfMgt ClassPortInfo. Bug: 14164 Change-Id: I652ba8ed2e0222db41ce2eb2e01a9c4b446e5bd4 Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24235 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-11-04packet-infiniband: SM class does not support ClassPortInfo or InformInfo ↵Hal Rosenstock1-2/+0
attributes Change-Id: I1fbe7a93e8a208a1a4abaf0b64e674536b642733 Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24229 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-11-04packet-infiniband: Make unknown GS class attributes show up in wireshark ↵Hal Rosenstock1-0/+6
Info column The following GS classes are now displayed there: BM DEV_MGT SNMP VENDOR APP RESERVED Change-Id: I94822784a7027afa1d5e99ca20467721a98cfe0a Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24234 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-11-04packet-infiniband: Better variable namingHal Rosenstock1-18/+18
Rather than use PERF_header_item for all classes, use acronym for class appended with _header_item Change-Id: I52ac46000c20b7f51c87c8dc4a8dfc85c20f31f3 Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24233 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: DETH Queue Key should be hex rather than decimalHal Rosenstock1-1/+1
as it is in other places where there is Q_Key Was: DETH - Datagram Extended Transport Header Queue Key: 2147549184 Now: DETH - Datagram Extended Transport Header Queue Key: 0x0000000080010000 Change-Id: I64d4b485e2a511c30b0e4a2849f529438591a122 Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24232 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Make unknown PerfMgt attributes show up as PERF in ↵Hal Rosenstock1-0/+1
wireshark Info column Change-Id: I9f6a60adaa0744d13d6c000d1a4e20f3b526355b Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24231 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Fix commentary typo (for consistency)Hal Rosenstock1-2/+2
Change GuidInforecord -> GuidInfoRecord Also, change VLArbitrationTableRecord comment to be consistent Change-Id: Ia7cc844779a8751bd7675354b71239922327d0e8 Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24230 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Add missing SA methods into mad_method_strHal Rosenstock1-0/+7
so they are not indicated as Method: Unknown under MAD Header - Common Management Datagram Change-Id: I8e8fe918eea86e7095967d0b82772a813eafe2a5 Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24228 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Fixed some PortInfo:CapabilityMask bit namesHal Rosenstock1-10/+10
to be consistent with IBA volume 1 spec IsOptionalIPDSupported IsCommunicationManagementSupported Change-Id: I55b29b7f291f49a9d0c3e104bda4d7d7aa78b42b Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24227 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Add first and last to RMPP_FlagsHal Rosenstock1-0/+1
RMPP flags 7 indicates that packet is both first and last packet in transfer Change-Id: Idf0e8783372296a7c276c8c0c80e4905afbe6c9a Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24226 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Fix some SM class attribute IDsHal Rosenstock1-4/+4
LinkSpeedWidthPairsTable is 0x001C SMInfo is 0x0020 VendorDiag is 0x0030 LedInfo is 0x0031 Change-Id: I93197590930a97c8538ef69d08213b1076a9f66a Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24225 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Fix SA MCMemberRecord attribute nameHal Rosenstock1-1/+1
rather than MCMembersRecord Change-Id: I96bf3ac45255295cf85b9faf0547df4df26f11c3 Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24222 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Use SA rather than SMA as Subnet Administration headerHal Rosenstock1-1/+1
SMA is acronym for Subnet Management Agent not Subnet Administration so change this from SMA to SA Change-Id: I1a293fff5de4796fe337daa133943bfa059cc9ff Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24224 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-04packet-infiniband: Removed erroneous MadHeader commentsHal Rosenstock1-50/+26
as it is not parameter in these APIs Also, fixed commentary typo Change-Id: I1ce53b9aae9837688e756b2e665f3b1df74b572c Signed-off-by: Hal Rosenstock <hal.rosenstock@gmail.com> Reviewed-on: https://code.wireshark.org/review/24223 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-29Add conversation endpoint typeMichael Mann1-6/+6
For the moment this mirrors the port_type enumeration (PT_XXX), but the intent is to move away from using "port types", eliminating most (if not all) Added conversation_pt_to_endpoint_type() so that conversations deal with the correct enumeration. This is for dissector that use pinfo->ptype as input to conversation APIs. Explicit use of port types are converted to using ENDPOINT_XXX type. Change-Id: Ia0bf553a3943b702c921f185407e03ce93ebf0ef Reviewed-on: https://code.wireshark.org/review/24166 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-26Add a ws_in6_addr typedef for struct e_in6_addr.Guy Harris1-2/+2
That allows a parallel typedef of ws_in4_addr for guint32. Change-Id: I03b230247065e0e3840eb87635315a8e523ef562 Reviewed-on: https://code.wireshark.org/review/24073 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-10-12infiniband: add PSN and RETH DMA length to infinibandinfo structJorge Mora1-8/+8
Expose the PSN (packet sequence number) and the RETH DMA length to protocol's dissectors. Change-Id: Ied53a8964d7cd5c3d148ec7c7642017951e56118 Reviewed-on: https://code.wireshark.org/review/23886 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-09infiniband: fix OpCodeMap string for UC_RDMA_WRITE_MIDDLEJorge Mora1-5/+1
Make string mapping for UC_RDMA_WRITE_MIDDLE consistent with all other mappings in the OpCodeMap table. Remove extra blank lines in the OpCodeMap table. Change-Id: Ifb3e242a89458103f3db3b5718d5d939dffb6dae Reviewed-on: https://code.wireshark.org/review/23867 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-10-03infiniband: fix ISO C does not allow extra ‘;’ outside of a function ↵Alexis La Goutte1-1/+1
[-Wpedantic] Change-Id: I892e7a92c231293f1977cba4513b49afda8c676c Reviewed-on: https://code.wireshark.org/review/23823 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-24Don't use proto_tree_add_uint() with FT_BYTES.Guy Harris1-1/+1
Change-Id: Ic647f39824e3d18a1a8d1aaef997ccd41db445c0 Reviewed-on: https://code.wireshark.org/review/23667 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-16Have register_decode_as_next_proto create dissector table.Michael Mann1-5/+3
For protocols that have don't have a unique identifier for their payload, have register_decode_as_next_proto be a one stop shop to create Decode As functionality and a dissector table of type FT_NONE. Change-Id: Ic1f2e9ed0aee0554a4eb8f232630b99c0604dfc0 Reviewed-on: https://code.wireshark.org/review/22575 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-09-12infinibnand: remove multi space before tvb (on proto_tree_add_item)Alexis La Goutte1-418/+418
Change-Id: Ie94127b42cb6fbd08fa17c8dcfaffff65a21aee6 Reviewed-on: https://code.wireshark.org/review/23460 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-10infiniband: always return line for offsetAlexis La Goutte1-10/+20
Change-Id: I34d631ac913620dbc661b9d56d4e34502c9b7d35 Reviewed-on: https://code.wireshark.org/review/23459 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-10infiniband: always display reserved field...Alexis La Goutte1-23/+48
Change-Id: If6976b2e1990ae562579134dbab3550faae8cfe3 Reviewed-on: https://code.wireshark.org/review/23458 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-10infiniband: merge all reserved fieldAlexis La Goutte1-81/+26
Change-Id: I31a0d84e9f9e811cc0568d171c6bd6f1fa3397c6 Reviewed-on: https://code.wireshark.org/review/23457 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-10infiniband: always return line for local_offsetAlexis La Goutte1-381/+762
Change-Id: I8bd9e76e44254c45be26c616bf22f712bcf50881 Reviewed-on: https://code.wireshark.org/review/23456 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-10Revert "infiniband: fix bitmap for Local CM Response Timeout / Retry Count"Alexis La Goutte1-2/+2
This reverts commit e624445adff8aa10ca6663e653b13ecd5c7db8d2. Bug: 13997 Change-Id: I80c6842f890c7c6e9674a6f51732bf0eadec1de8 Reviewed-on: https://code.wireshark.org/review/23454 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-10infiniband : Add value string for BTH opcodeAlexis La Goutte1-1/+88
Bug: 13998 Change-Id: Idd369e364bd2464b278fb4abcc1e77a0f8892641 Reviewed-on: https://code.wireshark.org/review/23452 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-28infiniband: fix bitmap for Remote CM Response Timeout / Transport Service TypeAlexis La Goutte1-2/+2
Issue reported by Yao Lin Ping-Bug: 13997 Change-Id: Ia90e58826c228500da0177fa2b8b90ec9ec2ff74 Reviewed-on: https://code.wireshark.org/review/23237 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-28Revert "infiniband: swap Local CM Response Timeout / Retry Count field"Alexis La Goutte1-2/+2
Follow the order of spec This reverts commit 4b8fee9da8c19cb64a8ee0c6ab45883f83c764a3. Change-Id: Ifeaf2c68813f8c452b6ab0247cd7a4313c95f619 Reviewed-on: https://code.wireshark.org/review/23236 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-26infiniband: fix infiniband: sIP and dIP inside IP CM Private Data are ↵Alexis La Goutte1-14/+14
decoded in the wrong order Issue reported by Yao Lin Bug: 14002 Change-Id: Ib49f74edbaac4830340fb9d7dba5105f0bdeb2f1 Reviewed-on: https://code.wireshark.org/review/23200 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2017-08-25infiniband: swap Local CM Response Timeout / Retry Count fieldAlexis La Goutte1-2/+2
Change-Id: Id693a83292ac7c3683a8e24a58dd452d828125d7 Ping-Bug: 13997 Reviewed-on: https://code.wireshark.org/review/23189 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-24infiniband: fix bitmap for Local CM Response Timeout / Retry CountAlexis La Goutte1-2/+2
Issue reported by Yao Lin Ping-Bug: 13997 Change-Id: I84fbf70b1871ce740f52b1b9dd9c1b8ed2af41e3 Reviewed-on: https://code.wireshark.org/review/23183 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-11Expand register_decode_as_next_proto to include prompt string.Michael Mann1-12/+1
Many dissectors don't have an identifier to pass to a dissector table. When using Decode As they all have a "value" function that returns 0 just so something is returned. A first step to a cleaner refactor of the functionality is to allow dissectors to provide a "prompt" function when registering Decode As with register_decode_as_next_proto() so that the text exposed in the GUI can vary, but the function that returns 0 (nothing) can be consolidated under decode as registration functionality. This casts a wider net for register_decode_as_next_proto() use. Change-Id: I2995b3c251dae70f5f529b672473d25c6288ed5c Reviewed-on: https://code.wireshark.org/review/22562 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-15infiniband: add RETH remote key to infinibandinfo structNitzan Carmi1-15/+18
RETH remote key might be needed in protocol's dissectors. Remote access key is shared out of band usually via RDMA send operation. This key sharing is upper layer protocol specific and protocol dissector knows about the key. infiniband layer do not know about which rkey is shared. For protocol dissectors to associate data packets with past command packets, infiniband needs to provide the rkey. Change-Id: I927116d649ed2b01c388afbcdb924cb7e5128e12 Signed-off-by: Nitzan Carmi <nitzanc@mellanox.com> Reviewed-by: Parav Pandit <parav@mellanox.com> Tested-by: Nitzan Carmi <nitzanc@mellanox.com> Reviewed-on: https://code.wireshark.org/review/22123 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-05dissectors: fix this statement may fall through ↵Alexis La Goutte1-0/+2
[-Werror=implicit-fallthrough=] found by gcc7 Change-Id: Iba6238988ded675cba328ab512232d1919d93b4a Reviewed-on: https://code.wireshark.org/review/20415 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-20infiniband: add shutdown routine.Dario Lombardo1-0/+8
Change-Id: I3e7c1b8f589662a81c665b8b43056f20c17428ca Reviewed-on: https://code.wireshark.org/review/19704 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-13packet-infiniband: Pass read request packets to ULP dissectorsParav Pandit1-1/+2
This patch passes RDMA read request packets to ULP dissectors similar to other RDMA packets so that ULP dissector can have opportunity to show as upper layer protocol instead of IB or RRoCE. Change-Id: I594d8eada858b7f77fc94be44e3639526789779e Tested-by: paravpandit@yahoo.com Reviewed-on: https://code.wireshark.org/review/19619 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-07Add support for RROCE(v2) over IPv4 (without UDP).Jeff Morriss1-2/+6
This isn't standard but has been seen in the wild, see: https://ask.wireshark.org/questions/58521/cannot-decode-rocev2-traffic With this change users can Decode-As an IP Protocol as RROCE (by selecting Infiniband (IB) as the protocol). Change-Id: Iec865478d056f687f2f66124d6e936f67707d2c4 Reviewed-on: https://code.wireshark.org/review/19572 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-05Update the preference help text to indicate the correct default RROCE port.Jeff Morriss1-2/+2
I97b82fb53fd63d9107ee5d4c64b94840e743fc72 changed the default but not the help text. Change-Id: I05375c44c01703e36686d0a16a094cb8d6b3dcd2 Reviewed-on: https://code.wireshark.org/review/19557 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-04No reason not to use etype_vals for an Ethertype field.Guy Harris1-1/+1
Maybe there was an issue on Windows back in the old days, when 1) we didn't have a shared libwireshark library from which to import functions and data variables and thus you couldn't get variables such as etype_vals in a plugin and 2) the Infiniband dissector was a plugin, but neither of those are the case any more. Change-Id: Id8b82886317bd36a32ad1e1591673623696d4808 Reviewed-on: https://code.wireshark.org/review/19530 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-01-03infiniband: remove offset variable.Dario Lombardo1-9/+7
Change-Id: Ie86c2aece05ebbc35eb15a54d8c3f2c455ff53cf Reviewed-on: https://code.wireshark.org/review/19516 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2017-01-03infiniband: fix error for clobbered variable.Dario Lombardo1-1/+1
Given by gcc-4.9.2 on arm: epan/dissectors/packet-infiniband.c:2708:9: error: variable ‘offset’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] int offset = 0; ^ cc1: all warnings being treated as errors Change-Id: I12066031093c1fa638792ff8be8f3f5457e3feda Reviewed-on: https://code.wireshark.org/review/19515 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-27 13:32:37 +0000