aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-ieee80211-radiotap.c
AgeCommit message (Collapse)AuthorFilesLines
2016-06-27radiotap: Fix for the VHT 20MHz MCS 9 data rate not displayedAshish Shukla1-1/+1
MCS 9 at 20 MHz is valid for 3 and 6 spatial streams. Changed the rate table to include rate (mbps) for VHT 20MHz MCS 9. Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Bug: 12558 Change-Id: Ia16ae545a5ac1779131e24e1f54a5659390cd321 Reviewed-on: https://code.wireshark.org/review/16146 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-27The "coding" subfield of the VHT field is a bitmask.Guy Harris1-6/+7
Treat it as such. Fetch it once, regardless of whether we have any non-zero NSS values or not, and use the per-user NSS value to decide whether a particular bit in the bitmask is valid and worth displaying. Make the four coding fields bitfields, with the appropriate bit. Change-Id: I506b35afa9d07da8d800da5c304d5d0aadd87c54 Reviewed-on: https://code.wireshark.org/review/16155 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-06-26Check for an invalid 11ac MCS/bandwidth/NSS combination.Guy Harris1-2/+92
A few of the combinations are marked as "Not valid" in 802.11ac-2013. Ping-Bug: 12558 Change-Id: I18b78ebb84ab32a6fc53c6d634ef07ae87fb4866 Reviewed-on: https://code.wireshark.org/review/16153 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-20Manually add protocol dependencies derived from find_dissector.Michael Mann1-2/+2
Started by grepping call_dissector_with_data, call_dissector_only and call_dissector and traced the handles passed into them to a find_dissector within the dissector. Then replaced find_dissector with find_dissector_add_dependency and added the protocol id from the dissector. "data" dissector was not considered to be a dependency. Change-Id: I15d0d77301306587ef8e7af5876e74231816890d Reviewed-on: https://code.wireshark.org/review/14509 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-15Correctly set the "short GI" flag in the generic radio information structure.Guy Harris1-1/+1
For 802.11n, if the GI length is present in the MCS field and is "short GI", "gi_length" is equal to 1, not to 0, so set the "short GI" flag in the generic radio information to "gi_length". Bug: 12123 Change-Id: Ica2c5794698a643a6393f0468cdbfe025aa90074 Reviewed-on: https://code.wireshark.org/review/13950 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-29Add A-MPDU reassembly information to the radio metadata.Guy Harris1-0/+8
Change-Id: I338e7fb60ff62d1d26ca0b32468ada4294d52d8d Reviewed-on: https://code.wireshark.org/review/13594 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-11Have separate subtrees for each present flags word.Guy Harris1-6/+23
If you have multiple present flags words, that makes it easier to see which bits belong to which words. Change-Id: Ib8168bf9ab540c3b11467e95d6ddfdd27a6ef317 Reviewed-on: https://code.wireshark.org/review/13193 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-11Rename some variables to make it clearer what they represent.Guy Harris1-35/+39
Change-Id: I025df298fb36320e32d0d932bce3f80217dde16b Reviewed-on: https://code.wireshark.org/review/13192 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-25Refactoring: Use data bits per symbol MCS table to calculate rates andSimon Barber1-8/+6
remove redundant HT MCS/rate table. Preparation for duration calculations that will use this data as well. Change-Id: Iee4fb2eefb00eaa53a6368eca4ed60f705ff49df Reviewed-on: https://code.wireshark.org/review/12856 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-24Refactor 802.11 radio flags.Simon Barber1-57/+50
The use of a flag field here is aesthetically unpleasing when the flags are referred to frequently. Convert these into bitfield entries. Change-Id: I6f47e31558439dfd343ec7f856d04480366a1237 Reviewed-on: https://code.wireshark.org/review/12511 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-24Add preference to interpret radiotap rates with bit 7 set as MCS.Simon Barber1-12/+9
Change-Id: Ib3a3a70e0edbaeba143703d9b5f4f9c5c8d90818 Reviewed-on: https://code.wireshark.org/review/12855 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-17Create capture dissector "info" structure (capture_packet_info_t)Michael Mann1-3/+3
While it currently only contains packet_counts, it will hopefully stabilize the capture function signature if more fields are added. Change-Id: I003552c58043c7c2d67aec458187b12b233057e2 Reviewed-on: https://code.wireshark.org/review/12690 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-14Create capture dissector tables.Michael Mann1-23/+15
They are modeled after dissection dissector tables, but for the moment, don't have/need the flexibility. They are intended to be much simpler/faster than full dissection. The two most used/needed are "wtap_encap" and "ethertype", so they were the basis of starting to use and test capture dissector table API. Others may be added in the future. The "capture dissector" function signature needed a bit of tweeking to handling "claiming" of a packet. The current application of this is capture functions returning TRUE if they affected a "type" of packet count. Returning FALSE ends up considering the packet an "other" type. Change-Id: I81d06a6ccb2c03665f087258a46b9d78d513d6cd Reviewed-on: https://code.wireshark.org/review/12607 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-13Standardize the capture dissector function signature.Michael Mann1-1/+1
This will make it easier to mold into (capture) dissector tables. Change-Id: Iad63f2c2869782977992a3a072adb020be4b1818 Reviewed-on: https://code.wireshark.org/review/12587 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-13Create a way to register "capture" dissectors.Michael Mann1-4/+17
Capture dissectors could be architected like dissection dissectors, with tables and subtables and possibly using tvbs to pass there data instead of raw byte arrays. This is a first step towards that by refactoring capture_info_packet() to work off of a "capture dissector table" Registering the capture dissection functions instead of calling them directly also clears up a bunch of dissector header files who sole purpose was providing the capture dissection function definition. Change-Id: I10e9b79e061f32d2572f009823601d4f048d37aa Reviewed-on: https://code.wireshark.org/review/12581 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-1/+1
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-14register_dissector -> new_register_dissectorMichael Mann1-8/+4
Picking off "easy" dissectors that only have one or two exit points at most. Change-Id: I25fe6a0aac93980333217d007702799d16946563 Reviewed-on: https://code.wireshark.org/review/11816 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-06Calculate the channel if we have only the frequency.Guy Harris1-0/+7
That way, the generic 802.11 radio dissector, and any future taps if we add a tap with radio information, can get the channel for radiotap and PPI headers, as we do for some other radio headers that supply just a frequency. Change-Id: I9e3037f69938bed3b3ba563689ff00aaed486a16 Reviewed-on: https://code.wireshark.org/review/10821 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-08-22Call the MCS field by its correct name.Guy Harris1-2/+2
Yes, it *should* have been called "HT", but hindsight is always 20-20. If you want less confusingly named information, look at what the "802.11 radio information" dissector puts into the protocol tree; the radiotap dissection is for people debugging radiotap implementations or looking for vendor-specific information that's not (yet) put into the generic 802.11 radio information. Change-Id: If6e97f82595a6f11a45e34d5a52e70e9ca686d7c Reviewed-on: https://code.wireshark.org/review/10202 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-07Use the NSS provided by the Ixia Veriwave hardware.Guy Harris1-0/+10
It doesn't appear to provide the FEC type, although radiotap does, so add a flag to indicate whether we have that. Change-Id: I298d79bc6b640ee2408c3d70075c32bf331a210c Reviewed-on: https://code.wireshark.org/review/9533 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-28"Short preamble" is 802.11[bg]-only, so put it in the PHY-specifc info.Guy Harris1-33/+30
We're already only setting it for 11b and 11g; this makes it a bit cleaner, e.g. we don't need to say "oh, wait, we *don't* have short preamble" for 11n and 11ac. Change-Id: Idcf3e8c93d6a417f0319e4bd33247b98f07b6052 Reviewed-on: https://code.wireshark.org/review/9209 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-28If we don't know whether STBC is being used, we don't know NSTS.Guy Harris1-8/+13
If we don't know whether space-time block coding is being used, we don't know the number of space-time streams, so don't try to calculate it and don't put it into the protocol tree. Mark it as generated, while we're at it, as it's not a value from the radiotap header, and make it a guint. Change-Id: Ib0b14f2f4f94e042d034311e10bb96b9b29a9d3e Reviewed-on: https://code.wireshark.org/review/9206 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-28The two bits of NESS are numbers, not Booleans.Guy Harris1-4/+2
Found by Pascal Quantin. Change-Id: I843db0c1d28bcd4714799285da5e1ea8a81307a1 Reviewed-on: https://code.wireshark.org/review/9204 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-28We only have the short preamble flag if we have a Flags field.Guy Harris1-9/+32
Don't set PHDR_802_11_HAS_SHORT_PREAMBLE or phdr.short_preamble unless we have the flags bits from the Flags field. Discovered by Pascal Quantin by running valgrind on the capture from bug 11317. Change-Id: I7e91dea116f6cc977101b7b5e76067021f68a0bf Reviewed-on: https://code.wireshark.org/review/9203 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-26Use "Present"/"Absent" for VHT presence flags.Guy Harris1-9/+9
Change-Id: I1571cf52d240c5d32dd8db0af2f18b91cc6e6d34 Reviewed-on: https://code.wireshark.org/review/9178 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-26Fix handling of 11ac radio metadata.Guy Harris1-4/+20
Add more fields to the metadata to handle everything radiotap has, and show them. Call the FEC type field just "FEC", and have it be an integer field with 0 meaning BCC and 1 meaning LDPC, rather than a Boolean. 11ac doesn't have *an* MCS, it can have up to 4, one per user. Label the 11ac bandwidth values the same way we do in the radiotap dissector. Change-Id: I2c2415baff3e5d68d49dda497980e8271d26b1f6 Reviewed-on: https://code.wireshark.org/review/9176 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-25Clean up 802.11 radio information handling.Guy Harris1-98/+124
Have a field that holds the PHY type but nothing else. Have a union with structures holding PHY-type-specific information, as a bunch of attributes are PHY-specific. If we have a channel and band, but don't have the frequency, attempt to calculate the frequency, and add that to the radio information if we succeed. If we have the frequency, but don't have the channel, attempt to calculate the channel, and add that to the radio information if we succeed. Handle FHSS information, 11a "half/quarter-clocked" and turbo information, 11g normal vs. Super G, additional 11n and 11ac information, and the "short preamble" flag for 11b and 11g. Add a PHY type for 11 legacy DSSS and detect it if possible. Clean up the AVS dissector - make all fields wlancap. fields (if you want generic fields, use the wlan_radio. fields). Set more fields when writing out Commview Wi-Fi files. Change-Id: I691ac59f5e9e1a23779b56a65124049914b72e69 Reviewed-on: https://code.wireshark.org/review/9146 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-24Remove another batch of deprecated tvb_length callsEvan Huus1-1/+1
Change-Id: Icfdde38e40cca05d0705a081153a4ea3e8782ee7 Reviewed-on: https://code.wireshark.org/review/9086 Reviewed-by: Evan Huus <eapache@gmail.com>
2015-06-24Pass the signal and noise dBm values to the 802.11 radio dissector.Guy Harris1-0/+4
Change-Id: Ia3fa6ba0b1d16315c77895f3e8ae96ed7e5e1e02 Reviewed-on: https://code.wireshark.org/review/9079 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-23Treat channel flags fields as just collections of bits, not as type fields.Guy Harris1-83/+61
The radiotap and PPI specs don't call them type fields, and don't list them as having type values, they call them flags fields and list the individual bits. Listing them as type fields is especially confusing with radiotap, as you can have multiple fields giving *different* channel types, as per, for example https://ask.wireshark.org/questions/42888/multiple-channel-types-and-mcs-missing where an 802.11ac packet has one "channel type" field claiming it's 802.11a and another one claiming it's 802.11n when it is, in fact, *neither* 11a *nor* 11n. If you want to know the channel type, look at the "802.11 radio information" tree that comes before the 802.11 header tree; it gives a reasonable summary of most of the radio metadata, giving the *correct* channel type, and not showing any field multiple times. Look at the radiotap or PPI or... tree only if either 1) you're debugging a driver that creates those headers or 2) there's some data in the header that *doesn't* show up in any form in the 802.11 radio information tree (in which case the code for radio information probably needs to be changed to show it). Change-Id: I545b81b08a993dbb219fa7a4f54daac3637ea071 Reviewed-on: https://code.wireshark.org/review/9051 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-22Don't use the value of the Flags field if we didn't have it.Guy Harris1-10/+14
Change-Id: Idd7771bd39ee823981b31b827645abd2ae516f66 Reviewed-on: https://code.wireshark.org/review/9039 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-22Fix handling of XChannel radiotap field.Guy Harris1-6/+19
Fetch the flags before using them; thanks to Peter Wu for catching that one. Fetch and use the frequency and channel. Have cflags be the variable for the flags in Channel and xcflags be the variable for the flags in XChannel. Change-Id: If82f7adb448eef04b769186a90a8722d03a702a3 Reviewed-on: https://code.wireshark.org/review/9038 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-22Provide PHY type and band information in the 802.11 pseudo-header.Guy Harris1-57/+199
Provide that information so that the "802.11 radio information" protocol can indicate whether a packet was 802.11 legacy/11b/11a/11g/11n/11ac, and possibly whether it's 2.4 GHz or 5 GHz 11n. (Sometimes the center frequency might not be supplied, so the band information can be useful.) Also, provide some 11ac information, now that we can distinguish between 11n and 11ac. Don't calculate the data rate from the MCS index unless it's 11n; we don't yet have code to calculate it for 11ac. For radiotap, only provide guard interval information for 11n and 11ac, not for earlier standards. Handle the 11ac flag in the Peek remote protocol. For Peek tagged files, the "extension flags" are 11n/11ac flags, so we don't have to check for the "MCS used" bit in order to decide that the packet is 11n or 11ac or to decide whether to provide the "bandwidth" or "short GI" information. Change-Id: Ia8a1a9b11a35243ed84eb4e72c384cc77512b098 Reviewed-on: https://code.wireshark.org/review/9032 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-20Call the "802.11 radio information" dissector for radio headers.Guy Harris1-21/+76
Have dissectors of various forms of radio information headers in the packets fill in a struct ieee_802_11_phdr with radio information as appropriate, and call the "802.11 radio information" dissector rather than the raw 802.11 dissector. This means that the radio information can be found in a protocol-independent and encapsulation-independent form when you're looking at the packet; that information can be presented in a form somewhat easier to read than the raw metadata header format. It also enables having a single "radio information" tap that allows statistics to handle all different sorts of radio information encapsulation. In addition, it lets us clean up some of the arguments passed to the common 802.11 dissector routine, by having it pull that information from the struct ieee_802_11_phdr. Ensure that the right structure gets passed to that routine, and that all the appropriate parts of that structure are filled in. Rename the 802.11 radio protocol to "wlan_radio", rather than just "radio", as it's 802.11-specific. Give all its fields "wlan_radio." names rather than "wlan." names. Change-Id: I78d79afece0ce0cf5fc17293c1e29596413b31c8 Reviewed-on: https://code.wireshark.org/review/8992 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-20Use "Present"/"Absent" for presence bits.Guy Harris1-29/+29
That's clearer than "True"/"False". Change-Id: I300c040f347eff8477a87f639bea8402772314b9 Reviewed-on: https://code.wireshark.org/review/8991 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-20Support the "number of extension spatial streams" information.Guy Harris1-2/+40
Change-Id: If69088aac0848d6ec8d239e3a9acc140ad376d6f Reviewed-on: https://code.wireshark.org/review/8990 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-18Pass the 802.11 pseudo-header as an argument.Guy Harris1-15/+22
Rather than accessing it through pinfo->pseudo_header, have it passed as an argument. This means we no longer tweak the pseudo-header filled in by libwiretap, but instead construct our own pseudo-header, which is a bit cleaner. It also opens up the possibility of other dissectors passing radio information down to the 802.11 dissector, so it can display it in a better-organized format than the raw metadata headers for radiotap/PPI/Prism/AVS/etc., and having some of the options for 802.11 dissection (Atheros padding, Centrino stuff, etc.) also passed in through that pseudo-header so we have fewer arguments to dissect_ieee80211_common(). Change-Id: I470300a0407ebf029c542f7ca5878593563a70a9 Reviewed-on: https://code.wireshark.org/review/8980 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-18The STBC subfield of the radiotap MCS field is a count, not a flag.Guy Harris1-10/+10
It's a 2-bit field that is the "number of STBC streams", according to the radiotap Web site item for the MCS field: http://www.radiotap.org/defined-fields/MCS Correctly label both the FCS type and STBC stream count fields. Change-Id: Ic49f6faec3335096c6bb8ce96ce0dec2f9342a37 Reviewed-on: https://code.wireshark.org/review/8971 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-16Add the wireless toolbar.Gerald Combs1-1/+1
Add the wireless toolbar to the Qt UI. Start adding AirPcap support to ui/80211_utils. Add FCS validation routines to ws80211_utils. Move a bunch of AirPcap routines that require epan from caputils to ui/gtk. They were required for driver key management, which we'll leave to the AirPcap Control Panel in the Qt UI. Move frequency-utils to wsutil. Change-Id: I44446758046621d183f5c2ba9f6526bf01e084f1 Reviewed-on: https://code.wireshark.org/review/8910 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-04-30Fix some cases where we're shifting a signed 1 left.Guy Harris1-1/+1
Shift 1U instead, to make sure it's unsigned; the result of, for example, the result of shifting a signed value left is undefined if the value times 2^{shift count} doesn't fit in the *signed* type of the shifted value. That means, in particular, that the result of shifting 1 left by {number of bits in an int - 1} is undefined. (In *practice*, it'll probably be -2^32, with the bit you want set, but that's not guaranteed, and GCC 5.1 seems not to like it.) Change-Id: I96114047d402d1bae537cdfeb28a8564b1c94712 Reviewed-on: https://code.wireshark.org/review/8256 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-12-23Deleting unnecessary #includes from dissectors.Martin Mathieson1-1/+0
Third batch (packet-icmpv6.c -> packet-mac-lte.c). Will look at cleaning up and committing script afterwards. Change-Id: Ib91e36ad200db01c3000605f6a7a21125b96a640 Reviewed-on: https://code.wireshark.org/review/6018 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-1/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-01Use proto_tree_add_bitmask for groups of proto_tree_add_boolean.Michael Mann1-156/+72
Part 2 of many Change-Id: I50815e7738b011382392f3078a7107d3d9eec4ec Reviewed-on: https://code.wireshark.org/review/5542 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-30Make the data rate field float, and calculate it for 802.11n.Guy Harris1-398/+0
Bug: 10637 Change-Id: Ifd4094f308246e92500cc7149c0d42c8496fb9f4 Reviewed-on: https://code.wireshark.org/review/5005 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-06Adjust indentation to match editor modelines; Do other minor whitespace changes.Bill Meier1-39/+39
Change-Id: Ic020b2c92db5d14a2be9dc4d35aef4514b8b0353 Reviewed-on: https://code.wireshark.org/review/4502 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-29High Throughput is 11n, not 11g or 11a.Guy Harris1-6/+6
Change-Id: I86b6dac9cf3f1f524c1168d675bff4a04e361cee Reviewed-on: https://code.wireshark.org/review/4374 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-2/+2
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-2/+2
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-26Use the correct define for the array length check, actually fixes the overflow IEvan Huus1-1/+1
originall tried to fix in r54441. svn path=/trunk/; revision=54462
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-26 01:43:55 +0000