aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-homeplug-av.c
AgeCommit message (Collapse)AuthorFilesLines
2017-03-19dissector: fix typo identifer -> identifierAlexis La Goutte1-1/+1
Change-Id: Id23d219f06c2c504b9e4c845a1bf9d4c2531bc93 Reviewed-on: https://code.wireshark.org/review/20629 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-15Improved parsing of sniffed homeplug-av dataNora Sandler1-146/+1041
This patch modifies the homeplug-av dissector to better decode sniffer data according to the IEEE 1901-2010 standard. The dissector now decodes MPDU variant fields correctly based on delimiter type, and decodes beacon MPDU payloads. There are some variable-length fields it doesn't handle yet. This patch should have no effect on how non-sniffer-data packets are decoded. These changes are based on Andrew Margolis' pull request to faifa at https://github.com/ffainelli/faifa/pull/11 Change-Id: Ia60ac7affa99a68b38f04ab66373ac715c761328 Reviewed-on: https://code.wireshark.org/review/19156 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-28homeplug-av: fix fix spelling typo found by lintianAlexis La Goutte1-1/+1
Change-Id: If75ea5e7e9ce16d270244f2a5aac86ad3abb30eb Reviewed-on: https://code.wireshark.org/review/18529 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-21Add proto_tree_add_checksum.Michael Mann1-4/+4
This is an attempt to standardize display/handling of checksum fields for all dissectors. The main target is for dissectors that do validation, but dissectors that just report the checksum were also included just to make them easier to find in the future. Bug: 10620 Bug: 12058 Ping-Bug: 8859 Change-Id: Ia8abd86e42eaf8ed50de6b173409e914b17993bf Reviewed-on: https://code.wireshark.org/review/16380 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_create_dissector_handle -> create_dissector_handle for dissector directory.Michael Mann1-1/+1
Some of the ASN.1 dissectors still generate a new_create_dissector_handle from the tool itself, so leave those for now. Change-Id: Ic6e5803b1444d7ac24070949f5fd557909a5641f Reviewed-on: https://code.wireshark.org/review/12484 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-16create_dissector_handle -> new_create_dissector_handleMichael Mann1-3/+4
Picking off "easy" dissectors that only have one or two exit points at most. Change-Id: I96aa9cf53533cbb07105aa400d42922baf3016b3 Reviewed-on: https://code.wireshark.org/review/11860 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-28convert to proto_tree_add_subtree[_format]Michael Mann1-6/+4
Change-Id: Ia7014003a3cff5181295172978d6c613c3b83b0b Reviewed-on: https://code.wireshark.org/review/2676 Tested-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-2/+2
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-2/+2
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-28packet-homeplug-av: use HOMEPLUG_AV_MMVER_1_1 consistentlyFlorian Fainelli1-7/+7
The HomePlug AV dissector was not consistently using the HOMEPLUG_AV_MMVER_1_1 constant and was sometimes using it and sometimes using mmver == 1 directly. Make sure we use that constant throughout the code to help clarifiying which version tests are applying to. Change-Id: I602413163e4e44dedfbf3e2364448a951fa70f54 Signed-off-by: Florian Fainelli <florian@openwrt.org> Reviewed-on: https://code.wireshark.org/review/428 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-02-28packet-homeplug-av: fix missing reserved byte for station dumpFlorian Fainelli1-1/+1
dissect_homeplug_av_nw_info_sta() was processing stations information correctly, except that after the first station dump, all dumps would be off-by-one byte because we were not reserving a missing byte at the end of the station dump. Fixes #9798. Change-Id: Iff3afd5ff536ae718fa446de3c59cd5e9851ff20 Signed-off-by: Florian Fainelli <florian@openwrt.org> Reviewed-on: https://code.wireshark.org/review/427 Reviewed-by: Evan Huus <eapache@gmail.com>
2013-12-15Fix [-Wmissing-prototypes]Jakub Zawadzki1-0/+3
svn path=/trunk/; revision=54135
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-3/+1
svn path=/trunk/; revision=49920
2013-03-30coverity 993742: potential division by zeroMartin Kaiser1-3/+6
svn path=/trunk/; revision=48659
2013-03-30fix indentation in one placeMartin Kaiser1-5/+6
svn path=/trunk/; revision=48658
2013-03-27From G.Gerrits via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8501 ↵Alexis La Goutte1-77/+343
HomeplugAV dissector: Decoding HPAV-1.1 Tone Map Tx/Rx Characteristics Req/Conf (0xA070/0xA071/0xA090/0xA091) Dissecting HPAV-1.1 Tone Map Characteristics Req/Conf (0xA070/0xA071) was not correct. Also found that MMType 0xA070/0xA071 is used for the Tx ToneMaps and the MMType 0xA090/0xA091 for the Rx ToneMaps. Added types and dissector for the Rx MMType. Although the Rx-Conf-Structure is almost identical to the Tx is did duplicate the dissector code to avoid mixups. Added some additional Infos to the carrier dissector output (Carrier#, #Modulated-Bits, Average#Modulated-Bits/Carrier). Also extended the homeplug_av_tone_map_vals with 0x08 for 12bit 4096-QAM (the AR74xx should support this kind of modulation) and changed the mask to 0x0f accordingly svn path=/trunk/; revision=48592
2013-02-26Fix spelling/typos found using a list of commonly misspelled words.Bill Meier1-1/+1
The misspellings were mostly in comments but some were in text strings visible to the user. svn path=/trunk/; revision=47899
2013-01-25Whitespace cleanup.Evan Huus1-235/+235
svn path=/trunk/; revision=47286
2013-01-25From Florian Fainelli via ↵Evan Huus1-2/+115
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8259 Improve the dissection of the "Get Software Version" confirmation frame as well as the "Read configuration Block" confirmation frame by properly dissecting the fields previously marked as reserved in the Homeplug-AV dissector. svn path=/trunk/; revision=47285
2013-01-25From Florian Fainelli via ↵Pascal Quantin1-2/+6
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8258 : HomePlugAV dissector: improve device ID decoding svn path=/trunk/; revision=47271
2013-01-25From Florian Fainelli via ↵Evan Huus1-9/+8
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8166 properly dissect the 0x6048 and 0x6038 frames with HomePlug AV 1.1 svn path=/trunk/; revision=47265
2013-01-24From Florian Fainelli via ↵Evan Huus1-38/+101
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8166 Fixes for decoding HPAV-1.1 Network Info Request/Confirmation From me: minor whitespace cleanup. svn path=/trunk/; revision=47257
2013-01-05From Guus Gerrits via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8148Evan Huus1-10/+31
Add some additional formatting to the mmhdr subtree (e.g. selecting 5 mmheaderbytes with mmver!=0, Added a subtree for the Fragmentation Info) svn path=/trunk/; revision=46956
2012-12-31From Florian Fainelli via ↵Pascal Quantin1-310/+322
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8148 : Fix dissection of HomePlug AV 1.1 frames with fragmentation information From me: indentation fixes svn path=/trunk/; revision=46871
2012-12-22From G.Gerrits:Jaap Keuter1-2/+3
Minor patch just adding the newer AR7400/INT7400 with dev_id==4 for decoding in the Homeplug AV "Get Device/SW Version Confirm (A001)" response. svn path=/trunk/; revision=46695
2012-10-08Patch from Florian Fainelli via bug #7772Jakub Zawadzki1-1/+1
Cleans up the mask used for the "High" part of the sub-carrier modulation to match (modulus the 4-bits shifting) the one used for the "Low" part. svn path=/trunk/; revision=45382
2012-10-08Patch from Florian FainelliJakub Zawadzki1-4/+14
Fix bug #7772: dissect only the number of active HomePlug AV subcarriers The dissector currently dissects all 1156 sub-carriers available in the Tone Map Characteristisc Confirmation frame no matter what is the number of active ones. This is not valid, because the frame only contains the number of active sub-carriers, even though it is padded to 1156 sub-carriers. This is also an issue for newest HomePlug AV devices with a 500Mbits/sec PHY rate, because those will have up to 2690 sub-carriers, and we would only dissect the first 1156 active ones. svn path=/trunk/; revision=45381
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-09From Florian Fainelli via ↵Pascal Quantin1-5/+2
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7707 : Fix dissection of small Homeplug AV frames svn path=/trunk/; revision=44823
2012-07-31From Florian Fainelli via ↵Alexis La Goutte1-1/+11
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7548 HomeplugAV dissector: decode device id adds proper device id decoding the in the Homeplug AV "Get Device/SW Version Confirm (A001)" response. svn path=/trunk/; revision=44163
2012-07-27Create/use extended value strings to access certain value string arrays;Bill Meier1-2014/+2029
Remove unneeded initializers; Use consistent indentation. svn path=/trunk/; revision=44073
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-06-09Do not use BASE_NONE for FT_*INT* types.Chris Maynard1-1/+1
svn path=/trunk/; revision=43177
2012-03-18From Reinhard Speyerer: Fix several misspellings/typos in WiresharkBill Meier1-1/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6967 svn path=/trunk/; revision=41645
2012-03-07Fix incorrect packet-details display of certain 1 bit FT_BOOLEAN fields.Bill Meier1-9/+9
(Use a valid 'parent field width' in the hf[] 'display' field. svn path=/trunk/; revision=41396
2012-01-15Shuffle the ett[] array elements around a bit, and add blank lines, toGuy Harris1-2/+6
match their definitions; add two missing elements that turned up. That should fix bug 6736. svn path=/trunk/; revision=40509
2011-10-25Fix encoding arg for ptvcursor_add() and ptvcursor_add_noadvance() function ↵Bill Meier1-387/+387
calls. svn path=/trunk/; revision=39566
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-08-16More misspellings of "unknown", for bug 6244.Guy Harris1-1/+1
svn path=/trunk/; revision=38565
2011-05-27Put proto_reg_handoff_...() at the end of the file as per the usual ↵Bill Meier1-10/+10
Wireshark convention. svn path=/trunk/; revision=37440
2011-05-26From Florian Fainelli via ↵Jeff Morriss1-0/+4248
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5943 : The two patches attached allow the dissection of the Homeplug AV Ethernet MAC management frames between a controlling device and a Homeplug AV Ethernet to PLC adapter. This protocol is pretty similar to the previous generation Homeplug protocol (dissected by packet-homeplug.c) but a couple of noticeable differences make it require its own dissector handler. This dissector is based on the work done by Nicolas Thill, Xavier Carcelle and myself in the Faifa project (https://dev.open-plc.org). The dissector handles the standard Homeplug AV Ethernet MAC management frames (called public) as well as the Intellon specific management frames (vendor). From me: Remove unnecessary global variables. Add to COL_INFO even when !tree. Remove gotos. Remove unnecessary includes. svn path=/trunk/; revision=37403
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-29 16:28:12 +0000