aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-gsm_rlcmac.h
AgeCommit message (Collapse)AuthorFilesLines
2013-08-10Fix (-W)documentation error found by ClangAlexis La Goutte1-2/+2
./packet-gsm_rlcmac.h:1086:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< MS Radio Access capability IE > ^~~ /**< ./packet-gsm_rlcmac.h:1089:26: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] typedef guint8 A5_bits_t;/*<A5 bits> ::= < A5/1 : bit> <A5/2 : bit> <A5/... ^~~~~ /**< packet-gsm_rlcmac.c:169:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Global TFI IE >*/ ^~~ /**< packet-gsm_rlcmac.c:171:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Starting Frame Number Description IE >*/ ^~~ /**< packet-gsm_rlcmac.c:174:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Ack/Nack Description IE >*/ ^~~ /**< packet-gsm_rlcmac.c:178:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Packet Timing Advance IE >*/ ^~~ /**< packet-gsm_rlcmac.c:183:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Power Control Parameters IE >*/ ^~~ /**< packet-gsm_rlcmac.c:191:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Global Power Control Parameters IE >*/ ^~~ /**< packet-gsm_rlcmac.c:195:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Global Packet Timing Advance IE >*/ ^~~ /**< packet-gsm_rlcmac.c:197:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Channel Quality Report struct >*/ ^~~ /**< packet-gsm_rlcmac.c:210:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< EGPRS Ack/Nack Description >*/ ^~~ /**< packet-gsm_rlcmac.c:216:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*<P1 Rest Octets>*/ ^~~~~ /**< packet-gsm_rlcmac.c:218:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*<P2 Rest Octets>*/ ^~~~~ /**< packet-gsm_rlcmac.c:264:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< SI 13 Rest Octets >*/ ^~~ /**< packet-gsm_rlcmac.c:288:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Packet TBF Release message content >*/ ^~~ /**< packet-gsm_rlcmac.c:293:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Packet Control Acknowledgement message content >*/ ^~~ /**< packet-gsm_rlcmac.c:299:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Packet Downlink Dummy Control Block message content >*/ ^~~ /**< packet-gsm_rlcmac.c:301:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< Packet Uplink Dummy Control Block message content >*/ ^~~ /**< packet-gsm_rlcmac.c:305:1: error: not a Doxygen trailing comment [-Werror,-Wdocumentation] /*< MS Radio Access capability IE >*/ ^~~ /**< svn path=/trunk/; revision=51267
2012-11-30From Mike Morrin:Anders Broman1-8/+8
The gsm rlcmac dissector truncates the 12 bit BSNs to 8 bits when storing them. Fix this and the handling of BSN2 is refactored to clarify the difference between BSN2 (the stored value) and BSN2_offset (the value transferred at the air interface). svn path=/trunk/; revision=46301
2012-09-29From Mike Morrin via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7615 :Pascal Quantin1-1/+1
Fix minor bug in dissection of "e" bit and add value strings for remaining data block header fields svn path=/trunk/; revision=45206
2012-09-14From Mike Morrin:Anders Broman1-5/+5
Fix pedantic compiler warnings in csn.1 dissectors. There is some tricky casting going on in csn.1 structures. To eliminate all the warnings, the function pointers needed to be moved out of the object pointer unions. Fortunately macros (mostly) hide these changes from the protocol dissector tables. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7686 svn path=/trunk/; revision=44899
2012-09-11Enhance dissection of PSI1Pascal Quantin1-14/+21
svn path=/trunk/; revision=44870
2012-09-07From Mike Morrin:Anders Broman1-19/+21
Interface based on header type rather than MCS. passes in the header type for EGPRS packets. This makes sense because in a real protocol stack, the header type is encoded in the burst stealing bits, allowing the header can be decoded, giving the CPS IE, which then allows the data blocks to be decoded, so wireshark now follows the same practice. I found that there was a (previously overlooked) alignment error in decoding the last octet of some headers due to the last "octet" having less than 8 bits, and both the protocol stacks I have here assume that the left-hand bits are missing (as per the figures in 44.060). I corrected this by making a small extension to the NULL encoding in packet-csn.[ch] to allow a NULL field to consume more than 0 bits. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7615 svn path=/trunk/; revision=44805
2012-09-02From Mike Morrin:Anders Broman1-8/+168
Enhancemnt to GSM RLCMAC dissection adding dissection of data block headers https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7615 svn path=/trunk/; revision=44741
2012-08-08Remove Uplink messages from the RlcMacDownlink_t structure (as they are part ↵Pascal Quantin1-37/+16
of the RlcMacUplink_t structure that is also used to call csnStreamDissector function) svn path=/trunk/; revision=44319
2012-08-07Make sure we have a corresponding 'u' member to RlcMacDownlink_t forGerald Combs1-17/+28
every call to csnStreamDissector. This should fix bug 7561. Based on attachment 8888 from Martin Kaiser. svn path=/trunk/; revision=44307
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-02-23From Lei Chen:Anders Broman1-0/+3
a patch to support decode FDD_CELL_INFORMATION of "UTRAN FDD Description" in packet-gsm_rlcmac.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6856 svn path=/trunk/; revision=41149
2012-01-21From Mike Morrin:Anders Broman1-3/+12
a patch which improves several aspects of GSM RLS/MAC dissection. Generic improvements to the csn.1 dissector include: • Added a flag to the type descriptor structure so that any type can (potentially) flagged as xxx_OR_NULL. This was specifically needed for UINT_OR_NULL for the ms capabilities struct. • Corrected the octet calculation in app of the proto_tree_add_text() and proto_item_set_len() calls. • Changed the CSN_SERIALIZE so that the length of the length field can be specified. • For CSN_NEXT_EXIST removed the requirement that the next type be CSN_END, to allow truncation of multiple IEs. • For CSN_LEFT_ALIGNED_VAR_BITMAP corrected the handling of bit_offset. • Added a new type CSN_PADDING_BITS to make inspection of padding bits more convenient. • Improved the CSN_RECURSIVE_TARRAY_1 to show the array index. Improvements to the gsm_rlcmac dissector include: • Comment out a couple of unused hf variables. • Rework the definition of EGPRS Ack/Nack Description so that the length IE (and absence thereof) is handled correctly. This is the original issue for which the bug was raised. • Added Padding Bits definitions to all PDUs • Change the Multislot_capability_t and Content_t definitions to allow truncation at any IE • Added proto_tree_add_protocol_format() calls so that the protocol can be added to a display filter • Append Protocol to the PROTOCOL column and PDU type to the INFO column. From me get rid of C++ style comments. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6375 svn path=/trunk/; revision=40627
2011-12-06#if 0 unused stuff ...Bill Meier1-93/+115
svn path=/trunk/; revision=40102
2011-09-07From Lei Chen:Anders Broman1-30/+145
upgrade PCCF/PMR/PEMR in packet-gsm_rlcmac.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6313 svn path=/trunk/; revision=38909
2011-09-01From Lei Chen:Anders Broman1-4/+341
Upgrade 'Packet Cell Change Order', 'Packet Cell Change Notification' and 'Packet Measurement Order' to R10. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6300 svn path=/trunk/; revision=38838
2011-07-29From Lei Chen:Anders Broman1-69/+176
support PSI5 and PSI13 in packet-gsm_rlcmac.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6177 svn path=/trunk/; revision=38248
2011-07-28From Lei Chen:Anders Broman1-32/+106
support 'Packet System Information Type 3' in packet-gsm_rlcmac.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6170 svn path=/trunk/; revision=38231
2011-07-26From Lei Chen:Anders Broman1-6/+6
This patch tries to support 'Packet System Information Type 2' in gsm rlcmac dissector. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6167 svn path=/trunk/; revision=38206
2011-07-20From Lei Chen:Anders Broman1-0/+42
patch to support "Additional MS Radio Access Capability" and "Packet Pause" in packet-gsm_rlcmac.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6133 svn path=/trunk/; revision=38136
2011-07-06From Ludovic Haessler:Anders Broman1-0/+1
Wrong decoding of RLC/MAC EGPRS Packet Downlink Ack/Nack (3GPP TS 44.060) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6098 svn path=/trunk/; revision=37919
2011-05-16Remove extra ;Anders Broman1-1/+1
svn path=/trunk/; revision=37177
2011-03-23From Vincent Helfre:Anders Broman1-688/+689
- added documentation in packet-csn1.h - fixed a bug in packet-csn1.c - fixed a BSIC description in packet-gsm_a_rr.c - removed the "_v" suffix in packet-gsm_rlcmac element description svn path=/trunk/; revision=36284
2011-02-28Remove unneeded #includes; Add #includes to packet-gsm_rlcmac.cBill Meier1-5/+0
svn path=/trunk/; revision=36099
2011-02-28Define global vars as static; Whitespace cleanup.Bill Meier1-112/+112
svn path=/trunk/; revision=36098
2011-02-28svn path=/trunk/; revision=36087Anders Broman1-0/+4386
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-25 00:41:12 +0000