aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-gsm_map.c
AgeCommit message (Collapse)AuthorFilesLines
2022-11-30asn2wrs: disable template line directive by defaultJoakim Karlsson1-51/+0
Same as with !8955, To debug with line directive build with -DENABLE_DEBUG_A2W=ON flag
2022-11-30asn2wrs: disable line directive by defaultJoakim Karlsson1-133/+1
To debug with line directive build with -DENABLE_DEBUG_A2W=ON flag
2022-06-10tap: Adding flags for tap_packetRoland Knall1-1/+1
This allows flags to be passed by the registering listener to the collection of information
2022-02-15Tools: Fix fix-encoding-args.pl ASCII string validationJoão Valverde1-1/+1
Do not require a useless ENC_NA parameter for string encodings. FT_STRING and FT_STRINGZ types don't have any ndianness. Follow-up to 6ec429622c9258eefd388caf21ce92ab5b9f54b4.
2021-12-19Replace g_strdup_printf() with ws_strdup_printf()João Valverde1-1/+1
Use macros from inttypes.h.
2021-12-06gsm_map: stat table formatting in cliJohn Thacker1-3/+3
The TABLE_ITEM_FLOATs (Avg Bytes, etc.) in the stat table need a float format string, or else unpredictable output happens with tshark.
2021-12-03epan: Remove STR_ASCII and STR_UNICODEJoão Valverde1-11/+11
These display bases work to replace unprintable characters so the name is a misnomer. In addition they are the same option and this display behaviour is not something that is configurable. This does not affect encodings because all our internal text strings need to be valid UTF-8 and the source encoding is specified using ENC_*. Remove the assertion for valid UTF-8 in proto.c because tvb_get_*_string() must return a valid UTF-8 string, always, and we don't need to assert that, it is expensive.
2021-11-08GSM-MAP: Dissect SM-DeliveryFailureCause variantsAnders Broman1-4/+8
V1 version may omit SEQUENCE and have only the SM_EnumeratedDeliveryFailureCause element.
2021-09-28GSM MAP Update to 3GPP TS 29.002 V17.1.0 (2021-06)Anders Broman1-75/+127
2021-09-28GSM MAP: Dissect message noteSubscriberPresent.Anders Broman1-5/+7
2021-09-02GSM MAP: Handle Version 1 of ResetArgAnders Broman1-4/+41
Closes #17549
2021-07-26asn1: convert most dissectors to pinfo->poolEvan Huus1-11/+11
Part 1/2 as the commits were too big for CI. Largely find/replace, with a few manual tweaks. Then regenerate the asn1 dissector sources and make sure everything still builds. There are a handful of cases I skipped as too complex, but this covers most of the asn1 dissectors.
2021-05-24GSM MAP:Use ENC_APN_STRAnders Broman1-24/+11
2021-04-20GSM_MAP: Error Code typo's fixBasiL1-4/+4
some of the error codes have missed last character
2021-03-30Prettify and standardize LAC, RAC, SAC, TAC in several ASN.1 dissectorsJohn Thacker1-3/+11
The LAC, RAC, SAC, and TAC tend to be defined in ASN.1 as OCTET STRINGS of lengths 1, 2, or 3. It generally makes sense to dissect them as FT_UINT[8,16,24], as appropriate, with BASE_DEC_HEX instead of as FT_BYTES, so standardize on that. See commit d6f91a7ca421caa7787c1539bca61f943923fa9c for similar work for S1AP.
2021-02-07gsm_map: create and populate the stats table only onceMartin Kaiser1-4/+13
Use the new stat_tap_find_table function during init to check if our statistics table already exists. If so, we can safely assume that its rows have already beend initialized. All we have to do is clear the data that was collected by the tap.
2021-01-14gsm_map: remove a variable that is always 0Martin Kaiser1-5/+4
There's just one table at index 0.
2020-09-24More dissector spelling fixes.Martin Mathieson1-1/+1
2020-09-05Fix some detected spelling errors in ASN1 dissectors.Martin Mathieson1-1/+1
Done by scanning the asan1 template files. If there are spelling mistakes in the specifications, we should ignore. Note that for z3950, I had already found and accidentally fixed the same errors in the generated file (before I taught my script to ignore gnerated dissector files).
2020-08-25Fix a couple of typos in true_false_string entries.Martin Mathieson1-1/+1
2020-08-17TFS: Add some commonly-defined string pairs to tfs.cMartin Mathieson1-8/+5
'check_tfs.py --common' can look for tfs values that appear multiple times. Current output prior to these dssector changes was: ('No Extension', 'Extension') appears 3 times in: ['epan/dissectors/packet-bssap.c', 'epan/dissectors/packet-camel.c', 'epan/dissectors/packet-gsm_map.c'] ('Optimised for signalling traffic', 'Not optimised for signalling traffic') appears 3 times in: ['epan/dissectors/packet-gsm_a_gm.c', 'epan/dissectors/packet-gsm_map.c', 'epan/dissectors/packet-gtp.c'] ('Data PDU', 'Control PDU') appears 3 times in: ['epan/dissectors/packet-pdcp-lte.c', 'epan/dissectors/packet-pdcp-nr.c', 'epan/dissectors/packet-rlc-nr.c'] ('Message sent to originating side', 'Message sent from originating side') appears 3 times in: ['epan/dissectors/packet-q2931.c', 'epan/dissectors/packet-q931.c', 'epan/dissectors/packet-q933.c'] ('User', 'Provider') appears 3 times in: ['epan/dissectors/packet-q2931.c', 'epan/dissectors/packet-q931.c', 'epan/dissectors/packet-q933.c'] The first and last ones were made common, the others seem a little too specialised. Checking some of the existing items in tfs.c (using QtCreator's 'Find Usages'), some of the common items are used a lot, but many of them are not referenced. Change-Id: Ia4006d2c4fa7cafbc3b004dc7a367a986dbeb0c4 Reviewed-on: https://code.wireshark.org/review/38177 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-06-19Fix the type of arrays of pointers to hf_ values for bitfield routines.Guy Harris1-48/+48
The static arrays are supposed to be arrays of const pointers to int, not arrays of non-const pointers to const int. Fixing that means some bugs (scribbling on what's *supposed* to be a const array) will be caught (see packet-ieee80211-radiotap.c for examples, the first of which inspired this change and the second of which was discovered while testing compiles with this change), and removes the need for some annoying casts. Also make some of those arrays static while we're at it. Update documentation and dissector-generator tools. Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc Reviewed-on: https://code.wireshark.org/review/37517 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-04-27Add string encoding values for various BCD encodings, and use them.Guy Harris1-75/+64
Add some ENC_ values for various flavors of packed BCD, and use that instead of explicitly calling tvb_bcd_dig_to_wmem_packet_str() and adding the result. Change-Id: I07511d9d09c9231b610c121cd6ffb3b16fb017a9 Reviewed-on: https://code.wireshark.org/review/36952 Reviewed-by: Guy Harris <gharris@sonic.net>
2020-04-06gsm_map: Dissect location number with the ISUP dissect functionVasil Velichkov1-116/+15
There are at least two problems with the previous implemenation: - The odd/even indicator was not used when dissecting the digits and an additional 0 was displayed when location number has odd number of digits. - For International Numbers the correct NA is 4 and not 3 (national) and for national numbers an incorrect country code is displayed. Change-Id: If5bb143642205eab762fbccae28f131af28d89c0 Reviewed-on: https://code.wireshark.org/review/36720 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-04-05proto: Add a debug check to sanity-check range_stringMartin Mathieson1-7/+6
Check is enabled by #ifdef ENABLE_CHECK_FILTER Remaining issues found by this check are fixed here, along with a documentation note that the entries are checked in order and the first match is used. The only issue not yet fixed is in packet-isup.c, where the spec was not available to me. Change-Id: Ife747cda9b91a265bc2b81ce0a53f55f3389919e Reviewed-on: https://code.wireshark.org/review/36708 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2020-03-11asn1: fix -Wmisleading-indentation warnings with Clang 10Peter Wu1-14/+14
A lot of auto-generated ASN.1 dissectors have broken identation and Clang 10 started warning about them for the first time. Fix these by using 2 spaces as indentation instead of 2, none, or tabs. Change-Id: Ia91668596c2f5000954d2265c39cc5dba18e44a7 Reviewed-on: https://code.wireshark.org/review/36368 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-02GSM MAP: Update to V15.5.0 (2019-06)Anders Broman1-4/+82
Change-Id: I7ff9ca683ba085f05b948c069eaeab9dffaf6605 Reviewed-on: https://code.wireshark.org/review/34676 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-14GSM MAP: Fix dissection of authenticationSet in SentParameterListAnders Broman1-5/+39
Ber choice called with a non FT_UINT hf variable. Work around by duplicating ASN1 code. Change-Id: I71b38e25288f222058793110eb43c122c012dcca Reviewed-on: https://code.wireshark.org/review/33191 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-23GSM MAP: Update to V15.4.0 (2018-12)Anders Broman1-58/+596
Change-Id: I2ce50236b963e14e48214e8a72a98bec96cfea71 Reviewed-on: https://code.wireshark.org/review/32958 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-04asn2wrs: Improve filtername of named bits.Anders Broman1-266/+266
Change-Id: Ie22137e95c8752a0783e3e9ff99b45c0b79b0d4a Reviewed-on: https://code.wireshark.org/review/32714 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-04epan: Convert our PROTO_ITEM_ macros to inline functions.Gerald Combs1-2/+2
Convert our various PROTO_ITEM_ macros to inline functions and document them. Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c Reviewed-on: https://code.wireshark.org/review/32706 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-03ASN.1: Use proto_tree_add_bitmask... () for named bits.Anders Broman1-417/+417
Change-Id: Ied0c91ea070ee76603e7ecb29d874e0c1a65892e Reviewed-on: https://code.wireshark.org/review/32684 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-02-25GSM MAP: Dissect several LocationInformationEPS's subparametersVasil Velichkov1-22/+73
Change DiameterIdentity's field type to FT_STRING and add dissection of - E-UTRAN Cell Global Identity - Tracking Area Identity - GeographicalInformation - GeodeticInformation Change-Id: Ifff52b511f495b281318778f6007be896748e4ce Reviewed-on: https://code.wireshark.org/review/32128 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-01Add a "failed" return for tap packet routines.Guy Harris1-2/+2
This allows taps that can fail to report an error and fail; a failed tap's packet routine won't be called again, so they don't have to keep track of whether they've failed themselves. We make the return value from the packet routine an enum. Don't have a separate type for the per-packet routine for "follow" taps; they're expected to act like tap packet routines, so just use the type for tap packet routines. One tap packet routine returned -1; that's not a valid return value, and wasn't one before this change (the return value was a boolean), so presume the intent was "don't redraw". Another tap routine's early return, without doing any work, returned TRUE; this is presumably an error (no work done, no need to redraw), so presumably it should be "don't redraw". Clean up some white space while we're at it. Change-Id: Ia7d2b717b2cace4b13c2b886e699aa4d79cc82c8 Reviewed-on: https://code.wireshark.org/review/31283 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-07GSM MAP: register a few more MAP SSNs by default.Jeff Morriss1-1/+1
SSNs 145 and 148-150 are all used by MAP so register for them. This allows Wireshark to decode messages between, for example, an SGSN and GMLC without having to touch the dissector preferences. Change-Id: Iaaad668bcde074a2a89d3de605659849856dc396 Reviewed-on: https://code.wireshark.org/review/30531 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-04Added support for new proprietary fields (private extensions) for Ericsson.dishadaniel1-495/+762
Change-Id: Ie97289527dbcef7e5d18e5e152659ebb5de9bc19 Reviewed-on: https://code.wireshark.org/review/27940 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-16GSM MAP: Dissect SM-RP-SMEAVasil Velichkov1-1/+12
According to 3GPP TS 29.002 this parameter contains an address field which is encoded as defined in 3GPP TS 23.040. Change-Id: If82a09e43729a90ede1619da34e50ed5d14e869a Reviewed-on: https://code.wireshark.org/review/27569 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-05-13Get rid of some GTK+-only stuff.Guy Harris1-2/+2
Change-Id: I85806476246a567f747e3911e3d15716e9cfe06b Reviewed-on: https://code.wireshark.org/review/27514 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-19Get rid of more new_ prefixes for statistics functions and types.Guy Harris1-21/+21
There are no "old" versions of them that we're keeping around. Change-Id: I3c76a14d0ec1a06df39c547da37f4dea9987df4d Reviewed-on: https://code.wireshark.org/review/25892 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-18ASN.1: update auto generated dissectorsPascal Quantin1-8/+8
Change-Id: Ic73e72b3d2e7590eaed07f6eb30f74f4303e7a65 Reviewed-on: https://code.wireshark.org/review/25880 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-30[GSM MAP] Propagate top_tree to external message handlers.AndersBroman1-3/+3
Change-Id: Ib3d0a43c0cdeca0ed32ff4dfef13c66e485fb0fb Reviewed-on: https://code.wireshark.org/review/23304 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-29[GSM MAP] Get rid of a global variable and use the newAndersBroman1-20/+19
dissector_try_uint_new() interface. Change-Id: I714ca04f43c00017969e8655614566df4c53e5e9 Reviewed-on: https://code.wireshark.org/review/23288 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Tomáš Kukosa <tomas.kukosa@ixperta.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-18[GSM MAP] Dissect Ext2-QoS-Subscribed, Ext3-QoS-Subscribed andAndersBroman1-29/+342
Ext4-QoS-Subscribed Change-Id: Ic6a0f80d5f2339fd90284d1fddffe57b66c6771d Reviewed-on: https://code.wireshark.org/review/23108 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-08-08We really only need one range_foreach routine.Guy Harris1-4/+4
Rename range_foreach_r() to range_foreach(), getting rid of the old range_foreach(). If your callback doesn't require an additional argument, just pass NULL when calling range_foreach(), and declare the argument as unused. Change-Id: I49a56f90610e39cf2ddc398c9e30ed11a6ca90db Reviewed-on: https://code.wireshark.org/review/23025 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-30GSM SMS: use TCAP OTID as last resort for reassembly when GSM MAP does not ↵Pascal Quantin1-75/+85
give info Bug: 13592 Change-Id: Ie13e7466da906e72418c6f9d5ea6f816ff14e129 Reviewed-on: https://code.wireshark.org/review/21425 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-04-29GSM MAP: use TCAP OTID to retrieve SM-RP-OA and SM-RP-DA fields when requiredPascal Quantin1-235/+387
Bug: 13592 Change-Id: Ib8a0ff6d897699c44e5c4b8834123169066cf904 Reviewed-on: https://code.wireshark.org/review/21397 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-04-24GSM SMS: optionally use GSM-MAP info to perform reassembly (off by default)Pascal Quantin1-90/+178
Change-Id: I62c7a04e62167bd2d68d861f1d8d854f3159b159 Ping-Bug: 13592 Reviewed-on: https://code.wireshark.org/review/21306 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-04-13[GSM MAP] Update to 3GPP TS 29.002 V14.3.0 (2017-03).AndersBroman1-25/+282
Change-Id: I97a4ee7cdcb8644a4f2e3f108842d4c28d788c54 Reviewed-on: https://code.wireshark.org/review/21076 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-05dissectors: fix this statement may fall through ↵Alexis La Goutte1-1/+1
[-Werror=implicit-fallthrough=] found by gcc7 Change-Id: Iba6238988ded675cba328ab512232d1919d93b4a Reviewed-on: https://code.wireshark.org/review/20415 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-01 01:58:10 +0000