aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-gsm_a_rr.c
AgeCommit message (Collapse)AuthorFilesLines
2012-08-25Following r44648, revert part of r44162 and followups so as to have a top ↵pascal1-358/+358
level gsm_a filter name git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@44667 f5534014-38df-0310-8fa8-9805f1628bb7
2012-08-10Use val_to_str_const() where appropriate;wmeier1-1/+1
Also (for a few files): - create/use some extended value strings; - remove unneeded #include files; - remove unneeded variable initialization; - re-order fcns slightly so prefs_reg_handoff...() at end, etc git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@44438 f5534014-38df-0310-8fa8-9805f1628bb7
2012-08-01Do not register fields twicepascal1-3/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@44195 f5534014-38df-0310-8fa8-9805f1628bb7
2012-08-01The minimum CCCH size is 3 bytes (L2 pseudo length + protocol discriminator ↵pascal1-1/+1
+ message type) git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@44192 f5534014-38df-0310-8fa8-9805f1628bb7
2012-08-01Follow-up of r44162: clean more filterspascal1-3/+7
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@44187 f5534014-38df-0310-8fa8-9805f1628bb7
2012-08-01Follow-up of r44162: RR dissector is not used only on Common Control ↵pascal1-366/+373
CHannels but also on Dedicated Control CHannels; update protocol name and filters accordingly git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@44185 f5534014-38df-0310-8fa8-9805f1628bb7
2012-08-01remove unnecessary underscores from display filtersmmann1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@44181 f5534014-38df-0310-8fa8-9805f1628bb7
2012-07-31Updated GSM dissectors display filters per checkfiltername.plmmann1-349/+349
Tried to provide consistency with GSM dissector (protocol) names, even if the filenames now don't match the dissector name. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@44162 f5534014-38df-0310-8fa8-9805f1628bb7
2012-06-28Update FSF address - part II.darkjames1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43538 f5534014-38df-0310-8fa8-9805f1628bb7
2012-06-20Use separate filters for the RTT found on a SACK and the RTT found on amorriss1-269/+267
DATA chunk: having them in both places is helpful when looking at the messages but having them separate is helpful when graphing the RTTs. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@43406 f5534014-38df-0310-8fa8-9805f1628bb7
2012-03-09From Sylvain Munaut: gsm_a_common: ELEM_MAND_VV_SHORT doesn't support IEs of ↵etxrab1-7/+14
different types. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6924 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@41445 f5534014-38df-0310-8fa8-9805f1628bb7
2012-03-06Don't use FT_*INT with true_false strings: the code to generatemorriss1-25/+25
representations of former is expecting value_strings--which are quite different than the latter. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@41362 f5534014-38df-0310-8fa8-9805f1628bb7
2012-02-23From Lei Chen:etxrab1-1/+1
a patch to support decode FDD_CELL_INFORMATION of "UTRAN FDD Description" in packet-gsm_rlcmac.c https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6856 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@41149 f5534014-38df-0310-8fa8-9805f1628bb7
2012-01-13Fix:wmeier1-7/+2
packet-gsm_a_rr.c:3867:101: error: parameter 'len' set but not used [-Werror=unused-but-set-parameter] packet-gsm_a_rr.c:6837:46: warning: variable 'bit_offset_sav2' set but not used [-Wunused-but-set-variable] packet-gsm_a_rr.c:7458:18: warning: variable 'curr_offset' set but not used [-Wunused-but-set-variab git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@40453 f5534014-38df-0310-8fa8-9805f1628bb7
2012-01-13Fix:etxrab1-11/+8
packet-gsm_a_rr.c:3289: warning: unused parameter 'len' packet-gsm_a_rr.c:3412: warning: unused parameter 'len' packet-gsm_a_rr.c:4449: warning: unused variable 'bit_len' packet-gsm_a_rr.c:4444: warning: unused parameter 'len' packet-gsm_a_rr.c:4557: warning: unused parameter 'len' packet-gsm_a_rr.c:6285: warning: unused parameter 'len' packet-gsm_a_rr.c:6765: warning: unused variable 'bit_len' packet-gsm_a_rr.c:6759: warning: unused parameter 'len' packet-gsm_a_rr.c:6987: warning: unused variable 'bit_len' packet-gsm_a_rr.c:6979: warning: unused parameter 'len' packet-gsm_a_rr.c:7457: warning: unused parameter 'len' git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@40451 f5534014-38df-0310-8fa8-9805f1628bb7
2012-01-13From Mike Morrin:etxrab1-632/+494
This is largely a cosmetic update of the gsm_a_rr dissector: • TBF starting time is now fully decoded. • “Double indenting” of IE groups (where an IE dissector adds a subtree just after the generic dissector adds a subtree) has been eliminated. • “Null” break points in CSN.1 IEs have been added where they were previously missing (this could have caused some correct PDUs to be reported as malformed). • The calculation of CSN.1 IE lengths has been corrected: ((a – b)>>3)+1 is not the same as (a>>3)-(b>>3)+1 . • The handling of CSN.1 padding bits is slightly improved. • The handling of CSN.1 “truncated” bits is slightly improved. • Eliminated superfluous checks for len==0 at the beginning of some rest-octet dissectors (the generic dissector won’t call the CSN.1 dissector if len is 0). • A few minor corrections to text strings and formatting. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6728 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@40447 f5534014-38df-0310-8fa8-9805f1628bb7
2012-01-11From Lei Chen:etxrab1-21/+14
An error in eutran_measurement_param_desc of GSM si2qua rest octet. From me fix similar bugs. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6721 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@40434 f5534014-38df-0310-8fa8-9805f1628bb7
2012-01-08From Mike Morrin:etxrab1-23/+4
GSM RR CCCH dissection ignores last octet of PDU. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6715 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@40405 f5534014-38df-0310-8fa8-9805f1628bb7
2012-01-05Fix the following error :alagoutte1-1/+1
packet-gsm_a_rr.c: In function 'de_rr_p2_rest_oct': packet-gsm_a_rr.c:4033:105: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@40386 f5534014-38df-0310-8fa8-9805f1628bb7
2012-01-05From Mike Morrin:etxrab1-1076/+634
Improvements to handling of gsm_um traces and dissection of ccch protocol https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5257 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@40385 f5534014-38df-0310-8fa8-9805f1628bb7
2012-01-01From Mike Morrin:etxrab1-20/+28
GSM ENHANCED MEASUREMENT REPORT PDUs were not dissected when present as L3_INFO in RSL MEAS_RES PDUs. It seems that the RSL L3_INFO needs to be handled by a different dissector depending on whether it contains a DTAP, SACCH or CCCH PDU, which fortunately can be deduced from the RSL PDU type. packet-rsl.c is updated to implement this. In packet-gsm_a_rr.c the dissection of PDUs with RR Short PD format is improved, and also some items are renamed to make clearer the difference between SACCH PDUs (which cna be normal or Short PD format) and RR Short PD format PDUs (which can occur on SACCH, CCCH, or DCH). https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6699 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@40357 f5534014-38df-0310-8fa8-9805f1628bb7
2011-12-12From Mike Morrin:etxrab1-32/+15
eliminates the global variable for tracking which nibble is to be decoded by taking advantage of the fact that half octet IEs always occur in pairs, and thus a pair can be grouped together for decoding. There was probably also some confusion caused by the macros UPPER_NIBBLE and LOWER_NIBBLE because the GSM bit numbering is opposite to Wireshark internal numbering, so I have changed these to be LEFT_NIBBLE and RIGHT_NIBBLE, which corresponds to the display format in Wireshark. The dissection order of half octet IEs has been adjusted where necessary to align with the ordering shown in the GSM specifications. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6658 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@40157 f5534014-38df-0310-8fa8-9805f1628bb7
2011-12-04From Vincent Helfre.etxrab1-5/+10
The offset in "Cell Selection Indicator after Release of all TCH and SDCCH" was not correct because the length was element was decoded twice. So I removed the second decoding of the length. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@40088 f5534014-38df-0310-8fa8-9805f1628bb7
2011-11-21Get rid of Warnings.etxrab1-8/+9
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39977 f5534014-38df-0310-8fa8-9805f1628bb7
2011-11-21From Vincent Helfre:etxrab1-87/+92
added the display of intermediate value used to decode ARFCN in range 1024/256 format. So now the W(n) values can be displayed and localised in the tvb buffer. The code was reworked a little to use the get_bit functions. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39976 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-24Fix encoding arg for various fcn calls:wmeier1-418/+418
- proto_tree_add_bits_item - proto_tree_add_bits_ret_val - proto_tree_add_bitmask - tvb_get_bits - tvb_get_bits16 - tvb_get_bits24 - tvb_get_bits32 - tvb_get_bits64 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39539 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-03Remove unused hf field.etxrab1-6/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39238 f5534014-38df-0310-8fa8-9805f1628bb7
2011-09-07Fix a 'set but not used' gcc warning; Mark param arg as _U_;wmeier1-27/+26
Whitespace cleanup: trailing blanks & "4 space tabs". git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38925 f5534014-38df-0310-8fa8-9805f1628bb7
2011-09-07From Lei Chen:etxrab1-15/+72
Implement 'IAR Rest Octets', 'IAX Rest Octets' and 'Multislot Allocation' https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6314 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38911 f5534014-38df-0310-8fa8-9805f1628bb7
2011-08-29From Lei Chen:etxrab1-1/+107
Support E-UTRAN neighbor cells in Enhanced Measurement Report. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6275 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38765 f5534014-38df-0310-8fa8-9805f1628bb7
2011-08-15From Jeremy Quirke:etxrab1-1/+1
misdecoding 3G Neighbour Cell Information Element in SI2quater message due to a coding typo https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6237 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38542 f5534014-38df-0310-8fa8-9805f1628bb7
2011-08-05From Lei Chen:etxrab1-3/+995
patch to support gsm rr decoding of Immediate Assignment rest octet https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6119 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38348 f5534014-38df-0310-8fa8-9805f1628bb7
2011-07-22Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.wmeier1-12/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38170 f5534014-38df-0310-8fa8-9805f1628bb7
2011-07-20Use ENC_BIG_ENDIAN.etxrab1-96/+96
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38135 f5534014-38df-0310-8fa8-9805f1628bb7
2011-04-09Don't assign to a proto_item * if the value won't be used: Coverity 911;wmeier1-2290/+2292
Fix bug wherein an item was apparently added to the wrong subtree: Coverity 910; Remove unneeded #includes; Do whitespace and indentation cleanup. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36530 f5534014-38df-0310-8fa8-9805f1628bb7
2011-04-04Change the signature of elem_fcn():ns to include pinfo.etxrab1-105/+101
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36443 f5534014-38df-0310-8fa8-9805f1628bb7
2011-04-04Change the msg_fcn() signature to include pinfo.etxrab1-54/+54
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36441 f5534014-38df-0310-8fa8-9805f1628bb7
2011-03-23From Vincent Helfre:etxrab1-1/+1
- added documentation in packet-csn1.h - fixed a bug in packet-csn1.c - fixed a BSIC description in packet-gsm_a_rr.c - removed the "_v" suffix in packet-gsm_rlcmac element description git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36284 f5534014-38df-0310-8fa8-9805f1628bb7
2011-02-23From Alexis La Goutte:etxrab1-2/+0
Cleanup packet-ipv6.h and dependency. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5713 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36031 f5534014-38df-0310-8fa8-9805f1628bb7
2011-02-22From Pascal Quantin:etxrab1-107/+95
[3GPP protocols] Prettify the display of Mandatory Value information elements https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5711 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36026 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-17- append TLLI value.etxrab1-43/+46
- Whitespace changes. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35572 f5534014-38df-0310-8fa8-9805f1628bb7
2010-12-16From Vincent Helfre:etxrab1-73/+258
fixed the conversions for utran and eutran threshold which are used for Enhanced Measurement Report. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35199 f5534014-38df-0310-8fa8-9805f1628bb7
2010-11-29From Vincent Helfre:etxrab1-175/+425
I have fixed some issue in the measurement information decoding in packet-gsm_a_rr.c. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35061 f5534014-38df-0310-8fa8-9805f1628bb7
2010-11-28From Alex Badea:etxrab1-2/+2
gsm_a_rr: System Information Type 4 / CBCH mobile allocation dissected incorrectly https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5436 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35054 f5534014-38df-0310-8fa8-9805f1628bb7
2010-11-09Add a value_string_ext.etxrab1-1/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34825 f5534014-38df-0310-8fa8-9805f1628bb7
2010-11-09Use value_string_ext for gsm_a_rr_rxlev_vals.etxrab1-4/+5
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34818 f5534014-38df-0310-8fa8-9805f1628bb7
2010-10-22From Vincent Helfre:etxrab1-27/+232
Some improvements for the presentations. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34620 f5534014-38df-0310-8fa8-9805f1628bb7
2010-10-20From Vincent Helfre:etxrab1-59/+94
various bug fix and enhancement for Release 8 additionnal parameters. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34585 f5534014-38df-0310-8fa8-9805f1628bb7
2010-09-27From Vincent Helfre:etxrab1-80/+58
Display the bits for .... .00. = PCID_Pattern: 0 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34262 f5534014-38df-0310-8fa8-9805f1628bb7
2010-09-27Initialize subtree.etxrab1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34261 f5534014-38df-0310-8fa8-9805f1628bb7
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-26 07:38:42 +0000