aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-gsm_a_gm.c
AgeCommit message (Collapse)AuthorFilesLines
2018-12-283GPP NAS: upgrade dissector to v15.5.0Pascal Quantin1-4/+55
Change-Id: I8cd60558ef6fb80d916f30aa79028cd87542d956 Reviewed-on: https://code.wireshark.org/review/31226 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-10-09NAS EPS: upgrade dissector to v15.4.0Pascal Quantin1-2/+36
Change-Id: I43c75c92beac87674bb1293ee4951e47560721d2 Reviewed-on: https://code.wireshark.org/review/30091 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-09-12gsm_a_gm: Fix dissection of 10.5.6.3 Protocol configuration options.AndersBroman1-3/+11
Session-AMBR dissected as QoS rules PDU session address lifetime dissected as Session-AMBR. Change-Id: Iee9e630644638718f37ddbc185e23add32ee61ea Reviewed-on: https://code.wireshark.org/review/29630 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-12NAS-5GS: Update towards spec 2.0.0AndersBroman1-1/+1
Change-Id: I31b1dda0f06bf1b719dc949dfd1a44c151f452b9 Reviewed-on: https://code.wireshark.org/review/28217 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-063GPP NAS: fix dissection of Linked TI IEPascal Quantin1-1/+1
Change-Id: Idb5713e8ab9ef7c33110380516261f0202b8b599 Reviewed-on: https://code.wireshark.org/review/28047 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-05-12gsm_a_gm: fix potential buffer overrun (read)Peter Wu1-3/+5
When the string "str" is empty, "str+1" is invalid. This function can be called from functions using SET_ELEM_VARS in packet-gsm_a_common.c which appear to check the length first, but packet-etsi_card_app_toolkit.c and packet-camel.c do not. Err on the safe side and do not add the item. Change-Id: I6bd559593bb10ff0b8bf08a48d828613e3d8ccf5 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4311 Reviewed-on: https://code.wireshark.org/review/27470 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-293GPP NAS: upgrade dissector to v15.2.0Pascal Quantin1-1/+50
Change-Id: I11510356950c1eab4d77f8473f62aa6428311853 Reviewed-on: https://code.wireshark.org/review/26682 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-01-183GPP NAS: rework PCO loop to better report extra data at the end of the payloadPascal Quantin1-7/+9
This will help identifying that the packet contains unexpected data at the end rather than triggering a malformed error when trying to fetch outside of the tvb. Change-Id: Ieb71204f3c364e809447157e7a71c3eb92620d85 Reviewed-on: https://code.wireshark.org/review/25366 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-01-033GPP NAS: upgrade dissector to v15.1.0Pascal Quantin1-0/+53
Change-Id: Ibfbed335d842e53eabce36e2955a9bb2790d46fb Reviewed-on: https://code.wireshark.org/review/25131 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-12-283GPP NAS: upgrade dissector to v14.6.0Pascal Quantin1-1/+24
Change-Id: If8d0ab933285f8398b0e8625e7c6e2ef0345fc95 Reviewed-on: https://code.wireshark.org/review/25040 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-11-173GPP NAS: fix dissection of PCO MSISDN container IDPascal Quantin1-3/+2
3GPP 24.008 is not very explicit regarding the encoding, but after rereading 3GPP 23.003 and 3GPP 29.272, it is most likely the E.164 number in TBCD encoding (so without TON/NPI byte). Change-Id: Iae58ccc2919d28cb802015205b3b5fb97a1c4abe Reviewed-on: https://code.wireshark.org/review/24463 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-09-253GPP NAS: upgrade dissector to v14.5.0Pascal Quantin1-6/+107
Change-Id: Ibf45c6b5930ee122004afc8d2ac84a751491f3a4 Reviewed-on: https://code.wireshark.org/review/23735 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-09-24GPRSCDR: decoding of PDPTypeJoakim Karlsson1-1/+1
Change-Id: Iec007c5276e30c982e776263ef753c002e2a9c72 Reviewed-on: https://code.wireshark.org/review/23660 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-093GPP NAS: upgrade dissector to v14.4.0Pascal Quantin1-3/+187
Change-Id: Iae5627a53683de0b359a95c21866513461b5d559 Reviewed-on: https://code.wireshark.org/review/22572 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-07GSM A GM: add APN rate control parameters elements in the right treePascal Quantin1-4/+4
Change-Id: Id0f4d84c9f0cf9c1e0ebfb45265a63e918f831e1 Reviewed-on: https://code.wireshark.org/review/22546 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-07-07GSM A GM: fix dissection of AER bitPascal Quantin1-2/+2
Change-Id: I705e0ed70bbd9c540615f6bf6e603596deb11d0d Reviewed-on: https://code.wireshark.org/review/22543 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-06-15gsm-a, nas-eps: enhance handling of missing mandatory i.e.Ivan Nardi1-80/+82
When a mandatory information element is missing, try to report an expert info, instead of throwing a fatal malformed exception (or of reporting nothing at all). According to TS 24.007 11.2.3, a mandatory i.e. may be part of the imperative part of the message, so that expert info should be at PI_ERROR level Change-Id: Id399c236f2923db36540bbda0d29d666548f7cbd Reviewed-on: https://code.wireshark.org/review/22134 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-13[ISAKMP] Dissect 3GPP private error and status messages in NOTIFY.AndersBroman1-1/+1
Change-Id: Iaa65c1cf9f358e36e77b4a5cad2543dcbb98072e Reviewed-on: https://code.wireshark.org/review/20090 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-23GSM A GM: align protocol / container id filter format with displayed onePascal Quantin1-1/+1
Change-Id: If5dcee6a2a9dd6de304e78f84456903c932ad452 Reviewed-on: https://code.wireshark.org/review/19393 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-12-23GSM A GM: use same spelling as the 3GPP specificationPascal Quantin1-2/+2
Change-Id: I706b64bb3875a15d8be0e486a03784e19ab5af23 Reviewed-on: https://code.wireshark.org/review/19392 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-12-21NAS EPS: upgrade dissector to v13.8.0Pascal Quantin1-2/+2
Change-Id: Ifad1fbd22984ad777278c7cc90622b205405cf1f Reviewed-on: https://code.wireshark.org/review/19377 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-12-16Remove proto_item_append_text calls in favor of BASE_UNIT_STRING.Michael Mann1-9/+8
Many proto_item_append_text calls were just adding a unit string to a field. There's a better way to do that now. Change-Id: Id18d5ac1ea4d8ecdc4cbe7ebaec07fbd2eab6e78 Reviewed-on: https://code.wireshark.org/review/19289 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-293GPP NAS: shorten some value_string to avoid truncation during displayPascal Quantin1-5/+5
Change-Id: I50f9bbec5405c17a59c5eaac9833929737b8c145 Reviewed-on: https://code.wireshark.org/review/18984 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-11-283GPP NAS: add an expert info when APN encoding exceeds 100 bytesPascal Quantin1-11/+13
As stated in 3GPP 23.003: "the APN has, after encoding as defined in the paragraph below, a maximum length of 100 octets" Change-Id: Iae23117f44ea5b668f6cb23dbd0e726e4e56ce41 Reviewed-on: https://code.wireshark.org/review/18972 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-10-11GSM A GM: add specific filters for IPv4 / IPv6 Protocol IDPascal Quantin1-10/+36
Bug: 13001 Change-Id: I6bdaa5cd034b9ccf608fe0f6913d099ee920f0db Reviewed-on: https://code.wireshark.org/review/18157 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-013GPP NAS: upgrade dissector to v13.7.0Pascal Quantin1-32/+89
Change-Id: I353608057c50e2631f6bae6a026f361640ec9560 Reviewed-on: https://code.wireshark.org/review/18006 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-08-31Don't do any Decode As stuff for dissector tables not used with Decode As.Guy Harris1-1/+1
Have all dissector tables have a "supports Decode As" flag, which defaults to FALSE, and which is set to TRUE if a register_decode_as() refers to it. When adding a dissector to a dissector table with a given key, only add it for Decode As if the dissector table supports it. For non-FT_STRING dissector tables, always check for multiple entries for the same protocol with different dissectors, and report an error if we found them. This means there's no need for the creator of a dissector table to specify whether duplicates of that sort should be allowed - we always do the check when registering something for "Decode As" (in a non-FT_STRING dissector table), and just don't bother registering anything for "Decode As" if the dissector table doesn't support "Decode As", so there's no check done for those dissector tables. Change-Id: I4a1fdea3bddc2af27a65cfbca23edc99b26c0eed Reviewed-on: https://code.wireshark.org/review/17402 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-07-05Network-Based IP Flow Mobility (NBIFOM) dissectorPascal Quantin1-4/+12
Based on 3GPP 24.161 V13.1.0 Change-Id: I7bf635c862bf7e0b73fd05bc8a55c900d1f4dd87 Reviewed-on: https://code.wireshark.org/review/16291 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-283GPP NAS: add a missing separator for optional stringPascal Quantin1-1/+1
Change-Id: Idddbae0e969b525ddbe31f3b1ddbccaed232891a Reviewed-on: https://code.wireshark.org/review/16197 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-283GPP NAS: upgrade dissector to v13.6.0Pascal Quantin1-48/+223
Change-Id: Ieffc5d6544f3bd121ff317ff598faaadb5f117ab Reviewed-on: https://code.wireshark.org/review/16194 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-15Allow control of individual columns to be (un)writable.Michael Mann1-2/+2
Most protocols just want to limit COL_INFO or COL_PROTOCOL so give that level of granularity. Bug: 12144 Bug: 5117 Bug: 11144 Change-Id: I8de9b7d2c69e90d3fbfc0a52c2bd78c3de58e2f8 Reviewed-on: https://code.wireshark.org/review/15894 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-233GPP NAS: upgrade dissector to v13.5.0Pascal Quantin1-6/+6
Change-Id: I454a6a07efe599924edcfd2a5adeeabaf902995b Reviewed-on: https://code.wireshark.org/review/14605 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-20Create call_data_dissector() to call data dissector.Michael Mann1-3/+1
This saves many dissectors the need to find the data dissector and store a handle to it. There were also some that were finding it, but not using it. For others this was the only reason for their handoff function, so it could be eliminated. Change-Id: I5d3f951ee1daa3d30c060d21bd12bbc881a8027b Reviewed-on: https://code.wireshark.org/review/14530 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-20Manually add protocol dependencies derived from find_dissector.Michael Mann1-2/+2
Started by grepping call_dissector_with_data, call_dissector_only and call_dissector and traced the handles passed into them to a find_dissector within the dissector. Then replaced find_dissector with find_dissector_add_dependency and added the protocol id from the dissector. "data" dissector was not considered to be a dependency. Change-Id: I15d0d77301306587ef8e7af5876e74231816890d Reviewed-on: https://code.wireshark.org/review/14509 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-17Associate dissector tables and heuristic subdissector lists with a protocol.Michael Mann1-1/+1
This will make it easier to determine protocol dependencies. Some LLC OUI dissector tables didn't have an associated protocol, so they were left without one (-1 used) Change-Id: I6339f16476510ef3f393d6fb5d8946419bfb4b7d Reviewed-on: https://code.wireshark.org/review/14446 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-103GPP NAS: fix dissection of GMM Identity Request, Response and ↵Pascal Quantin1-1/+1
Authentication and Ciphering Failure messages Bug: 12246 Change-Id: I0cad1c951c4939bde41c281cfc0cf5b4a08ea2a3 Reviewed-on: https://code.wireshark.org/review/14406 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-12-293GPP NAS: upgrade dissector to v13.4.0Pascal Quantin1-1/+164
Change-Id: Id4c7b29d63216e0475da93ed38b5a275bd29cd5c Reviewed-on: https://code.wireshark.org/review/12905 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-11-04Don't allow multiple registrations of a protocol in dissector tables.Michael Mann1-1/+1
The target here is the Decode As dialog where protocols have multiple registrations into a dissector table and that shows up as multiple entries in the Decode As dialog list with the same name so users are unsure which "dissector" they are choosing. The "default" behavior (done in this commit) is to not allow duplicates for a dissector table, whether its part of Decode As or not. It's just ENFORCED for Decode As. Bug: 3949 Change-Id: Ibe14fa61aaeca0881f9cc39b78799e314b5e8127 Reviewed-on: https://code.wireshark.org/review/11405 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-16GSM: fix dissection of additional access technology typePascal Quantin1-1/+1
Bug: 11599 Change-Id: I80e92eefd233ad7939f8fdf684727164bd89abf4 Reviewed-on: https://code.wireshark.org/review/11094 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-07-013GPP NAS: upgrade dissector to v12.10.0Pascal Quantin1-3/+20
Change-Id: Ia89e49d098f86450245c73c4d06a4359a25e3d53 Reviewed-on: https://code.wireshark.org/review/9444 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-04GSM: fix no previous prototype for 'de_sm_re_attempt_ind' [-Wmissing-prototypes]Alexis La Goutte1-1/+1
Change-Id: Iaf4c01f659f9c0eed8615e77d0eab81724b44385 Reviewed-on: https://code.wireshark.org/review/7908 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-033GPP NAS: upgrade dissector to v12.9.0Pascal Quantin1-4/+59
Change-Id: I6bffe7b5b95d72031df5aecac66129d2ceff517e Reviewed-on: https://code.wireshark.org/review/7889 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-012G/3G NAS: follow-up of ge74cb41Pascal Quantin1-150/+144
Change-Id: Id095bfb4a39b205517a8545e8a1c66927b4f4515 Reviewed-on: https://code.wireshark.org/review/7872 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-01Remove proto_tree_add_text from GSM dissectors.Michael Mann1-332/+291
Change-Id: I72a7c1a44bda7755d8b1376dd5e57c46f137ff31 Reviewed-on: https://code.wireshark.org/review/7870 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-18Add a CF_FUNC macro for casting BASE_CUSTOM functions.Gerald Combs1-1/+1
Add a CF_FUNC macro to match VALS, TFS, etc. This should help us to avoid the following warning: warning: ISO C forbids initialization between function pointer and 'void *' [-Wpedantic] We could start adding DIAG_OFF+DIAG_ON everywhere but this seems to be more consistent with the other macros in proto.h. Update each instance of BASE_CUSTOM to use CF_FUNC. Adjust a dummy variable name generated by asn2wrs.py that was triggering an invalid error in checkhf.pl. Fix an encoding arguement in packet-elasticsearch.c found by fix-encoding-args.pl. Change-Id: Id0e75076c2d71736639d486f47b87bab84e07d22 Reviewed-on: https://code.wireshark.org/review/7150 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-263GPP: upgrade 2G/3G NAS dissector to v12.8.0 and NAS EPS dissector to v12.7.0Pascal Quantin1-11/+31
Change-Id: I770506762074b50d40b4f4742d8316368f14b4de Reviewed-on: https://code.wireshark.org/review/6794 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-01-14[E212]Modify dissect_e212_mcc_mnc() to take E212 number type as anAndersBroman1-3/+3
argument. While at it remove deprecated APIs Change-Id: Ib1a7e9d7aeba6379fb4492816a0ac602e67493c6 Reviewed-on: https://code.wireshark.org/review/6534 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-07tvb_bytes_to_ep_str -> tvb_bytes_to_strMichael Mann1-2/+2
Change-Id: I79c613cbdd8dc939dd4c29ebc477fb6eefd5bfc4 Reviewed-on: https://code.wireshark.org/review/6371 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-02Replace proto_tree_add_text in dissector header files where it was used in a ↵Michael Mann1-64/+64
macro that should be expert info. Change-Id: I045368a0a91586231fc4b1e2700c2275088b76af Reviewed-on: https://code.wireshark.org/review/6244 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-25 16:01:39 +0000