aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-gsm_a_dtap.c
AgeCommit message (Collapse)AuthorFilesLines
2014-06-29convert to proto_tree_add_subtree[_format]Michael Mann1-143/+95
Change-Id: If110de1e0555637264f86f1508858d569871a9c7 Reviewed-on: https://code.wireshark.org/review/2675 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-1/+1
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-1/+1
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-16Convert a bunch of time_to_str functions to wmemEvan Huus1-1/+1
Change-Id: I24fe3cc4a3589dadc4528a77fe7ff13d06b1a983 Reviewed-on: https://code.wireshark.org/review/2245 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-2/+2
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-06-04packet-q931.c: proto_tree_add_text -> something filterable.Michael Mann1-1/+0
Change-Id: I576f8d7fcf01a4c1dc6e486f7dd0a5b46edce502 Reviewed-on: https://code.wireshark.org/review/1935 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-07(Benign) Don't use "address-of" operator on arg of VALS() (not that it makes ↵Bill Meier1-3/+3
any actual difference).. Change-Id: I0766d0f130648aaa5a58d9f4062fa24e898cbdc3 Reviewed-on: https://code.wireshark.org/review/545 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-25Remove trailing whitespace.Bill Meier1-6/+6
Change-Id: Ia03a1cd4590aceda30ead4aa93ad413d90c6aea6 Reviewed-on: https://code.wireshark.org/review/372 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-23Fix dissection of BCD numbersPascal Quantin1-7/+5
Do not use of tvb_get_string(): what we really want is the byte string, not an ASCII string Change-Id: I8b9a8b7ccacbdaf6d9525771ff8ed883ba01ad34 Reviewed-on: https://code.wireshark.org/review/329 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-01-01Add proto_tree_add_ts_23_038_7bits_item() / tvb_get_ts_23_038_7bits_string() ↵Pascal Quantin1-13/+2
functions and update dissectors to use it. Remove gsm_sms_char_7bit_unpack() / gsm_sms_chars_to_utf8() functions. Update documentation a bit. svn path=/trunk/; revision=54534
2013-12-23Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-6/+0
svn path=/trunk/; revision=54415
2013-12-20Fix a "'str' may be used uninitialized in this function" errorPascal Quantin1-1/+1
svn path=/trunk/; revision=54285
2013-12-20Fix time dissection broken in r54274Pascal Quantin1-14/+15
svn path=/trunk/; revision=54282
2013-12-19Try to please Clang-Code-Analysis buildbotPascal Quantin1-3/+2
svn path=/trunk/; revision=54278
2013-12-19proto_tree_add_text -> proto_tree_add_xxx conversion.Michael Mann1-1096/+732
svn path=/trunk/; revision=54274
2013-12-19Rename a couple of to_str functions to have ep_ in the name. This makes itEvan Huus1-2/+2
obvious that the returned string is ephemeral, and opens up the original names in the API for versions that take a wmem pool (and thus can work in any scope). svn path=/trunk/; revision=54249
2013-12-19Use tvb_get_string_enc(), or proto_tree_add_item(), rather thanGuy Harris1-19/+2
tvb_get_unicode_string() or g_iconv stuff. svn path=/trunk/; revision=54244
2013-12-18Add a sixteenth element to all BCD digit sets to avoid garbage values whenEvan Huus1-1/+1
decoding corrupt bytes. Some of these digit sets could probably be deduplicated... svn path=/trunk/; revision=54224
2013-12-15Fix [-Wmissing-prototypes]Jakub Zawadzki1-0/+3
svn path=/trunk/; revision=54135
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-1/+1
svn path=/trunk/; revision=52591
2013-09-22emem -> wmem conversion:Pascal Quantin1-4/+4
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-17Fix off by 1 error when dissecting Data Radio Bearer identity numberPascal Quantin1-2/+5
svn path=/trunk/; revision=52128
2013-09-16Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if ↵Michael Mann1-2/+2
hf_ field name is the first part of the formatted string. This was all manual inspection and most cases were either: 1. Case sensitivity differences between hf_ field name and formatted string. 2. Unnecessary whitespace between hf_ field name and colon in formatted string There are cases where the hf_ field name doesn't quite match the proto_tree_add_uint_format, but it's close enough that one of them should be "right", I'm just not sure which is, I just know the string in proto_tree_add_uint_format is the one displayed. svn path=/trunk/; revision=52098
2013-09-15Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if ↵Michael Mann1-4/+3
hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly. The script didn't catch as many as I would have liked, but it's a start. The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum. svn path=/trunk/; revision=52045
2013-09-03Batch of filterable expert info.Michael Mann1-9/+28
svn path=/trunk/; revision=51689
2013-08-30Convert a few dissectors from EMEM to WMEM APIPascal Quantin1-4/+4
svn path=/trunk/; revision=51597
2013-04-05Highlight the correct byte for TimezonePascal Quantin1-2/+2
svn path=/trunk/; revision=48751
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-6/+6
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-24Do not initialize ett_tree and dtap_msg_fcn when match_strval_idx does not ↵Pascal Quantin1-10/+27
find a match svn path=/trunk/; revision=48520
2013-03-19Upgrade NAS disssectors to v11.6.0Pascal Quantin1-1/+1
svn path=/trunk/; revision=48427
2013-03-19From beroset:Anders Broman1-3/+3
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48426
2013-03-18As suggested by Evan Huus, use extended value_stringsPascal Quantin1-10/+11
svn path=/trunk/; revision=48407
2013-03-18use enum values instead of hardcoded valuesPascal Quantin1-81/+81
(as suggested by Sylvain Munaut in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8487) svn path=/trunk/; revision=48397
2013-03-05From Joseph Chai:Anders Broman1-0/+1
Add aditional IE dissection. From me patch cleanup and add set fence for multiple DTAP messages in one frame. svn path=/trunk/; revision=48087
2013-01-22Try to fix dissection of GSM protocol family broken by r47209.Pascal Quantin1-80/+80
Using val_to_str seemed to be a good idea, but most value_string arrays were not properly filled or were using hacks. (I hope I got everything right...) svn path=/trunk/; revision=47218
2012-12-29Upgrade NAS disssectors to v11.5.0Pascal Quantin1-1/+1
svn path=/trunk/; revision=46842
2012-11-26Fix a purported [-Wshadow] warning;Bill Meier1-350/+352
Also: Do some minor whitespace and formatting changes. svn path=/trunk/; revision=46195
2012-10-04Upgrade NAS dissector to v11.4.0 (Release 11)Pascal Quantin1-33/+46
svn path=/trunk/; revision=45325
2012-09-21Dissect Update UE Location Information messagePascal Quantin1-2/+136
svn path=/trunk/; revision=45047
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-08-25Following r44648, revert part of r44162 and followups so as to have a top ↵Pascal Quantin1-89/+89
level gsm_a filter name svn path=/trunk/; revision=44667
2012-08-10Use val_to_str_const() where appropriate;Bill Meier1-5/+5
Also (for a few files): - create/use some extended value strings; - remove unneeded #include files; - remove unneeded variable initialization; - re-order fcns slightly so prefs_reg_handoff...() at end, etc svn path=/trunk/; revision=44438
2012-08-01Follow-up of r44162: clean more filtersPascal Quantin1-11/+0
svn path=/trunk/; revision=44187
2012-07-31Update filter names following the changes done in r44162Pascal Quantin1-140/+140
svn path=/trunk/; revision=44168
2012-07-31Updated GSM dissectors display filters per checkfiltername.plMichael Mann1-56/+56
Tried to provide consistency with GSM dissector (protocol) names, even if the filenames now don't match the dissector name. svn path=/trunk/; revision=44162
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-06-12Upgrade GSM BSSMAP dissection to Release 9 (V9.8.0)Pascal Quantin1-1/+1
svn path=/trunk/; revision=43227
2012-05-21Display Element ID in hexadecimal (like in 3GPP specs)pascal1-1/+1
Display EPS bearer ID in decimal svn path=/trunk/; revision=42755
2012-05-20Upgrade NAS dissector to Release 10 (v10.6.1)pascal1-6/+105
svn path=/trunk/; revision=42728
2012-05-15Remove unneeded #includes (stdlib, stdio, ctypes, time);Bill Meier1-1/+1
In a few cases: do some whitespace, indentation cleanup & reformatting. svn path=/trunk/; revision=42632
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 13:10:47 +0000