aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-gsm_a_common.c
AgeCommit message (Collapse)AuthorFilesLines
2020-06-08GSM A Common: Advance offset after reading type_of_shape.Anders Broman1-1/+1
Change-Id: Ic72c679ccacd707129574d62d20719e35746a3bf Reviewed-on: https://code.wireshark.org/review/37401 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-06-04gsm_a_common: Fix Dead StoreAlexis La Goutte1-1/+0
Fix dead store (Dead assignement/Dead increment) Warning found by Clang Change-Id: Ic4af292bf494355a78f75df7e00d3c06bfc6eb50 Reviewed-on: https://code.wireshark.org/review/37373 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-05-19gsm_common: Update geographical_descriptionAnders Broman1-4/+131
Change-Id: I53b24f55427af53b17233897a71cf5fd70131404 Reviewed-on: https://code.wireshark.org/review/37248 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-04-283GPP: Update Geographical Area Description (GAD).Anders Broman1-7/+13
Change-Id: I1ad8a4bd21ed590eae4d64b7a287256860e597ca Reviewed-on: https://code.wireshark.org/review/36963 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-22geographical_description: Don't mask Orientation of major axis octet 12Anders Broman1-2/+1
Change-Id: I7034cb6304bc7bab5f344b7438ffee6c5ea8844c Reviewed-on: https://code.wireshark.org/review/35897 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-01-21Diameter: Fix Location estimate.Anders Broman1-4/+4
- The AVP should be an OctetString - Orientation of major axis should not be multiplied by 2 according to the latest standard. Change-Id: I68532108cc36f4699c10b35ffdbcfaef0c29d9fe Reviewed-on: https://code.wireshark.org/review/35890 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-08-21GSM A DTAP: Try to ensure that global variable sccp_assoc is cleared.Anders Broman1-1/+1
Change-Id: I970e9314724c55c19d0b98578e54a5d1b598e307 Reviewed-on: https://code.wireshark.org/review/34336 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-06-20NAS 5GS: Framwork for dissecting UPDP messages.Anders Broman1-0/+6
Change-Id: Id08fe25cdf118e6912fa3f201dfd07bde5ebdaf9 Reviewed-on: https://code.wireshark.org/review/33679 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-04epan: Convert our PROTO_ITEM_ macros to inline functions.Gerald Combs1-2/+2
Convert our various PROTO_ITEM_ macros to inline functions and document them. Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c Reviewed-on: https://code.wireshark.org/review/32706 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-01Add a "failed" return for tap packet routines.Guy Harris1-15/+15
This allows taps that can fail to report an error and fail; a failed tap's packet routine won't be called again, so they don't have to keep track of whether they've failed themselves. We make the return value from the packet routine an enum. Don't have a separate type for the per-packet routine for "follow" taps; they're expected to act like tap packet routines, so just use the type for tap packet routines. One tap packet routine returned -1; that's not a valid return value, and wasn't one before this change (the return value was a boolean), so presume the intent was "don't redraw". Another tap routine's early return, without doing any work, returned TRUE; this is presumably an error (no work done, no need to redraw), so presumably it should be "don't redraw". Clean up some white space while we're at it. Change-Id: Ia7d2b717b2cace4b13c2b886e699aa4d79cc82c8 Reviewed-on: https://code.wireshark.org/review/31283 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-12GSM A: detect buffer overrun when decoding MS Classmark 3 IEPascal Quantin1-2/+7
Change-Id: I12d372afd8a50b9a04f92c53077e79116db6c255 Reviewed-on: https://code.wireshark.org/review/31024 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-10-04Revert "gsm-a-common: Use expert info on "to few bytes left""Anders Broman1-26/+1
This test does not work when looking for optional elements. This reverts commit 0cc8feb4b6bd5c2576ae5f11e947d172fe1e6cb1. Change-Id: Ib6794c647f6e1541b7257a59c4717a6a497c3a8a Reviewed-on: https://code.wireshark.org/review/30013 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-27gsm-a-common: Use expert info on "to few bytes left"AndersBroman1-1/+26
Change-Id: Iaa84d52c28fcb65cd65963f04a389f5902536eeb Reviewed-on: https://code.wireshark.org/review/29884 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-12NAS-5GS: Update towards spec 2.0.0AndersBroman1-0/+9
Change-Id: I31b1dda0f06bf1b719dc949dfd1a44c151f452b9 Reviewed-on: https://code.wireshark.org/review/28217 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-13Get rid of some GTK+-only stuff.Guy Harris1-22/+22
Change-Id: I85806476246a567f747e3911e3d15716e9cfe06b Reviewed-on: https://code.wireshark.org/review/27514 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-26[NAS 5GS] Add dissector for NAS5GS 3GPP TS 24.501.AndersBroman1-0/+9
This is not a complete dissector but can be commited as is. To be worked on. Change-Id: I2e698b57c849013657a1eeacef4b984c8b8c39ee Reviewed-on: https://code.wireshark.org/review/26051 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-19Get rid of more new_ prefixes for statistics functions and types.Guy Harris1-19/+19
There are no "old" versions of them that we're keeping around. Change-Id: I3c76a14d0ec1a06df39c547da37f4dea9987df4d Reviewed-on: https://code.wireshark.org/review/25892 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-30packet-rsl.c: Use value-string in RXLEV and RXQUAL fieldsPau Espin Pedrol1-0/+12
RXLEV and RXQUAL fields in RSL "Uplink Measurements" use same scale format (0-63, 0-7) as RXLEV and RXQUAL in RR. RXQUAL value-string is moved to packet-gsm_a_common.c in order to use it in both protocols. Change-Id: Idadd9505225353fec76b9605e2045a5222669475 Reviewed-on: https://code.wireshark.org/review/24663 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-08-29gsm_a_common: fix 'pinfo/len' was marked unused but was used ↵Alexis La Goutte1-4/+4
[-Wused-but-marked-unused] Change-Id: I831565d624711ebbcaf84b05e3a34dae58e1e064 Reviewed-on: https://code.wireshark.org/review/23282 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-16Remove proto_item_append_text calls in favor of BASE_UNIT_STRING.Michael Mann1-14/+8
Many proto_item_append_text calls were just adding a unit string to a field. There's a better way to do that now. Change-Id: Id18d5ac1ea4d8ecdc4cbe7ebaec07fbd2eab6e78 Reviewed-on: https://code.wireshark.org/review/19289 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-08GSM A: allow a length of 3 bytes when using the 'no identity' typePascal Quantin1-1/+1
As stated in 3GPP 24.008 §10.5.1.4, for GMM and EMM procedures the length should be set to 3 when using the 'no identity' type. Change-Id: Ib2d5930416b0d26853f4cc430df0ce2f29488877 Reviewed-on: https://code.wireshark.org/review/18707 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-09-02GSM MAP: Add OSM URI for locationEstimateUli Heilmeier1-3/+20
As requested by bug 10969 add a link to OSM for locationEstimate. Bug: 10969 Change-Id: I715b3b5eae9728999d5c8f8c155bbcef3911ee93 Reviewed-on: https://code.wireshark.org/review/17375 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-07-14packet-gsm_a_common.c: Create typedef declaration for elem_func signature.Michael Mann1-9/+11
This should keep VS Code Analysis happy. Change-Id: I99ebdc644ba353d5986d6509da784eeaa37dcc8f Reviewed-on: https://code.wireshark.org/review/16420 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-16qt: move free_stat_tables from SimpleStatisticsDialog::fillTree to ↵Dario Lombardo1-10/+20
~SimpleStatisticsDialog. Add a reference count to stat_tap_table_ui to prevent bad deallocations. Bug: 12437 Change-Id: Ib9b1f929d08a574c306dc755ec416ab94a3fd6d3 Reviewed-on: https://code.wireshark.org/review/15920 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-04-15GSM: add a sanity checkPascal Quantin1-0/+3
Like the one added in gcfc47c1 Change-Id: Ieb6aaa406ad141502980d4447d5ee9f03044acbe Reviewed-on: https://code.wireshark.org/review/14930 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-12-29Rename new_stat_tap_ui to stat_tap_table_ui.Guy Harris1-31/+31
A "new" statistics tap UI is a statistics tap UI where the statistics are maintained as tables and common code handles the tables; what matters is the tables, not that it's "new". Change-Id: I7a0e63cfac98c24cd5e7dce973b9a0cc5b6a03ba Reviewed-on: https://code.wireshark.org/review/12897 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-29There's no "old" stat_tap_table, so remove "new_" from the name.Guy Harris1-5/+5
Change-Id: I1a0349d5d9d47210a97ff7a99fb358e59fd70e72 Reviewed-on: https://code.wireshark.org/review/12896 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-07Spelling fixes for errors found by lintianBalint Reczey1-1/+1
Change-Id: I889283902875193f4d3f3fd59788f59f8d9bcc20 Reviewed-on: https://code.wireshark.org/review/11945 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-29Fix bugs introduced in gcfc47c1Pascal Quantin1-2/+1
Bug: 11797 Change-Id: I2574e19aa2b86f7c72370d98dd6a2b72b471da25 Reviewed-on: https://code.wireshark.org/review/12280 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-29Replace my_dgt_tbcd_unpack with the safer tvb_bcd_dig_to_wmem_packet_str.Michael Mann1-58/+6
Bug: 11797 Change-Id: I07fdf3f7564424eac053f4c17de17f0d96597cca Reviewed-on: https://code.wireshark.org/review/12239 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-04Don't include "file.h" if you don't need it.Guy Harris1-0/+1
It ends up dragging in libwireshark headers, which programs not linking with libwireshark shouldn't do. In particular, including <epan/address.h> causes some functions that refer to libwireshark functions to be defined if the compiler doesn't handle "static inline" the way GCC does, and you end up requiring libwireshark even though you shouldn't require it. Move plurality() to wsutil/str_util.h, so that non-libwireshark code can get it without include epan/packet.h. Fix includes as necessary. Change-Id: Ie4819719da4c2b349f61445112aa419e99b977d3 Reviewed-on: https://code.wireshark.org/review/11545 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-08-10GSM (a_common): fix indent (replace tab by 8 spaces)Alexis La Goutte1-142/+142
Change-Id: Id1d6bfcb04ac75d767fe6f09454dc8235de7bc75 Reviewed-on: https://code.wireshark.org/review/9928 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-08-08GSM (a_common): fix no previous prototype for 'gsm_a_*_init' ↵Alexis La Goutte1-11/+11
[-Wmissing-prototypes] Change-Id: I2990cb3432ad377cbed7039ad8fe15019eb7e7f5 Reviewed-on: https://code.wireshark.org/review/9927 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-08-08GSM (a_common): fix comma at end of enumerator list [-Wpedantic]Alexis La Goutte1-1/+1
Change-Id: I0ea06451861412b642d033a70e0a639aae753beb Reviewed-on: https://code.wireshark.org/review/9926 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-08-06Fixup stat_tap table freeing.Gerald Combs1-4/+16
As it turns out we *do* need to free table elements. We also need to free the tables themselves and clear the table array. Do so. Change-Id: Ic1c81388eac8f47f74caea0169c79685a83aaff9 Reviewed-on: https://code.wireshark.org/review/9901 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-08-04Convert the GSM A stats to new "generic stat API".Gerald Combs1-0/+363
These are largely untested, but the two abis captures on the wiki seem to work OK. The menu item names could also use some work. Patches welcome. Change-Id: I19a5b5fe3476b49d1dd0b684cbb7f367c6ebd4b4 Reviewed-on: https://code.wireshark.org/review/9869 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-07-013GPP NAS: upgrade dissector to v12.10.0Pascal Quantin1-1/+14
Change-Id: Ia89e49d098f86450245c73c4d06a4359a25e3d53 Reviewed-on: https://code.wireshark.org/review/9444 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-13GSM A: force display of the bits sequence corresponding to "Degrees of ↵Pascal Quantin1-1/+1
longitude" field It makes the display more consistent with other fields of Location Estimate IE Bug: 11114 Change-Id: Ib31c61a34f419cf97601a660f3b807454b1becd9 Reviewed-on: https://code.wireshark.org/review/8049 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-04GSM: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-2/+0
Change-Id: If10a9902c231b87995562fd0c687a25dcab3e250 Reviewed-on: https://code.wireshark.org/review/7910 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-033GPP NAS: upgrade dissector to v12.9.0Pascal Quantin1-1/+14
Change-Id: I6bffe7b5b95d72031df5aecac66129d2ceff517e Reviewed-on: https://code.wireshark.org/review/7889 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-033GPP NAS: display Short Element Identifier as it was done prior to ge74cb41Pascal Quantin1-1/+1
Change-Id: Ie001b420eb1fd29c8f5c941e69f4e2929250d887 Reviewed-on: https://code.wireshark.org/review/7885 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-04-01Remove proto_tree_add_text from GSM dissectors.Michael Mann1-135/+103
Change-Id: I72a7c1a44bda7755d8b1376dd5e57c46f137ff31 Reviewed-on: https://code.wireshark.org/review/7870 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-14[E212]Modify dissect_e212_mcc_mnc() to take E212 number type as anAndersBroman1-2/+2
argument. While at it remove deprecated APIs Change-Id: Ib1a7e9d7aeba6379fb4492816a0ac602e67493c6 Reviewed-on: https://code.wireshark.org/review/6534 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-02Replace proto_tree_add_text in dissector header files where it was used in a ↵Michael Mann1-18/+20
macro that should be expert info. Change-Id: I045368a0a91586231fc4b1e2700c2275088b76af Reviewed-on: https://code.wireshark.org/review/6244 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-23Deleting unneccessary #includes from dissectors.Martin Mathieson1-2/+0
Second batch (packet-eth.c -> packet-icmpv6.d). Will look at cleaning up and committing script afterwards. Change-Id: I14295758b81a59115d8c88899f166cc3d5d17594 Reviewed-on: https://code.wireshark.org/review/6013 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-4/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-043GPP: upgrade 2G/3G NAS dissector to v12.7.0 and NAS EPS dissector to v12.6.0Pascal Quantin1-3/+57
Change-Id: I1e5bc5d28cb956b333c302b1cb18335b59d096a8 Reviewed-on: https://code.wireshark.org/review/5621 Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-11-26Remove sccp_info member from packet_info structure.Michael Mann1-1/+0
sccp_msg_info_t* is now passed from SCCP dissector to its subdissectors through dissector data parameter. Change-Id: Iab4aae58f8995e844f72e02e9f2de36e83589fc0 Reviewed-on: https://code.wireshark.org/review/5442 Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-21 06:35:30 +0000