aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-goose.c
AgeCommit message (Collapse)AuthorFilesLines
2024-02-21R-GOOSE: Strengthen heuristic for CLTP on UDPJohn Thacker1-40/+0
Reduce false positives of the CLTP on UDP dissector (RFC 1240) by looking at the parameters as well and also ruling out length indicator zero. See https://ask.wireshark.org/question/31455/i-see-a-malformed-packet-in-wireshark-from-a-google-ip-address-on-port-2400-using-r-goose-protocol-what-could-this-be/ RFC 1240 was rendered Historic by RFC 2556, which noted that "at this time there do not seem to be any implementations" and recommended TPKT (ISO on TCP) instead. However, R-GOOSE does use RFC 1240. In practice, it seems like R-GOOSE uses the IANA registered port for ISO-TSAP, 102, just like TPKT does on TCP. Perhaps we should register the dissector to that port instead of a heuristic dissector if someone can confirm that. Move the dissector from goose to ositp. This doesn't cause any preference issues because heuristic dissectors are saved in the preference file by name and the name won't change.
2024-01-08asn2wrs: Fix our recursion checksGerald Combs1-1/+3
Don't subtract our cycle size when resetting our proto depth. Fixes #19580
2024-01-02asn2wrs: Add recursion checksGerald Combs1-0/+8
Add a recursion depth check whenever we have cyclic dependencies. Regenerate our dissectors. Fixes #19501
2023-11-02asn2wrs: Update to not initialize static proto valuesStig Bjørlykke1-125/+125
2023-08-08Convert asn2ws to generate C99 typesAnders Broman1-35/+35
2022-11-30asn2wrs: disable template line directive by defaultJoakim Karlsson1-33/+0
Same as with !8955, To debug with line directive build with -DENABLE_DEBUG_A2W=ON flag
2022-11-30asn2wrs: disable line directive by defaultJoakim Karlsson1-7/+1
To debug with line directive build with -DENABLE_DEBUG_A2W=ON flag
2022-11-01GOOSE: add back goose.floating_point filterPascal Quantin1-5/+4
Let's add it as a hidden filter for IEEE 754 single precision floating point Closes #18491
2022-04-05Regenerate ASN.1 dissectorsJoão Valverde1-3/+3
2022-03-29BER: Add a function to add a BER encoded boilerplate.Anders Broman1-5/+6
2021-07-26asn1: convert most dissectors to pinfo->poolEvan Huus1-3/+3
Part 1/2 as the commits were too big for CI. Largely find/replace, with a few manual tweaks. Then regenerate the asn1 dissector sources and make sure everything still builds. There are a handful of cases I skipped as too complex, but this covers most of the asn1 dissectors.
2021-02-01GOOSE: New option to display float valuesAitor Garcia1-12/+31
Added to the protocol a new option to display the decimal representation of floating-point values. Minor fixes: Avoid the double 'return' on dissect_goose_UtcTime function and fix the simulation BLURB to follow other fields approach.
2020-12-29GOOSE: fix a duplicate FIELD_RENAMEPascal Quantin1-2/+2
2020-12-29GOOSE: Interpret reserve1 S bitAitor Garcia1-14/+98
The simulated mirror bit of the reserve1 field is now interpreted. New expert info warning: S bit set and simulation attribute clear.
2020-12-28Improve R-GOOSE protocol treeĐorđije Manojlović1-14/+26
This enables filtering R-GOOSE packets on protocol level, too.
2020-12-16R-GOOSE dissector: Fix subtree item lengthsĐorđije Manojlović1-5/+11
2020-12-15Fix duplicated filter names.Anders Broman1-14/+14
2020-11-24Extend IEC 61850 GOOSE dissector to support IEC 61850 R-GOOSE protocolĐorđije Manojlović1-35/+422
R-GOOSE (Routable GOOSE) protocol is GOOSE protocol embedded into RFC 1240: OSI Connectionless Transport over UDP.
2020-02-25goose: test field is renamed to simulationAlexis La Goutte1-4/+4
The GOOSE dissector included Wireshark is using the GOOSE message definition that was described in an older version of the IEC 61850 standard. To be precise, the current field names in Wireshark corresponds to the Edition 1 of the IEC 61850 standard. This GOOSE message definition is defined in Table 23 of the IEC 61850-7-2:2003. In this release (IEC 61850-7-2:2003) there is a field name called: Test. However, in the new version of the IEC 61850, the Edition 2 of the IEC 61850 standard, the Test field was renamed to Simulation. To be precise, the new GOOSE message definition is defined in Table 43 of the IEC 61850-7-2:2010. Bug: 16402 Change-Id: I407987d7f4564b5bafa0c9217756c3f9f23918f6 Reviewed-on: https://code.wireshark.org/review/36175 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-03ASN.1: Use proto_tree_add_bitmask... () for named bits.Anders Broman1-1/+1
Change-Id: Ied0c91ea070ee76603e7ecb29d874e0c1a65892e Reviewed-on: https://code.wireshark.org/review/32684 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-18ASN.1: update auto generated dissectorsPascal Quantin1-5/+5
Change-Id: Ic73e72b3d2e7590eaed07f6eb30f74f4303e7a65 Reviewed-on: https://code.wireshark.org/review/25880 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-01ASN.1 dissectors - don't try to find yourself.Michael Mann1-6/+5
If an ASN.1 dissector is calling register_dissector for itself in its proto_register_xxx function and then calling find_dissector for itself in its proto_reg_handoff_xxx function then just create a static handle for that dissector and use the return value of register_dissector, so the find isn't necessary. Change-Id: I911bdadc2fb4259601c141b955e741a2369cc447 Reviewed-on: https://code.wireshark.org/review/16233 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-13Move /asn1 to /epan/dissectorsJoão Valverde1-13/+13
Change-Id: I1208fe3c2ba428995526f561e8f792b8d871e9a9 Reviewed-on: https://code.wireshark.org/review/14388 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: João Valverde <j@v6e.pt>
2015-12-09"new" dissector API -> dissector API for ASN.1 dissectors.Michael Mann1-1/+1
Change-Id: I7b794cba2feda2cae40411e2b1cb9fb091d08220 Reviewed-on: https://code.wireshark.org/review/12480 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-22register_dissector -> new_register_dissector for ASN.1 dissectors.Michael Mann1-23/+23
Change-Id: I0476519c02ffdd426b4fdfe8a206d61b728c327a Reviewed-on: https://code.wireshark.org/review/12026 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-09Replace deprecated API tvb_length -> tvb_reported_lengthAndersBroman1-1/+1
Change-Id: I9c8bf6beec47afb901e492723b335a28a24f455e Reviewed-on: https://code.wireshark.org/review/8004 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-23asn1 generated dissectors: cleanup #include usageBill Meier1-6/+5
Change-Id: I36b2731d67f9345d2fd0c23800bba7d2be94c387 Reviewed-on: https://code.wireshark.org/review/6008 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-08-09Eliminate (almost all) proto_tree_add_text calls from ASN.1 dissectors.Michael Mann1-6/+8
This mostly involved adding expert info capabilities to many of the dissectors so that they could correctly flag error conditions. Only remaining proto_tree_add_text calls are in H248.cnf, which has a convoluted way of using hf_ data to make its tree. Change-Id: I6412150c2ec1977d7fa38f3f0ed416680bdfb141 Reviewed-on: https://code.wireshark.org/review/3500 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-1/+1
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-1/+1
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-16Convert a bunch of time_to_str functions to wmemEvan Huus1-1/+1
Change-Id: I24fe3cc4a3589dadc4528a77fe7ff13d06b1a983 Reviewed-on: https://code.wireshark.org/review/2245 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-15Remove unused const variables errors seen with recent Clang versionPascal Quantin1-7/+1
Fixes bug 9886 Change-Id: I8624ef1c5874aea5521d21c998510fc29c838936 Reviewed-on: https://code.wireshark.org/review/657 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-02-18Remove $Id$ from the ASN.1 dissectors and regenerate them.Jeff Morriss1-8/+6
Change-Id: Ie476c6f82f318188b41ed922b92c6fec119ea954 Reviewed-on: https://code.wireshark.org/review/244 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2013-12-20Change G_GINT64_CONSTANT(xxxxU) to G_GUINT64_CONSTANT(xxxx)Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=54314
2013-12-19Rename more to_str functions to have ep_ in the name if they return ephemeralEvan Huus1-1/+1
buffers. Remove two unused functions. svn path=/trunk/; revision=54250
2013-12-08- Forward declaration of register functions.Anders Broman1-5/+8
svn path=/trunk/; revision=53872
2013-07-03expert_add_info + proto_tree_add_text = proto_tree_add_expert, where applicableMichael Mann1-6/+1
svn path=/trunk/; revision=50337
2013-06-25Move a couple of time-related modules into wsutil.Jeff Morriss1-6/+5
A bunch of files didn't really need to include these header files so remove the include line rather than changing it. svn path=/trunk/; revision=50154
2013-06-03Convert ASN.1 dissectors to use filterable expert info.Michael Mann1-7/+16
NOTE: Kerberos ASN.1 template was updated, but not generated to source. svn path=/trunk/; revision=49707
2013-05-27Postfix FT_NONE fields with "_element" string to reduce number of ↵Pascal Quantin1-12/+12
incompatible filters in ASN.1 dissectors https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2402 svn path=/trunk/; revision=49599
2013-04-26From me: only sign-extend BER integers if the field is actually signedEvan Huus1-2/+2
From Guy: override two fields in the GOOSE ASN.1 dissector to be unsigned Together these fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8250 svn path=/trunk/; revision=49055
2013-04-11Update the ASN.1 based dissectors following the changes done in r48812Pascal Quantin1-2/+2
svn path=/trunk/; revision=48820
2012-09-24Regenerate asn.1 dissectors.Jakub Zawadzki1-5/+5
svn path=/trunk/; revision=45110
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-02-05GOOSE Messages don't use the length field to perform the dissection.Anders Broman1-33/+27
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6734 #BACKPORT:YES svn path=/trunk/; revision=40873
2012-01-21From Martin Lutz:Anders Broman1-0/+41
Updated the GOOSE dissector ASN.1 file to be able to display data for UTC timestamps. svn path=/trunk/; revision=40628
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-2/+2
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-15Update generated ASN1 *.[hc] files after recent work done by Jeff Morriss;Bill Meier1-1/+1
The only change in each file is in a comment showing the asn2wrs cmd used to build that file. svn path=/trunk/; revision=39427