aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-giop.c
AgeCommit message (Collapse)AuthorFilesLines
2011-12-06Register giop by name (TCP).etxrab1-0/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@40107 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-24Fix encoding arg for various fcn calls:wmeier1-1/+1
- proto_tree_add_bits_item - proto_tree_add_bits_ret_val - proto_tree_add_bitmask - tvb_get_bits - tvb_get_bits16 - tvb_get_bits24 - tvb_get_bits32 - tvb_get_bits64 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39539 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.wmeier1-2/+2
Also: remove trailing whitespace for a number of files. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39503 f5534014-38df-0310-8fa8-9805f1628bb7
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵wmeier1-3/+3
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39260 f5534014-38df-0310-8fa8-9805f1628bb7
2011-09-21Fix vi "modeline" so it works;wmeier1-1/+1
See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5748 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@39074 f5534014-38df-0310-8fa8-9805f1628bb7
2011-08-16Based on patch from Denis Ovsienko viamorriss1-1/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6244 : Fix typo: s/unkown/unknown/ git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38561 f5534014-38df-0310-8fa8-9805f1628bb7
2011-07-13Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warningswmeier1-25/+25
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37999 f5534014-38df-0310-8fa8-9805f1628bb7
2011-07-11As noted by Jaap Keuter on -dev, be sure to use message_size instead ofcmaynard1-1/+1
header->message_size for a correct host endianness comparison. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37957 f5534014-38df-0310-8fa8-9805f1628bb7
2011-06-28Replace all strerror() with g_strerror().stig1-4/+1
Remove our local strerror implementation. Mark strerror as locale unsafe API. This fixes bug 5715. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@37812 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-07If we get an unknown reply status, don't print a g_warning message -guy1-2/+6
just put the reply body, if any, into the protocol tree as a blob. The protocol tree will note that it's an unknown status. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35414 f5534014-38df-0310-8fa8-9805f1628bb7
2010-12-06Make some (preference) variables static.morriss1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35134 f5534014-38df-0310-8fa8-9805f1628bb7
2010-10-30Use value_string_ext fcns to access a value_string array.wmeier1-6/+8
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@34726 f5534014-38df-0310-8fa8-9805f1628bb7
2010-05-28Move some code (including the optional objects) into libwsutilmorriss1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33012 f5534014-38df-0310-8fa8-9805f1628bb7
2010-05-13As suggested in ↵morriss1-17/+12
http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html (as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 : Write a new convenience routine for finding a conversation and, if it is not found, create it. The frame number and addresses are taken from pinfo (as is the common case). Use this function in a bunch of dissectors. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32790 f5534014-38df-0310-8fa8-9805f1628bb7
2010-02-01Various fixes:wmeier1-128/+182
1. Make message flags field filterable; 2. Fix various (relatively small) memory leaks mostly by using "seasonal" memory (instead of using g_malloc/g_new) so that memory is properly freed each time a capture file is (re)read. 3. Add some code so that use of a nested CLEANUP_PUSH could be removed. (The nested CLEANUP_PUSH was causing a gcc -Wshadow warning). 4. Use ep_alloc'd memory in one case to simplify code. 5. Clean up some indentation. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31758 f5534014-38df-0310-8fa8-9805f1628bb7
2010-02-01Create "decompressed Content" tab in hex bytes pane only if decompression ↵wmeier1-48/+54
actually done. This is a revision of SVN #29086 which caused the "decompressed Content" tab in the hex bytes pane to always be displayed. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31755 f5534014-38df-0310-8fa8-9805f1628bb7
2010-01-18Use consistent indentation; Reformat a few hf[] array entries.wmeier1-971/+984
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31553 f5534014-38df-0310-8fa8-9805f1628bb7
2009-09-08From Steve Osselton:etxrab1-17/+41
Fix for MIOP dissector for GIOP < 1.2. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3892 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29805 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-23Avoid 'cast to pointer from integer of different size'krj1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29511 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-22From Frederic Peters (made endian-aware by me):rbalint1-1/+14
fixed segfault with some GIOP packets git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29509 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-16Switch a bunch of dissectors over to using tvb_new_subset_remaining()krj1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29446 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-10From Steve Osselton:etxrab1-2/+11
GIOP dissector update for MIOP. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3847 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29369 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-09Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_checkkrj1-4/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29345 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkkrj1-2/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29340 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-13Check to see if tvb_child_uncompress returns NULL. Fixes bug 3705.gerald1-50/+52
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29086 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-07From Kovarththanan Rajaratnam:stig1-2/+2
More FT_XXX cleanup. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28971 f5534014-38df-0310-8fa8-9805f1628bb7
2009-06-18From Kovarththanan Rajaratnam via bug 3548:stig1-44/+44
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28770 f5534014-38df-0310-8fa8-9805f1628bb7
2009-05-14Apply some of the patches from:etxrab1-2/+1
http://wiki.wireshark.org/Development/Optimization git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28362 f5534014-38df-0310-8fa8-9805f1628bb7
2009-05-08FT_BOOLEAN fields w/o bitmasks really should use BASE_NONE (not BASE_DEC,...).wmeier1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28317 f5534014-38df-0310-8fa8-9805f1628bb7
2009-03-29More size_t casts.etxrab1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27879 f5534014-38df-0310-8fa8-9805f1628bb7
2009-03-03From Alvaro Vega Garcia:etxrab1-2/+19
Support ZIOP and MIOP (specialized CORBA protocols). https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3238 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27589 f5534014-38df-0310-8fa8-9805f1628bb7
2008-12-17Fix some typos and spelling (mostly in text strings)wmeier1-19/+19
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27037 f5534014-38df-0310-8fa8-9805f1628bb7
2008-11-13Small changes related to proto_register & proto_reg_handoffwmeier1-2/+1
- Move find_dissector_table(...) to proto_reg_handoff; - Use dissactor_add_handle instead of registering the dissector to tcp port 0; - Use find_dissector when appropriate. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26767 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-31Fix some "format not a string literal and no format arguments" warnings.stig1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26647 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-30Fix bug #3017: remove un-necessary code (and thus fix a small memory leak)wmeier1-3/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26626 f5534014-38df-0310-8fa8-9805f1628bb7
2008-09-11"Response flags" in GIOP Request is misinterpretedetxrab1-2/+12
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2800 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26177 f5534014-38df-0310-8fa8-9805f1628bb7
2008-05-22Move the file utility functions from wiretap to libwsutil so thatmorriss1-6/+6
libwireshark (and the plugins using those functions) do not depend on wiretap on Windows. While doing that, rename the eth_* functions to ws_*. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25354 f5534014-38df-0310-8fa8-9805f1628bb7
2008-04-09Remove:etxrab1-3/+0
#ifdef NEED_G_ASCII_STRCASECMP_H #include "g_ascii_strcasecmp.h" #endif git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24859 f5534014-38df-0310-8fa8-9805f1628bb7
2008-02-21Unkomment the now fixed value string...etxrab1-2/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24412 f5534014-38df-0310-8fa8-9805f1628bb7
2008-02-21Put back the use of g_ascii_strcasecmp(), so we don't get rudelyguy1-187/+190
surprised by, for example, "i" not comparing equal to "I" in Turkish locales. Make gMessageType local - it's not used as a global variable. Also, make it a pointer to const, so that we don't have to cast away the constness. dissect_giop_fragment() doesn't use the "header" argument, so get rid of it. Clean up indentation a bit. The first element of a value_string is the value, and the second argument is the string; fix up the initialization of the table of code set values. Fix a proto_tree_add_text() call to match the format and the arguments. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24411 f5534014-38df-0310-8fa8-9805f1628bb7
2008-02-21From Wolf Neumann:etxrab1-30/+251
GIOP reassembly fails when first packet of a PDU is received Out-of-Order http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1453 The patch changed to use value_string but not all values included in the current value_string. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24410 f5534014-38df-0310-8fa8-9805f1628bb7
2007-11-27strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delendaguy1-1/+5
est. Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our own versions if they're missing from GLib (as is the case with GLib 1.x). In the code to build the list of named fields for Diameter, don't use g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping in the hash function and use g_ascii_strcasecmp() in the compare function. We do this because there is no guarantee that toupper(), tolower(), and functions that use them will, for example, map between "I" and "i" in all locales; in Turkish locales, for example, there are, in both upper case and lower case, versions of "i" with and without a dot, and the upper-case version of "i" is "I"-with-a-dot and the lower-case version of "I" is "i"-without-a-dot. This causes strings that should match not to match. This finishes fixing bug 2010 - an earlier checkin prevented the crash (as there are other ways to produce the same crash, e.g. a bogus dictionary.xml file), but didn't fix the case-insensitive string matching. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23623 f5534014-38df-0310-8fa8-9805f1628bb7
2007-10-27From Steve Osselton:etxrab1-15/+18
The GIOP Fragment message type was added as of GIOP 1.1. However the Fragment message header (containing a request id) was only added as of GIOP 1.2. The GIOP Fragment dissector incorrectly attempts to process the request id for a version 1.1 request. To fix add a version check to the dissect_giop_fragment function in packet-giop.c: git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23289 f5534014-38df-0310-8fa8-9805f1628bb7
2007-10-23Apply the small performance enhancment patches for:etxrab1-1/+1
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster. Replace - col_append_fstr() with faster col_append_str() - col_add_str() with col_set_str() when it's safe git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23252 f5534014-38df-0310-8fa8-9805f1628bb7
2007-10-16Change more fopen() to eth_fopen() to finish fixing bug 1827:morriss1-1/+2
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1827 Update README.developer to tell developers not to use fopen() and friends directly. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23206 f5534014-38df-0310-8fa8-9805f1628bb7
2007-04-22Fix for bug 1541. Adjust offset for long longs by 8, not by 4.jake1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21496 f5534014-38df-0310-8fa8-9805f1628bb7
2007-04-14fix MacOSX gcc-3.3 warnings about unused tfs/value_string variablesstandel1-8/+2
most have been tagged unused (few have been deleted if dissector has not been modified since a long time) move packet-ssl-utils.c to DISSECTOR_SRC git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21431 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-24Clean up some more warnings: unused variables, unitialized variables, wrong ↵morriss1-31/+27
format (%ld instead of %d) in packet-sccp.c git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21167 f5534014-38df-0310-8fa8-9805f1628bb7
2006-12-22Fix for bug 1272.jake1-1/+4
Check length remaining before aligning. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20198 f5534014-38df-0310-8fa8-9805f1628bb7
2006-10-31change the signature for the get_pdu_len() function pointer passed to ↵sahlberg1-1/+1
tcp_dissect_pdus() to also include a packet_info pointer. there are many reasons why some protocols actually need to be able to access the pinfo structure while determining the pdu size git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19751 f5534014-38df-0310-8fa8-9805f1628bb7