aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-ftp.c
AgeCommit message (Collapse)AuthorFilesLines
2013-12-13Try to appease Visual Studio Code Analysis to avoid a false warning (as far ↵Chris Maynard1-4/+3
as I can tell), namely: warning C6054: String 'forbidden' might not be zero-terminated svn path=/trunk/; revision=54009
2013-12-13Do one or more of the following:Bill Meier1-5/+5
- Convert "4 space tabs" to spaces; - Remove some unneeded initializers; - 'offset++' --> 'offset += 1' for consistency; - Reformat hf[] entries; - Rework/add whitespace; - Adjust editor modelines (set tab-width to 8). svn path=/trunk/; revision=54005
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-7/+7
svn path=/trunk/; revision=52591
2013-09-14emem -> wmemMartin Kaiser1-7/+7
svn path=/trunk/; revision=52044
2013-07-16"man inet_pton" only says that it returns a negative value, zero or a ↵Chris Maynard1-47/+47
postive value, and not specifically -1, 0, or 1, so even though we know that's what wsutil's inet_pton will return, we shouldn't test against those exact values. svn path=/trunk/; revision=50670
2013-05-26Batch of filterable expert infos.Michael Mann1-6/+16
svn path=/trunk/; revision=49584
2012-12-26Fix a bunch of warnings.Guy Harris1-1/+1
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-12-07removed a last if (tree) check in dissect_ftpdata()Martin Kaiser1-21/+19
svn path=/trunk/; revision=46460
2012-12-07EPRT parameters are mandatory, flag up an error if they're missingMartin Kaiser1-52/+52
remove if (linelen!=0) check svn path=/trunk/; revision=46459
2012-12-07remove some more if (tree) checksMartin Kaiser1-23/+17
svn path=/trunk/; revision=46457
2012-12-07at one place, offset was incremented depending on if (tree)Martin Kaiser1-12/+10
this created a bug when offset was used later on remove the if (tree) check svn path=/trunk/; revision=46456
2012-12-07dissect_ftp() start at the beginning of the tvbMartin Kaiser1-11/+10
make this clear by not using a variable offset which is always 0 svn path=/trunk/; revision=46455
2012-12-07remove some more unnecessary if (tree) checksMartin Kaiser1-47/+43
svn path=/trunk/; revision=46454
2012-12-07remove some unnecessary if (tree) checks in the ftp dissectorMartin Kaiser1-41/+25
svn path=/trunk/; revision=46452
2012-10-24fix compliation on Win64Martin Kaiser1-1/+1
svn path=/trunk/; revision=45780
2012-10-24From Alexander KoeppeMartin Kaiser1-17/+93
parse EPSV response from me - no expert info under if(tree) - use hf_ftp_epsv_port instead of hf_ftp_pasv_port - don't use isdigit(), this is C99 - use temporary variable for IPv4 address https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7729 svn path=/trunk/; revision=45778
2012-10-15From Alexander KoeppeMartin Kaiser1-32/+44
use inet_pton() for address parsing in FTP's EPRT command support IPv6 addresses https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7729 svn path=/trunk/; revision=45565
2012-10-04From Alexander KoeppeMartin Kaiser1-1/+251
support for EPRT command as defined in RFC 2428 (IPv4 addresses only) from me simplify the code, expert info must not be under if(tree) based on the submission in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7729 svn path=/trunk/; revision=45308
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-05fix compilation on Win7x64 (I hope)Martin Kaiser1-1/+1
svn path=/trunk/; revision=44783
2012-09-05add modelines for the ftp dissectorMartin Kaiser1-0/+13
svn path=/trunk/; revision=44782
2012-09-05from Alexander KoeppeMartin Kaiser1-8/+19
ftp PASV and PORT commands: mark ip address and port in data view https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7693 svn path=/trunk/; revision=44781
2012-07-23Now check the first few bytes of the ftp-data segment to see if it looksMartin Mathieson1-16/+22
printable. If binary, just show the number of bytes in summary. Not that there are no items inside it, don't create ftp-data as a tree. Also, fix the type of the variable 'ti'. svn path=/trunk/; revision=43929
2012-07-22Calling tvb_format_text() for binary data segments (c1400 bytes) wasMartin Mathieson1-3/+6
*very* slow (in a profiled run where FTP data is carried over LTE MAC/RLC/PDCP/IP/TCP, this one function call was 20% of overall runtime). Have limited to call to ITEM_LABEL_LENGTH, as that is all that will be displayed anyway. As per comment, I'm not convinced that doing this for binary FTP data segments is worthwhile at all. It doesn't even display as hex. svn path=/trunk/; revision=43908
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-04-28Avoid assignement and clang warning.Martin Mathieson1-2/+1
svn path=/trunk/; revision=42317
2012-03-18Use a value_string_ext to reference a value_string array;Bill Meier1-599/+590
Use consistent indentation; Reformat some lines. svn path=/trunk/; revision=41640
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-2/+2
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵Bill Meier1-3/+3
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39426
2011-06-23Remove not needed forward declaration.Jakub Zawadzki1-3/+0
svn path=/trunk/; revision=37759
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-3/+3
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-11-04Corrected pointer types to avoid warnings from clang.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=34773
2010-09-15Remove a few more calls to check_col()Martin Mathieson1-13/+9
svn path=/trunk/; revision=34124
2010-01-18Fix a number of gcc _Wshadow warningsBill Meier1-3/+3
svn path=/trunk/; revision=31557
2009-10-25From Jakub Zawadzki:Anders Broman1-6/+2
Cleanup dissector code - use proper memory functions. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164 svn path=/trunk/; revision=30691
2009-10-19Adding RFC 2228 FTP replies.Jaap Keuter1-0/+15
svn path=/trunk/; revision=30623
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-4/+2
svn path=/trunk/; revision=29340
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-4/+4
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-03-30In packet-enttec.c and packet-fw1.c, replace string pointer tracking with aGerald Combs1-2/+2
string buffer. In packet-ftp.c and packet-gift.c, cast some size_t's. svn path=/trunk/; revision=27896
2008-09-27Minor cleanup for proto_reg-handoff & etcBill Meier1-5/+3
svn path=/trunk/; revision=26285
2008-07-30Register the FTP and ftp-data dissectors by nameJeff Morriss1-4/+6
svn path=/trunk/; revision=25871
2008-05-14Fix some of the Errors/warnings detected by checkapi.Bill Meier1-5/+9
svn path=/trunk/; revision=25290
2008-02-07Removed even more "statement not reached" warnings.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=24286
2007-07-30Parse EPSV responses (229) & set up FTP-DATA conversation.Martin Mathieson1-12/+113
svn path=/trunk/; revision=22423
2007-03-28Remove almost all of the casts I committed recently and in place ofStephen Fisher1-2/+2
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it. svn path=/trunk/; revision=21253
2007-03-27Fix about 100 simple to fix warnings from gcc 4.0 in epan/dissectors Stephen Fisher1-2/+2
svn path=/trunk/; revision=21233
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=18196
2005-08-17replace g_malloc() with ep_alloc() for ftp and sdpRonnie Sahlberg1-2/+2
sdp never free the allocated memory so it were leaking memory for every packet containng sdp. fix memleak for sdp svn path=/trunk/; revision=15381
2005-02-02From Jon Ringle:Anders Broman1-2/+2
1) Added a setup_frame parameter to conversation_t 2) Used the conversation_t next to maintain a list of conversations with the same src/dest tuple but different setup_frame number. 3) Changed the signature of find_conversation() and conversation_new() to pass in the frame number. 4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image are present, and T.38 conversation if only m=image is present. I expect that RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 packets. svn path=/trunk/; revision=13243
2004-07-18Move dissectors to epan/dissectors directory.Gilbert Ramirez1-0/+644
Also move ncp222.py, x11-fields, process-x11-fields.pl, make-reg-dotc, and make-reg-dotc.py. Adjust #include lines in files that include packet-*.h files. svn path=/trunk/; revision=11410
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-24 19:23:54 +0000