aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-fmp_notify.c
AgeCommit message (Collapse)AuthorFilesLines
2016-04-25fmp (notify): fix 'pinfo' was marked unused but was used ↵Alexis La Goutte1-1/+1
[-Werror,-Wused-but-marked-unused] Change-Id: Ib993d34e0def7c4f0c604357910635dfc4b41795 Reviewed-on: https://code.wireshark.org/review/15091 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-07-21Do all the work of registering an ONC RPC-based protocol in rpc_init_prog().Guy Harris1-5/+6
Hand it a table of version/procedure table/hf-for-program-number triplets. Change-Id: I2acc03c2da83353165bd422d8537362201c814e2 Reviewed-on: https://code.wireshark.org/review/9740 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-19Require dissectors for all ONC RPC calls and replies.Guy Harris1-2/+4
Either there's a known body for the call or reply, in which case we already have a dissector for it, or the body is empty, in which case we now have dissect_rpc_void() to dissect it, or the body is unknown or nobody's bothered writing it, in which case we use dissect_rpc_unknown() for now. This means that an attempt to look up the dissector for a known procedure will always succeed, so we can label it with the name rather than with "proc-N". It also means that we distinguish between "it's void" and "it's unknown", so that unknown values will get flagged as such. Change-Id: I748580c1dca61d1f0972396db1a3b0885fc0a541 Reviewed-on: https://code.wireshark.org/review/9699 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-07-02Have RPC dissector use real dissector tables for its subdissectors instead ↵Michael Mann1-1/+1
of a "homegrown" method. Change-Id: I06d7d4e9747ed8593cf40506cae3a09ae237846b Reviewed-on: https://code.wireshark.org/review/9456 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-07-02Replace RPC "dissect_function_t" function signature with "new style" ↵Michael Mann1-35/+31
dissector function signature. This paves the way for using dissector tables. Change-Id: I88ac165ef9aa5bf5c05e1115f7321e18e734d683 Reviewed-on: https://code.wireshark.org/review/9453 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-23Deleting unneccessary #includes from dissectors.Martin Mathieson1-1/+0
Second batch (packet-eth.c -> packet-icmpv6.d). Will look at cleaning up and committing script afterwards. Change-Id: I14295758b81a59115d8c88899f166cc3d5d17594 Reviewed-on: https://code.wireshark.org/review/6013 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-3/+1
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-10-04Add editor modelines; Reformat as appropriate.Bill Meier1-200/+213
Change-Id: I8e9c58b75eea85877d22024201e5d8d0e9a3dbfd Reviewed-on: https://code.wireshark.org/review/4459 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-06-26convert to proto_tree_add_subtree[_format]Michael Mann1-15/+6
Change-Id: I525ac2aae2bdbfd5f3a2f3b35f1bf10dde053f66 Reviewed-on: https://code.wireshark.org/review/2667 Tested-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-15Fix [-Wmissing-prototypes]Jakub Zawadzki1-0/+3
svn path=/trunk/; revision=54135
2013-11-10Add data parameter to dissect_function_t in vsff structure. The intention ↵Michael Mann1-14/+14
here is to use it to replace some pinfo->private_data. I didn't realize how expansive this change would be, so committing it now before replacing the pinfo->private_data, so if something needs to be reverted, all of this is not lost. svn path=/trunk/; revision=53213
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-1/+1
svn path=/trunk/; revision=52591
2013-07-17Convert proto_tree_add_tree calls to something filterable.Michael Mann1-57/+42
Remove "effectively useless" blurbs. svn path=/trunk/; revision=50689
2013-03-19From beroset:Anders Broman1-2/+2
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48426
2013-02-05Add missing hf[] entries found by checkhf.Bill Meier1-1/+19
ERROR: NO ARRAY: packet-fmp_notify.c, hf_fmp_extentList_len ERROR: NO ARRAY: packet-fmp_notify.c, hf_fmp_extent_state ERROR: NO ARRAY: packet-fmp_notify.c, hf_fmp_numBlks ERROR: NO ARRAY: packet-fmp_notify.c, hf_fmp_startOffset ERROR: NO ARRAY: packet-fmp_notify.c, hf_fmp_volID svn path=/trunk/; revision=47494
2013-02-03#if 0 unused hf[] entries & etc.Bill Meier1-1/+3
Note: All (or almost all) unused hf[] entries in non-generated Wireshark dissectors have been #if 0'd (or commented) out. (This applies only to 'static hf_...' vars). A number of (non-generated) dissector files with *missing* hf[] entries still need to be fixed. svn path=/trunk/; revision=47459
2012-10-12Move proto_register...() and proto_reg_handoff...() to the end of the file ↵Bill Meier1-99/+97
as per convention; Do minor whitespace changes. svn path=/trunk/; revision=45503
2012-10-12Fix (what appears to be) a minor "off by one" bug in 'for' loop.Bill Meier1-1/+1
svn path=/trunk/; revision=45500
2012-10-11Change 'for (i=1; i<=n;...' to 'for (i=0; i<n; ...)Bill Meier1-2/+2
The changes fix definite problems or are done "just in case" for cases not esily determined to be a problem by quick inspection. Note: in some cases for loop index variables have been renamed to ensure all required codes changes detected. ##backport svn path=/trunk/; revision=45477
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45017
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-05-04AFAICT sys/types.h & netinet/in.h #includes are not needed for these files.Bill Meier1-4/+0
(Let's see if any of the buildbots give any errors). Also: remove trailing whitespace on lines. svn path=/trunk/; revision=42429
2011-08-08Dissectors don't need to #include <gmodule.h>Bill Meier1-1/+0
Also: #include <stdlib.h> not req'd in some cases. svn path=/trunk/; revision=38409
2011-07-28 Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warning;Bill Meier1-49/+23
Also: Return same 'offset' from functions whether or not 'if(tree)' svn path=/trunk/; revision=38244
2011-05-26From Michael Mann.Anders Broman1-1/+1
Part of "display filters with redundancies of PROTABBREV in them." The ones left outs should be fixed differently I think. Rename som ndps hf variables while at it. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2794 svn path=/trunk/; revision=37406
2011-02-11Register a couple ett_ variables. Declare all the ett_ variables together.Jeff Morriss1-6/+7
svn path=/trunk/; revision=35919
2010-12-06Make a whole bunch of symbols static.Jeff Morriss1-20/+20
svn path=/trunk/; revision=35139
2010-04-06#include <string.h> not needed.Bill Meier1-1/+0
svn path=/trunk/; revision=32410
2009-08-23Get rid of a bunch of "warning: redundant redeclaration of" messages.Jörg Mayer1-1/+19
In that process, include the contents of packet-fmp_notify.h directly in packet-fmp_notify.c - it wasn't used anywhere else. svn path=/trunk/; revision=29512
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-5/+5
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2008-08-25#include <prefs.h> not req'dBill Meier1-1/+0
svn path=/trunk/; revision=26089
2007-02-04From Sebastien Tandel:Stephen Fisher1-0/+0
Execute permission should be changed [removed] on files packet-fmp.[c,h] and packet-fmp_notify.[c,h]. svn path=/trunk/; revision=20713
2007-02-01 Ronnie Sahlberg1-0/+644
Ian Schorr <ian.schorr@gmail.com> Wed, Jan 31, 2007 at 7:24 PM To: wireshark-dev@wireshark.org Hello, Please consider for checkin the following new dissectors, for the FMP protocol. FMP (File Mapping Protocol) is the network protocol basis for EMC's HighRoad (MPFS) technology.  Highroad is used to allow multiple clients to share access to NAS-shared files while allowing clients to directly access data volumes (via, for example, Fibre Channel or iSCSI).  EMC currently uses this technology in our Celerra NAS servers, and we're currently in the process of open sourcing portions of the technology. FMP actually consists of two ONC/RPC-based protocols - the core FMP protocol, and FMP/Notify.  The latter is used as an asynchronous callback to inform clients of status changes, such as lock revocation. We'd like to offer these dissectors to Wireshark users for help in debugging or otherwise troubleshooting MPFS-related problems.  There are still a few minor changes that need to be made ( i.e. a handful of fields that aren't decoded) but the dissector is overall fairly complete and very usable. Let me know if there are questions or feedback, or otherwise if other info is needed (like sample captures, which I don't want to send out to the mailing list). Thanks, Ian Schorr EMC Corporation svn path=/trunk/; revision=20679