Age | Commit message (Collapse) | Author | Files | Lines |
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26089 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
The Fibre-channel FCP dissector shows the wrong byte as the response info
response code byte. The byte with offset 2 in the FCP frame is shown
instead of byte 3 inside the response info.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25439 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25305 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
-set_str2add_str_val_to_str
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23406 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20866 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19682 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
dissector (dissect_scsi_payload) so that we can later add reassembly of data pdu's
and also (if reassembly is disabled) only dissect the initial (offset==0) data pdu.
dissect_scsi_payload() does not yet use this parameter.
now that we have both data offset and expected data length/bidir expected data length and also the read/write flags availabe we have what we need to reassemble data in/out pdus (modulo overflow/underflow but those are so rare we can worry about them later).
ndmp: ndmp conceptually always has a data in and a data out phase and never fragment the data into smaller pdu's os that dissector always report offset as 0.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19511 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
pass conversation form the transports up to the scsi layer
add tracking of conversation specific info to scsi osd
add tracking of conversation+lun specific info to scsi osd
for scsi osd add tracking of PARTITIONS and display in which frame they were created/removed
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19505 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
so that the two scsi transports FCP and ISCSI can provide the expected data transfer lengths to SCSI to allow SCSI reassembly.
NDMP does not really need these hints since for NDMP (and also iscsi-lite) there is conceptually always both data in and data out phases and there is never any fragmentation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19493 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19492 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18894 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18196 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
update the comment in packet-scsi.c to reflect that it is the transport now that is responsible to track itl and itlq data
make scsi tapable
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17974 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
structures for scsi.
we no longer need the scsi_task_id structure passed by pinfo->private_data so get rid of it.
we no longer need the (broken by design) scsi_task_data hash table since this has been replaced byt hte itl and itlq structures and tracking
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17952 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
part of the exchange data in itlq
remove the two fields opcode and devtype from the scsi_task_data structure since these are also part of the itlq and itl structures
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17949 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
and get rid of some breakage in the design
let the scsi transport keep track of itl (initiator, target, lun) matching
and let it pass a itl structure to scsi that is persistent across packets.
let scsi use this itl structure to track device type for a specific itl instead of the (must have been) broken hashtable.
update both iscsi and fc to track the itl structure for scsi and schange the scsi signature to accept itl as a parameter.
more to come.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17942 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17922 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
just a lun.
this finally allows us to have scsi.time for scsi transactions but we need to cleanup and refactor the other three scsi entrypoints before we should implement scsi srt to make the other three also take an exchange data structure as parameter from their transports (and get rid of the pinfo->private_data )
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17838 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
way through to the response
and get rid of the broken hashtable used for the same purpose previously.
some additional cleanups.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17827 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17826 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17824 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
structure.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17823 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
track them in the main entry point for the protocol dissector instead.
this is semi-temporary though since FCP will always sit ontop of FC which also tracks the same conversations so there is no need to do a redundant conversation tracking in fcp itself.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17822 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
dont dereference cdata null pointer
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17814 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
helper functions
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17813 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17812 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
call the scsi response dissector as well
(so that eventually we can do things like SRT for SCSI)
it doesnt work yet since fcp is using some incredibly broken logic to
track state between frames.
the cdata stuff can just not ever work exscept for single scan tethereal dissection.
is there noone at all looking at these protocols wioth ethereal?
has noone noticed it is completely broken yet?
sigh, soon i think i will be able to add the originally estimated trivial to implement SCSI SRT
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17811 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17807 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
add missing flags to the dissection and during refactoring fix several things that just can not have worked previously.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17805 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
convey that something real bad has happened.
Therefore put them and fence them at the start of the Info column
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17393 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
remove the remaining strcpy() from this dissector and make it decode the bitmap PROPERLY.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15995 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
and get rid of the silly strcpy() stuff.
there is a HUGE number of these kinds of very ugly bitmap dissection in all the fibre channel related dissectors and all need to be converted to proer dissection.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15994 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
directory to the epan directory. Some of them should perhaps ultimately
be moved to epan/dissectors, if they pertain only to stuff exported by a
particular dissector.
Fix Gerald's e-mail address in files we're moving.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15844 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
I've done more than a day to change the timestamp resolution from microseconds to nanoseconds. As I really don't want to loose those changes, I'm going to check in the changes I've done so far. Hopefully someone else will give me a helping hand with the things left ...
What's done: I've changed the timestamp resolution from usec to nsec in almost any place in the sources. I've changed parts of the implementation in nstime.s/.h and a lot of places elsewhere.
As I don't understand the editcap source (well, I'm maybe just too tired right now), hopefully someone else might be able to fix this soon.
Doing all those changes, we get native nanosecond timestamp resolution in Ethereal. After fixing all the remaining issues, I'll take a look how to display this in a convenient way...
As I've also changed the wiretap timestamp resolution from usec to nsec we might want to change the wiretap version number...
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15520 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15321 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
-use g_snprintf instead of sprintf and snprintf
-use g_strdup_printf where appropriate
-remove #include "snprintf.h" (as only g_snprintf should be used)
-replace some more alloc/realloc/calloc/free with their glib pendants
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15264 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
The FC D_id and S_id fields in teh FC frame encapsulated inside iFCP unfortunately has "undefined" (semi-random) values so we can not use th S_/D_id matching in FC when transported atop iFCP.
Change iFCP to call a new fc_ifcp handler instead of the fc handler.
Add a new handler to FC specific to iFCP.
Only set the pinfo->src/dst fields to the S_id/D_id fields IFF the FC frame was NOT transported ontop of iFCP.
Othervise we just use the TCP/IP values that are already stored there.
Some Hosts use RelativeOffset fields for FC. We can only dissect the RelOff field with offset 0.
Change FC to only call the FCP subdissector if offset==0 when relative offsets are used.
Some hosts when using relative offsets do not specify a proper value for rxid in teh commands instead htey lkeave it as 0xffff
Change the FCP conversation matching to ignore RXID when searching for a conversation.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15076 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
Fix up whitespace and newlines.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15072 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14473 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
change the signature for dissect_scsi_cdb since we no longer need to pass offset over.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14472 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
Use "tvb_ensure_bytes_exist()" to check for some invalid lengths.
Add some comments about possible problems in the code.
Get rid of an unnecessary length check (the length is the sum of a small
constant and a value extracted from a single byte, so the sum won't
overflow).
For a FCP_RSP, make the top-level protocol tree item run to the end of
the tvbuff and then set its length when we finish dissecting it (if we
throw an exception and don't get around to setting the length, that
means that we hit the end of the tvbuff before we hit the end of the
item). Add some checks to catch too-large length fields.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13917 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
places.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13899 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
parameters"
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13684 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
on scsi.lun and prettify the summary line a bit.
ndmp still needs some work to track luns between commands
and fcp needs verification it works for volumesetaddressing.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13420 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
1) Added a setup_frame parameter to conversation_t
2) Used the conversation_t next to maintain a list of conversations with the
same src/dest tuple but different setup_frame number.
3) Changed the signature of find_conversation() and conversation_new() to pass
in the frame number.
4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image
are present, and T.38 conversation if only m=image is present. I expect that
RTP/T.38 dissecting to be better, but I don't have a way to generate T.38
packets.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@13243 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
pointers.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12890 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12115 f5534014-38df-0310-8fa8-9805f1628bb7
|
|
Also move ncp222.py, x11-fields, process-x11-fields.pl,
make-reg-dotc, and make-reg-dotc.py.
Adjust #include lines in files that include packet-*.h
files.
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11410 f5534014-38df-0310-8fa8-9805f1628bb7
|