aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-fcp.c
AgeCommit message (Collapse)AuthorFilesLines
2013-12-12Get rid of a dissector table that has never been used.Guy Harris1-21/+0
Get rid of a field that was hidden, always set to 0, and not obviously used anywhere. svn path=/trunk/; revision=53994
2013-12-10Reject the packet if data is NULL.Chris Maynard1-1/+6
svn path=/trunk/; revision=53899
2013-11-28Bugfix Negative Fibre Channel scsi_time value. Bug 3209 ↵Michael Mann1-29/+92
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3209) The solution was to move the itlq_nexus_t structure handling from the FC dissector to the FCS dissector since it's actually the one with the LUN field. OXID+LUN makes a unique exchange at FC layer so track that separately. Also needed some additional OXID->LUN mapping at the FC layer to keep LUN correctly persistent. Not backporting because this was partially made possible by r53569, which won't be backported. svn path=/trunk/; revision=53620
2013-11-25mark unused parameterMartin Kaiser1-1/+1
svn path=/trunk/; revision=53571
2013-11-25Remove Fibre Channel specific fields from packet_info and just have the ↵Michael Mann1-9/+7
fc_hdr or fc_data_t structure passed between all necessary dissectors. svn path=/trunk/; revision=53569
2013-11-23Create the ability to have packet scoped "proto" data. Bug 9470 ↵Michael Mann1-3/+3
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470) I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do. The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As. All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data. svn path=/trunk/; revision=53520
2013-10-21Pass fc_hdr "private data" into subdissectors instead of using ↵Michael Mann1-6/+6
pinfo->private_data. svn path=/trunk/; revision=52729
2013-08-31Convert another 10 dissectors to wmem.Evan Huus1-11/+11
svn path=/trunk/; revision=51612
2013-07-03Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+4
svn path=/trunk/; revision=50357
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-10/+4
svn path=/trunk/; revision=49920
2013-05-12Add the posibillity to use a key for per-packet-data.Anders Broman1-3/+3
svn path=/trunk/; revision=49259
2013-03-19From beroset:Anders Broman1-7/+7
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48412
2013-01-31Comment out unused hf[] entries & etc.Bill Meier1-4/+8
(found by checkhf) svn path=/trunk/; revision=47389
2012-12-08Fix some compiler warnings under gcc.Evan Huus1-11/+22
svn path=/trunk/; revision=46466
2012-12-08Bugfix FCP lun request/response tracking.Michael Mann1-30/+67
This works towards bug 3209 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3209) by at least satisfying the layer under SCSI. All of the dissectors that feed into SCSI seem to have similar "lun tracking" issues, so I think a more general solution may be needed to fix the bug "right" #BACKPORT svn path=/trunk/; revision=46464
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-05-04AFAICT sys/types.h & netinet/in.h #includes are not needed for these files.Bill Meier1-8/+0
(Let's see if any of the buildbots give any errors). Also: remove trailing whitespace on lines. svn path=/trunk/; revision=42429
2012-05-03General cleanup to include:Bill Meier1-386/+481
- remove unneeded includes; - remove "boilerplate" comments; - reformat hf[] entries; - reformat long lines; - unneeded use of check_col(); - whitespace fixes. svn path=/trunk/; revision=42402
2011-10-10 Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-2/+2
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260) svn path=/trunk/; revision=39328
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-18/+18
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-10-05Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-1/+1
reference an hf item with types in hf[] of: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID svn path=/trunk/; revision=39261
2011-06-19Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.Bill Meier1-7/+1
svn path=/trunk/; revision=37716
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-1/+1
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-04-06#include <string.h> not needed.Bill Meier1-1/+0
svn path=/trunk/; revision=32410
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
2010-01-13From Didier Gautheron:Anders Broman1-21/+7
check_col.diff Remove redundant calls to check_col() if it guards only one columns function with one parameter after the column type. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4394 svn path=/trunk/; revision=31519
2009-10-17From Joe Eykholt:Jaap Keuter1-8/+85
It would be nice to have dissection of the Fibre-Channel FCP "Sequence retransmission request" (SRR) request. This is like an FC ELS request, but it has FC type FCP, so it's a little strange. It seemed like the best place to put it is in packet-fcp.c but a slight hook is needed in packet-fc.c to recognize that packet-fcp is the correct dissector. svn path=/trunk/; revision=30587
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-37/+37
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2008-08-25#include <prefs.h> not req'dBill Meier1-1/+0
svn path=/trunk/; revision=26089
2008-06-10From Joe Eykholt:Jaap Keuter1-3/+3
The Fibre-channel FCP dissector shows the wrong byte as the response info response code byte. The byte with offset 2 in the FCP frame is shown instead of byte 3 inside the response info. svn path=/trunk/; revision=25439
2008-05-15Fix some of the Errors/warnings detected by checkapi.Bill Meier1-67/+71
svn path=/trunk/; revision=25305
2007-11-08Apply yet another set of the optimization patches:Anders Broman1-1/+1
-set_str2add_str_val_to_str svn path=/trunk/; revision=23406
2007-02-19Continuing the tradition: squelch some compiler warnings ....Bill Meier1-2/+2
svn path=/trunk/; revision=20866
2006-10-25Squelch Coverity CID 220. Fix up whitespace.Gerald Combs1-20/+22
svn path=/trunk/; revision=19682
2006-10-13pass the relative data offset of data in/out pdu's to the scsi data in/out ↵Ronnie Sahlberg1-1/+1
dissector (dissect_scsi_payload) so that we can later add reassembly of data pdu's and also (if reassembly is disabled) only dissect the initial (offset==0) data pdu. dissect_scsi_payload() does not yet use this parameter. now that we have both data offset and expected data length/bidir expected data length and also the read/write flags availabe we have what we need to reassemble data in/out pdus (modulo overflow/underflow but those are so rare we can worry about them later). ndmp: ndmp conceptually always has a data in and a data out phase and never fragment the data into smaller pdu's os that dissector always report offset as 0. svn path=/trunk/; revision=19511
2006-10-12wireshark does not yet consume enough memory for me to be happyRonnie Sahlberg1-0/+1
pass conversation form the transports up to the scsi layer add tracking of conversation specific info to scsi osd add tracking of conversation+lun specific info to scsi osd for scsi osd add tracking of PARTITIONS and display in which frame they were created/removed svn path=/trunk/; revision=19505
2006-10-11add a task_flags bitmap and two lengths (data and bidirectional data)Ronnie Sahlberg1-1/+27
so that the two scsi transports FCP and ISCSI can provide the expected data transfer lengths to SCSI to allow SCSI reassembly. NDMP does not really need these hints since for NDMP (and also iscsi-lite) there is conceptually always both data in and data out phases and there is never any fragmentation. svn path=/trunk/; revision=19493
2006-10-11move the ITL and the ITLQ structure to packet-scsi.h where it belongsRonnie Sahlberg1-1/+1
svn path=/trunk/; revision=19492
2006-08-14rename some structures and defines from the se_tree to the emem_tree prefixRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=18894
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-3/+3
svn path=/trunk/; revision=18196
2006-04-24change the signature for dissect_scsi_snsinfo() to take itlq and itl structuresRonnie Sahlberg1-1/+1
update the comment in packet-scsi.c to reflect that it is the transport now that is responsible to track itl and itlq data make scsi tapable svn path=/trunk/; revision=17974
2006-04-22the scsi transports (fc/fcp and iscsi) now track both itl and itlqRonnie Sahlberg1-17/+1
structures for scsi. we no longer need the scsi_task_id structure passed by pinfo->private_data so get rid of it. we no longer need the (broken by design) scsi_task_data hash table since this has been replaced byt hte itl and itlq structures and tracking svn path=/trunk/; revision=17952
2006-04-21remover the lun parameter from dissect_scsi_cdb/payload since this is now ↵Ronnie Sahlberg1-2/+2
part of the exchange data in itlq remove the two fields opcode and devtype from the scsi_task_data structure since these are also part of the itlq and itl structures svn path=/trunk/; revision=17949
2006-04-21updates to get the fc and scsi dissectorsRonnie Sahlberg1-29/+34
and get rid of some breakage in the design let the scsi transport keep track of itl (initiator, target, lun) matching and let it pass a itl structure to scsi that is persistent across packets. let scsi use this itl structure to track device type for a specific itl instead of the (must have been) broken hashtable. update both iscsi and fc to track the itl structure for scsi and schange the scsi signature to accept itl as a parameter. more to come. svn path=/trunk/; revision=17942
2006-04-20rename hte itlq structures to itlqRonnie Sahlberg1-10/+10
svn path=/trunk/; revision=17922
2006-04-07make dissect_scsi_rsp() take an exchange structure as parameter instead of ↵Ronnie Sahlberg1-1/+1
just a lun. this finally allows us to have scsi.time for scsi transactions but we need to cleanup and refactor the other three scsi entrypoints before we should implement scsi srt to make the other three also take an exchange data structure as parameter from their transports (and get rid of the pinfo->private_data ) svn path=/trunk/; revision=17838
2006-04-06use the fc exchange structure to track LUN values from fcp command all the ↵Ronnie Sahlberg1-149/+17
way through to the response and get rid of the broken hashtable used for the same purpose previously. some additional cleanups. svn path=/trunk/; revision=17827
2006-04-06use the fc exchange data to track fcp response timesRonnie Sahlberg1-3/+35
svn path=/trunk/; revision=17826
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-28 12:51:11 +0000