aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-fc.c
AgeCommit message (Collapse)AuthorFilesLines
2013-09-15Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if ↵Michael Mann1-14/+12
hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly. The script didn't catch as many as I would have liked, but it's a start. The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum. svn path=/trunk/; revision=52045
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-1/+1
svn path=/trunk/; revision=51852
2013-08-31More wmem.Evan Huus1-9/+9
svn path=/trunk/; revision=51617
2013-08-05Keep result of [new_]register_dissector in some dissectors.Jakub Zawadzki1-7/+5
svn path=/trunk/; revision=51156
2013-07-17Remove fragment_data, add fragment_head, fragment_item - for now alias it to ↵Jakub Zawadzki1-1/+1
the same structure. This is begin of work to split fragment head and fragments items. svn path=/trunk/; revision=50708
2013-07-14Rewrite reassemble API to use TVBs instead of raw data.Jakub Zawadzki1-3/+1
(it seems to be working for TCP ^^) svn path=/trunk/; revision=50580
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-10/+8
svn path=/trunk/; revision=49920
2013-05-26Batch of filterable expert infos.Michael Mann1-1/+10
svn path=/trunk/; revision=49584
2013-05-08From Christian SvenssonMartin Kaiser1-14/+18
use correct Fibre Channel EOFs according to the FC-FS-3 specification https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8636 svn path=/trunk/; revision=49210
2013-04-22Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=48985
2013-03-22Don't wire into the reassembly code the notion that reassemblies shouldGuy Harris1-4/+6
be done on flows from one address to another; reassembly for protocols running atop TCP should be done on flows from one TCP endpoint to another. We do this by: adding "reassembly table" as a data structure; associating hash tables for both in-progress reassemblies and completed reassemblies with that data structure (currently, not all reassemblies use the latter; they might keep completed reassemblies in the first table); having functions to create and destroy keys in that table; offering standard routines for doing address-based and address-and-port-based flow processing, so that dissectors not needing their own specialized flow processing can just use them. This fixes some mis-reassemblies of NIS YPSERV YPALL responses (where the second YPALL response is processed as if it were a continuation of a previous response between different endpoints, even though said response is already reassembled), and also allows the DCE RPC-specific stuff to be moved out of epan/reassembly.c into the DCE RPC dissector. svn path=/trunk/; revision=48491
2013-03-18From beroset:Anders Broman1-12/+12
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48399
2013-01-31Comment out unused hf[] entries & etc.Bill Meier1-1/+3
(found by checkhf) svn path=/trunk/; revision=47389
2012-12-08Bugfix FCP lun request/response tracking.Michael Mann1-1/+0
This works towards bug 3209 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3209) by at least satisfying the layer under SCSI. All of the dissectors that feed into SCSI seem to have similar "lun tracking" issues, so I think a more general solution may be needed to fix the bug "right" #BACKPORT svn path=/trunk/; revision=46464
2012-12-02Introduce, and start using, TVB_SET_ADDRESS() and TVB_SET_ADDRESS_HF(). TheyJeff Morriss1-2/+2
are like the non-TVB versions except that they take a TVB and an offset instead of (frequently) a pointer into the TVB. Calling tvb_get_ptr() before modifying the rest of the fields should help fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7960 (though I can't reproduce that problem). Replace a bunch of calls like: SET_ADDRESS(..., AT_XXX, length, tvb_get_ptr(tvb, offset, length)); with: TVB_SET_ADDRESS(..., AT_XXX, tvb, offset, length); svn path=/trunk/; revision=46324
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-4/+1
svn path=/trunk/; revision=45017
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-05-15Remove unneeded #includes (stdlib, stdio, ctypes, time);Bill Meier1-2/+0
In a few cases: do some whitespace, indentation cleanup & reformatting. svn path=/trunk/; revision=42632
2012-05-04AFAICT sys/types.h & netinet/in.h #includes are not needed for these files.Bill Meier1-8/+0
(Let's see if any of the buildbots give any errors). Also: remove trailing whitespace on lines. svn path=/trunk/; revision=42429
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-17/+17
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-08-31Second try to move crc routines to libwsutil.Stig Bjørlykke1-1/+1
This time keep the tvb routines in epan. Now we can use common crc routines outside epan. svn path=/trunk/; revision=38810
2011-08-30Revert r38800, as the crc routines contains some tvb functions.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=38803
2011-08-30Move all crc routines to libwsutil.Stig Bjørlykke1-1/+1
This way we can use the crc routines in wiretap. svn path=/trunk/; revision=38800
2011-06-20Fix some gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings;Bill Meier1-4/+4
(Code commented out since it may be required in the future (at least in some cases). svn path=/trunk/; revision=37723
2011-01-16Use tvb_ip_to_str().Jeff Morriss1-2/+2
There's no need to pass the result of tvb_get_ptr() as the 'value' in proto_tree_add_*(): just use proto_tree_add_item(). Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the return string is NULL terminated. svn path=/trunk/; revision=35545
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-3/+3
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-10-11Define some fcns & vars as static;Bill Meier1-174/+174
Minor whitespace and comments cleanup. svn path=/trunk/; revision=34477
2010-05-13As suggested in ↵Jeff Morriss1-42/+35
http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html (as referenced in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907 ) and https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3411 : Write a new convenience routine for finding a conversation and, if it is not found, create it. The frame number and addresses are taken from pinfo (as is the common case). Use this function in a bunch of dissectors. svn path=/trunk/; revision=32790
2010-04-06#include <string.h> not needed.Bill Meier1-1/+0
svn path=/trunk/; revision=32410
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
2009-10-17From Joe Eykholt:Jaap Keuter1-1/+6
It would be nice to have dissection of the Fibre-Channel FCP "Sequence retransmission request" (SRR) request. This is like an FC ELS request, but it has FC type FCP, so it's a little strange. It seemed like the best place to put it is in packet-fcp.c but a slight hook is needed in packet-fc.c to recognize that packet-fcp is the correct dissector. svn path=/trunk/; revision=30587
2009-10-16Don't init fc_fragment_table twice via registered_init_routines...Bill Meier1-7/+0
svn path=/trunk/; revision=30582
2009-10-05Rewrote fc_sof_t and fc_eof_t from enum to defines, as enumStig Bjørlykke1-30/+26
is defined as signed int. svn path=/trunk/; revision=30328
2009-09-24Don't guard col_append_str with check_colKovarththanan Rajaratnam1-6/+2
svn path=/trunk/; revision=30125
2009-09-09From kahou:Jaap Keuter1-3/+7
FCSOF incorrect checksum calculation. svn path=/trunk/; revision=29815
2009-08-23From kahou:Jaap Keuter1-2/+194
Add Fibre Channel Delimiter Dissector for Fibre Channel FC2. svn path=/trunk/; revision=29531
2009-08-16Switch a bunch of dissectors over to using tvb_new_subset_remaining()Kovarththanan Rajaratnam1-3/+3
svn path=/trunk/; revision=29446
2009-08-09Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-6/+2
svn path=/trunk/; revision=29345
2009-08-09Don't guard col_set_str (COL_INFO) with col_checkKovarththanan Rajaratnam1-4/+2
svn path=/trunk/; revision=29342
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-6/+3
svn path=/trunk/; revision=29340
2009-07-16From Kahou via bug 3739:Stig Bjørlykke1-0/+5
New DLT value is added for Fibre Channel FC2. svn path=/trunk/; revision=29115
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-25/+25
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-05-13Apply some of the patches from:Anders Broman1-2/+1
http://wiki.wireshark.org/Development/Optimization svn path=/trunk/; revision=28356
2009-05-08FT_BOOLEAN fields w/o bitmasks really should use BASE_NONE (not BASE_DEC,...).Bill Meier1-1/+1
svn path=/trunk/; revision=28317
2008-12-17Fix some typos and spelling (mostly in text strings)Bill Meier1-1/+1
svn path=/trunk/; revision=27037
2008-05-14Fix some of the Errors/warnings detected by checkapi.Bill Meier1-18/+24
svn path=/trunk/; revision=25290
2007-09-16The Fibre Channel protocol defines a virtual fabric tag (VFT) similar toJaap Keuter1-25/+93
ethernet's VLAN tag. It is sometimes called the VSAN tag. It used to be proprietary, but now it's standard. Wireshark currently displays it as an 8-byte field without dissecting it further. It'd be nice to have it broken down into fields. A patch is attached. svn path=/trunk/; revision=22879
2007-06-13Fix for bug 1633:Jaap Keuter1-4/+10
Adding BLS ABTS handling. svn path=/trunk/; revision=22087
2007-04-14fix MacOSX gcc-3.3 warnings about unused tfs/value_string variablesSebastien Tandel1-1/+1
most have been tagged unused (few have been deleted if dissector has not been modified since a long time) move packet-ssl-utils.c to DISSECTOR_SRC svn path=/trunk/; revision=21431
2006-10-13if FC type is FPC/SCSI and the relative offset bit is set in f_ctl then the ↵Ronnie Sahlberg1-0/+14
parameter field is 4 bytes and contain the relative offset of the data for data in/out decode this field as relative offset and also store it in the fc_hdr structure so that FCP can pick it up and pass if to the SCSI payload data in/out dissector later svn path=/trunk/; revision=19510