aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-eigrp.c
AgeCommit message (Collapse)AuthorFilesLines
2013-11-20Fix minor issue introduced with conversion to new expert API in r51688.Evan Huus1-1/+1
Specifically, proto_tree_add_expert() must take an actual tree node (for example from proto_item_add_subtree()) and cannot take just any old item node. The original intent (before the conversion) appeared to be just to put it on the tree, so do that. Another assertion gone from https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9406 svn path=/trunk/; revision=53456
2013-11-02Require dissector_try_string to pass a data parameter to its subdissectors. ↵Michael Mann1-2/+2
There weren't that many calls, so might as well modify the function than create a need for dissector_try_string_new. svn path=/trunk/; revision=53049
2013-09-22emem -> wmem conversion:Pascal Quantin1-1/+1
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-7/+7
svn path=/trunk/; revision=51852
2013-09-02Batch of filterable expert info.Michael Mann1-38/+47
svn path=/trunk/; revision=51688
2013-08-10Fix (-W)documentation error found by ClangAlexis La Goutte1-67/+28
packet-eigrp.c:633:10: error: unrecognized parameter passing direction, valid directions are '[in]', '[out]' and '[in,out]' [-Werror,-Wdocumentation] * @param[in|out] tree detail dissection result ^~~~~~~~ packet-eigrp.c:638:5: error: '@return' command used in a comment that is attached to a function returning void [-Werror,-Wdocumentation] * @return void ~^~~~~~~~~~~ packet-eigrp.c:691:10: error: unrecognized parameter passing direction, valid directions are '[in]', '[out]' and '[in,out]' [-Werror,-Wdocumentation] * @param[in|out] tree detail dissection result ^~~~~~~~ packet-eigrp.c:696:5: error: '@return' command used in a comment that is attached to a function returning void [-Werror,-Wdocumentation] * @return void ~^~~~~~~~~~~ packet-eigrp.c:765:10: error: unrecognized parameter passing direction, valid directions are '[in]', '[out]' and '[in,out]' [-Werror,-Wdocumentation] * @param[in|out] tree detail dissection result ^~~~~~~~ packet-eigrp.c:769:5: error: '@return' command used in a comment that is attached to a function returning void [-Werror,-Wdocumentation] * @return void ~^~~~~~~~~~~ packet-eigrp.c:814:10: error: unrecognized parameter passing direction, valid directions are '[in]', '[out]' and '[in,out]' [-Werror,-Wdocumentation] * @param[in|out] tree detail dissection result ^~~~~~~~ packet-eigrp.c:818:5: error: '@return' command used in a comment that is attached to a function returning void [-Werror,-Wdocumentation] * @return void ~^~~~~~~~~~~ packet-eigrp.c:853:10: error: unrecognized parameter passing direction, valid directions are '[in]', '[out]' and '[in,out]' [-Werror,-Wdocumentation] * @param[in|out] tree detail dissection result ^~~~~~~~ packet-eigrp.c:857:5: error: '@return' command used in a comment that is attached to a function returning void [-Werror,-Wdocumentation] * @return void ~^~~~~~~~~~~ packet-eigrp.c:878:10: error: unrecognized parameter passing direction, valid directions are '[in]', '[out]' and '[in,out]' [-Werror,-Wdocumentation] * @param[in|out] tree detail dissection result ^~~~~~~~ packet-eigrp.c:882:19: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param[out] None ~~~~~~~~~~~~~~~^ packet-eigrp.c:884:5: error: '@return' command used in a comment that is attached to a function returning void [-Werror,-Wdocumentation] * @return void ~^~~~~~~~~~~ packet-eigrp.c:880:15: error: parameter 'pinfo' not found in the function declaration [-Werror,-Wdocumentation] * @param[in] pinfo general data about the protocol ^~~~~ packet-eigrp.c:881:15: error: parameter 'ti' not found in the function declaration [-Werror,-Wdocumentation] * @param[in] ti protocol item ^~ packet-eigrp.c:882:16: error: parameter 'None' not found in the function declaration [-Werror,-Wdocumentation] * @param[out] None ^~~~ packet-eigrp.c:902:19: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param[out] None ~~~~~~~~~~~~~~~^ packet-eigrp.c:904:5: error: '@return' command used in a comment that is attached to a function returning void [-Werror,-Wdocumentation] * @return void ~^~~~~~~~~~~ packet-eigrp.c:902:16: error: parameter 'None' not found in the function declaration [-Werror,-Wdocumentation] * @param[out] None ^~~~ packet-eigrp.c:1712:15: error: parameter 'pinfo' not found in the function declaration [-Werror,-Wdocumentation] * @param[in] pinfo general data about the protocol ^~~~~ packet-eigrp.c:1712:15: note: did you mean 'ti'? * @param[in] pinfo general data about the protocol ^~~~~ ti packet-eigrp.c:2585:18: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param[in] void ~~~~~~~~~~~~~~^ packet-eigrp.c:2585:15: error: parameter 'void' not found in the function declaration [-Werror,-Wdocumentation] * @param[in] void ^~~~ packet-eigrp.c:3324:18: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation] * @param[in] void ~~~~~~~~~~~~~~^ packet-eigrp.c:3324:15: error: parameter 'void' not found in the function declaration [-Werror,-Wdocumentation] * @param[in] void ^~~~ svn path=/trunk/; revision=51266
2013-03-17[-Wmissing-prototypes]Anders Broman1-0/+1
Use explicit casts. svn path=/trunk/; revision=48347
2013-02-26it's ==> its & its ==> it's as needed.Bill Meier1-6/+6
svn path=/trunk/; revision=47891
2013-02-19How can I get a new tvbuff that starts at an offset within a givenGuy Harris1-1/+1
tvbuff and runs to the end of the tvbuff? Let me count the ways.... Replace a bunch of different ways of doing that (some incorrect, in that they're not properly handling tvbuffs where the captured and reported lengths are different) with tvb_new_subset_remaining(). svn path=/trunk/; revision=47751
2012-10-08fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7800Martin Kaiser1-2/+2
use correct data types in eigrp dissector to prevent overflow svn path=/trunk/; revision=45408
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-2/+2
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-08-10Use val_to_str_const() where appropriate;Bill Meier1-4/+3
Also (for a few files): - create/use some extended value strings; - remove unneeded #include files; - remove unneeded variable initialization; - re-order fcns slightly so prefs_reg_handoff...() at end, etc svn path=/trunk/; revision=44438
2012-07-12Don't call subdissectors / expert...() / col...() under 'if (tree)'Bill Meier1-116/+114
Also: Remove some uneeded initializers; Do some whitespace cleanup and re-formatting. svn path=/trunk/; revision=43681
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-04-26Fix some "conflicting" value_string warnings.Jakub Zawadzki1-2/+2
copy & paste errors, not 0-terminated value_string arrays, etc. svn path=/trunk/; revision=42260
2012-03-18Fix one of the dissector assertions in ↵Jeff Morriss1-9/+10
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6962 : tidlist is registered as a FT_UINT16 so don't add an array of 16-bit entities (tids) using it. Instead add each TID individually. svn path=/trunk/; revision=41637
2012-03-06Use tvb_new_subset_remaining() rather than tvb_new_subset();Bill Meier1-1637/+1637
#include <styring.h> not req'd (in a few cases); Minor reformating & whitespace cleanup. svn path=/trunk/; revision=41374
2012-02-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-13/+17
svn path=/trunk/; revision=40901
2011-10-25Fix some set but not used [-Wunused-but-set-variable] warnings.Anders Broman1-2/+1
svn path=/trunk/; revision=39579
2011-10-24Fix encoding arg for various fcn calls:Bill Meier1-2/+2
- proto_tree_add_bits_item - proto_tree_add_bits_ret_val - proto_tree_add_bitmask - tvb_get_bits - tvb_get_bits16 - tvb_get_bits24 - tvb_get_bits32 - tvb_get_bits64 svn path=/trunk/; revision=39539
2011-10-20Use ENC_NA as proto_tree_add_item() encoding arg for FT_ETHER hf[] field type.Bill Meier1-2/+2
(Some minor whitespace cleanup). svn path=/trunk/; revision=39488
2011-10-16Do some conversions of proto_tree_add_item() 'encoding' arg.Bill Meier1-11/+11
(previously missed). 57 FT_BOOLEAN: FALSE-->ENC_BIG_ENDIAN 31 FT_BOOLEAN: TRUE-->ENC_LITTLE_ENDIAN 10 FT_BYTES: ENC_BIG_ENDIAN-->ENC_NA 1 FT_BYTES: ENC_LITTLE_ENDIAN-->ENC_NA 21 FT_BYTES: FALSE-->ENC_NA 2 FT_BYTES: TRUE-->ENC_NA 2 FT_IPXNET: ENC_BIG_ENDIAN-->ENC_NA 6 FT_IPv6: ENC_BIG_ENDIAN-->ENC_NA 1 FT_IPv6: FALSE-->ENC_NA 6 FT_NONE: ENC_BIG_ENDIAN-->ENC_NA 19 FT_NONE: FALSE-->ENC_NA 3 FT_NONE: TRUE-->ENC_NA 1 FT_STRING: ENC_BIG_ENDIAN-->ENC_ASCII|ENC_NA 1 FT_STRING: ENC_LITTLE_ENDIAN-->ENC_ASCII|ENC_NA 5 FT_STRING: FALSE-->ENC_ASCII|ENC_NA 1 FT_STRING: TRUE-->ENC_ASCII|ENC_NA 4 FT_STRINGZ: ENC_NA-->ENC_ASCII|ENC_NA 8 FT_STRINGZ: FALSE-->ENC_ASCII|ENC_NA 1 FT_INT32: FALSE-->ENC_BIG_ENDIAN 1 FT_INT32: TRUE-->ENC_LITTLE_ENDIAN 11 FT_UINT8: 0-->ENC_BIG_ENDIAN 111 FT_UINT8: FALSE-->ENC_BIG_ENDIAN 17 FT_UINT8: TRUE-->ENC_LITTLE_ENDIAN 1 FT_UINT16: 0-->ENC_BIG_ENDIAN 68 FT_UINT16: FALSE-->ENC_BIG_ENDIAN 18 FT_UINT16: TRUE-->ENC_LITTLE_ENDIAN 4 FT_UINT24: FALSE-->ENC_BIG_ENDIAN 70 FT_UINT32: FALSE-->ENC_BIG_ENDIAN 1 FT_UINT32: TRUE-->ENC_LITTLE_ENDIAN 4 FT_UINT64: FALSE-->ENC_BIG_ENDIAN 1 FT_UINT64: TRUE-->ENC_LITTLE_ENDIAN 1 FT_UINT_STRING: FALSE-->ENC_ASCII|ENC_BIG_ENDIAN svn path=/trunk/; revision=39442
2011-10-16From Donnie Savage:Anders Broman1-78/+10
EIGRP dissector cleanup. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6459 svn path=/trunk/; revision=39438
2011-10-12There are no preferences for this dissector so eliminate unneeded ↵Chris Maynard1-61/+33
preference-related code. Fixes Coverity CID 1311. svn path=/trunk/; revision=39391
2011-10-10Use guint64Anders Broman1-1/+1
svn path=/trunk/; revision=39342
2011-10-10From Donnie Savage:Anders Broman1-1621/+3310
Re-write of the EIGRP dissector to support Multi-Protocol (TLV 2.0) and Multi-Topology (TLV 3.0). This version also support Service Advertisement Framework(SAF) extensions to EIGRP Dissector includes: - Dissection of all EIGRP Opcodes and TLVs - Decode of EIGRP Flags and bitfields - Decode of EIGRP Communities - Decode of latest EIGRP "wide metric" formats - Decode of EIGRP Extended Metrics - Decode of SAF packets with XML client data handed off to XML dissector From me: Fix checkapi errors/warnings use G_GINT64_CONSTANT and G_GINT64_MODIFIER svn path=/trunk/; revision=39339
2011-10-10 Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-24/+24
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_BOOLEAN FT_IPv4 FT_EUI64 FT_GUID FT_UINT_STRING Also: For type FT_ITv6 use ENC_NA. (This was missed in SVN #39260) svn path=/trunk/; revision=39328
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-111/+111
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-4/+4
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39260
2011-05-02From Peter Paluch via bug #5877: EIGRP dissector enhancement for RS/EOTStephen Fisher1-1/+17
flags Me: Add Peter to AUTHORS file. svn path=/trunk/; revision=36965
2011-02-07Remove unneeded #includes (stdio.h,stdlib.h);Bill Meier1-729/+729
Whitespace cleanup: trailing, indentation, "4-space tabs" svn path=/trunk/; revision=35850
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-3/+3
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-09-27Fix the offset errors reported in bug 5261.Stig Bjørlykke1-6/+6
svn path=/trunk/; revision=34267
2010-03-19From Jochen Bartl:Jaap Keuter1-9/+49
EIGRP IPX routing updates TLV cleanup. I have replaced the remaining proto_tree_add_text by proto_tree_add_item in IPX routing update TLVs. svn path=/trunk/; revision=32247
2010-02-01From Jochen Bartl:Jaap Keuter1-58/+83
Expert infos patch for EIGRP dissector. svn path=/trunk/; revision=31749
2009-10-26From Jochen Bartl:Jaap Keuter1-2/+12
This patch fixes the display filter for the prefix length of IPv6 external route updates and the length calculation of the destination address in IPv6 route updates. svn path=/trunk/; revision=30703
2009-10-09From Didier Gautheron:Anders Broman1-6/+7
Dissectors using call_dissector() function inside a 'if (tree) {}' block. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4107 svn path=/trunk/; revision=30415
2009-08-19From Jochen Bartl:Anders Broman1-289/+1478
EIGRP dissector enhancements (IPv6, Stub routing, Authentication TLVs) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3907 svn path=/trunk/; revision=29473
2009-08-16Switch a bunch of dissectors over to using tvb_new_subset_remaining()Kovarththanan Rajaratnam1-1/+1
svn path=/trunk/; revision=29446
2009-08-09Don't guard col_clear with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29344
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-2/+2
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2008-06-25From Max Ivanov:Jaap Keuter1-1/+1
The destination unreachable indication for external IP routes is at offset 24, not 4 as in internal IP routes. svn path=/trunk/; revision=25598
2008-03-24FIx for bug 2381:Jaap Keuter1-24/+30
The eigrp update packets may contain more than one destination advertisement per one "IP external route" or "IP internal route" TLV. Recurse over prefix/network address pairs until TLV is exhausted. svn path=/trunk/; revision=24721
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=18196
2005-04-20Remove leftover debugging code.Gerald Combs1-1/+0
svn path=/trunk/; revision=14152
2005-04-20Fix an infinite loop. Fixes bug 80.Gerald Combs1-2/+3
svn path=/trunk/; revision=14151
2004-09-29Move various tables into the epan directory.Guy Harris1-1/+1
svn path=/trunk/; revision=12130
2004-08-06From Albert Chin: rename resolv.{ch} to addr_resolv.{ch}, so that anGuy Harris1-1/+1
include of <resolv.h> in any system header file gets the system <resolv.h> (needed for builds on Tru64 with GTK+ 1.2[.x]). svn path=/trunk/; revision=11615