aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-docsis-tlv.c
AgeCommit message (Collapse)AuthorFilesLines
2020-10-28DOCSIS/XRA: fix typos + cleanup.Dieter Dobbelaere1-21/+21
2020-08-07Find and fix dissectors that should be using a default tfs.Martin Mathieson1-22/+13
Found using tools/check_tfs.py, included in this commit. Here are the reports that were fixed here: Examining: All dissector modules epan/dissectors/packet-assa_r3.c tfs_mortisepins_flags - could have used tfs_high_low from tfs.c instead: {High,Low} epan/dissectors/packet-btle.c tfs_present_bit - could have used tfs_present_not_present from tfs.c instead: {Present,Not Present} epan/dissectors/packet-dhcp.c tfs_fqdn_s - could have used tfs_server_client from tfs.c instead: {Server,Client} epan/dissectors/packet-docsis-macmgmt.c mdd_tfs_on_off - could have used tfs_on_off from tfs.c instead: {On,Off} epan/dissectors/packet-docsis-macmgmt.c mdd_tfs_en_dis - could have used tfs_enabled_disabled from tfs.c instead: {Enabled,Disabled} epan/dissectors/packet-docsis-macmgmt.c req_not_req_tfs - could have used tfs_requested_not_requested from tfs.c instead: {Requested,Not Requested} epan/dissectors/packet-docsis-tlv.c on_off_tfs - could have used tfs_on_off from tfs.c instead: {On,Off} epan/dissectors/packet-docsis-tlv.c activation_tfs - could have used tfs_active_inactive from tfs.c instead: {Active,Inactive} epan/dissectors/packet-docsis.c ena_dis_tfs - could have used tfs_enabled_disabled from tfs.c instead: {Enabled,Disabled} epan/dissectors/packet-ecmp.c tfs_not_expected_expected - could have used tfs_odd_even from tfs.c instead: {Odd,Even} epan/dissectors/packet-erf.c erf_link_status_tfs - could have used tfs_up_down from tfs.c instead: {Up,Down} epan/dissectors/packet-h263.c on_off_flg - could have used tfs_on_off from tfs.c instead: {On,Off} epan/dissectors/packet-h263.c cpm_flg - could have used tfs_on_off from tfs.c instead: {On,Off} epan/dissectors/packet-interlink.c flags_set_notset - could have used tfs_set_notset from tfs.c instead: {Set,Not set} epan/dissectors/packet-ip.c tos_set_low - could have used tfs_low_normal from tfs.c instead: {Low,Normal} epan/dissectors/packet-ip.c tos_set_high - could have used tfs_high_normal from tfs.c instead: {High,Normal} epan/dissectors/packet-isakmp.c flag_r - could have used tfs_response_request from tfs.c instead: {Response,Request} epan/dissectors/packet-isis-lsp.c tfs_metric_supported_not_supported - could have used tfs_no_yes from tfs.c instead: {No,Yes} epan/dissectors/packet-kerberos.c supported_tfs - could have used tfs_supported_not_supported from tfs.c instead: {Supported,Not supported} epan/dissectors/packet-kerberos.c set_tfs - could have used tfs_set_notset from tfs.c instead: {Set,Not set} epan/dissectors/packet-mac-lte.c mac_lte_scell_status_vals - could have used tfs_activated_deactivated from tfs.c instead: {Activated,Deactivated} epan/dissectors/packet-p_mul.c no_yes - could have used tfs_no_yes from tfs.c instead: {No,Yes} epan/dissectors/packet-pgm.c opts_present - could have used tfs_present_not_present from tfs.c instead: {Present,Not Present} epan/dissectors/packet-rsl.c rsl_ms_fpc_epc_mode_vals - could have used tfs_inuse_not_inuse from tfs.c instead: {In use,Not in use} epan/dissectors/packet-sita.c tfs_sita_on_off - could have used tfs_on_off from tfs.c instead: {On,Off} epan/dissectors/packet-vines.c tfs_vine_rtp_no_yes - could have used tfs_no_yes from tfs.c instead: {No,Yes} epan/dissectors/packet-vnc.c button_mask_tfs - could have used tfs_pressed_not_pressed from tfs.c instead: {Pressed,Not pressed} 27 issues found Change-Id: I7e53b491f20289955c9e9caa8357197d9010a5aa Reviewed-on: https://code.wireshark.org/review/38087 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2020-06-19Fix the type of arrays of pointers to hf_ values for bitfield routines.Guy Harris1-10/+10
The static arrays are supposed to be arrays of const pointers to int, not arrays of non-const pointers to const int. Fixing that means some bugs (scribbling on what's *supposed* to be a const array) will be caught (see packet-ieee80211-radiotap.c for examples, the first of which inspired this change and the second of which was discovered while testing compiles with this change), and removes the need for some annoying casts. Also make some of those arrays static while we're at it. Update documentation and dissector-generator tools. Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc Reviewed-on: https://code.wireshark.org/review/37517 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-05-20docsis: fix header filenameAlexis La Goutte1-1/+1
Change-Id: I835e9d1920575aabf54729443e87800fa22dda74 Reviewed-on: https://code.wireshark.org/review/33271 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-29docsis: enhancements and additions for DOCSIS TLVs 5.20 and 5.40Andrii Vladyka1-4/+7
Change-Id: If819d1f7e75b458d5fc28e23b28fa260637491fb Reviewed-on: https://code.wireshark.org/review/31240 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-22docsis: SF TLV 23 is applicable to both US and DS; added SF TLVs 24.25 and 24.26Andrii Vladyka1-7/+52
Change-Id: Id52d6e7c08c5e8d516ca8e80543f33a1e61cf907 Reviewed-on: https://code.wireshark.org/review/31166 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-10DOCSIS: Added some additional tlvsBruno Verstuyft1-3/+49
TLV 26.13 PHS Dynamic Bonding Change Action TLV 48.4.2 Receive Module Adjacent Channels TLV 64.3 Static Multicast CMIM Encoding Change-Id: I3a48e0092e7fe523adfdff5b155dcdbb88720f41 Reviewed-on: https://code.wireshark.org/review/30997 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-12-07DOCSIS: better decoding for unknown tlvsBruno Verstuyft1-46/+95
Previous decoding showed "Unknown TLV: <TLV value>". This was confusing, because people interpreted the value as the type of the unknown TLV. Change-Id: Ia9259db547fca393c248f78ea7c758969b69548e Reviewed-on: https://code.wireshark.org/review/30959 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-06DOCSIS: Added Partial Service Downstream Channels TLV 49.6Bruno Verstuyft1-0/+30
Change-Id: Iac09d71a56024440a826ff9ca870c05eeee3a77b Reviewed-on: https://code.wireshark.org/review/30942 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-12-06DOCSIS: Added Modem Capabilities 54-62 and TLV 49.8Bruno Verstuyft1-0/+358
Change-Id: I24815d5ec5dc288066712318e12f75a9cc6a9495 Reviewed-on: https://code.wireshark.org/review/30938 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-04DOCSIS: Added QAM modulation support tlvsBruno Verstuyft1-0/+256
Change-Id: I18dc306b23a042e137c703cc8b14c45c66de10d2 Reviewed-on: https://code.wireshark.org/review/30912 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-30DOCSIS: Added Modem Capabilities 47-51Bruno Verstuyft1-0/+112
Change-Id: I66efc73bb27d8703872b9477c86bf7471446a32a Reviewed-on: https://code.wireshark.org/review/30846 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-29DOCSIS: Added Downstream Resequencing TLV (25.17)Bruno Verstuyft1-0/+24
Change-Id: I496130e8abf6fe9996d886cd8ad7231005edf91a Reviewed-on: https://code.wireshark.org/review/30822 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-27DOCSIS: Added Energy Management TLVsBruno Verstuyft1-6/+59
Change-Id: I2b1f71a0adb2e16a2b03fdc2138024773b1d792e Reviewed-on: https://code.wireshark.org/review/30802 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-20DOCSIS: REGRSP-MP: TLV fixesBruno Verstuyft1-11/+69
Added decodings for TLVs 46.10 and 46.11. Fixed formatting of TLVs. Change-Id: Iec8829929a8b6981e1760614f76d16400b94d05c Reviewed-on: https://code.wireshark.org/review/30709 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-11-14DOCSIS: both TLV 43 and 44 need VSIF encodingsBruno Verstuyft1-3/+38
Change-Id: Ide8fe96de05423fed135797988dd620b92e9cddc Reviewed-on: https://code.wireshark.org/review/30628 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-10-31DOCSIS: Added Simplified Receive Channel Configuration (TLV 49.7)Bruno Verstuyft1-0/+168
Change-Id: I75f5fa44eedd0525e389e334f00f3065a74be9e3 Reviewed-on: https://code.wireshark.org/review/30427 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-26DOCSIS: Added Service Flow Peak Traffic RateBruno Verstuyft1-0/+18
Change-Id: Iad5ec8521ff38afb110c799e2af58114ede6f0b7 Reviewed-on: https://code.wireshark.org/review/29857 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-20epan: fix various misannotations of VALS/RVALS/VALS64/TFSPeter Wu1-1/+1
No functional change, just using the correct macro for value_strings. Other fixes: Taking the address of the first element of an array gives the same address as the array itself. An array of a structure with a single element is the same as the single element itself (packet-sprt.c). Change-Id: I08bc9de49fbd1659a6700ace863e5f05144c7b3e Reviewed-on: https://code.wireshark.org/review/29752 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-06-13DOCSIS: correct reassembly of UCD in REG-RSP-MP and DBC-REQ messagesBruno Verstuyft1-13/+156
Change-Id: I7c84b6cce113b71aea0c17741024916f9b17bdf9 Reviewed-on: https://code.wireshark.org/review/28202 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-13Make the DOCSIS dissector a built-in dissector.Guy Harris1-0/+6518
Stuff that calls it is built in, and stuff it calls is built in, so there's not much point in having it be a plugin; we already have examples of plugin dissectors. Change-Id: I512e0fda62faedb5f03f476fbece2e267e1d644f Reviewed-on: https://code.wireshark.org/review/25775 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 05:47:17 +0000