aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-dns.c
AgeCommit message (Collapse)AuthorFilesLines
2019-01-01Add a "failed" return for tap packet routines.Guy Harris1-2/+2
This allows taps that can fail to report an error and fail; a failed tap's packet routine won't be called again, so they don't have to keep track of whether they've failed themselves. We make the return value from the packet routine an enum. Don't have a separate type for the per-packet routine for "follow" taps; they're expected to act like tap packet routines, so just use the type for tap packet routines. One tap packet routine returned -1; that's not a valid return value, and wasn't one before this change (the return value was a boolean), so presume the intent was "don't redraw". Another tap routine's early return, without doing any work, returned TRUE; this is presumably an error (no work done, no need to redraw), so presumably it should be "don't redraw". Clean up some white space while we're at it. Change-Id: Ia7d2b717b2cace4b13c2b886e699aa4d79cc82c8 Reviewed-on: https://code.wireshark.org/review/31283 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-28DNS: Use seconds as resolution for stat response time.Michael Mann1-3/+3
This keeps it in the same resolution as the dns.time field. Ping-Bug: 15382 Change-Id: Ibacf8761819c0fac2e87fa147f7381336ce5cb39 Reviewed-on: https://code.wireshark.org/review/31223 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-28Allow floating point values for stats_treeMichael Mann1-29/+29
Bug: 4234 Change-Id: Ibd59809b2dd9890a7851eb57ef7af384e280a74b Reviewed-on: https://code.wireshark.org/review/31222 Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-27DNS: Use microsecond resolution for request/response statistics.Michael Mann1-2/+3
The stat tree API only supports 32-bit integers and if nanosecond resolution is used correctly it's easy to hit integer overflow issues on even a fairly small capture file trying to sum up response times. Bug: 15382 Change-Id: I15d2cfbdbec7b0bef2bcfe1afe4f6eb6fc1d2456 Reviewed-on: https://code.wireshark.org/review/31217 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2018-12-27Try to squeeze some bytes out of the frame_data structure.Guy Harris1-1/+1
Make the time stamp precision a 4-bit bitfield, so, when combined with the other bitfields, we have 32 bits. That means we put the flags at the same structure level as the time stamp precision, so they can be combined; that gets rid of an extra "flags." for references to the flags. Put the two pointers next to each other, and after a multiple of 8 bytes worth of other fields, so that there's no padding before or between them. It's still not down to 64 bytes, which is the next lower power of 2, so there's more work to do. Change-Id: I6f3e9d9f6f48137bbee8f100c152d2c42adb8fbe Reviewed-on: https://code.wireshark.org/review/31213 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-11-07DNS: fix compilation broken by g224aa2ed98Pascal Quantin1-1/+1
Change-Id: I913fdeb3cc827347b0ef11d10f03981c59cad1df Reviewed-on: https://code.wireshark.org/review/30526 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2018-11-07Add XMSS for SSHFP. This has shipped with OpenSSH since release 7.7Loganaden Velvindron1-0/+2
Change-Id: I995b0c93cef0f0b15b4a8115408b68bd7f4e12a3 Reviewed-on: https://code.wireshark.org/review/30523 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-27DNS: fix DNS transaction tracking for DoHPeter Wu1-13/+46
Handle DoH messages specially, use the HTTP/2 Stream ID for matching requests with responses. Fixes misleading "retransmission" expert infos and properly link (successive) requests with (out-of-order) responses. Change the "Protocol" column to "DoH" while at it. Change-Id: I42b22c5c8560ee029051dcb3561e188572a4245f Ping-Bug: 14433 Reviewed-on: https://code.wireshark.org/review/29889 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-09-27DNS: update content type for DoH draft -07 (up to draft -14)Peter Wu1-3/+3
This is required for the latest version. The message type "dns/message" was briefly used in draft -06, but it was changed in the next version. Change-Id: If26e367b71b7e270cad2f61eaee76041f530273c Ping-Bug: 14433 Reviewed-on: https://code.wireshark.org/review/29887 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-25Rename packet-ssl* to packet-tls*Gerald Combs1-1/+1
Rename packet-ssl{,-utils}.[ch] to packet-tls{,-utils}.[ch]. Change-Id: I4732162ec131ddf0734b3dd191ccc9e48a76ce06 Reviewed-on: https://code.wireshark.org/review/29659 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-07-08dns: fix off-by-one buffer overflow (write)Peter Wu1-3/+3
"maxname" is the size of the buffer which also includes the "null label" (represented by the NUL byte). Do not write this past the end. Bug: 14955 Change-Id: I51e2237741807aded7ffb82c178d7d7ce5123f78 Fixes: v2.9.0rc0-1142-g53e04b621c ("DNS: fix in expand_dns_name") Reviewed-on: https://code.wireshark.org/review/28657 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Erika Szelleová <szelleerika@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-07-02DNS: fix in expand_dns_nameErika Szelleova1-2/+12
The function parsed the DNS name correctly, however, it did not indicate that a given name is too long (more than MAX_DNAME_LEN bytes). Bug: 14041 Change-Id: I4078db488a814ca2114c725d1a17e3ef757843c5 Reviewed-on: https://code.wireshark.org/review/28410 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-06-28Add macros to initialize nstime_t values and use them.Guy Harris1-1/+1
This allows code to initialize them without having to know the details of the structure; the initializes should, and will, be changed if the members of the structure are changed. Change-Id: I93e6ebfcde9ceca17df696fcba4e8410c5afb175 Reviewed-on: https://code.wireshark.org/review/28501 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-06-19DNS: changed maximum length of dns names from 1025 to 255Erika Szelleova1-5/+6
According to RFC1035 there are limitations on the maximum length of DNS names. The maximum length in the code was defined as 1025, this commit changes it to 255. Also a new macro is introduced which holds the minimum length of a DNS name. Bug: 14041 Change-Id: Ic63b332b2a357e33728df183c05ab0e222faf13f Reviewed-on: https://code.wireshark.org/review/28309 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-05-14dns: fix null pointer deref for empty name in SRV recordPeter Wu1-3/+1
Per RFC 2782, the name should follow the "_Service._Proto.Name" format. If a malformed packet does not adhere to this and provides a zero-length name, then wmem_strsplit returns NULL. Bug: 14681 Change-Id: I7b9935238a9800a1526c8b694fd2c63d3b488d0b Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7416 Reviewed-on: https://code.wireshark.org/review/27499 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-19DNS: fix inverted condition for filtering error packets in statsPeter Wu1-1/+1
Change-Id: I9d867992e4f10c056c6070f0eb1aa0c8bb7cf117 Fixes: v2.5.2rc0-72-ga055e3c299 ("dns: skip stats if packet is within icmp.") Reviewed-on: https://code.wireshark.org/review/27026 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo <lomato@gmail.com>
2018-04-10Add, and use, "fetch signed value" for lengths < 40 bits.Guy Harris1-1/+1
Add 8-bit, 16-bit, 24-bit, and 32-bit "fetch signed value" routines, and use them rather than casting the result of the 8/16/24/32-bit "fetch unsigned value" routines to a signed type (which, BTW, isn't sufficient for 24-bit values, so this appears to fix a bug in epan/dissectors/packet-zbee-zcl.c). Use numbers rather than sizeof()s in various tvb_get_ routines. Change-Id: I0e48a57fac9f70fe42de815c3fa915f1592548bd Reviewed-on: https://code.wireshark.org/review/26844 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-04dns: check if name is root before any other check.Dario Lombardo1-4/+8
Bug: 14574 Change-Id: Ibacb6955c227a21ab813c48aad463a666fe45c40 Reviewed-on: https://code.wireshark.org/review/26695 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Uli Heilmeier <openid@heilmeier.eu> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-04-02dns: make expand_dns_name() an internal functionMartin Kaiser1-1/+1
The expand_dns_name() function is not used outside of the DNS dissector (any more?). Remove the function declaration from the public header file, make the function internal. Change-Id: Ibba81fa68a0dfd195ca3bbfca3eca20c39cc01f4 Reviewed-on: https://code.wireshark.org/review/26698 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-03-22dns: fix indentation.Dario Lombardo1-90/+98
Change-Id: I25894fd4e28002f75e43b7a6fd7bec58889e0590 Reviewed-on: https://code.wireshark.org/review/26538 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-22dns: skip stats if packet is within icmp.Dario Lombardo1-0/+3
Change-Id: I0f1866361ce60713535b1875fc9b75fe049f1790 Reviewed-on: https://code.wireshark.org/review/26537 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-22dns: add filters for retransmitted and unsolicited packets.Dario Lombardo1-1/+28
Change-Id: I1af293a9dc53869858dafc5921792aa3fbbfe766 Reviewed-on: https://code.wireshark.org/review/26536 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-03-22dns: add service-level stats.Dario Lombardo1-4/+38
They include: - request-response time - unsolicited response count - retransmissions count Change-Id: I01398bf1a88a23fb7850715f256b178c66d933a4 Reviewed-on: https://code.wireshark.org/review/26535 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2018-02-28Redo the way we choose N/S/E/W.Guy Harris1-3/+2
This should squelch a warning from Visual Studio Code Analyzer. Change-Id: Ie66e45276458a6f880c9b020ff541b7d2a71433a Reviewed-on: https://code.wireshark.org/review/26184 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-26DNS: add partial DOH (DNS Queries over HTTPS) supportPeter Wu1-6/+10
Add support for POST requests, and GET and POST responses containing a DNS (UDP) payload. GET requests are still unsupported. (DOH is sent over HTTP2/TLS/TCP which means that a special check is needed in dissect_dns to avoid matching DNS over TCP). Change-Id: I82bfcda068baf6f06c5a0159d73e6d40d1d9a758 Ping-Bug: 14433 Reviewed-on: https://code.wireshark.org/review/25806 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-17Use appropriate pointer types rather than guint8 *.Guy Harris1-7/+10
This means we don't lose alignment information that causes spurious compiler warnings. Change-Id: I721f180c137bcffbcf7edf88cf8caf52c33fa545 Reviewed-on: https://code.wireshark.org/review/25842 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-11-22Add support to handle DNS retransmissionsMichael Mann1-20/+95
Add a preference to the DNS dissector to specify how many seconds can elapse before a DNS query is considered a retransmission because the transaction ID is shared with a previous request. If retransmission is found, add expert info and hf_ field linking to the original request. If a retransmission of a response is found, add expert info and hf_ field linking to the original response. Bug: 14178 Bug: 13313 Change-Id: Idd77ab7f7638f5056d5690633c787a4d52285aee Reviewed-on: https://code.wireshark.org/review/24525 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-26Add a ws_in6_addr typedef for struct e_in6_addr.Guy Harris1-4/+4
That allows a parallel typedef of ws_in4_addr for guint32. Change-Id: I03b230247065e0e3840eb87635315a8e523ef562 Reviewed-on: https://code.wireshark.org/review/24073 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-09-10DNS: replace g_strsplit by wmem_strsplitPascal Quantin1-3/+1
It avoids leaking memory in case an exception is thrown during dissection Change-Id: Iab72bcb4cc1ac56e7ce5ff2693e3111aead03e7d Reviewed-on: https://code.wireshark.org/review/23464 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-07dns: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+0
Change-Id: I1bb25125d9bd7b62b5784bd43d933dc5ff13987c Reviewed-on: https://code.wireshark.org/review/23005 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-07dns: remove extra semicolonAlexis La Goutte1-4/+4
Change-Id: I710d9c519ccf012d3e74e7c2087d0f9fc5cfca12 Reviewed-on: https://code.wireshark.org/review/23004 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-07XFP: use switch for adress_familyAlexis La Goutte1-23/+27
Change-Id: Id0f9fd6d49669f5d4606448788658e5a8ed89f8d Reviewed-on: https://code.wireshark.org/review/23003 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-30dns: add missing breakMartin Mathieson1-0/+1
Change-Id: Iec47e262beb9600fc6596242c4ce0d56162be74f Reviewed-on: https://code.wireshark.org/review/22881 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2017-07-30DNS dissector support for draft-bellis-dnsop-xpfArjen Zonneveld1-0/+89
Add support for draft-bellis-dnsop-xpf to the DNS dissector: - Parse the XPF additional RR (currently using a temp value of 65422) Bug: 13928 Change-Id: I2d4fa23a8d3828db483bc41fafe6cbd8885514dc Reviewed-on: https://code.wireshark.org/review/22803 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-30DNS: Apply LOC record angle capJaap Keuter1-5/+14
The LOC records LATITUDE and LONGITUDE angle values may become too large. Find these and stop conversion into invalid values. Bug: 13914 Change-Id: Ia01ac1ecf5080350454f06536c9be1cf758d6f3c Reviewed-on: https://code.wireshark.org/review/22847 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-07-29DNS: Fix APL record IPv4 address presentationJaap Keuter1-7/+5
When getting the (partial) IPv4 address make sure to pass the full 32 bits of the address when adding the proto tree item. Bug: 13923 Change-Id: I5b849705e723efd1269a64ee28b8d93724ab769a Reviewed-on: https://code.wireshark.org/review/22838 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-06-22dns: Put request/response tracking last in the treeStig Bjørlykke1-24/+24
Change-Id: I56b99941db63ca87cd233112967592c948d2a390 Reviewed-on: https://code.wireshark.org/review/22361 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-29Fix up dissector tables' UI names.Jeff Morriss1-1/+1
This was inspired by using the Decode-As UI to decode Field "SSL TCP Dissector" Value (port) XXX as YYY. "SSL Port" makes more sense as the UI name. Change-Id: Id6398a5dc79e32bddc4f1bfcf0a468ae1364808f Reviewed-on: https://code.wireshark.org/review/19573 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-11dns: improve loop detection in label decompressionPeter Wu1-9/+7
Previously the number of allowed pointers within a message is equal to the data in a tvb (16575 in one example). This is still expensive, so implement an alternative detection mechanism that looks for a direct self-loop and limits the total pointers to about 256. Bug: 13633 Change-Id: I803873e24ab170c7ef0b881d3bdc9dfd4014de97 Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1206 Reviewed-on: https://code.wireshark.org/review/21507 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2017-04-10dns: fix this statement may fall through [-Werror=implicit-fallthrough] ↵Alexis La Goutte1-0/+2
found by gcc7 and add also a missing (optional) break after default Change-Id: I03d594db4702ccb4ebab3fca6b071d323e7f8d39 Reviewed-on: https://code.wireshark.org/review/20994 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-04-04White space and style cleanups.Guy Harris1-169/+101
Get rid of extra blank lines. Clean up indentation. Use the same style for switch statements inside cases for the main switch statement in dissect_dns_answer() that's used for the main switch statement. Change-Id: I77da88a9ffcbf176d27e16222e75c778202c651b Reviewed-on: https://code.wireshark.org/review/20907 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-04-02DNS: add an expert info if buffer is too short to compute a key idPascal Quantin1-11/+22
Bug: 13548 Change-Id: I4c018ae7a46ebb3e667004293b3f6e180f9d693f Reviewed-on: https://code.wireshark.org/review/20855 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-31dns: prevent repeatedly overwriting resolved entriesPeter Wu1-2/+4
When a packet contains multiple conflicting names for the same address, it would result in modification of the resolved name every time this DNS packet is selected. In Qt, this causes a periodic (one second) redissection of the current (DNS!) packet which interferes with user interaction. To avoid this, only add the address on the first visit. Bug: 13533 Change-Id: Ic71515131da4d666bfd589df9ff90a866a30778c Reviewed-on: https://code.wireshark.org/review/20800 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-28Fix up time encodings.Guy Harris1-1/+1
Add some new encodings for absolute time stamps, and use them as appropriate; this fixes some cases where the time stamps in question were being dissected incorrectly. For the encodings with seconds and 1/2^32s of a second, don't arbitrarily give only microsecond resolution; 2^32 is greater than 1 million, and, in fact, at least some NTP RFCs explicitly talk about time resolution greater than 1 microsecond. Update references in the RELOAD dissector to reflect the documents in question having been updated and published as RFCs. Change-Id: Icbe0b696d65eb622978eb71e99ddf699b84e4fca Reviewed-on: https://code.wireshark.org/review/20759 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2017-02-21DNS: Add Edwards-Curve Digital Security Algorithm (EdDSA) for DNSSEC (RFC 8080)Alexis La Goutte1-1/+5
Change-Id: I39a8c6639174e73f90bc4c3d8bccf628c3a477c3 Reviewed-on: https://code.wireshark.org/review/20179 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-19DNS: Don't display DNSSEC Protocol and Algo in flag treeAlexis La Goutte1-2/+2
Change-Id: Ifbee604f25c27076750f41ada9dfef6157ac7819 Reviewed-on: https://code.wireshark.org/review/20180 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-31format_text_wmem -> format_textMichael Mann1-36/+36
All cases of the "original" format_text have been handled to add the proper wmem allocator scope. Remove the "original" format_text and replace it with one that has a wmem allocator as a parameter. Change-Id: I278b93bcb4a17ff396413b75cd332f5fc2666719 Reviewed-on: https://code.wireshark.org/review/19884 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-31Add format_text_wmem.Michael Mann1-36/+36
This allows for a wmem_allocator for users of format_text who want it (dissectors for wmem_packet_scope()). This lessens the role of current format_text functionality in hopes that it will eventually be replaced. Change-Id: I970557a65e32aa79634a3fcc654ab641b871178e Reviewed-on: https://code.wireshark.org/review/19855 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-01-22DNS: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
Change-Id: Ib376127546aa15806ed37a7c26fe29b0fa80225c Reviewed-on: https://code.wireshark.org/review/19722 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-25 12:18:28 +0000