aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-diameter.c
AgeCommit message (Collapse)AuthorFilesLines
2008-04-05Mark a local function static rather than extern.Martin Mathieson1-12/+9
Get rid of an unused variable. Was going to use proto_register_prefix(), but am not sure if its appropriate. Even with tree == NULL, dictionary items are used to generate info column. Loading the dictionary lazily would mean doing a lot of work as part of dissecting the first diameter frame, which could decrease our chances of capturing frames that arrive very soon after that one... svn path=/trunk/; revision=24784
2008-02-18Add an expert item about AVP:s without "data".Anders Broman1-0/+3
svn path=/trunk/; revision=24377
2008-01-28Dissect Vendor id and Auth-application Id.Anders Broman1-0/+23
svn path=/trunk/; revision=24216
2008-01-27Make it possible to do subdissection of Diameter AVP:s and add dissectionAnders Broman1-0/+21
of some 3GPP AVP:s. svn path=/trunk/; revision=24211
2007-12-12Update a comment about some flagsJörg Mayer1-1/+1
svn path=/trunk/; revision=23853
2007-11-27strcasecmp(), strncasecmp(), g_strcasecmp(), and g_strncasecmp() delendaGuy Harris1-8/+33
est. Use g_ascii_strcasecmp() and g_ascii_strncasecmp(), and supply our own versions if they're missing from GLib (as is the case with GLib 1.x). In the code to build the list of named fields for Diameter, don't use g_strdown(); do our own g_ascii_-style upper-case to lower-case mapping in the hash function and use g_ascii_strcasecmp() in the compare function. We do this because there is no guarantee that toupper(), tolower(), and functions that use them will, for example, map between "I" and "i" in all locales; in Turkish locales, for example, there are, in both upper case and lower case, versions of "i" with and without a dot, and the upper-case version of "i" is "I"-with-a-dot and the lower-case version of "I" is "i"-without-a-dot. This causes strings that should match not to match. This finishes fixing bug 2010 - an earlier checkin prevented the crash (as there are other ways to produce the same crash, e.g. a bogus dictionary.xml file), but didn't fix the case-insensitive string matching. svn path=/trunk/; revision=23623
2007-11-27Check for AVPs with a list of values and a type that's not a 32-bit orGuy Harris1-14/+38
shorter integral type. Fixes bug 2027. Rename the "bytes" pointer to "octetstring", and initialize it in a fashion that makes it clearer that it points to the first of the basic types, to make it clearer that it's for OctetString. svn path=/trunk/; revision=23615
2007-11-08Change dissecton of address type for AVP < 256 (RADIUS address).Anders Broman1-7/+32
svn path=/trunk/; revision=23402
2007-10-26Remove some unnecessary includes.Martin Mathieson1-4/+0
svn path=/trunk/; revision=23280
2007-10-24Remove a couple of unused variables.Gerald Combs1-36/+35
svn path=/trunk/; revision=23266
2007-10-24Add port ranges.Anders Broman1-14/+33
svn path=/trunk/; revision=23265
2007-10-24Make sure characters aren't sign-extended before being handed toGuy Harris1-1/+1
isalnum(). svn path=/trunk/; revision=23254
2007-10-23Apply the small performance enhancment patches for:Anders Broman1-6/+6
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster. Replace - col_append_fstr() with faster col_append_str() - col_add_str() with col_set_str() when it's safe svn path=/trunk/; revision=23252
2007-07-27Check the length in unsigned32 AVP data fields.Martin Mathieson1-2/+44
svn path=/trunk/; revision=22413
2007-07-20- add an all_cmds array for looking up 'RFC' packetsMartin Mathieson1-4/+32
- improve error/expert info when see unmatched AVPs, commands, appids svn path=/trunk/; revision=22363
2007-07-20- <?avp-proto and <?type-proto to instruct about which dissector to use for ↵Luis Ontanon1-24/+123
a given type or avp - dissect timestamps - add all the avps that were commented out in the dictionary svn path=/trunk/; revision=22360
2007-07-18Fix two Windows compile warningsBill Meier1-1/+1
svn path=/trunk/; revision=22353
2007-07-18Minor changes to expert itemsMartin Mathieson1-4/+7
svn path=/trunk/; revision=22350
2007-07-17Add Address decoding, two debug environment variables ↵Luis Ontanon1-49/+253
(WIRESHARK_DEBUG_DIAM_DICT_PARSER and WIRESHARK_DUMP_DIAM_DICT) and fix some issues pointed out by Martin svn path=/trunk/; revision=22345
2007-07-17If we can't find dictionary.xml, fail instead of trying to read fromGerald Combs1-83/+86
stdin (which makes distcheck unhappy). Fixup whitespace. svn path=/trunk/; revision=22338
2007-07-16for MSVC (vendor_flag ? 12 : 8) is signed ...Luis Ontanon1-1/+1
well for gcc is either signed or unsigned (they are two literals!) svn path=/trunk/; revision=22321
2007-07-16Rewrite of the diameter dissector to use the dictionary for creating hfids, ↵Luis Ontanon1-2225/+673
drop libxml dependency. The work is still incomplete (anything but strings and numbers appears as bytes) but I want others to start testing it. TODO: builders and decoders for: - (ntp) timestamps - addresses - diameteruris - diameteridentities - ipfilterrules - qosfilterrules - mipregistrationrequests svn path=/trunk/; revision=22318
2007-07-10Allow filtering of whole AVPMartin Mathieson1-1/+8
svn path=/trunk/; revision=22284
2007-07-09- Fix a broken comment in xml fileMartin Mathieson1-4/+4
- Add/fix some AVPs - Print unmatched command codes in decimal svn path=/trunk/; revision=22275
2007-06-20- include gqpolicy.xml properly!Martin Mathieson1-20/+34
- print more specific console disgnostics when AVPs don't match because of vendorID being different svn path=/trunk/; revision=22142
2007-04-23Add some GCC warnings to the standard set, and add some others to theGuy Harris1-14/+18
--enable-extra-gcc-checks set. If we turn on -pedantic, try turning on -Wno-long-long as well, so that it's not *so* pedantic that it rejects the 64-bit integral data types that we explicitly require. Constify a bunch of stuff, and make some other changes, to get rid of warnings. Clean up some indentation. svn path=/trunk/; revision=21526
2007-04-04Fix a warningStephen Fisher1-4/+5
svn path=/trunk/; revision=21336
2007-03-28Remove almost all of the casts I committed recently and in place ofStephen Fisher1-2/+2
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it. svn path=/trunk/; revision=21253
2007-03-27Fix about 100 simple to fix warnings from gcc 4.0 in epan/dissectors Stephen Fisher1-2/+2
svn path=/trunk/; revision=21233
2007-03-23fix a lot more warningsUlf Lamping1-4/+4
svn path=/trunk/; revision=21142
2007-01-31Fix bug 1332 properly.Martin Mathieson1-0/+24
svn path=/trunk/; revision=20650
2007-01-30Size passed to IP address fields is now fixed (reported AVP size includes 2 ↵Martin Mathieson1-2/+2
bytes of padding), causing assertion reported in bug 1332. svn path=/trunk/; revision=20623
2006-10-31change the signature for the get_pdu_len() function pointer passed to ↵Ronnie Sahlberg1-1/+1
tcp_dissect_pdus() to also include a packet_info pointer. there are many reasons why some protocols actually need to be able to access the pinfo structure while determining the pdu size svn path=/trunk/; revision=19751
2006-08-01Delete leftover printfMartin Mathieson1-1/+0
svn path=/trunk/; revision=18809
2006-07-17From Martin Mathieson:Anders Broman1-36/+75
sip_stats.c and tap_sipstat.c: adds the code 429 ("Provide Referrer Identity", from RFC 3892) to SIP stats. chargecontrol.xml packet-diameter.c : These patches - add a few more chargecontrol AVPs, and add the vendor-id where needed - report as expert info when AVPs' lengths don't match their type svn path=/trunk/; revision=18743
2006-07-07From Martin Mathieson:Anders Broman1-1/+1
packet-diameter.c - show vendor ID as a decimal number diameter/chargecontrol.xml - add more AVP entries from 3GPP TS 32.299 (6.6.0) svn path=/trunk/; revision=18679
2006-07-03From Martin Mathieson:Anders Broman1-457/+473
packet-diameter.c -------------------------- I completely reindented dissect_avps() before I made any changes, but when ignoring white space (in tkdiff, -w plus checking 'Ignore blanks when diffing'), its easy to see the small changes I've made: - when fail to find AVP info, show code in tree parent in decimal (as specs do) - add an expert info (undecoded, note) to indicate unknown AVP codes diameter/imscxdx.xml ------------------------------- - added 'Associated-Identities' svn path=/trunk/; revision=18641
2006-05-28Ethereal->WiresharkAnders Broman1-5/+5
svn path=/trunk/; revision=18234
2006-05-23From Martin Mathieson:Anders Broman1-0/+3
- Many DCT2000 protocols can be embedded within an IP primitive message. Add a heuristic to see if we can find the protocol payload within in IP primitive message, and look for an ethereal dissector matching the DCT2000 protocol name (this is useful for simple protocol testing where no physical links are involved) - Make some more of these protocols (diameter, http, mgcp) findable by name - Adds protocol 'variant' number to stub and dissector - Break the duplicated writing of the stub header out into a separate function svn path=/trunk/; revision=18212
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=18196
2006-05-15dissect_diameter_tcp should be static voidAnders Broman1-5/+2
svn path=/trunk/; revision=18166
2006-03-20From Martin Mathieson:Anders Broman1-34/+39
Some cosmetic changes: - when working out the application id description to show in the info column, also consider vendor application identifiers - make sure application ids and command codes are always shown as decimal numbers - a little whitespace tidyup svn path=/trunk/; revision=17684
2006-03-15from Martim Mattieson:Anders Broman1-6/+65
This small patch will cause the current AVP dictionary to be freed and repopulated when relevant preferences have changed. svn path=/trunk/; revision=17635
2006-03-15From Martin MathiesonAnders Broman1-14/+34
>>>This patch: >>>- makes it possible to turn off use of the XML AVP dictionary (which >>>relies upon the XML lib being installed). A failed load results in 3 >>>annoying dialogs popping up the first time a diameter packet is read. >>>Default is previous behaviour. svn path=/trunk/; revision=17628
2006-02-16Use the new "proto_tree_add_*_format_value" routines.Guy Harris1-12/+12
svn path=/trunk/; revision=17316
2006-01-20packet-bgp.c: Fix incorrect use of g_snprintf return valueJörg Mayer1-5/+9
mp_addr_to_str was unnecessary 'complex' - simplified it packet-dns.c: Fix incorrect use of g_snprintf return value packet-dcm.c: Fix incorrect use of g_snprintf return value Someone who understands the protocol should look at the "vr, tr might be used uninitialized..." warning. packet-x11.c: Fix incorrect use of g_snprintf return value packet-kerberos.c: Fix incorrect use of g_snprintf return value Someone should take a look at the "longjump might clobber ..." messages packet-diameter.c: Fix incorrect use of g_snprintf return value Get rid of unsigned < 0 check packet-pgm.c: Fix incorrect use of g_snprintf return value packet-nbns.c: Fix incorrect use of g_snprintf return value packet-winsrepl.c: Collateral damage to packet-nbns.c fix packet-netbios.c: Collateral damage to packet-nbns.c fix packet-netbios.h: Collateral damage to packet-nbns.c fix packet-kerberos.c: Collateral damage to packet-nbns.c fix packet-nbipx.c: Collateral damage to packet-nbns.c fix svn path=/trunk/; revision=17065
2006-01-10Handle <application id="4294967295" name="Relay"/>Anders Broman1-3/+2
svn path=/trunk/; revision=16988
2006-01-05Bill Meier:Jörg Mayer1-2/+2
Spelling fixes. svn path=/trunk/; revision=16956
2005-11-19Use VendorID from sminmpec.Anders Broman1-26/+42
svn path=/trunk/; revision=16552
2005-11-16Display AVP:s of Dimater type Unsigned32 as such even when they have "value ↵Anders Broman1-6/+40
translation". svn path=/trunk/; revision=16510