aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-dcom.c
AgeCommit message (Collapse)AuthorFilesLines
2011-08-16Based on patch from Denis Ovsienko viamorriss1-2/+2
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6244 : Fix typo: s/unkown/unknown/ git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38561 f5534014-38df-0310-8fa8-9805f1628bb7
2011-07-19Add a DREP_LITTLE_ENDIAN for the DCE RPC endianness bit in the dataguy1-4/+4
representation. Use it rather than a raw 0x10. Add a DREP_ENC_INTEGER() macro that takes a pointer to the data representation and returns either ENC_LITTLE_ENDIAN or ENC_BIG_ENDIAN; use it for the encoding argument to proto_tree_add_item(), rather than just the AND of drep[0] and DREP_LITTLE_ENDIAN, as it's not a boolean any more, and for string values we'll be supporting character encodings as well and thus won't be able to trust that the 0x10 bit will mean "little endian". Use ENC_NA for some other encoding values, i.e. for FT_BYTES and the like. Fix a couple of places in the DCOM dissector where we were passing the byte-order bit rather than the field value to proto_tree_add_uint_format(). Clean up white space. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@38128 f5534014-38df-0310-8fa8-9805f1628bb7
2011-04-26get_host_ipaddr() was returning numeric addresses in host byte ordergerald1-2/+0
and hostnames in network byte order. Have it return everything in network byte order. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36873 f5534014-38df-0310-8fa8-9805f1628bb7
2011-01-16Use tvb_ip_to_str().morriss1-4/+2
There's no need to pass the result of tvb_get_ptr() as the 'value' in proto_tree_add_*(): just use proto_tree_add_item(). Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the return string is NULL terminated. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@35545 f5534014-38df-0310-8fa8-9805f1628bb7
2010-05-28Move some code (including the optional objects) into libwsutilmorriss1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33012 f5534014-38df-0310-8fa8-9805f1628bb7
2010-04-16Fix the fuzz failure found inmorriss1-162/+176
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4685 : Don't store pointers to g_malloc()'d memory (in this case GLists) in se_alloc()'d memory: the se_alloc()'d memory is freed before the reinit functions are called so it's no longer safe to use. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32490 f5534014-38df-0310-8fa8-9805f1628bb7
2010-02-09Fix some memory leaks; Fix some indentation.wmeier1-134/+160
This is a re-submission of SVN #31838 this time properly using g_list_free() instead of g_free(). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31848 f5534014-38df-0310-8fa8-9805f1628bb7
2010-02-09Revert SVN #31838; It's NG.wmeier1-156/+134
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31847 f5534014-38df-0310-8fa8-9805f1628bb7
2010-02-08Fix some memory leaks; Fix some indentation.wmeier1-134/+156
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31838 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-09Removed an unused variable.stig1-2/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30880 f5534014-38df-0310-8fa8-9805f1628bb7
2009-10-11Make ett_* values static.stig1-12/+12
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30508 f5534014-38df-0310-8fa8-9805f1628bb7
2009-10-05Initialize u32BoundElements.stig1-0/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30333 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-21Sanitize epan includeskrj1-3/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29499 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-07Changed flags_set_truth -> tfs_set_notsetstig1-11/+11
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28989 f5534014-38df-0310-8fa8-9805f1628bb7
2009-06-18From Kovarththanan Rajaratnam via bug 3548:stig1-88/+88
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28770 f5534014-38df-0310-8fa8-9805f1628bb7
2009-02-14try to fix some solaris buildbot warningsulfl1-3/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27449 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-24Windows build: #include winsock2.h only when needed.wmeier1-0/+4
#include winsock2.h pulls in about 90 distinct .h files and about 140 total .h files. Currently winsock2.h is (mostly unnecessarily) included for each dissector via packet.h/wtap.h. This patch removes #include winsock2.h from wtap.h and then includes winsock2.h (or windows.h) in the few specific places required. With this patch, my Windows Wireshark build takes about 30% less time. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26535 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-20Fix a bit more spacingwmeier1-28/+28
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26506 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-20Oops ! Revert (Remove) development stuff ....wmeier1-2/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26505 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-20Adjust indentation to be more consistent ....wmeier1-355/+358
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26504 f5534014-38df-0310-8fa8-9805f1628bb7
2008-09-26Addt'l minor cleanupwmeier1-45/+42
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26279 f5534014-38df-0310-8fa8-9805f1628bb7
2008-09-26prefs callback not req'dwmeier1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26278 f5534014-38df-0310-8fa8-9805f1628bb7
2008-06-27Fix some warnings reported by gcc -Wshadow ... wmeier1-25/+21
Fix some spacing in packet-dcom.c git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25618 f5534014-38df-0310-8fa8-9805f1628bb7
2008-02-02Rewrote some prohibited APIs in epan/dissectors/ (sprintf, strcpy, strcat).stig1-1/+1
If we get some truncated strings we probably overwrote some buffers... git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24249 f5534014-38df-0310-8fa8-9805f1628bb7
2007-06-18Fix compilation on OS X with GLib 1.2 by including ctype.h since oursfisher1-0/+1
isprint.h override only kicks in for GLib 2+. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22125 f5534014-38df-0310-8fa8-9805f1628bb7
2007-05-29Use G_GINT64_MODIFIER, rather than the PRI[douxX]64 macros, for GLibguy1-1/+1
routines and routines using those routines. GLib might use different modifiers for 64-bit quantities than the platform's C library does. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21990 f5534014-38df-0310-8fa8-9805f1628bb7
2007-04-23Add some GCC warnings to the standard set, and add some others to theguy1-1/+1
--enable-extra-gcc-checks set. If we turn on -pedantic, try turning on -Wno-long-long as well, so that it's not *so* pedantic that it rejects the 64-bit integral data types that we explicitly require. Constify a bunch of stuff, and make some other changes, to get rid of warnings. Clean up some indentation. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21526 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-28Remove almost all of the casts I committed recently and in place ofsfisher1-1/+1
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21253 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-27Fix about 100 simple to fix warnings from gcc 4.0 in epan/dissectors sfisher1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21233 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-22correct multidimensional SAFEARRAYsulfl1-5/+7
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21123 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-14Correctly return the item value through the pointer.guy1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21030 f5534014-38df-0310-8fa8-9805f1628bb7
2007-02-25add a new function dissect_dcom_HRESULT_item() for some more flexibility, ↵ulfl1-0/+24
use it in the CBA-ACCO dissector - as the value_strings from dcom can't be used in hf_register_info from a plugin git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20926 f5534014-38df-0310-8fa8-9805f1628bb7
2007-02-19Continuing the tradition: squelch some compiler warnings ....wmeier1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20866 f5534014-38df-0310-8fa8-9805f1628bb7
2007-02-06dissector changes:ulfl1-8/+12
- new: ICBALogicalDevice2::PBAddressInfo - enhanced: GROUPERRORDEF simplify ett registration add a callback for SAFEARRAY data dissection git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@20723 f5534014-38df-0310-8fa8-9805f1628bb7
2006-11-07From Albert Chin:jake1-1/+1
Patch attached to convert usage of ntohl() -> g_ntohl(). On HP-UX, ntohl() isn't available unless you -D_XOPEN_SOURCE_EXTENDED but there are other uses of g_ntohl(). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19844 f5534014-38df-0310-8fa8-9805f1628bb7
2006-11-06Remove some // comments.jmayer1-2/+1
Fix a warning about nested comments. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19828 f5534014-38df-0310-8fa8-9805f1628bb7
2006-10-18Squelch compiler warningsjake1-2/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19597 f5534014-38df-0310-8fa8-9805f1628bb7
2006-09-07distinguish between things "ToBeDone" and "NoSpecificationAvailable" as some ↵ulfl1-8/+30
DCOM things are just unknown and cannot be implemented therefore git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19174 f5534014-38df-0310-8fa8-9805f1628bb7
2006-08-28add a new this/that flag valueulfl1-0/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19066 f5534014-38df-0310-8fa8-9805f1628bb7
2006-08-19Fix some format strings and format string arguments.guy1-3/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18957 f5534014-38df-0310-8fa8-9805f1628bb7
2006-08-17some further work on the GUID/UUID resolvingsulfl1-117/+35
most of the relevant code moved to guid_utils lot of corresponding code cleanup in packet-dcerpc.c still using GHashTable still not using a manuf like file git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18939 f5534014-38df-0310-8fa8-9805f1628bb7
2006-08-16various UUID/GUID based changes.ulfl1-78/+146
I think I've changed all corresponding appearances from FT_STRING to FT_GUID, so assert the FT_ type as it should only be a FT_GUID now. Add a generic implementation in guid_utils.h to have a way to store data about GUID to name resolving (something like value_string for e.g. int). It might be better to have a single registry for all GUID's of all dissectors and implement the GUID name resolving into the proto_tree_add... functions. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18935 f5534014-38df-0310-8fa8-9805f1628bb7
2006-08-14various minor DCOM dissection enhancements:ulfl1-12/+109
- add a generic guid register to dissect UUID's (move this to a seperate file?) - this enables us to set some known names for special UUID's - use standard DCOM fields for IID and alike in remunk.c - cleanup dcom_protseq_vals handling - some FT_STRING to FT_GUID changes git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18904 f5534014-38df-0310-8fa8-9805f1628bb7
2006-08-11add an experimental DCOM object "database" based on the exchanged interface ↵ulfl1-42/+271
pointers add a lot more PROFINET CBA dissection output based on these DCOM context information still need some improvements, e.g. dissection uses a simple (slow) linear list search changes are fuzz-tested git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18882 f5534014-38df-0310-8fa8-9805f1628bb7
2006-07-01remove two old commentsulfl1-2/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18632 f5534014-38df-0310-8fa8-9805f1628bb7
2006-06-28add dissection of custom marshalled OBJREF's (as far as known)ulfl1-3/+19
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18596 f5534014-38df-0310-8fa8-9805f1628bb7
2006-06-15fix the hresult "filter" fieldsulfl1-3/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18469 f5534014-38df-0310-8fa8-9805f1628bb7
2006-06-13dcom_tvb_get_nwstringz0(): convert output to hexdump if the string contains ↵ulfl1-78/+74
nonprintable characters git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18453 f5534014-38df-0310-8fa8-9805f1628bb7
2006-05-21change a whole bunch of ethereal into wiresharksahlberg1-140/+140
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18196 f5534014-38df-0310-8fa8-9805f1628bb7
2006-05-05fix VARIANT BOOL meaningulfl1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18095 f5534014-38df-0310-8fa8-9805f1628bb7