aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-dcm.c
AgeCommit message (Collapse)AuthorFilesLines
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-2/+2
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-06-19Fix gcc 4.6 "set but not used [-Wunused-but-set-variable]" warnings.Bill Meier1-2/+0
svn path=/trunk/; revision=37716
2011-05-27Make TVBs opaque for most users.Jeff Morriss1-1/+1
Convert TVB_RAW_OFFSET() and TVB_GET_DS_TVB() into functions. svn path=/trunk/; revision=37422
2011-05-27Treat TVBs as opaque: use the accessor functions instead of accessing the fieldsJeff Morriss1-6/+7
directly. svn path=/trunk/; revision=37420
2011-05-04Cleanup: replace sizeof(arr)/sizeof(arr[0]) with shorter array_length(arr)Jakub Zawadzki1-3/+3
svn path=/trunk/; revision=36986
2011-04-30Check our PDU length. Fixes the infinite loop found in bug 5876.Gerald Combs1-0/+7
svn path=/trunk/; revision=36958
2011-04-16Fix Coverity CIDs 603 & 604.Gerald Combs1-2/+2
svn path=/trunk/; revision=36672
2011-03-23Removed "comparing an array to null", with no effect.Stig Bjørlykke1-2/+1
Coverity 532. svn path=/trunk/; revision=36279
2011-03-22Remove two tests for fail return from g_malloc(); Fixes Coverity #424 ↵Bill Meier1-8/+4
"FORWARD_NULL" svn path=/trunk/; revision=36267
2011-02-10Modify proto_tree_add_bytes_format() and proto_tree_add_bytes_format_value()Jeff Morriss1-13/+11
so that if the start_ptr is NULL the bytes are extracted from the given TVB using the given offset and length. Replace a bunch of: proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, tvb_get_ptr(tvb, offset, length), [...]) with: proto_tree_add_bytes_format*(tree, hf, tvb, offset, length, NULL, [...]) svn path=/trunk/; revision=35896
2011-01-31Fix two cases of 'if (x = y)' which should be 'if (x == y)'.Bill Meier1-1/+1
Found by reviewing msvc level 4 warnings "assignment within conditional expression". (Unfortunately most of the warnings are false positives so this warning can't be enabled) svn path=/trunk/; revision=35726
2011-01-30Introduce "Fragment count" filter element for all protocols doing reassembly.Stig Bjørlykke1-0/+5
svn path=/trunk/; revision=35705
2011-01-20Roll some calls to tvb_get_ptr() into proto_tree_add_bytes_format() (insteadJeff Morriss1-30/+12
of going through a temporary variable). This just makes it more obvious which add_bytes_format() calls are or are not being given pointers into the TVB. Use tvb_ip_to_str() and tvb_ip6_to_str() in a couple spots. svn path=/trunk/; revision=35593
2011-01-16Use tvb_memeql() and tvb_memcpy().Jeff Morriss1-2/+2
Use tvb_ip_to_str() and tvb_ip6_to_str(). There's no need to pass the result of tvb_get_ptr() as the 'value' in proto_tree_add_*(): just use proto_tree_add_item(). Replace some tvb_get_ptr()s with tvb_get_ephemeral_string()s to ensure the return string is NULL terminated. svn path=/trunk/; revision=35546
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-2/+2
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-12-06Fix various typos and spelling errors.Bill Meier1-1/+1
svn path=/trunk/; revision=35126
2010-08-09From David Aggeler:Jaap Keuter1-356/+627
- Finally, better reassembly using fragment_add_seq_next(). The previous mode is still supported. - Fixed sporadic decoding and export issues. Always decode association negotiation, since performance check (tree==NULL) is now only in dissect_dcm_pdv_fragmented(). - Added one more PDV length check - Show Association Headers as individual items - Code cleanup. i.e. moved a few lookup functions to be closer to the dissection. svn path=/trunk/; revision=33751
2010-06-09Do some constifying [or other] based upon gcc -Wwrite-strings warnings.Bill Meier1-4/+4
svn path=/trunk/; revision=33198
2010-05-14From David Aggeler via ↵Jeff Morriss1-51/+67
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4762 : - Fixed HF to separate signed & unsigned values and to have BASE_DEC all signed - Fixed private sequences with undefined length in ILE - Fixed some spellings in comments svn path=/trunk/; revision=32815
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
2010-03-19Squelch a bunch of compiler warnings.Guy Harris1-55/+57
svn path=/trunk/; revision=32246
2010-01-25From Didier Gautheron via bug 4419:Stig Bjørlykke1-100/+34
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized data with 0. svn path=/trunk/; revision=31654
2010-01-18Fix a number of gcc _Wshadow warningsBill Meier1-5/+5
svn path=/trunk/; revision=31557
2009-11-04tvb_format_text() always returns a non NULL pointer so don't check return ↵Kovarththanan Rajaratnam1-3/+3
value for NULL pointer svn path=/trunk/; revision=30821
2009-10-25From Jakub Zawadzki:Anders Broman1-45/+29
Cleanup dissector code - use proper memory functions. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164 svn path=/trunk/; revision=30691
2009-08-28Fix possible memmove with a NULL poiunter.Bill Meier1-2/+4
svn path=/trunk/; revision=29599
2009-08-09Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-3/+1
svn path=/trunk/; revision=29345
2009-07-10From David Aggeler:Jaap Keuter1-159/+78
* - Fixed corrupt files on DICOM Export * - Fixed memory limitation on DICOM Export * - Removed minimum packet length for static port mode * - Simplified checks for heuristic mode * - Removed unused functions svn path=/trunk/; revision=29060
2009-05-18From David Aggeler:Jaap Keuter1-59/+178
Not much, just a little bit of fine tuning: - Spelling - Added expert_add_info() for status responses with warning & error level - Added command details in info column (optionally) Also plugging memory leak. svn path=/trunk/; revision=28392
2009-03-29More size_t casts.Anders Broman1-1/+1
svn path=/trunk/; revision=27880
2009-03-15From Jakub Zawadzki:Stig Bjørlykke1-5/+3
More remove checking for NULL before g_free(). svn path=/trunk/; revision=27728
2008-12-19Back out r27047 and r27053.Gerald Combs1-9/+9
svn path=/trunk/; revision=27062
2008-12-18Update calls to proto_tree_add_bytes_format to reflect r27047.Gerald Combs1-9/+9
svn path=/trunk/; revision=27053
2008-12-18Fix two typosBill Meier1-2/+2
svn path=/trunk/; revision=27052
2008-12-18Fix various typos and spelling errors (mostly in text strings)Bill Meier1-15/+15
svn path=/trunk/; revision=27050
2008-12-17Fix typos and spelling (mostly in text strings) Bill Meier1-5/+5
svn path=/trunk/; revision=27028
2008-10-31From David Aggeler:Jaap Keuter1-88/+156
Added Tag matching based on masks for remaining tags in the standard. Now all tags (except private tags) should be supported. svn path=/trunk/; revision=26662
2008-10-31Fix some "format not a string literal and no format arguments" warnings.Stig Bjørlykke1-6/+6
svn path=/trunk/; revision=26646
2008-10-12From David Aggeler:Anders Broman1-24/+25
Reworked the item creation. svn path=/trunk/; revision=26424
2008-10-11Really make it compile. Someone should have a look at this.Stig Bjørlykke1-7/+7
svn path=/trunk/; revision=26417
2008-10-11Just try to make it compile.Anders Broman1-8/+8
svn path=/trunk/; revision=26416
2008-10-11From David Aggeler: Anders Broman1-797/+4218
packet-dcm, improved DICOM Tag support, misc fixes. svn path=/trunk/; revision=26413
2008-08-09From Shinsuke SUZUKI (bug 2789):Stig Bjørlykke1-4/+4
Remove some non-ASCII characters. svn path=/trunk/; revision=25972
2008-07-25From David Aggeler:Anders Broman1-62/+89
Follow-up from SVN 25825 check in The g_slist_free() is really needed in export_object.c, otherwise, the export list has false (repetitive) entries in it, that cause a crash when selecting them. Whether false entries are in the list, only depends on the speed of the export processing, since this tap is Replaced all guchar with gchar. This should eliminate the warnings on solaris. I guess I used the wrong reference. Added patch for 'Authors' in case I need to add myself to the list. svn path=/trunk/; revision=25834
2008-07-25static variable declarations don't belong in header filesJeff Morriss1-8/+281
svn path=/trunk/; revision=25830
2008-07-25Remove an unused variable and cast a string constant into a guchar. Also ↵Jeff Morriss1-3/+2
add newline at the end of the file. svn path=/trunk/; revision=25829
2008-07-25Try to fix some of the warnings.Anders Broman1-2/+0
svn path=/trunk/; revision=25827
2008-07-25Try to fix some of the warnings.Anders Broman1-11/+7
svn path=/trunk/; revision=25826
2008-07-25From David Aggeler:Anders Broman1-498/+1359
multiple PDV per PDU support - Support multiple PDVs per PDU - Better summary, in PDV, PDU header and in INFO Column, e.g. show commands like C-STORE - Fixed Association Reject (was working before my changes) - Fixed PDV Continuation with very small packets. Reduced minimum packet length from 10 to 2 Bytes for PDU Type 4 - Fixed PDV Continuation. Last packet was not found correctly. - Fixed complilation warning (build 56 on solaris) - Fixed tree expansion (hf_dcm_xxx) - Added expert_add_info() for Assoctiation Reject - Added expert_add_info() for Assoctiation Abort - Added expert_add_info() for short PDVs (i.e. last fragment, but PDV is not completed yet) - Clarified and grouped data structures and its related code (dcmItem, dcmState) to have consistent _new() & _get() functions and to be be according to coding conventions - Added more function declaration to be more consistent - All dissect_dcm_xx now have (almost) the same parameter order - Removed DISSECTOR_ASSERT() for packet data errors. Not designed to handle this. - Handle multiple DICOM Associations in a capture correctly, i.e. if presentation contexts are different. svn path=/trunk/; revision=25824
2008-07-25From David Aggeler:Anders Broman1-500/+1411
DICOM dissector bugfixes and features svn path=/trunk/; revision=25823
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 00:40:41 +0000