aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-dcm.c
AgeCommit message (Collapse)AuthorFilesLines
2010-08-09From David Aggeler:jake1-356/+627
- Finally, better reassembly using fragment_add_seq_next(). The previous mode is still supported. - Fixed sporadic decoding and export issues. Always decode association negotiation, since performance check (tree==NULL) is now only in dissect_dcm_pdv_fragmented(). - Added one more PDV length check - Show Association Headers as individual items - Code cleanup. i.e. moved a few lookup functions to be closer to the dissection. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33751 f5534014-38df-0310-8fa8-9805f1628bb7
2010-06-09Do some constifying [or other] based upon gcc -Wwrite-strings warnings.wmeier1-4/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@33198 f5534014-38df-0310-8fa8-9805f1628bb7
2010-05-14From David Aggeler via ↵morriss1-51/+67
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4762 : - Fixed HF to separate signed & unsigned values and to have BASE_DEC all signed - Fixed private sequences with undefined length in ILE - Fixed some spellings in comments git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32815 f5534014-38df-0310-8fa8-9805f1628bb7
2010-04-03Remove unneeded #include <stdio.h>wmeier1-1/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32367 f5534014-38df-0310-8fa8-9805f1628bb7
2010-03-19Squelch a bunch of compiler warnings.guy1-55/+57
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32246 f5534014-38df-0310-8fa8-9805f1628bb7
2010-01-25From Didier Gautheron via bug 4419:stig1-100/+34
se_alloc and ep_alloc never return NULL and se_alloc0 already initialized data with 0. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31654 f5534014-38df-0310-8fa8-9805f1628bb7
2010-01-18Fix a number of gcc _Wshadow warningswmeier1-5/+5
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31557 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-04tvb_format_text() always returns a non NULL pointer so don't check return ↵krj1-3/+3
value for NULL pointer git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30821 f5534014-38df-0310-8fa8-9805f1628bb7
2009-10-25From Jakub Zawadzki:etxrab1-45/+29
Cleanup dissector code - use proper memory functions. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4164 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30691 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-28Fix possible memmove with a NULL poiunter.wmeier1-2/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29599 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-09Don't guard col_set_str (COL_INFO/COL_PROTOCOL) with col_checkkrj1-3/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29345 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-10From David Aggeler:jake1-159/+78
* - Fixed corrupt files on DICOM Export * - Fixed memory limitation on DICOM Export * - Removed minimum packet length for static port mode * - Simplified checks for heuristic mode * - Removed unused functions git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29060 f5534014-38df-0310-8fa8-9805f1628bb7
2009-05-18From David Aggeler:jake1-59/+178
Not much, just a little bit of fine tuning: - Spelling - Added expert_add_info() for status responses with warning & error level - Added command details in info column (optionally) Also plugging memory leak. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28392 f5534014-38df-0310-8fa8-9805f1628bb7
2009-03-29More size_t casts.etxrab1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27880 f5534014-38df-0310-8fa8-9805f1628bb7
2009-03-15From Jakub Zawadzki:stig1-5/+3
More remove checking for NULL before g_free(). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27728 f5534014-38df-0310-8fa8-9805f1628bb7
2008-12-19Back out r27047 and r27053.gerald1-9/+9
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27062 f5534014-38df-0310-8fa8-9805f1628bb7
2008-12-18Update calls to proto_tree_add_bytes_format to reflect r27047.gerald1-9/+9
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27053 f5534014-38df-0310-8fa8-9805f1628bb7
2008-12-18Fix two typoswmeier1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27052 f5534014-38df-0310-8fa8-9805f1628bb7
2008-12-18Fix various typos and spelling errors (mostly in text strings)wmeier1-15/+15
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27050 f5534014-38df-0310-8fa8-9805f1628bb7
2008-12-17Fix typos and spelling (mostly in text strings) wmeier1-5/+5
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27028 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-31From David Aggeler:jake1-88/+156
Added Tag matching based on masks for remaining tags in the standard. Now all tags (except private tags) should be supported. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26662 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-31Fix some "format not a string literal and no format arguments" warnings.stig1-6/+6
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26646 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-12From David Aggeler:etxrab1-24/+25
Reworked the item creation. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26424 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-11Really make it compile. Someone should have a look at this.stig1-7/+7
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26417 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-11Just try to make it compile.etxrab1-8/+8
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26416 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-11From David Aggeler: etxrab1-797/+4218
packet-dcm, improved DICOM Tag support, misc fixes. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26413 f5534014-38df-0310-8fa8-9805f1628bb7
2008-08-09From Shinsuke SUZUKI (bug 2789):stig1-4/+4
Remove some non-ASCII characters. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25972 f5534014-38df-0310-8fa8-9805f1628bb7
2008-07-25From David Aggeler:etxrab1-62/+89
Follow-up from SVN 25825 check in The g_slist_free() is really needed in export_object.c, otherwise, the export list has false (repetitive) entries in it, that cause a crash when selecting them. Whether false entries are in the list, only depends on the speed of the export processing, since this tap is Replaced all guchar with gchar. This should eliminate the warnings on solaris. I guess I used the wrong reference. Added patch for 'Authors' in case I need to add myself to the list. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25834 f5534014-38df-0310-8fa8-9805f1628bb7
2008-07-25static variable declarations don't belong in header filesmorriss1-8/+281
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25830 f5534014-38df-0310-8fa8-9805f1628bb7
2008-07-25Remove an unused variable and cast a string constant into a guchar. Also ↵morriss1-3/+2
add newline at the end of the file. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25829 f5534014-38df-0310-8fa8-9805f1628bb7
2008-07-25Try to fix some of the warnings.etxrab1-2/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25827 f5534014-38df-0310-8fa8-9805f1628bb7
2008-07-25Try to fix some of the warnings.etxrab1-11/+7
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25826 f5534014-38df-0310-8fa8-9805f1628bb7
2008-07-25From David Aggeler:etxrab1-498/+1359
multiple PDV per PDU support - Support multiple PDVs per PDU - Better summary, in PDV, PDU header and in INFO Column, e.g. show commands like C-STORE - Fixed Association Reject (was working before my changes) - Fixed PDV Continuation with very small packets. Reduced minimum packet length from 10 to 2 Bytes for PDU Type 4 - Fixed PDV Continuation. Last packet was not found correctly. - Fixed complilation warning (build 56 on solaris) - Fixed tree expansion (hf_dcm_xxx) - Added expert_add_info() for Assoctiation Reject - Added expert_add_info() for Assoctiation Abort - Added expert_add_info() for short PDVs (i.e. last fragment, but PDV is not completed yet) - Clarified and grouped data structures and its related code (dcmItem, dcmState) to have consistent _new() & _get() functions and to be be according to coding conventions - Added more function declaration to be more consistent - All dissect_dcm_xx now have (almost) the same parameter order - Removed DISSECTOR_ASSERT() for packet data errors. Not designed to handle this. - Handle multiple DICOM Associations in a capture correctly, i.e. if presentation contexts are different. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25824 f5534014-38df-0310-8fa8-9805f1628bb7
2008-07-25From David Aggeler:etxrab1-500/+1411
DICOM dissector bugfixes and features git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25823 f5534014-38df-0310-8fa8-9805f1628bb7
2007-11-09Apply yet another set of the optimization patches:etxrab1-1/+1
janitor work, replace col_add_fstr/ col_set_fstr. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23411 f5534014-38df-0310-8fa8-9805f1628bb7
2007-04-23Add some GCC warnings to the standard set, and add some others to theguy1-13/+17
--enable-extra-gcc-checks set. If we turn on -pedantic, try turning on -Wno-long-long as well, so that it's not *so* pedantic that it rejects the 64-bit integral data types that we explicitly require. Constify a bunch of stuff, and make some other changes, to get rid of warnings. Clean up some indentation. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21526 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-29Fix some more warningssfisher1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21273 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-28Remove almost all of the casts I committed recently and in place ofsfisher1-3/+3
them, add -Wno-pointer-sign to CFLAGS when gcc will accept it. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21253 f5534014-38df-0310-8fa8-9805f1628bb7
2007-03-27Fix about 100 simple to fix warnings from gcc 4.0 in epan/dissectors sfisher1-3/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@21233 f5534014-38df-0310-8fa8-9805f1628bb7
2006-11-14nikai@nikai.net:jmayer1-1/+0
Remaining fixes from: http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1225 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19895 f5534014-38df-0310-8fa8-9805f1628bb7
2006-10-31change the signature for the get_pdu_len() function pointer passed to ↵sahlberg1-1/+1
tcp_dissect_pdus() to also include a packet_info pointer. there are many reasons why some protocols actually need to be able to access the pinfo structure while determining the pdu size git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19751 f5534014-38df-0310-8fa8-9805f1628bb7
2006-05-21change a whole bunch of ethereal into wiresharksahlberg1-5/+5
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18196 f5534014-38df-0310-8fa8-9805f1628bb7
2006-01-20packet-bgp.c: Fix incorrect use of g_snprintf return valuejmayer1-9/+18
mp_addr_to_str was unnecessary 'complex' - simplified it packet-dns.c: Fix incorrect use of g_snprintf return value packet-dcm.c: Fix incorrect use of g_snprintf return value Someone who understands the protocol should look at the "vr, tr might be used uninitialized..." warning. packet-x11.c: Fix incorrect use of g_snprintf return value packet-kerberos.c: Fix incorrect use of g_snprintf return value Someone should take a look at the "longjump might clobber ..." messages packet-diameter.c: Fix incorrect use of g_snprintf return value Get rid of unsigned < 0 check packet-pgm.c: Fix incorrect use of g_snprintf return value packet-nbns.c: Fix incorrect use of g_snprintf return value packet-winsrepl.c: Collateral damage to packet-nbns.c fix packet-netbios.c: Collateral damage to packet-nbns.c fix packet-netbios.h: Collateral damage to packet-nbns.c fix packet-kerberos.c: Collateral damage to packet-nbns.c fix packet-nbipx.c: Collateral damage to packet-nbns.c fix git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17065 f5534014-38df-0310-8fa8-9805f1628bb7
2005-10-16get rid of some strcpysahlberg1-29/+10
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@16234 f5534014-38df-0310-8fa8-9805f1628bb7
2005-09-17remove some strcpy()sahlberg1-8/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15849 f5534014-38df-0310-8fa8-9805f1628bb7
2005-08-27sprintf removalsahlberg1-10/+12
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15550 f5534014-38df-0310-8fa8-9805f1628bb7
2005-08-14change a g_malloc() that was never released into ep_alloc()sahlberg1-9/+10
this function would always leak memory when called. this fixes a memleak in dcm git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15352 f5534014-38df-0310-8fa8-9805f1628bb7
2005-08-12gmemchunk -> se_alloc() improvementssahlberg1-11/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15323 f5534014-38df-0310-8fa8-9805f1628bb7
2005-08-10rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the ↵sahlberg1-1/+1
documentation in README.developer git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15270 f5534014-38df-0310-8fa8-9805f1628bb7
2005-08-08various code cleanup:ulfl1-9/+5
-use g_snprintf instead of sprintf and snprintf -use g_strdup_printf where appropriate -remove #include "snprintf.h" (as only g_snprintf should be used) -replace some more alloc/realloc/calloc/free with their glib pendants git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15264 f5534014-38df-0310-8fa8-9805f1628bb7
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-02 01:07:43 +0000