aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-dcerpc-winreg.c
AgeCommit message (Collapse)AuthorFilesLines
2020-06-19Fix the type of arrays of pointers to hf_ values for bitfield routines.Guy Harris1-4/+4
The static arrays are supposed to be arrays of const pointers to int, not arrays of non-const pointers to const int. Fixing that means some bugs (scribbling on what's *supposed* to be a const array) will be caught (see packet-ieee80211-radiotap.c for examples, the first of which inspired this change and the second of which was discovered while testing compiles with this change), and removes the need for some annoying casts. Also make some of those arrays static while we're at it. Update documentation and dissector-generator tools. Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc Reviewed-on: https://code.wireshark.org/review/37517 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-06tools/pidl: Keep case from fieldnames.Günther Deschner1-149/+149
Change-Id: I5626cfa0487cc88eb65cc349c05ae1762bc953f4 Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/16720 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-18DCE/RPC: fix array of pointers with NULLBinh Trinh1-1/+5
Change-Id: Ie89f8fd4ec744d427d41866206d5a6784c5b224f Reviewed-on: https://code.wireshark.org/review/16004 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-16DCE/RPC proto_tree_add_boolean -> proto_tree_add_bitmask_valueMichael Mann1-8/+11
Change-Id: I88398aa1923e86bb83b97cc3904529a5810f6c40 Reviewed-on: https://code.wireshark.org/review/15978 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-16DCE/RPC proto_tree_add_boolean -> proto_tree_add_bitmask_with_flagsMichael Mann1-145/+41
Change-Id: I8891ec90244ffd9609d8443df631a7c8e6453b7e Reviewed-on: https://code.wireshark.org/review/15942 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-02Revert "PIDL: Remove _U_ and remove unused-parameter via pragma"Guy Harris1-641/+639
This reverts commit db4f7fcdeac833f24807994b372d1e42479754bf. That doesn't work with the compiler being used on the OS X buildbot; that compiler is probably some version of llvm-gcc, which might be based on an older version of GCC without support for that pragma, or might not support it properly courtesy of the GCC front end and the LLVM back end not quite fitting together Change-Id: I6cd5f1322b4872ef0c4eb5695f021cec00ba85b7 Reviewed-on: https://code.wireshark.org/review/15246 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-05-02PIDL: Remove _U_ and remove unused-parameter via pragmaAlexis La Goutte1-639/+641
Change-Id: Ic40f86850dc94338a8c2205e04679793f368672f Reviewed-on: https://code.wireshark.org/review/14967 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-29PIDL: regen pidl-generated dissectorsAurelien Aptel1-21/+7
mapi&nspi dissectors skipped on purpose since they the output is malformed. This was already the case before the samba sync. Change-Id: Ib3b78459e3506c755aaa219433ac6b5865482f01 Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-on: https://code.wireshark.org/review/13968 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-10-30DCERPC: Regenerate PIDL dissectorAlexis La Goutte1-1/+1
Fix some not updated link to wiki... Change-Id: Iafaa743c4adda36e6dffe2ec2a3a25b8228b9778 Reviewed-on: https://code.wireshark.org/review/11424 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-03-03Eliminate e_uuid_t in favor of e_guid_t.Guy Harris1-1/+1
That eliminates a redundant and confusing data type, and avoids issues with one piece of code using e_uuid_t but wanting to use routines expecting an e_guid_t. Change-Id: I95e172d46d342ab40f6254300ecbd2a0530cde60 Reviewed-on: https://code.wireshark.org/review/7506 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-03Regenerate DCE RPC dissectors with the current pidl.Guy Harris1-440/+454
Change-Id: I3cfb9399a9e5ed783083fa5b26a39646fb53875f Reviewed-on: https://code.wireshark.org/review/5101 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-08Remove #pragma warning (MSVC) for PIDL generate dissectorAlexis La Goutte1-7/+0
Change-Id: I1e4c7944a2cd877f5c707703dcff44fe9f955a2c Reviewed-on: https://code.wireshark.org/review/4479 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-09-28PIDL (DCERPC winreg): enhance dissectorAlexis La Goutte1-15/+3
* Fix PIDL generator for NOEMIT Element (fix -Wunused-function for DCERPC winreg dissector) * Fix indent (use tabs) * Remove DCERPC winreg dissector from DIRTY list Change-Id: I5d16cbfe8481a5e5f7e5df9b51735c93ae4375a7 Reviewed-on: https://code.wireshark.org/review/4322 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-28PIDL: fix -Wmissing-prototypeAlexis La Goutte1-0/+2
Change-Id: I4cae47450e8026b10bd373828f235184560e0a99 Reviewed-on: https://code.wireshark.org/review/4308 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-27PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-4/+4
Change-Id: I7f6f974732b7905f4ea4686e1a79ca6fbef78fa8 Reviewed-on: https://code.wireshark.org/review/4319 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-09-27Regenerate PIDL dissectors with our current PIDL.Guy Harris1-441/+441
Change-Id: I63a1874d157c55df6c3c3f69c68098528adbb384 Reviewed-on: https://code.wireshark.org/review/4330 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-20proto_tree_add_text -> proto_tree_add_subtree[_format] for DCE/RPC dissectors.Michael Mann1-464/+463
Change-Id: I84755d059ef70ca98b0e7626b6425360daf0529d Reviewed-on: https://code.wireshark.org/review/4199 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-19Update generated DCE/RPC dissectors.Michael Mann1-440/+440
Now all generated dissectors can successfully compile. Change-Id: I74728926915d5a9f1694cc49c753b80f213df767 Reviewed-on: https://code.wireshark.org/review/2598 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-31Continue to remove $Id$ from top of fileAlexis La Goutte1-3/+1
(Using sed : sed -i '/^ \t$Id\$/,+0 d') (tab before $Id$) Also modify generator (NDR.pm) Change-Id: I348a1d129d1d1320bd80b428038ea5ed291d6ca8 Reviewed-on: https://code.wireshark.org/review/878 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-11-24Move dceprc_procedure_name from packet_info to dcerpc_info. Doesn't appear ↵Michael Mann1-72/+72
to be "used" by dissectors, just stored (for help in debugging?). svn path=/trunk/; revision=53552
2013-11-06With the updated pidl it is now possible to generate severalJörg Mayer1-159/+158
of the dcerpc dissectors again. Commit those of the generated onces that actually compile. svn path=/trunk/; revision=53122
2013-11-06Remove pinfo->private_data from DCERPC dissectors and instead have ↵Michael Mann1-1324/+1316
dcerpc_info* infomation be passed in as a function parameter. Bug 9387 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9387) All "generated" source was manually modified (with the power of search/replace), but I believe the "source input" files have been adjusted (checked into revs 53098 and 53099) to reflect the necessary changes (with possible whitespace formatting differences). The Microsoft compiler doesn't flag "unused function parameters", so I apologize in advance if I may have missed a few. The "dcerpc_info* di" parameter is used in almost every function. svn path=/trunk/; revision=53100
2013-10-21Sync with latest SAMBA PIDL source per ↵Michael Mann1-349/+1316
http://www.wireshark.org/lists/wireshark-dev/201310/msg00217.html Didn't integrate 0010-frsrpc-Regenerate-frsrpc-due-to-changes-in-the-pidl-.patch 0016-Regenerate-the-dnserver.patch due to compilation errors on Windows. svn path=/trunk/; revision=52744
2013-10-01Remove check_col from generated DCE/RPC dissectors. Bug 8804 ↵Michael Mann1-35/+35
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8804). I still couldn't figure out how to generate the source, so I made the modifications to the generated dissectors "manually" (search/replace tool in VS) that would match the "PIDL source" included here. I will be sending the "PIDL source" (non dissector files) to the samba team. svn path=/trunk/; revision=52313
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45017
2010-10-30Add an SVN Id to these PIDL-generated dissectors. A patch to PIDL will be ↵Jeff Morriss1-0/+2
sent upstream to the Samba developers. svn path=/trunk/; revision=34713
2009-12-19For fields of type FT_ABSOLUTE_TIME, have the "display" value be one ofGuy Harris1-2/+2
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL == (int)BASE_NONE, so there's no source or binary compatiblity issue, although we might want to eliminate BASE_NONE at some point and have the BASE_ values used with integral types start at 0, so that you can't specify BASE_NONE for an integral field. svn path=/trunk/; revision=31319
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-112/+112
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2007-05-07update the conformance file for winreg to specify that the string for Ronnie Sahlberg1-1/+1
OpenKey keynames should be saved/stored in the dcv structure. this now makes all policy handles generated by the OpenKey function show OpenKey(/path/keyname) for all such policyhandles svn path=/trunk/; revision=21720
2007-05-07using latest version of pidl, which includes the required pragmas and Ronnie Sahlberg1-7/+10
which also handles TYPE and PARAM_VALUE for strings, regenerate winreg after using hte conformance file to prettify how and where strings are to be used to decorate the summary line and the dissection tree svn path=/trunk/; revision=21717
2007-05-05disable warning 4005 *again*Ulf Lamping1-0/+4
svn path=/trunk/; revision=21688
2007-05-03use the latest version of PIDL to regenerate winreg using the new TYPE Ronnie Sahlberg1-320/+345
conformance file directive to replace winreg_String with our own code. PARAM_VALUE does not yet work for this however which needs to looked into svn path=/trunk/; revision=21669
2007-03-29regenerate the dissectors with an even newer patched version of pidl to add ↵Ronnie Sahlberg1-0/+2
two more pragmas you need this patch ontop of svn pidl to regenerate the files : Index: lib/Parse/Pidl/Wireshark/NDR.pm =================================================================== --- lib/Parse/Pidl/Wireshark/NDR.pm (revision 22005) +++ lib/Parse/Pidl/Wireshark/NDR.pm (working copy) @@ -916,6 +916,14 @@ $res{headers} .= "#ifdef HAVE_CONFIG_H\n"; $res{headers} .= "#include \"config.h\"\n"; $res{headers} .= "#endif\n\n"; + + $res{headers} .= "#ifdef _MSC_VER\n"; + $res{headers} .= "#pragma warning(disable:4005)\n"; + $res{headers} .= "#pragma warning(disable:4013)\n"; + $res{headers} .= "#pragma warning(disable:4018)\n"; + $res{headers} .= "#pragma warning(disable:4101)\n"; + $res{headers} .= "#endif\n\n"; + $res{headers} .= "#include <glib.h>\n"; $res{headers} .= "#include <string.h>\n"; $res{headers} .= "#include <epan/packet.h>\n\n"; svn path=/trunk/; revision=21262
2007-03-29regenerate these dissectors using a patched pidl to add some extra pragmas ↵Ronnie Sahlberg1-0/+5
to keep ms compilers happy the pidl patch required : Index: lib/Parse/Pidl/Wireshark/NDR.pm =================================================================== --- lib/Parse/Pidl/Wireshark/NDR.pm (revision 22005) +++ lib/Parse/Pidl/Wireshark/NDR.pm (working copy) @@ -916,6 +916,14 @@ $res{headers} .= "#ifdef HAVE_CONFIG_H\n"; $res{headers} .= "#include \"config.h\"\n"; $res{headers} .= "#endif\n\n"; + + $res{headers} .= "#ifdef _MSC_VER\n"; + $res{headers} .= "#pragma warning(disable:4005)\n"; + $res{headers} .= "#pragma warning(disable:4013)\n"; + $res{headers} .= "#endif\n\n"; + + + $res{headers} .= "#include <glib.h>\n"; $res{headers} .= "#include <string.h>\n"; $res{headers} .= "#include <epan/packet.h>\n\n"; svn path=/trunk/; revision=21260
2007-03-29update winreg to the latest idlRonnie Sahlberg1-18/+221
svn path=/trunk/; revision=21256
2007-03-29regenerate winreg using the latest pidl. almost all warnings are now goneRonnie Sahlberg1-515/+531
svn path=/trunk/; revision=21255
2007-03-27as Gisle Vanem noted that MingW doesn't "like" the #pragmas:Ulf Lamping1-1/+1
change #ifdef _WIN32 -> #ifdef _MSC_VER around pragma warnings svn path=/trunk/; revision=21228
2007-03-27fix the remaining MSVC warnings by setting individual ↵Ulf Lamping1-0/+7
#pragma(warning:disable) settings - this is very certainly not the way to go, but the way to prevent additional warnings rushing in ... svn path=/trunk/; revision=21221
2007-03-04add dissection of the WINREG specific bits in the accessmask for WINREG objectsRonnie Sahlberg1-0/+8
svn path=/trunk/; revision=20968
2007-02-25add new PIDL friendly helpers for dissection of integer types.Ronnie Sahlberg1-57/+57
these new helpers take a parameter that can be used to decorate the tree and summary line (when this parameter is acted upon/implemented in the code inside the helpers) WINREG was regenerated using a patched version of PIDL. Mainline version of PIDL does not yet have this patch applied. svn path=/trunk/; revision=20918
2007-02-21regenerate WINREG as a test with the some new PIDL enhancements to show ithe ↵Ronnie Sahlberg1-73/+143
name of the iprocedure a policy handle was created in. also fix some mistakes in the conformance file for when handles are opened/created svn path=/trunk/; revision=20896
2007-02-20add a PIDL specific helper for managing dissection of policy handles.Ronnie Sahlberg1-28/+28
let this helper take a parameter to describe how the policy handle should be managed (is this an open, close ?) to improve policy handle tracking. (centralizing to a single function of code makes other changes easier) create defines to indicate OPEN/CLOSE and use them as a start/test in the winreg conformance file. svn path=/trunk/; revision=20872
2007-02-20changes to comments generated for winreg using the latest svn of pidlRonnie Sahlberg1-16/+24
pidl will probably be in flux for a short while and this checkin is to reduce the some noice generated to winreg while other changes are implemented. this change only affects c-code comments in the pidl generated code svn path=/trunk/; revision=20871
2007-02-19the policy handles created/opened in CreateKey and OpenKey are now called ↵Ronnie Sahlberg1-3/+3
"handle" and not "new_handle" update the conformance file so the correct functions are loaded with the correct PARAM value to signal "in this frame, this policy handle was created" svn path=/trunk/; revision=20857
2007-02-15using the latest SVN of PIDL it is now possible to compile the corrected ↵Ronnie Sahlberg1-25/+76
WINREG.IDL where QueryInfoKey responses are parsed correctly. (since we do not yet use all of the various idl files from s4 i commented out the import directove from the idl file since othervise it would generate #include directives for files we do not yet provide) svn path=/trunk/; revision=20816
2006-11-05testing out latest pidl where PARAM values can be used to track policy ↵Ronnie Sahlberg1-18/+24
handles properly winreg now tracks also where policy handles were closed which previously didnt work properly svn path=/trunk/; revision=19800
2006-09-24pidl has been updated to use WERR instead of DOS error tables.Ronnie Sahlberg1-36/+36
regenerate some dissectors svn path=/trunk/; revision=19311
2006-09-21winreg updates resync idl from s4Ronnie Sahlberg1-166/+256
svn path=/trunk/; revision=19276
2006-09-07 pidl now handles empty bitmaps properly so no need for the dummy (dont ↵Ronnie Sahlberg1-11/+2
trigger empty bitmapbug entry) svn path=/trunk/; revision=19170
2006-06-09some updates from new pidlRonnie Sahlberg1-443/+496
svn path=/trunk/; revision=18408