aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-dcerpc-samr.c
AgeCommit message (Collapse)AuthorFilesLines
2016-06-18DCE/RPC: fix array of pointers with NULLBinh Trinh1-5/+15
Change-Id: Ie89f8fd4ec744d427d41866206d5a6784c5b224f Reviewed-on: https://code.wireshark.org/review/16004 Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-16DCE/RPC proto_tree_add_boolean -> proto_tree_add_bitmask_valueMichael Mann1-38/+53
Change-Id: I88398aa1923e86bb83b97cc3904529a5810f6c40 Reviewed-on: https://code.wireshark.org/review/15978 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-16DCE/RPC proto_tree_add_boolean -> proto_tree_add_bitmask_with_flagsMichael Mann1-607/+114
Change-Id: I8891ec90244ffd9609d8443df631a7c8e6453b7e Reviewed-on: https://code.wireshark.org/review/15942 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-02Revert "PIDL: Remove _U_ and remove unused-parameter via pragma"Guy Harris1-1748/+1746
This reverts commit db4f7fcdeac833f24807994b372d1e42479754bf. That doesn't work with the compiler being used on the OS X buildbot; that compiler is probably some version of llvm-gcc, which might be based on an older version of GCC without support for that pragma, or might not support it properly courtesy of the GCC front end and the LLVM back end not quite fitting together Change-Id: I6cd5f1322b4872ef0c4eb5695f021cec00ba85b7 Reviewed-on: https://code.wireshark.org/review/15246 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-05-02PIDL: Remove _U_ and remove unused-parameter via pragmaAlexis La Goutte1-1746/+1748
Change-Id: Ic40f86850dc94338a8c2205e04679793f368672f Reviewed-on: https://code.wireshark.org/review/14967 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-29PIDL: regen pidl-generated dissectorsAurelien Aptel1-195/+67
mapi&nspi dissectors skipped on purpose since they the output is malformed. This was already the case before the samba sync. Change-Id: Ib3b78459e3506c755aaa219433ac6b5865482f01 Signed-off-by: Aurelien Aptel <aaptel@suse.com> Reviewed-on: https://code.wireshark.org/review/13968 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-01-24Add the packet number to the packet_info structure, and use it.Guy Harris1-1/+1
That removes most of the uses of the frame number field in the frame_data structure. Change-Id: Ie22e4533e87f8360d7c0a61ca6ffb796cc233f22 Reviewed-on: https://code.wireshark.org/review/13509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-06-23Remove deprecated tvb_length from PIDL dissectorsEvan Huus1-1/+1
Also regenerate all to pick up the usage of https in some comment links. Change-Id: Ic17b6368d2118627178b0b560031450d98e5b5e5 Reviewed-on: https://code.wireshark.org/review/9060 Reviewed-by: Evan Huus <eapache@gmail.com>
2015-03-03Eliminate e_uuid_t in favor of e_guid_t.Guy Harris1-1/+1
That eliminates a redundant and confusing data type, and avoids issues with one piece of code using e_uuid_t but wanting to use routines expecting an e_guid_t. Change-Id: I95e172d46d342ab40f6254300ecbd2a0530cde60 Reviewed-on: https://code.wireshark.org/review/7506 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-11-03Regenerate DCE RPC dissectors with the current pidl.Guy Harris1-1639/+1761
Change-Id: I3cfb9399a9e5ed783083fa5b26a39646fb53875f Reviewed-on: https://code.wireshark.org/review/5101 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-10-08Remove #pragma warning (MSVC) for PIDL generate dissectorAlexis La Goutte1-7/+0
Change-Id: I1e4c7944a2cd877f5c707703dcff44fe9f955a2c Reviewed-on: https://code.wireshark.org/review/4479 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-09-28PIDL: fix -Wmissing-prototypeAlexis La Goutte1-0/+2
Change-Id: I4cae47450e8026b10bd373828f235184560e0a99 Reviewed-on: https://code.wireshark.org/review/4308 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-27PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-5/+5
Change-Id: I7f6f974732b7905f4ea4686e1a79ca6fbef78fa8 Reviewed-on: https://code.wireshark.org/review/4319 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-09-27Regenerate PIDL dissectors with our current PIDL.Guy Harris1-1648/+1648
Change-Id: I63a1874d157c55df6c3c3f69c68098528adbb384 Reviewed-on: https://code.wireshark.org/review/4330 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-09-20proto_tree_add_text -> proto_tree_add_subtree[_format] for DCE/RPC dissectors.Michael Mann1-1695/+1687
Change-Id: I84755d059ef70ca98b0e7626b6425360daf0529d Reviewed-on: https://code.wireshark.org/review/4199 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-09-19Update generated DCE/RPC dissectors.Michael Mann1-1782/+1735
Now all generated dissectors can successfully compile. Change-Id: I74728926915d5a9f1694cc49c753b80f213df767 Reviewed-on: https://code.wireshark.org/review/2598 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-31Continue to remove $Id$ from top of fileAlexis La Goutte1-3/+1
(Using sed : sed -i '/^ \t$Id\$/,+0 d') (tab before $Id$) Also modify generator (NDR.pm) Change-Id: I348a1d129d1d1320bd80b428038ea5ed291d6ca8 Reviewed-on: https://code.wireshark.org/review/878 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-11-24Move dceprc_procedure_name from packet_info to dcerpc_info. Doesn't appear ↵Michael Mann1-136/+136
to be "used" by dissectors, just stored (for help in debugging?). svn path=/trunk/; revision=53552
2013-11-06Remove pinfo->private_data from DCERPC dissectors and instead have ↵Michael Mann1-3480/+3462
dcerpc_info* infomation be passed in as a function parameter. Bug 9387 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9387) All "generated" source was manually modified (with the power of search/replace), but I believe the "source input" files have been adjusted (checked into revs 53098 and 53099) to reflect the necessary changes (with possible whitespace formatting differences). The Microsoft compiler doesn't flag "unused function parameters", so I apologize in advance if I may have missed a few. The "dcerpc_info* di" parameter is used in almost every function. svn path=/trunk/; revision=53100
2013-10-21Sync with latest SAMBA PIDL source per ↵Michael Mann1-75/+74
http://www.wireshark.org/lists/wireshark-dev/201310/msg00217.html Didn't integrate 0010-frsrpc-Regenerate-frsrpc-due-to-changes-in-the-pidl-.patch 0016-Regenerate-the-dnserver.patch due to compilation errors on Windows. svn path=/trunk/; revision=52744
2013-10-01Remove check_col from generated DCE/RPC dissectors. Bug 8804 ↵Michael Mann1-68/+68
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8804). I still couldn't figure out how to generate the source, so I made the modifications to the generated dissectors "manually" (search/replace tool in VS) that would match the "PIDL source" included here. I will be sending the "PIDL source" (non dissector files) to the samba team. svn path=/trunk/; revision=52313
2013-03-02From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 :Pascal Quantin1-63/+63
Remove C++ incompatibilities from most of the dcerpc code svn path=/trunk/; revision=48023
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45017
2010-12-30The rids argument to samr_GetGroupsForUser() is *not* a single RID, it'sGuy Harris1-2/+5
an array of samr_RidWithAttributeArray structures. Don't equate it to hf_samr_rid; that causes hf_samr_rid to be added as an item with a length of -1, but, as hf_samr_rid is an FT_UINT32 field, that causes a dissector bug error. The version of Yapp I was using, at least, didn't like C++-style comments in the IDL file; replace them with C-style comments. svn path=/trunk/; revision=35304
2010-10-30Add an SVN Id to these PIDL-generated dissectors. A patch to PIDL will be ↵Jeff Morriss1-0/+2
sent upstream to the Samba developers. svn path=/trunk/; revision=34713
2009-12-19For fields of type FT_ABSOLUTE_TIME, have the "display" value be one ofGuy Harris1-23/+23
ABSOLUTE_TIME_LOCAL or ABSOLUTE_TIME_UTC, indicating whether to display the date/time in local time or UTC. (int)ABSOLUTE_TIME_LOCAL == (int)BASE_NONE, so there's no source or binary compatiblity issue, although we might want to eliminate BASE_NONE at some point and have the BASE_ values used with integral types start at 0, so that you can't specify BASE_NONE for an integral field. svn path=/trunk/; revision=31319
2009-10-09explicitely cast a guin64 to int to avoid compile warningsRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=30412
2009-10-07Reverting previous patch as requested by Ronnie.Anders Broman1-3/+2
svn path=/trunk/; revision=30390
2009-10-07Make the windows build compile again.Anders Broman1-2/+3
(Probably not the right fix). svn path=/trunk/; revision=30388
2009-10-07new samr compiled as a test by the samba4 pidl compiler from mainlineRonnie Sahlberg1-7/+2
svn path=/trunk/; revision=30383
2009-10-06more updates to samr to harmonize it with sambaRonnie Sahlberg1-230/+177
svn path=/trunk/; revision=30354
2009-10-04Atemt to fix compilation of samr for Windows.Anders Broman1-2/+7
svn path=/trunk/; revision=30294
2009-10-04more merges from samba samr idl fileRonnie Sahlberg1-486/+504
svn path=/trunk/; revision=30292
2009-10-04more merges from the samba samr idl fileRonnie Sahlberg1-11/+92
svn path=/trunk/; revision=30290
2009-10-04more samr updates for ndr64Ronnie Sahlberg1-129/+181
svn path=/trunk/; revision=30273
2009-10-04merge some changes to samr from the samba idlRonnie Sahlberg1-337/+812
svn path=/trunk/; revision=30272
2009-10-03rename dissect_ndr_4or8 to dissect_ndr_uint3264 to match hte name of Ronnie Sahlberg1-4/+4
the new datatype uint3264. create a fake guint3264 type as well svn path=/trunk/; revision=30264
2009-10-03add a helper that supports decoding either a 16 or 32 bit integer based Ronnie Sahlberg1-2/+2
on whether nrd or ndr64 is used. svn path=/trunk/; revision=30263
2009-10-03update the handmarshalled code in samr.cnf to handle ndr64 encodingRonnie Sahlberg1-5/+5
svn path=/trunk/; revision=30261
2009-10-03a new samr dissector, created using samba PIDL with ndr64 supportRonnie Sahlberg1-45/+45
svn path=/trunk/; revision=30259
2009-10-03update the alignment for UserInfo so it handles either NDR or NDR64.Ronnie Sahlberg1-1/+1
This should be done by PIDL once it gets updated. svn path=/trunk/; revision=30255
2009-07-28update samr.idl and remove a keyword we no longer support in pidlRonnie Sahlberg1-555/+555
regenerate samr and frstrans with the new version of pidl svn path=/trunk/; revision=29219
2009-07-28regenerate SAMR using the new version of pidlRonnie Sahlberg1-555/+555
svn path=/trunk/; revision=29215
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-555/+555
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2008-10-03samr enhancementsRonnie Sahlberg1-32/+48
svn path=/trunk/; revision=26342
2008-10-03SAMR updatesRonnie Sahlberg1-15/+18
svn path=/trunk/; revision=26340
2008-10-02samr updatesRonnie Sahlberg1-260/+369
svn path=/trunk/; revision=26335
2008-10-02enhancements to SAMRRonnie Sahlberg1-58/+136
svn path=/trunk/; revision=26332
2008-10-02update to SAMRRonnie Sahlberg1-1027/+2382
svn path=/trunk/; revision=26330
2007-10-02remove a test for null that we dont need since the variable can not be Ronnie Sahlberg1-3/+1
null at this point svn path=/trunk/; revision=23045