Age | Commit message (Collapse) | Author | Files | Lines |
|
Use explicit casts.
svn path=/trunk/; revision=48313
|
|
svn path=/trunk/; revision=45017
|
|
Rename header_fields[] tp hf[] as per convention;
Reformat hf[] entries;
Remove empty proto_reg_handoff...().
svn path=/trunk/; revision=43670
|
|
svn path=/trunk/; revision=43538
|
|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6967
svn path=/trunk/; revision=41645
|
|
The attached patches fix the following issues:
1. CIP-Motion shouldn't be a heuristic dissector. CIP-Motion packets are
determined by specific fields in a CIP ForwardOpen. I ran into situations
where CIP-Motion's "vague" heuristics incorrectly dissected packets meant for
CIP-Safety. Of course this requires the ForwardOpen to be in the trace, but it
is the most deterministic way to have CIP-Motion packets.
2. Minor bugfix to the CIP-Safety dissector. A couple of fields were
"missing", causing errant malformed packets.
svn path=/trunk/; revision=41283
|
|
CIP Motion parsing of set axis attribute list request is messing up attr data
parsing a CIP Motion 'Set Axis Attribute List' Request returns correct data for attribute ID, dimension and element size but 'attribute data' field retrieves the same data for each attribute in the list rather than the real data sent in the request.
From me :
Fix the typo error (use the wrong offset variable, need to use local_offset variable)
svn path=/trunk/; revision=41257
|
|
svn path=/trunk/; revision=40373
|
|
Improved CIP and ENIP dissectors
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6416
svn path=/trunk/; revision=39595
|
|
Also: remove trailing whitespace for a number of files.
svn path=/trunk/; revision=39503
|
|
'inst_count' may be used uninitialized in this function.
svn path=/trunk/; revision=39400
|
|
svn path=/trunk/; revision=39399
|
|
svn path=/trunk/; revision=39398
|
|
svn path=/trunk/; revision=39397
|
|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5929
From me:
packet-cipmotion.c:
FT_BOOLEAN fields with bitmasks need a bit-fieldwidth in the hf[] entry 'display' field;
Define attribute_size as guint32 since it has to store guint8*guint16;
Use ENC_NA as encoding arg in proto_tree_add_item() for FT_BYTES field types;
Remove trailing whitespace from lines;
Other minor cleanup and reformatting.
packet-enip.c:
Use ENC_NA as encoding arg in proto_tree_add_item() for FT_BYTES field types;
svn path=/trunk/; revision=39396
|