aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-btle.c
AgeCommit message (Collapse)AuthorFilesLines
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-05-30btle: Correctly detect l2cap fragment startJonas Jonsson1-3/+3
The first L2CAP PDU fragment starts with the 4 octet long L2CAP header consisting of the Length and the CID fields. The Length field doesn't include the header itself. Thus the Length field in the BLE Data header will be 4 octets larger than the L2CAP PDU header Length field if the packet wouldn't be fragmented. The current implementation doesn't correctly detect the start fragment causing reassembly to fail as it compares the BLE Data Length with the L2CAP Length without compensating for the header. By increasing the L2CAP PDU Length field with the header length the reassembly works. Rename the variable to better reflect what length it actually represents. Bug: 15807 Change-Id: Idcb6bdccc4daae756a63a9bae0839fe25ae99f23 Reviewed-on: https://code.wireshark.org/review/33428 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-04-04epan: Convert our PROTO_ITEM_ macros to inline functions.Gerald Combs1-5/+5
Convert our various PROTO_ITEM_ macros to inline functions and document them. Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c Reviewed-on: https://code.wireshark.org/review/32706 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-01-31btle: Add Version 5.1 to ll_version_number_valsStig Bjørlykke1-0/+1
Change-Id: I777dcaa6bd7f161ecbdc7411c3f816480c76834d Reviewed-on: https://code.wireshark.org/review/31827 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-12-27Try to squeeze some bytes out of the frame_data structure.Guy Harris1-10/+10
Make the time stamp precision a 4-bit bitfield, so, when combined with the other bitfields, we have 32 bits. That means we put the flags at the same structure level as the time stamp precision, so they can be combined; that gets rid of an extra "flags." for references to the flags. Put the two pointers next to each other, and after a multiple of 8 bytes worth of other fields, so that there's no padding before or between them. It's still not down to 64 bytes, which is the next lower power of 2, so there's more work to do. Change-Id: I6f3e9d9f6f48137bbee8f100c152d2c42adb8fbe Reviewed-on: https://code.wireshark.org/review/31213 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-05-02btle: Show correct LLData Timeout valueStig Bjørlykke1-1/+1
The spec states that connSupervisionTimeout = Timeout * 10 ms Change-Id: I89494c74d80b63c85f001540ea79850736457b21 Reviewed-on: https://code.wireshark.org/review/27255 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-09Generalize wtap_pkthdr into a structure for packet and non-packet records.Guy Harris1-2/+2
Separate the stuff that any record could have from the stuff that only particular record types have; put the latter into a union, and put all that into a wtap_rec structure. Add some record-type checks as necessary. Change-Id: Id6b3486858f826fce4b096c59231f463e44bfaa2 Reviewed-on: https://code.wireshark.org/review/25696 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-01-06bluetooth: Group Bluetooth dissector preferencesStig Bjørlykke1-1/+1
Change-Id: Ib5360fcbfd8f6b2aee6b33ec7d9dc77362feb50e Reviewed-on: https://code.wireshark.org/review/25162 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-10-02btle: Add preference to detect retransmissionStig Bjørlykke1-20/+31
In cases with missing frames, frames with incorrect CRC or unknown direction it must be possible to turn off detecting retransmissions. Change-Id: Ia5a1194004f768986b939b4195a21c6e7a2ac4c8 Reviewed-on: https://code.wireshark.org/review/23803 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-29btle: Don't ignore frames with incorrect CRC when detecting retransmission.Stig Bjørlykke1-3/+3
The retrans detection using SN must use all available frames to make a best effort. The probability for having error in the SN bit is little compared to reassembly errors occuring when discarding frames with incorrect CRC. Change-Id: I40f89e69b19600939b6e0a85a2e655b6681ea5b2 Reviewed-on: https://code.wireshark.org/review/23783 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-29btle: Improve retransmit detectionStig Bjørlykke1-11/+5
Only use SN to detect retransmission. Lower retransmit expert info severity to Note. Change-Id: I4604903cce9cc58a6fcffff6597e7e99d228aa80 Reviewed-on: https://code.wireshark.org/review/23780 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-09-29btle: Ignore retransmitted frames in reassemblyStig Bjørlykke1-57/+48
Change NESN/SN check to detect retransmit pr. connection. Frames with same SN in one direction is retransmit. Ignore retransmit frames when doing reassembly (btle and l2cap). Also ignore frames with incorrect CRC when doing reassembly. This fix is related to g95e09a60. Change-Id: I6386b42758ec3abada07ec1964d3e1b7ba7400e4 Reviewed-on: https://code.wireshark.org/review/23771 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-19btle: Use bd_addr as link-layer address in data PDUStig Bjørlykke1-2/+6
This can be used in a higher layer 6LoWPAN to recreate the source and destination addresses. Change-Id: I967c3ac7c3a50526a10bec067521419d0aed8b4f Reviewed-on: https://code.wireshark.org/review/23616 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-09-15btle: Add Bluetooth 5.0 LL Control PDUsStig Bjørlykke1-31/+269
* Dissect LL_PHY_REQ, LL_PHY_RSP, LL_PHY_UPDATE_IND and LL_MIN_USED_CHANNELS_IND. * Add Control Feature Set values. * Change Advertising Header Length from 6 bits to 8 bits (and removed RFU). * Change Data Header Length from 5 bits to 8 bits (and removed RFU). Change-Id: I453583fbb8c36dc87642c3c5087ab6dd77c46e45 Reviewed-on: https://code.wireshark.org/review/23536 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-08-31btle: Add Channel Selection AlgorithmStig Bjørlykke1-3/+17
Change-Id: I4d215bfb991ecf057ee9f6dda346b2fe6cee0bad Reviewed-on: https://code.wireshark.org/review/23324 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-08-31btle: Add Version 5.0 to ll_version_number_valsStig Bjørlykke1-1/+2
Change-Id: I427da1f56a69785b70e965e08696fa24b114bb9c Reviewed-on: https://code.wireshark.org/review/23323 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-08-23BTLE: fix bitmap for link data Hop / Sleep Clock AccuracyPhil Beeson1-3/+3
Bug: 13990 Change-Id: I4d5acaf580adbe2c5bff1aac3d2837a8842cd519 Reviewed-on: https://code.wireshark.org/review/23172 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-07-04btle: Add item for the generated l2cap indexStig Bjørlykke1-17/+67
Also detect "Missing Fragment Start" packet. Change-Id: I4ec300ae5dd9e79bd4c27f84e7235e03eeb3c89c Reviewed-on: https://code.wireshark.org/review/22498 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-30btle: Improve reassembly when missing packetsStig Bjørlykke1-18/+32
Create a unique reassembly id to improve reassembly when having missing btle packets. Change-Id: I0d8e4c6b4fea9ba5eb98a88b0573b541cfee59af Reviewed-on: https://code.wireshark.org/review/22477 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2017-06-30btle: Support reassembly in both directionsStig Bjørlykke1-6/+40
Create one connection_info_tree for each direction to support reassembly in both directions simultaneously. Change-Id: If83e8705412062b07f3fa47a73f42db8c7895e78 Reviewed-on: https://code.wireshark.org/review/22476 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-29btle: Reorder elements in Packet Header and Data HeaderStig Bjørlykke1-10/+10
This shows the elements in a little-endian fashion and aligns with other element trees using bitmask. Change-Id: I8e16eaee9944c2b56bc9fe18f31a983047aca121 Reviewed-on: https://code.wireshark.org/review/22453 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-05-17Use proto_tree_add_item instead of proto_tree_add_xxx.Michael Mann1-10/+13
It's a little more efficient to use proto_tree_add_item, than proto_tree_add_xxx, passing it the returned tvb_get_xxx value. Change-Id: I22ddd7ab36e1ee5aae78fc693d7dbac4b4f802f2 Reviewed-on: https://code.wireshark.org/review/21691 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-14BT LE LL: fix invalid memory access reported by valgrindPascal Quantin1-3/+3
- broadcast_addr shoudl be static and not on call stack - set the AT_STRINGZ address length with the string length and not the buffer length Bug: 13381 Change-Id: I86e15ccaa9b5d7779c266ab24b637476e983664c Reviewed-on: https://code.wireshark.org/review/20103 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-02-03BTLE: check connection_info presence before trying to perform reassemblyPascal Quantin1-48/+52
Bug: 13379 Change-Id: Idafa780f24bf9f181c0913cbe16a0cfa9bce382e Reviewed-on: https://code.wireshark.org/review/19927 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-01packet-btle.c: If frame information is missing, provide a default.Michael Mann1-1/+4
"default" frame information sets no retransmission or more fragments. Bug: 13015 Change-Id: I1c8a29fe06d0b38abc789c8e454dc484490186f9 Reviewed-on: https://code.wireshark.org/review/19891 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-29Register reassembly tablesMichael Mann1-15/+2
Register all reassembly tables with a central unit, allowing the central unit to have the callback that initializes and destroys the reassembly tables, rather than have dissectors do it individually. Change-Id: Ic92619c06fb5ba6f1c3012f613cae14982e101d4 Reviewed-on: https://code.wireshark.org/review/19834 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-20btle: Add a convenience btle.length fieldStig Bjørlykke1-0/+10
Add a convenience btle.length field for easier filtering of BTLE packets without data and with specific length ranges. Change-Id: If56eac9c86ccf40741a6ceb50d13a1733132f448 Reviewed-on: https://code.wireshark.org/review/19348 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.tomasz.labedzki@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-12-16Remove proto_item_append_text calls in favor of BASE_UNIT_STRING.Michael Mann1-6/+4
Many proto_item_append_text calls were just adding a unit string to a field. There's a better way to do that now. Change-Id: Id18d5ac1ea4d8ecdc4cbe7ebaec07fbd2eab6e78 Reviewed-on: https://code.wireshark.org/review/19289 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-09-26btle: Fix Feature support bit positionsStig Bjørlykke1-8/+8
From BT spec 4.2 volume 6 part B section 4.6, Feature support. Bug: 12946 Change-Id: I065e9bc9af88bb1daf53d26ae683d7ddedbb8ebf Reviewed-on: https://code.wireshark.org/review/17911 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-09-25btle: Show full LL_VERSION_IND SubVersNrStig Bjørlykke1-1/+1
The BT spec does not specify a bitmask for Subversion Number. Change-Id: If6f384badc4228ea1e1c30ec8156f382ca5959e0 Reviewed-on: https://code.wireshark.org/review/17936 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-09-25btle: Add LL_LENGTH_REQ/RSP control dataStig Bjørlykke1-0/+43
Change-Id: Ib09232a25c70fc319b1df90dc09a89a34cf59c3e Reviewed-on: https://code.wireshark.org/review/17932 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-08-17Show millisecond values as both raw and "(N msec)".Guy Harris1-4/+13
Do as we do with other Bluetooth fields that, when multiplied by 1.25, give time amounts in milliseconds. Change-Id: I89c599e68f91c134b216c495dabdbf77db10def3 Reviewed-on: https://code.wireshark.org/review/17099 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-08-11btle: Improved packet header displayStig Bjørlykke1-10/+17
Show elements in correct order. Show TxAdd and RxAdd values as "Random" or "Public". Change-Id: Ie75716d05d2aadf3d573a9dc078f32e6f981a691 Reviewed-on: https://code.wireshark.org/review/17012 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-11btle: No expert info for correct CRCStig Bjørlykke1-5/+0
We don't usually use expert info when checksum is correct. Change-Id: Ifc0e020ea86d69330df8cdb625672fbc9b4269ae Reviewed-on: https://code.wireshark.org/review/17013 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-09btle: Renamed Message fragments to L2CAP fragmentsStig Bjørlykke1-13/+13
The already used terminology is L2CAP fragments. Change-Id: I900f5fed479e53c3a23154caa3b8a569c58dbb20 Reviewed-on: https://code.wireshark.org/review/16984 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-08[BTLE] Dissect LE Information frame.AndersBroman1-14/+2
Change-Id: Id4411526eef895fc0130108457866892216d5b03 Reviewed-on: https://code.wireshark.org/review/16958 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-08[BTLE] Implement reassembly of BTLE messages.AndersBroman1-31/+277
Change-Id: I93eb7dbc834ffc9bf74faf98a13b58a73bf4ae99 Reviewed-on: https://code.wireshark.org/review/16901 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-02[BTLE] Change address from unknown_0x... to master or slave.AndersBroman1-5/+26
Change-Id: I571a2f6f96c37e608201092e7ea7f53862b8d2ad Reviewed-on: https://code.wireshark.org/review/16844 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-02[BLE] Make the Nordic BLE dissector fill in the btle_context_t struct.AndersBroman1-1/+3
Change-Id: I14e62126d022dde10dcce2d7e974def0dc664b20 Reviewed-on: https://code.wireshark.org/review/16840 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-28[BTLE] Add Version 4.2 to ll_version_number_valsAndersBroman1-2/+3
Change-Id: I88e988e11e1cae6f2f6f6d190890b62f2beb1e92 Reviewed-on: https://code.wireshark.org/review/16745 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-27[BTLE] Add new Link layer Feature flags.AndersBroman1-5/+19
Change-Id: Ib646d90c6e44075e7ae67f2022dc633fe6423c20 Reviewed-on: https://code.wireshark.org/review/16724 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-27[BTLE] Use the correct struct.AndersBroman1-8/+8
Change-Id: I5b26e97a6b1a0724f4290084418cdd43661ff8d0 Reviewed-on: https://code.wireshark.org/review/16701 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-04-02Bluetooth: Fix conflicting address fieldsMichal Labedzki1-2/+3
For Broadcast address use FT_ETHER with FF:FF:FF:FF:FF:FF address instead of string address "Broadcast". Change-Id: I638d3d6a1baa9c965dd0a9f548cedbd81af3ec5b Reviewed-on: https://code.wireshark.org/review/14767 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-03-20Manually add protocol dependencies derived from find_dissector.Michael Mann1-3/+3
Started by grepping call_dissector_with_data, call_dissector_only and call_dissector and traced the handles passed into them to a find_dissector within the dissector. Then replaced find_dissector with find_dissector_add_dependency and added the protocol id from the dissector. "data" dissector was not considered to be a dependency. Change-Id: I15d0d77301306587ef8e7af5876e74231816890d Reviewed-on: https://code.wireshark.org/review/14509 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-06Bluetooth: BTLE: Fix Random Rx/Tx BdAddr bit presentationMichal Labedzki1-3/+3
Random Rx/Tx bit are properly decoded but incorrect present in parent tree. Change-Id: I4c31d8e77b1adb5f821da6074bde5dff400d6c04 Reviewed-on: https://code.wireshark.org/review/13738 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-02-05Fix some Coverity issueMichal Labedzki1-3/+3
>>> CID 1349726: Incorrect expression (COPY_PASTE_ERROR) >>> "tvb_reported_length_remaining" in "tvb_reported_length_remaining(tvb, offset)" looks like a copy-paste error. >>> CID 1349727: Incorrect expression (COPY_PASTE_ERROR) >>> "tree" in "dissector_try_uint_new(bluetooth_eir_ad_manufacturer_company_id, company_id, new_tvb, pinfo, >>> CID 1349728: (DEADCODE) >>> Execution cannot reach this expression "0" inside statement "(0 && ((__s1_len = __builti...". >>> CID 1306904: Logically dead code (DEADCODE) >>> Execution cannot reach this statement "tap_hci_summary->interface_...". Change-Id: I5f99e37e6d5fac39da7082649caa8373d06bb808 Reviewed-on: https://code.wireshark.org/review/13739 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-25Move the proto data stuff out of frame_data.[ch].Guy Harris1-0/+2
It's not tied to the frame_data structure any more, so it belongs by itself. Clean up some #includes while we're at it; in particular, frame_data.h doesn't use anything related to tvbuffs, so don't have it gratuitiously include tvbuff.h. Change-Id: Ic32922d4a3840bac47007c5d4c546b8842245e0c Reviewed-on: https://code.wireshark.org/review/13518 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-24Add the packet number to the packet_info structure, and use it.Guy Harris1-2/+2
That removes most of the uses of the frame number field in the frame_data structure. Change-Id: Ie22e4533e87f8360d7c0a61ca6ffb796cc233f22 Reviewed-on: https://code.wireshark.org/review/13509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-1/+1
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>