aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-bthci_vendor.c
AgeCommit message (Collapse)AuthorFilesLines
2024-07-26For literal strings, prefer col_set_str() to col_add_fstr()Martin Mathieson1-4/+4
2024-07-17epan: convert dissectors B to C99 types (rerun script)Joakim Karlsson1-18/+18
Ping #19116
2024-07-16first pass, before fixing CSB -> CPB more thoroughlyJustin Case1-6/+6
2024-07-04epan: convert dissectors A-B to C99 typesJoakim Karlsson1-45/+45
Ping #19116
2024-02-07Fix some more spelling errorsMartin Mathieson1-1/+1
2024-01-31Fix more spellings - mostly commentsMartin Mathieson1-1/+1
2024-01-25Fix more FT_BOOLEAN items with no mask - set len to BASE_NONEMartin Mathieson1-2/+2
2024-01-25bthci_vendor: Add broadcom read mem and refactor writememAntonio Vázquez Blanco1-16/+32
2023-11-20Remove init of proto variablesStig Bjørlykke1-179/+179
Remove init of proto, header field, expert info and subtree variables. This will reduces the binary size by approximate 1266320 bytes due to using .bss to zero-initialize the fields. The conversion is done using the tools/convert-proto-init.py script.
2023-06-02Fix some filters not matching labelsMartin Mathieson1-2/+2
2023-05-29label-vs filter checking: Only report dissector appears to be written that wayMartin Mathieson1-1/+1
2023-04-21Add tools/check_val_to_str.py and fix some of the errorsMartin Mathieson1-3/+3
2023-02-12Try to check that all items in bitmask set have same widthMartin Mathieson1-12/+12
2021-07-21First pass pinfo->pool conversion, part 2Evan Huus1-6/+6
Automated find/replace of wmem_packet_scope() with pinfo->pool in all files where it didn't cause a build failure.
2020-08-30More spelling fixes, start of second pass of dissectors.Martin Mathieson1-13/+13
Now easier to find errors due to script improvements and more complete dictionary file.
2020-06-19Fix the type of arrays of pointers to hf_ values for bitfield routines.Guy Harris1-3/+3
The static arrays are supposed to be arrays of const pointers to int, not arrays of non-const pointers to const int. Fixing that means some bugs (scribbling on what's *supposed* to be a const array) will be caught (see packet-ieee80211-radiotap.c for examples, the first of which inspired this change and the second of which was discovered while testing compiles with this change), and removes the need for some annoying casts. Also make some of those arrays static while we're at it. Update documentation and dissector-generator tools. Change-Id: I789da5fc60aadc15797cefecfd9a9fbe9a130ccc Reviewed-on: https://code.wireshark.org/review/37517 Petri-Dish: Guy Harris <gharris@sonic.net> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-12-27Try to squeeze some bytes out of the frame_data structure.Guy Harris1-1/+1
Make the time stamp precision a 4-bit bitfield, so, when combined with the other bitfields, we have 32 bits. That means we put the flags at the same structure level as the time stamp precision, so they can be combined; that gets rid of an extra "flags." for references to the flags. Put the two pointers next to each other, and after a multiple of 8 bytes worth of other fields, so that there's no padding before or between them. It's still not down to 64 bytes, which is the next lower power of 2, so there's more work to do. Change-Id: I6f3e9d9f6f48137bbee8f100c152d2c42adb8fbe Reviewed-on: https://code.wireshark.org/review/31213 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2018-04-16Forbid leading, duplicated and trailing dots in field namesPeter Wu1-1/+1
In order to simplify the display filter scanner, try to restrict the use of dots ('.') in field names. Forbid leading dots, does not affect current dissectors. Fix '..' typo in fpp dissector and forbid it. Forbid trailing dots after fixing dissectors: some of them just have an excess dot, others are missing a name after the dot. Change-Id: I6e58a04ef0306ee8c16fbf6a3cabb076d7fc69c9 Reviewed-on: https://code.wireshark.org/review/26967 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-04-03Use col_append_str() for fixed stringsStig Bjørlykke1-2/+2
Change from col_append_fstr() to col_append_str() when appending strings without formatting. Change-Id: I8975704c246f2b9a1301ed5f96273aa9d61c6f44 Reviewed-on: https://code.wireshark.org/review/20857 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-29Bluetooth: fix conflicting entries in its value_string.Michael Mann1-1/+1
Change-Id: Ie0f9bc800b5d86effa18a8ae333bbf8da18d0c3b Reviewed-on: https://code.wireshark.org/review/20775 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michal Labedzki <michal.tomasz.labedzki@gmail.com>
2016-09-13Bluetooth: HCI vendor: Add support for some Intel commands/eventsMichal Labedzki1-426/+1783
This change based on BlueZ code on the same license that Wireshark is. It seems that a lot of commands/events are incomplete or unknown, however better to have them. Also rename variables (etc.) of the first dissector to contain vendor name like new one, to distinguish them. Change-Id: I2db3ed73d477699032a44bac2d3c88a9230b0095 Reviewed-on: https://code.wireshark.org/review/17657 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-07-21Constify a few value_strings which were generated at run-timeBalint Reczey1-51/+36
Change-Id: Idc479a89a34fd21b743faee07020be284f828e2c Reviewed-on: https://code.wireshark.org/review/16298 Petri-Dish: Balint Reczey <balint@balintreczey.hu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2016-06-23bthci: add missing break (CID 1362832)Dario Lombardo1-0/+1
Change-Id: I705cb17d7c6d615361d29f00ba840a94dc835ff0 Reviewed-on: https://code.wireshark.org/review/16090 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-06-21bthci: Show unknown ocf as undecodedStig Bjørlykke1-1/+6
Don't show unknown ocf values as unexpected parameters. Change-Id: I08a6c8c20d6382a847f0a2969e4c523a2873dd6f Reviewed-on: https://code.wireshark.org/review/16048 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-03-20Manually add protocol dependencies derived from find_dissector.Michael Mann1-1/+1
Started by grepping call_dissector_with_data, call_dissector_only and call_dissector and traced the handles passed into them to a find_dissector within the dissector. Then replaced find_dissector with find_dissector_add_dependency and added the protocol id from the dissector. "data" dissector was not considered to be a dependency. Change-Id: I15d0d77301306587ef8e7af5876e74231816890d Reviewed-on: https://code.wireshark.org/review/14509 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-24Add the packet number to the packet_info structure, and use it.Guy Harris1-1/+1
That removes most of the uses of the frame number field in the frame_data structure. Change-Id: Ie22e4533e87f8360d7c0a61ca6ffb796cc233f22 Reviewed-on: https://code.wireshark.org/review/13509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-1/+1
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-20Bluetooth: HCI vendor: Add some Broadcom commandsMichal Labedzki1-8/+96
Add some Broadcom commands found in BlueZ. Change-Id: I6b5c6ca2a55142550c2e901443d548a5a686bc90 Reviewed-on: https://code.wireshark.org/review/11981 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-10-17Bluetooth: Fix expert info for undecoded dataMichal Labedzki1-1/+1
Swap PI_* values avoid crashes (assert...) of expert info. Change-Id: I5f5188c9358a4ac93565fc079a3a0e8ea4b7f965 Reviewed-on: https://code.wireshark.org/review/11019 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-07-17Qt/Bluetooth: Add HCI Summary dialogueMichal Labedzki1-1/+68
HCI Summary dialogue collect HCI Opcodes, HCI Events, Hardware Errors, Statuses and Reasons. Also show occurrence of them. The top level item is group of items (by OGF or types), the second level item is in real command, event, hardware error, status or reason. The third level items are direct link to packet that contains second level item type. Change-Id: I6b6bd02533c4605a2dd2c1f5dfee46f72a0f3fdc Reviewed-on: https://code.wireshark.org/review/9676 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-06-19Bluetooth: Coverity fixesMichal Labedzki1-4/+13
Try to fix Coverity issues in Bluetooth HCI and androiddump. Change-Id: Id2ed35130eb4dbb0698b7a54afccdba56af62bfd Reviewed-on: https://code.wireshark.org/review/8983 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-06-18Bluetooth: ensure to give bluetooth_data structure to dissect_eir_ad_data()Pascal Quantin1-1/+1
Bug: 11285 Change-Id: I1d3a4900fe3daec6f8d7596a9925322063f2c4eb Reviewed-on: https://code.wireshark.org/review/8976 Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-06-15Qt/Bluetooth: Add Devices dialogueMichal Labedzki1-4/+4
Please found it under Bluetooth menu. It shows all devices found in logs, not only connected, all that its address can be found in logs. Show if device is local (in most cases: capturing on it side) and manufacturer and LMP version what should answer the question what version of Bluetooth is used by Bluetooth device chip. Also firmware version. Change-Id: I32e3b7100cdebcaa850b6541de0ab89dff41c0e1 Reviewed-on: https://code.wireshark.org/review/8901 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Tested-by: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-05-18Bluetooth: HCI: Add command-event trackingMichal Labedzki1-1/+3
HCI Commands in most cases generate response in Event queue, so try to map event to command and give user response time information. Change-Id: Ib4956829b7d0064ab528aa3202f8f959d8d371b7 Reviewed-on: https://code.wireshark.org/review/8514 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-02-02Bluetooth: Simplify to "UnknownDirection" in Info column when direction is ↵Michal Labedzki1-2/+1
unknown Change-Id: Ibad679c0b6c95d65389ce087f65b8f31cf3acd68 Reviewed-on: https://code.wireshark.org/review/6903 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-02-02Bluetooth: HCI Vendor: Fix for "Enable WBS" commandMichal Labedzki1-3/+6
Codec value for mSBC is 0x02 (not 0x01), also "Codec" field does not appear when Codec state in Disable. Change-Id: I4f0b27d0dc8659fdc054eaf18b54a42aad60275b Reviewed-on: https://code.wireshark.org/review/6899 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-01-10Bluetooth: HCI: Detect Vendor by "Read Local Version Information"Michal Labedzki1-3/+2
There is information about manufacturer of Bluetooth chip. Also try to detect if that "permament" info is not changed, if so informs user about this rare event (probably there is an issue) Change-Id: I1fa748a67ad7943e61d4445d240f0578b94560fc Reviewed-on: https://code.wireshark.org/review/6408 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-01-10Bluetooth: SMP: Add missing opcode for "Identity Address Information"Michal Labedzki1-8/+2
Also fix tvb_length, tvb_length_remaining warnings. Bug: 10299 Change-Id: Ib8b55ea9f2220394a5896d13e5cc4e2cefff1e13 Reviewed-on: https://code.wireshark.org/review/6407 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-01-10Bluetooth: Add HCI Vendor Broadcom dissectorMichal Labedzki1-0/+1418
Since those command/events are vendor specific and proprietary not all commands/events are implemented. All implemented commands can be found in Open Source implementations for Broadcom chip. If you found more, please let me know. Change-Id: Ie68d3737c88a8cef39260a9d93192cfc81871d6c Reviewed-on: https://code.wireshark.org/review/6406 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>