aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-bssgp.c
AgeCommit message (Collapse)AuthorFilesLines
2016-01-08Fix a lot of typos and misspellingsmoshekaplan1-2/+2
Change-Id: I8512cfa1d424f82a873a0e0e1d22c7b075fdd7f3 Reviewed-on: https://code.wireshark.org/review/13069 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-1/+1
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-23register_dissector -> new_register_dissectorMichael Mann1-4/+5
Change-Id: Ic368dd8e83cf39e0c934da0ae2744778e2d54ce6 Reviewed-on: https://code.wireshark.org/review/12050 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-02Eliminate proto_tree_add_text from some dissectors.Michael Mann1-32/+84
Change-Id: If617016f588bbf940f37699e27559dc5c59cf508 Reviewed-on: https://code.wireshark.org/review/10349 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-08-16Conversion of random proto_tree_add_text calls.Michael Mann1-37/+62
Change-Id: I6505ce34de84bfe46d5bc7b4d6a3c6044f3fb4b5 Reviewed-on: https://code.wireshark.org/review/10041 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-30BSSGP: ensure that all Optional / Conditional Information Elements are ↵Pascal Quantin1-9/+9
treated as such Bug: 10903 Change-Id: I8f6b970a6988fd4e700203304586c8e53dd5696b Reviewed-on: https://code.wireshark.org/review/6845 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-01-12[E212] Make it possible to use different filters for MCC and MNC in LAIAndersBroman1-1/+1
RAI and SAI. Change-Id: I2abcc868899b8752f66347b3a0fe190670c3ce3f Reviewed-on: https://code.wireshark.org/review/6447 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-02Replace proto_tree_add_text in dissector header files where it was used in a ↵Michael Mann1-238/+239
macro that should be expert info. Change-Id: I045368a0a91586231fc4b1e2700c2275088b76af Reviewed-on: https://code.wireshark.org/review/6244 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-2/+1
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-11-20Replace tvb_length...() calls.AndersBroman1-1/+1
Change-Id: Idda7cd56a12b36d18774a1fe324c69eb8f5e4330 Reviewed-on: https://code.wireshark.org/review/5412 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-06Adjust some whitespace to match editor modelines.Bill Meier1-167/+167
Change-Id: Ia22cac3ebd7a454c156f98d967e6fd61f708a2b3 Reviewed-on: https://code.wireshark.org/review/4489 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-29Add editor modelines and adjust indentation as needed.Bill Meier1-0/+13
Change-Id: Id57d264299f2026d703c5b08bace4b24b32f184c Reviewed-on: https://code.wireshark.org/review/4371 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-06-22convert to proto_tree_add_subtree[_format]Michael Mann1-26/+22
Change-Id: Ib60ca75b7da8cfa21cfe2999c9b9448a02c332df Reviewed-on: https://code.wireshark.org/review/2560 Tested-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-1/+1
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-1/+1
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-4/+4
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-10-23#if 0 numerous "unused const variables" (mostly value-string-arrays);Bill Meier1-0/+2
Also; fix a few "set but not used" warnings. svn path=/trunk/; revision=52780
2013-10-13whitespace fixes; mostly: remove trailing blanksBill Meier1-3/+3
svn path=/trunk/; revision=52591
2013-09-23Add dissection of new IEs in UL_UNITDATAAnders Broman1-2/+31
svn path=/trunk/; revision=52191
2013-09-17From Jason Wzhy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9157 :Pascal Quantin1-1/+1
BSSGP: Fix dissection of Trace Type IE in SGSN-INVOKE-TRACE message svn path=/trunk/; revision=52131
2013-09-03Batch of filterable expert info.Michael Mann1-67/+78
svn path=/trunk/; revision=51689
2013-05-03Remove static packet_info *gpinfo and just use the packet_info provided by ↵Michael Mann1-33/+31
the function. svn path=/trunk/; revision=49145
2013-04-07Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=48781
2013-04-04From Lukasz Wachowski via ↵Pascal Quantin1-1/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8559 : Fix dissection of RAN-INFORMATION-APPLICATION-ERROR RIM PDU Indications svn path=/trunk/; revision=48726
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-1/+1
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-24Do not initialize ett_tree and msg_fcn_p when match_strval_idx_ext does not ↵Pascal Quantin1-2/+4
find a match svn path=/trunk/; revision=48538
2013-03-18As suggested by Evan Huus, use extended value_stringsPascal Quantin1-1/+2
svn path=/trunk/; revision=48407
2013-03-18use enum values instead of hardcoded valuesPascal Quantin1-153/+153
(as suggested by Sylvain Munaut in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8487) svn path=/trunk/; revision=48397
2013-03-15[-Wmissing-prototypes]Anders Broman1-1/+5
Use explicit casts. svn path=/trunk/; revision=48313
2013-03-05fixMartin Kaiser1-10/+2
packet-bssgp.c: In function 'de_bssgp_unconfim_send_state_var': packet-bssgp.c:3318:13: error: variable 'state_var' set but not used [-Werror=unused-but-set-variable] svn path=/trunk/; revision=48095
2013-03-05From Joseph Chai:Anders Broman1-8/+147
Add aditional IE dissection. From me patch cleanup and add set fence for multiple DTAP messages in one frame. svn path=/trunk/; revision=48087
2013-02-11Fix bit_offset.Anders Broman1-4/+4
svn path=/trunk/; revision=47637
2013-01-22Try to fix dissection of GSM protocol family broken by r47209.Pascal Quantin1-58/+58
Using val_to_str seemed to be a good idea, but most value_string arrays were not properly filled or were using hacks. (I hope I got everything right...) svn path=/trunk/; revision=47218
2012-11-25Fix several [-Wshadow] warnings;Bill Meier1-14/+14
Also: Do some minor whitespace and formatting changes. -This line, and those below, will be ignored-- M dissectors/packet-bootp.c M dissectors/packet-bssgp.c M dissectors/packet-babel.c svn path=/trunk/; revision=46191
2012-11-21fixMartin Kaiser1-1/+1
/home/wireshark/builders/trunk/ubuntu1204x64/build/epan/dissectors/packet-bssgp.c: In function de_bssgp_son_transfer_app_id: /home/wireshark/builders/trunk/ubuntu1204x64/build/epan/dissectors/packet-bssgp.c:3173:12: error: variable next_tvb set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors svn path=/trunk/; revision=46125
2012-11-21Clean up white space (no tabs).Guy Harris1-3/+4
svn path=/trunk/; revision=46120
2012-11-21The previous change means the "len" argument is now being used.Guy Harris1-3/+1
svn path=/trunk/; revision=46113
2012-11-21From l.wachowski:Anders Broman1-5/+9
Allign the tables for dissection. From me try to fix the dissection of SONtransferApplicationIdentity_PDU. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8008 svn path=/trunk/; revision=46111
2012-11-19From l.wachowski:Anders Broman1-4/+2
- In de_bssgp_pdu_in_error() use current_offset isof 0. - in function de_bssgp_ran_inf_error_rim_cont. Error rim container doesn't have field rim sequence number. This field exists in the rest of containers but not in this one. So I have removed this field. In this function we have field pdu in error and this field is mandatory, not optional https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8000 svn path=/trunk/; revision=46081
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-10Initial commit to support yet another method of passing data between dissectors.Jakub Zawadzki1-10/+10
Add new parameter 'data' to heur_dissector_t and new_dissector_t, for now it's always NULL svn path=/trunk/; revision=44860
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-05-21Display Element ID in hexadecimal (like in 3GPP specs)pascal1-1/+1
Display EPS bearer ID in decimal svn path=/trunk/; revision=42755
2012-03-10Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-3/+1
svn path=/trunk/; revision=41466
2012-02-16Use tce correct IE idAnders Broman1-4/+9
svn path=/trunk/; revision=41043
2012-01-19Fix some duplicate display filter names.Chris Maynard1-6/+6
svn path=/trunk/; revision=40586
2011-12-08Try to get the container stuff right...Anders Broman1-4/+2
svn path=/trunk/; revision=40119
2011-11-06Dissect RIM related IEsAnders Broman1-1/+1
svn path=/trunk/; revision=39740
2011-10-27Fix proto_tree_add_item( encoding args;Bill Meier1-4207/+4214
Do whitespace cleanup (for a few files). svn path=/trunk/; revision=39640