aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-bgp.c
AgeCommit message (Collapse)AuthorFilesLines
2008-06-27Fix some warnings reported by gcc -Wshadow ...wmeier1-11/+9
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25616 f5534014-38df-0310-8fa8-9805f1628bb7
2008-05-09Fix some of the Errors/warnings detected by checkapi.etxrab1-3/+8
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25264 f5534014-38df-0310-8fa8-9805f1628bb7
2008-05-05Remove depreciated functions g_string_sprint, g_string_sprintfa.etxrab1-5/+5
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25238 f5534014-38df-0310-8fa8-9805f1628bb7
2007-10-23Apply the small performance enhancment patches for:etxrab1-1/+1
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster. Replace - col_append_fstr() with faster col_append_str() - col_add_str() with col_set_str() when it's safe git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23252 f5534014-38df-0310-8fa8-9805f1628bb7
2007-10-11Swapped block-size and block-offset in BGP VPLS NLRI - fixes bug 1907.stig1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23151 f5534014-38df-0310-8fa8-9805f1628bb7
2007-08-23Clean up the code.jake1-163/+161
- Move add. info from header - Remove excess comma's - Use plurality macro - NULL pointer for field descriptions git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22607 f5534014-38df-0310-8fa8-9805f1628bb7
2007-08-23From David Helder:jake1-1/+5
The MP_REACH_NLRI (and MP_UNREACH_NLRI) parser incorrectly increments a buffer offset. Any attributes following will be skipped and/or parsed incorrectly. No security problem I see - the bounds are checked before parsing each attribute. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22598 f5534014-38df-0310-8fa8-9805f1628bb7
2006-11-26fix compiler warningwmeier1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19991 f5534014-38df-0310-8fa8-9805f1628bb7
2006-10-06From Aaron Campbell:jake1-1/+1
The expression (BGP_OSPF_RTYPE_EXT ||BGP_OSPF_RTYPE_NSSA) will always evaluate to 1. As well, neither of these constants are defined as flag values, so a bitwise op was probably not intended either. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@19444 f5534014-38df-0310-8fa8-9805f1628bb7
2006-07-03From: Hannes Gredlerjake1-4/+9
attached a patch for the BGP dissector for correct display of VPLS NLRIs as per the latest spec (draft-ietf-l2vpn-vpls-bgp-08). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18638 f5534014-38df-0310-8fa8-9805f1628bb7
2006-05-21change a whole bunch of ethereal into wiresharksahlberg1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@18196 f5534014-38df-0310-8fa8-9805f1628bb7
2006-03-15From RABRET Laurent RD-MAPS-ISS:etxrab1-2/+2
Please find enclosed a patch for the BGP dissector. A 0 length IP address is valid in NLRI dissection. It just means "0/0 address". git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17634 f5534014-38df-0310-8fa8-9805f1628bb7
2006-03-08fix minor bug coverity 74sahlberg1-2/+2
length_remaining could become -1 and if so the next tvb access (tvb_memcpy()) would cause an exception. not really an ethereal since it would have no ill effects in reality. change !=0 to >0 to make it more clear what we actually test. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17528 f5534014-38df-0310-8fa8-9805f1628bb7
2006-01-20packet-bgp.c: Fix incorrect use of g_snprintf return valuejmayer1-20/+19
mp_addr_to_str was unnecessary 'complex' - simplified it packet-dns.c: Fix incorrect use of g_snprintf return value packet-dcm.c: Fix incorrect use of g_snprintf return value Someone who understands the protocol should look at the "vr, tr might be used uninitialized..." warning. packet-x11.c: Fix incorrect use of g_snprintf return value packet-kerberos.c: Fix incorrect use of g_snprintf return value Someone should take a look at the "longjump might clobber ..." messages packet-diameter.c: Fix incorrect use of g_snprintf return value Get rid of unsigned < 0 check packet-pgm.c: Fix incorrect use of g_snprintf return value packet-nbns.c: Fix incorrect use of g_snprintf return value packet-winsrepl.c: Collateral damage to packet-nbns.c fix packet-netbios.c: Collateral damage to packet-nbns.c fix packet-netbios.h: Collateral damage to packet-nbns.c fix packet-kerberos.c: Collateral damage to packet-nbns.c fix packet-nbipx.c: Collateral damage to packet-nbns.c fix git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@17065 f5534014-38df-0310-8fa8-9805f1628bb7
2005-10-15get rid of one stack buffer and some strcpy() and strcat()sahlberg1-10/+11
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@16233 f5534014-38df-0310-8fa8-9805f1628bb7
2005-10-11From Hannes Gredler:etxrab1-11/+26
fixes the AF/SAFI codepoints for BGP Layer-2 VPNs from a Juniper pre-standard implementation to the new "official" IANA assigned codepoints. From Julian Onions packet-rmt-norm.ch Decode more oif the protocol git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@16183 f5534014-38df-0310-8fa8-9805f1628bb7
2005-09-13Convert some more "tvb_memcpy()"s fetching IPv4 and IPv6 addresses toguy1-33/+34
calls to "tvb_get_ipv4()" and "tvb_get_ipv6()". Fix a call in the BGP dissector to properly fetch an IEEE floating-point number. Update some I-D info. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15774 f5534014-38df-0310-8fa8-9805f1628bb7
2005-09-12Don't collide with the "regular" IPv6 defintions in at least someguy1-1/+1
platforms in ipv6-utils.h. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15764 f5534014-38df-0310-8fa8-9805f1628bb7
2005-09-11Replace tvb_memcpy() calls that extract IPv4 addresses into a guint32,guy1-3/+3
and that extract IPv6 addresses into a "struct e_in6_addr", with tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we remove, by using proto_tree_add_item(), rather than replacing. Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct e_in6_addr" (not necessary to declare the tvbuff routines, but including it there means "struct e_in6_addr" is guaranteed to be defined before those declarations, so we don't get compiler complaints if we define it *after* those declarations). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15758 f5534014-38df-0310-8fa8-9805f1628bb7
2005-09-01Get rid of a trailing comma.guy1-3/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15654 f5534014-38df-0310-8fa8-9805f1628bb7
2005-08-31remove some g_string_printf[a]() and replace with g_snprintf()sahlberg1-47/+56
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15632 f5534014-38df-0310-8fa8-9805f1628bb7
2005-08-28add missing value_string terminationsahlberg1-0/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15575 f5534014-38df-0310-8fa8-9805f1628bb7
2005-08-08various code cleanup:ulfl1-6/+2
-use g_snprintf instead of sprintf and snprintf -use g_strdup_printf where appropriate -remove #include "snprintf.h" (as only g_snprintf should be used) -replace some more alloc/realloc/calloc/free with their glib pendants git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15264 f5534014-38df-0310-8fa8-9805f1628bb7
2005-07-28char -> const char warning fixesjmayer1-3/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@15126 f5534014-38df-0310-8fa8-9805f1628bb7
2005-06-26Get rid of the private "my_match_strval()" routine in many dissectors;guy1-3/+3
add a "match_strval_idx()" routine that does the same thing, and have "match_strval()" call it. Make those routines, and "val_to_str()", return a "const" pointer. Update dissectors as necessary to squelch compiler warnings produced by that. Use "val_to_str()" rather than using "match_strval()" and then, if the result is null, substituting a specific string. Clean up some other "match_strval()"/"val_to_str()" usages. Add a null pointer check in the NDPS dissector's "attribute_value()" routine, as it's not clear that "global_attribute_name" won't be null at that point. Make some global variables in the AFS4INT dissector local. Make some routines not used outside the module they're in static. Make some tables "static const". Clean up white space. Fix Gerald's address in some files. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@14786 f5534014-38df-0310-8fa8-9805f1628bb7
2005-01-07From Carlos Pignataro:guy1-1/+203
o BGPv4 SAFI-Specific Attribute support - draft-kapoor-nalawade-idr-bgp-ssa-00.txt o Tunnel SAFI support for BGP - draft-nalawade-kapoor-tunnel-safi-02.txt o Small length fix git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12977 f5534014-38df-0310-8fa8-9805f1628bb7
2004-10-01From Carlos Pignataro:guy1-59/+92
o Fix EXTENDED_COMMUNITIES output that was appending the Carried Extended communities; fix BGP_EXT_COM_L2INFO was not appending to the bgpext_com_type o Update various text with the specific afi/safi o Decode fields in MP Reach NLRI for labeled VPNv4 and labeled IPv4 (and small offset fix for the latter) o Decode unknown address family in MP Reach NLRI git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12165 f5534014-38df-0310-8fa8-9805f1628bb7
2004-09-29Move various tables into the epan directory.guy1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12130 f5534014-38df-0310-8fa8-9805f1628bb7
2004-09-27Move prefs.c and prefs.h into the epan subdirectory.guy1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@12115 f5534014-38df-0310-8fa8-9805f1628bb7
2004-08-21Prevent the word "desegmentation" at the GUI, but use reassembling at that ↵ulfl1-2/+3
places, as we also use "defragmentation" and "reassembling". Use reassembling as the general term for such actions. I (hopefully) didn't changed any protocol fields or preference file names, but only the GUI labels appearing in the protocol display and the protocol preferences. Also added a note to the protocol preferences (where appropriate), that you have to enable "Allow subdissectors to reassemble TCP streams" at the corresponding protocol settings for TCP reassembling to take effect. If you encounter any mistakes I've made here, please let me know... git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11784 f5534014-38df-0310-8fa8-9805f1628bb7
2004-07-18Move dissectors to epan/dissectors directory.gram1-0/+2802
Also move ncp222.py, x11-fields, process-x11-fields.pl, make-reg-dotc, and make-reg-dotc.py. Adjust #include lines in files that include packet-*.h files. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@11410 f5534014-38df-0310-8fa8-9805f1628bb7