aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-bgp.c
AgeCommit message (Collapse)AuthorFilesLines
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-1/+1
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-10-08Restore pinfo->private_data after an exception was thrown by a subdissector.Jeff Morriss1-10/+17
This is necessary in case a subdissector had changed it but was unable to restore it (due to the exception). Remove check_col(). svn path=/trunk/; revision=34436
2010-08-04Avoid a possible dereference of null pointer.Stig Bjørlykke1-2/+2
svn path=/trunk/; revision=33708
2010-05-11Use consistent indentation; Whitesapce & formatting cleanup.Bill Meier1-1526/+1526
svn path=/trunk/; revision=32755
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
2010-01-23Fix for bug 4410:Jaap Keuter1-1/+11
Adding two more SSA types. svn path=/trunk/; revision=31631
2009-08-09Don't guard col_clear with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29344
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-8/+8
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-05-25From Thomas M. Knoll:Jaap Keuter1-2/+2
The CoS Capability extended community has been changed to a transitive ext. community and was reassigned an IANA type number. It has changed from 0x40 to 0x05. see: http://www.iana.org/assignments/bgp-extended-communities svn path=/trunk/; revision=28467
2009-04-14ep_strbuf usage: ep_strbuf_new_label("") --> ep_strbuf_new_label(NULL);Bill Meier1-6/+6
ep_strbuf_append() --> ep_strbuf_append_c() in a few cases. svn path=/trunk/; revision=28052
2009-03-28Fix a couple items from the last checkin.Gerald Combs1-17/+18
svn path=/trunk/; revision=27874
2009-03-28Replace a lot of pointer tracking and some GStrings with emem_strbufs. AddGerald Combs1-140/+127
ep_strbuf_printf and ep_strbuf_append_c. svn path=/trunk/; revision=27873
2009-02-23Fix for bug 3247:Jaap Keuter1-1/+1
Incorrect index adjustment causes failure to dissect multiple capabilities in optional parameters. svn path=/trunk/; revision=27529
2009-01-14From Thomas M. Knoll:Jaap Keuter1-3/+28
- New dissector for CoS Capability attributes added - tiny changes in my committed dissector for QoS Marking attributes svn path=/trunk/; revision=27232
2009-01-10From Thomas M. Knoll:Jaap Keuter1-76/+151
Added a new dissector for BGP QoS Marking extended community attributes as defined in http://tools.ietf.org/id/draft-knoll-idr-qos-attribute. svn path=/trunk/; revision=27206
2008-11-22From Peter (bug 2942):Stig Bjørlykke1-2/+2
Allow optimalization with -ftracer. svn path=/trunk/; revision=26822
2008-06-27Fix some warnings reported by gcc -Wshadow ...Bill Meier1-11/+9
svn path=/trunk/; revision=25616
2008-05-09Fix some of the Errors/warnings detected by checkapi.Anders Broman1-3/+8
svn path=/trunk/; revision=25264
2008-05-05Remove depreciated functions g_string_sprint, g_string_sprintfa.Anders Broman1-5/+5
svn path=/trunk/; revision=25238
2007-10-23Apply the small performance enhancment patches for:Anders Broman1-1/+1
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster. Replace - col_append_fstr() with faster col_append_str() - col_add_str() with col_set_str() when it's safe svn path=/trunk/; revision=23252
2007-10-11Swapped block-size and block-offset in BGP VPLS NLRI - fixes bug 1907.Stig Bjørlykke1-1/+1
svn path=/trunk/; revision=23151
2007-08-23Clean up the code.Jaap Keuter1-163/+161
- Move add. info from header - Remove excess comma's - Use plurality macro - NULL pointer for field descriptions svn path=/trunk/; revision=22607
2007-08-23From David Helder:Jaap Keuter1-1/+5
The MP_REACH_NLRI (and MP_UNREACH_NLRI) parser incorrectly increments a buffer offset. Any attributes following will be skipped and/or parsed incorrectly. No security problem I see - the bounds are checked before parsing each attribute. svn path=/trunk/; revision=22598
2006-11-26fix compiler warningBill Meier1-1/+1
svn path=/trunk/; revision=19991
2006-10-06From Aaron Campbell:Jaap Keuter1-1/+1
The expression (BGP_OSPF_RTYPE_EXT ||BGP_OSPF_RTYPE_NSSA) will always evaluate to 1. As well, neither of these constants are defined as flag values, so a bitwise op was probably not intended either. svn path=/trunk/; revision=19444
2006-07-03From: Hannes GredlerJaap Keuter1-4/+9
attached a patch for the BGP dissector for correct display of VPLS NLRIs as per the latest spec (draft-ietf-l2vpn-vpls-bgp-08). svn path=/trunk/; revision=18638
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-2/+2
svn path=/trunk/; revision=18196
2006-03-15From RABRET Laurent RD-MAPS-ISS:Anders Broman1-2/+2
Please find enclosed a patch for the BGP dissector. A 0 length IP address is valid in NLRI dissection. It just means "0/0 address". svn path=/trunk/; revision=17634
2006-03-08fix minor bug coverity 74Ronnie Sahlberg1-2/+2
length_remaining could become -1 and if so the next tvb access (tvb_memcpy()) would cause an exception. not really an ethereal since it would have no ill effects in reality. change !=0 to >0 to make it more clear what we actually test. svn path=/trunk/; revision=17528
2006-01-20packet-bgp.c: Fix incorrect use of g_snprintf return valueJörg Mayer1-20/+19
mp_addr_to_str was unnecessary 'complex' - simplified it packet-dns.c: Fix incorrect use of g_snprintf return value packet-dcm.c: Fix incorrect use of g_snprintf return value Someone who understands the protocol should look at the "vr, tr might be used uninitialized..." warning. packet-x11.c: Fix incorrect use of g_snprintf return value packet-kerberos.c: Fix incorrect use of g_snprintf return value Someone should take a look at the "longjump might clobber ..." messages packet-diameter.c: Fix incorrect use of g_snprintf return value Get rid of unsigned < 0 check packet-pgm.c: Fix incorrect use of g_snprintf return value packet-nbns.c: Fix incorrect use of g_snprintf return value packet-winsrepl.c: Collateral damage to packet-nbns.c fix packet-netbios.c: Collateral damage to packet-nbns.c fix packet-netbios.h: Collateral damage to packet-nbns.c fix packet-kerberos.c: Collateral damage to packet-nbns.c fix packet-nbipx.c: Collateral damage to packet-nbns.c fix svn path=/trunk/; revision=17065
2005-10-15get rid of one stack buffer and some strcpy() and strcat()Ronnie Sahlberg1-10/+11
svn path=/trunk/; revision=16233
2005-10-11From Hannes Gredler:Anders Broman1-11/+26
fixes the AF/SAFI codepoints for BGP Layer-2 VPNs from a Juniper pre-standard implementation to the new "official" IANA assigned codepoints. From Julian Onions packet-rmt-norm.ch Decode more oif the protocol svn path=/trunk/; revision=16183
2005-09-13Convert some more "tvb_memcpy()"s fetching IPv4 and IPv6 addresses toGuy Harris1-33/+34
calls to "tvb_get_ipv4()" and "tvb_get_ipv6()". Fix a call in the BGP dissector to properly fetch an IEEE floating-point number. Update some I-D info. svn path=/trunk/; revision=15774
2005-09-12Don't collide with the "regular" IPv6 defintions in at least someGuy Harris1-1/+1
platforms in ipv6-utils.h. svn path=/trunk/; revision=15764
2005-09-11Replace tvb_memcpy() calls that extract IPv4 addresses into a guint32,Guy Harris1-3/+3
and that extract IPv6 addresses into a "struct e_in6_addr", with tvb_get_ipv4() and tvb_get_ipv6() calls - except for some that we remove, by using proto_tree_add_item(), rather than replacing. Have epan/tvbuff.h include epan/ipv6-utils.h, to define "struct e_in6_addr" (not necessary to declare the tvbuff routines, but including it there means "struct e_in6_addr" is guaranteed to be defined before those declarations, so we don't get compiler complaints if we define it *after* those declarations). svn path=/trunk/; revision=15758
2005-09-01Get rid of a trailing comma.Guy Harris1-3/+3
svn path=/trunk/; revision=15654
2005-08-31remove some g_string_printf[a]() and replace with g_snprintf()Ronnie Sahlberg1-47/+56
svn path=/trunk/; revision=15632
2005-08-28add missing value_string terminationRonnie Sahlberg1-0/+1
svn path=/trunk/; revision=15575
2005-08-08various code cleanup:Ulf Lamping1-6/+2
-use g_snprintf instead of sprintf and snprintf -use g_strdup_printf where appropriate -remove #include "snprintf.h" (as only g_snprintf should be used) -replace some more alloc/realloc/calloc/free with their glib pendants svn path=/trunk/; revision=15264
2005-07-28char -> const char warning fixesJörg Mayer1-3/+3
svn path=/trunk/; revision=15126
2005-06-26Get rid of the private "my_match_strval()" routine in many dissectors;Guy Harris1-3/+3
add a "match_strval_idx()" routine that does the same thing, and have "match_strval()" call it. Make those routines, and "val_to_str()", return a "const" pointer. Update dissectors as necessary to squelch compiler warnings produced by that. Use "val_to_str()" rather than using "match_strval()" and then, if the result is null, substituting a specific string. Clean up some other "match_strval()"/"val_to_str()" usages. Add a null pointer check in the NDPS dissector's "attribute_value()" routine, as it's not clear that "global_attribute_name" won't be null at that point. Make some global variables in the AFS4INT dissector local. Make some routines not used outside the module they're in static. Make some tables "static const". Clean up white space. Fix Gerald's address in some files. svn path=/trunk/; revision=14786
2005-01-07From Carlos Pignataro:Guy Harris1-1/+203
o BGPv4 SAFI-Specific Attribute support - draft-kapoor-nalawade-idr-bgp-ssa-00.txt o Tunnel SAFI support for BGP - draft-nalawade-kapoor-tunnel-safi-02.txt o Small length fix svn path=/trunk/; revision=12977
2004-10-01From Carlos Pignataro:Guy Harris1-59/+92
o Fix EXTENDED_COMMUNITIES output that was appending the Carried Extended communities; fix BGP_EXT_COM_L2INFO was not appending to the bgpext_com_type o Update various text with the specific afi/safi o Decode fields in MP Reach NLRI for labeled VPNv4 and labeled IPv4 (and small offset fix for the latter) o Decode unknown address family in MP Reach NLRI svn path=/trunk/; revision=12165
2004-09-29Move various tables into the epan directory.Guy Harris1-1/+1
svn path=/trunk/; revision=12130
2004-09-27Move prefs.c and prefs.h into the epan subdirectory.Guy Harris1-1/+1
svn path=/trunk/; revision=12115
2004-08-21Prevent the word "desegmentation" at the GUI, but use reassembling at that ↵Ulf Lamping1-2/+3
places, as we also use "defragmentation" and "reassembling". Use reassembling as the general term for such actions. I (hopefully) didn't changed any protocol fields or preference file names, but only the GUI labels appearing in the protocol display and the protocol preferences. Also added a note to the protocol preferences (where appropriate), that you have to enable "Allow subdissectors to reassemble TCP streams" at the corresponding protocol settings for TCP reassembling to take effect. If you encounter any mistakes I've made here, please let me know... svn path=/trunk/; revision=11784
2004-07-18Move dissectors to epan/dissectors directory.Gilbert Ramirez1-0/+2802
Also move ncp222.py, x11-fields, process-x11-fields.pl, make-reg-dotc, and make-reg-dotc.py. Adjust #include lines in files that include packet-*.h files. svn path=/trunk/; revision=11410