aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-bacapp.c
AgeCommit message (Collapse)AuthorFilesLines
2010-04-07Squelch a compiler warning.guy1-1/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32415 f5534014-38df-0310-8fa8-9805f1628bb7
2010-04-03Remove unneeded #include <stdio.h>wmeier1-1/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@32367 f5534014-38df-0310-8fa8-9805f1628bb7
2010-02-06Renamed some reassembled data texts.stig1-57/+47
Removed some check_col(). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31809 f5534014-38df-0310-8fa8-9805f1628bb7
2010-02-02Introduce "Reassembled length" filter element for all protocols doingstig1-1/+7
reassembly. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31767 f5534014-38df-0310-8fa8-9805f1628bb7
2010-01-18Fix a number of gcc _Wshadow warningswmeier1-4/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31557 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-29From Herbert Lischka:etxrab1-0/+10
Patch to resolve Error in decoding BACnet NotificationParameters, https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4250 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@31111 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-17Added format argument.stig1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30986 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-17Herbert Lischka:etxrab1-2/+65
Recipients as IPv4 and IPv6. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30985 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-13From Herbert Lischka:jake1-27/+2128
- packet-bacapp.h eliminated and included in packet-bacapp.c - dissection of recipient-list and client-cov-increment added git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30955 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-09Avoid a warning about signed/unsigned comparison.martinm1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30875 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-08Fixed printing of BACnetTypeName in the Packet Details tree.stig1-10/+10
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30870 f5534014-38df-0310-8fa8-9805f1628bb7
2009-11-08From Steve Karg and Herbert Lischka via bug 4190:stig1-308/+340
Modified the open/close context tagging to include context tag number. Modified the info column to show more specific information about certain packets. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30869 f5534014-38df-0310-8fa8-9805f1628bb7
2009-10-27From Herbert Lischka:etxrab1-3/+3
Minor changes to dissector packet-bacapp.c to solve some strange views to ReadPropertyMultiple-Acknowledge frames. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4161 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30726 f5534014-38df-0310-8fa8-9805f1628bb7
2009-10-18Use %f for double in printf.stig1-3/+3
Made some functions static. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30602 f5534014-38df-0310-8fa8-9805f1628bb7
2009-09-24* Prefer col_append_str instead of col_append_fstr for constant stringskrj1-2/+1
* Remove check_col guards git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@30127 f5534014-38df-0310-8fa8-9805f1628bb7
2009-08-11Add some length checks. Fixes a few recent fuzz bugs.gerald1-116/+135
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29384 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-23From Steve Karg:etxrab1-52/+82
BACnet Action property not decoded correctly. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3766 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29173 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-21Another try to fix the compiler warnings on win64.stig1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29161 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-21More gsizery.guy1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29158 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-21GLib documentation says the 3rd and 5th arguments to g_iconv are "gsizeguy1-1/+1
*"s. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29157 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-21size_t -> int to make the Win64 build bot happy.etxrab1-2/+2
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29156 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-21Initialize bacapp_invoke_id to avoid a compiler warning.stig1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29155 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-21Stop using the C++ 'true' and 'false'.martinm1-3/+3
I still get a compilation error... packet-bacapp.c: In function `dissect_bacapp': packet-bacapp.c:6350: warning: 'bacapp_invoke_id' might be used uninitialized in this function ... although I've followed the paths (including the setting of 'segment'), and it looks bogus to me. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29154 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-21Fix typo.guy1-2/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29153 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-21Don't use tvb_length_remaining() - that just reports how much capturedguy1-106/+105
data is available, not how big the packet really is. Clean up white space. Get rid of an unused parameter and two unused variables. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29152 f5534014-38df-0310-8fa8-9805f1628bb7
2009-07-21From Herbert Lischka:etxrab1-121/+431
Added some new features to BACnet dissection: - ListOfObjectPropertyReferences in scheduler - RestartReason - Properties for loop-object - LogDeviceObjectProperty in trend-log object - log-buffer entries in trend-log object - reassemby of fragmented messages - fallback changed if iconv-library is not here Me: Moved includes from .h to .c as thats how we normaly do it. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3736 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@29151 f5534014-38df-0310-8fa8-9805f1628bb7
2009-06-18From Kovarththanan Rajaratnam via bug 3548:stig1-29/+29
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28770 f5534014-38df-0310-8fa8-9805f1628bb7
2009-03-27More size_t casts.gerald1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27866 f5534014-38df-0310-8fa8-9805f1628bb7
2009-03-22P64 changes: Fix some cases for which size_t is not requiredwmeier1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27822 f5534014-38df-0310-8fa8-9805f1628bb7
2009-03-16Removed some non-ASCII characters.stig1-5/+5
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27736 f5534014-38df-0310-8fa8-9805f1628bb7
2009-03-06From Steve Karg:jake1-1/+1
BACnet TimeSync message of 12:20 was displayed as 12:20 AM. It should have displayed as 12:20 PM. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27624 f5534014-38df-0310-8fa8-9805f1628bb7
2009-02-23From Steve Karg:jake1-40/+310
The ConfirmedEventNotification decoding was only done as far as context tag 8, so BACnetNotificationParameters 9, 10, and 11 displayed as malformed packet. Added context tag decoding for BACnetNotificationParameters 9, 10, and 11. Added missing breaks in several switch statements. Corrected some dissector aborts. Added several new enumerations from the latest BACnet 135-2008 standard, and updated the list of BACnet Vendor IDs. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27527 f5534014-38df-0310-8fa8-9805f1628bb7
2009-02-17From Steve Karg:etxrab1-10/+28
BACnet PrivateTransferError shows malformed packet. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3257 git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27470 f5534014-38df-0310-8fa8-9805f1628bb7
2008-12-18Fix various typos and spelling errors (mostly in text strings)wmeier1-3/+3
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27050 f5534014-38df-0310-8fa8-9805f1628bb7
2008-12-17Fix some typos and spelling (mostly in text strings)wmeier1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27037 f5534014-38df-0310-8fa8-9805f1628bb7
2008-12-17Fix typos and spelling (mostly in text strings) wmeier1-1/+1
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@27028 f5534014-38df-0310-8fa8-9805f1628bb7
2008-10-31Fix some "format not a string literal and no format arguments" warnings.stig1-4/+4
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@26646 f5534014-38df-0310-8fa8-9805f1628bb7
2008-07-17We require GLIB-2 now so there's no need to attempt to use regular iconv: usemorriss1-172/+175
the GLIB version instead. Reindent some (does someone have their tabstops set to 4?). Create and use some #defines instead of hard-coded values. For example, replace 0x00 with ANSI_X34 in both the value_string and the case statement. (This file could use a lot more of such changes.) packet-bacapp.c appears to compile cleanly now so move it to CLEAN_DISSECTOR_SOURCE. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25758 f5534014-38df-0310-8fa8-9805f1628bb7
2008-06-02From Rudolf Weidmann (bug 2583):stig1-1/+1
Fixed enumeration type for new-mode in change-of-life-safety. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25409 f5534014-38df-0310-8fa8-9805f1628bb7
2008-05-10From Steve Karg:jake1-24/+26
Corrected decode of a BACnet ReadRange request with no range specified (i.e. all) which showed ‘malformed packet’ in the decoder. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@25269 f5534014-38df-0310-8fa8-9805f1628bb7
2008-04-07From Steve Karg:jake1-9/+341
Received user request for enhancements. Added a display filter for BACnet property ID. Added a display filter and names for BACnet Vendor ID. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24832 f5534014-38df-0310-8fa8-9805f1628bb7
2008-03-16From Steve Karg:jake1-24/+108
Here is a modified patch that fixes the BACnet Schedule object Weekly_Schedule decoding when an array index is used. It also fixes the Priority_Array property when an array index is used. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24653 f5534014-38df-0310-8fa8-9805f1628bb7
2008-03-04match_strval() may return NULL so don't blindly pass its return value into ↵morriss1-10/+10
col_add_*() or proto_add_*(); use val_to_str() (returning "Unknown (%d)" if no match is found) instead. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24557 f5534014-38df-0310-8fa8-9805f1628bb7
2008-03-03From Alan McBride :etxrab1-1/+4
BACnet handling of readPropertyMultiple request / response. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24537 f5534014-38df-0310-8fa8-9805f1628bb7
2008-02-22From Evan via bug http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2293 : Inmorriss1-8/+8
epan/dissectors/packet-bacapp.c the BACnetErrorCode array contains incorrect enumeration mappings for BACnet error codes. Attached is a version of the file with the mappings straightened out. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24435 f5534014-38df-0310-8fa8-9805f1628bb7
2008-02-07Removed some "statement not reached" warnings.stig1-16/+0
git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24282 f5534014-38df-0310-8fa8-9805f1628bb7
2008-02-02From Alan McBride:jake1-2/+21
The decoding of a SubscribeCOVProperty packet is not properly decoding the Monitored Property Identifier field. It leaves a number of decoded bytes at the end as data. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24245 f5534014-38df-0310-8fa8-9805f1628bb7
2008-01-09From Steve Karg:jake1-8/+9
Wireshark decodes a BACnet ReadRange Ack packet as malformed. The packet itself is valid as checked with the BACnet 135-2004 specification. git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@24039 f5534014-38df-0310-8fa8-9805f1628bb7
2007-10-23Apply the small performance enhancment patches for:etxrab1-1/+1
- if offset is 0, tvb_length is the same as tvb_length_remaining, just faster. Replace - col_append_fstr() with faster col_append_str() - col_add_str() with col_set_str() when it's safe git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@23252 f5534014-38df-0310-8fa8-9805f1628bb7
2007-09-01From Steve Karg:jake1-0/+4
Fix for bug 1807. This patch corrects the decoding of the NotificationParameters. I fuzz tested with these and other captures (Pass > 100). git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@22766 f5534014-38df-0310-8fa8-9805f1628bb7
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 17:26:30 +0000