aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-bacapp.c
AgeCommit message (Collapse)AuthorFilesLines
2016-06-15Allow control of individual columns to be (un)writable.Michael Mann1-23/+17
Most protocols just want to limit COL_INFO or COL_PROTOCOL so give that level of granularity. Bug: 12144 Bug: 5117 Bug: 11144 Change-Id: I8de9b7d2c69e90d3fbfc0a52c2bd78c3de58e2f8 Reviewed-on: https://code.wireshark.org/review/15894 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-05-13BACAPP: event-time-stamps decode fixLori Tribble1-1/+7
event-time-stamps decode when array-index is 0. Bug: 12422 Change-Id: I9f1f90e269352a49a8fc8a2ba2f64211f3cf7961 Reviewed-on: https://code.wireshark.org/review/15409 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-12BACAPP: Added dissection for NotificationParameterLori Tribble1-0/+36
Case 19 - change-of-reliability and related enums Bug: 11734 Change-Id: Ie40acc9d157adcf4d69b9cc57c6419daf8f6263d Reviewed-on: https://code.wireshark.org/review/15350 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-28Fix more -Wused-but-marked-unused warnings/errors.Joerg Mayer1-5/+5
Change-Id: Ieb3e70a23c1a55b7ba60b1b32f159341adfe65b7 Reviewed-on: https://code.wireshark.org/review/14682 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-17Associate dissector tables and heuristic subdissector lists with a protocol.Michael Mann1-1/+1
This will make it easier to determine protocol dependencies. Some LLC OUI dissector tables didn't have an associated protocol, so they were left without one (-1 used) Change-Id: I6339f16476510ef3f393d6fb5d8946419bfb4b7d Reviewed-on: https://code.wireshark.org/review/14446 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-1/+1
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-13register_dissector -> new_register_dissectorMichael Mann1-5/+4
Picking off "easy" dissectors that only have one or two exit points at most. Change-Id: I3d5e576b796556ef070bb36d8b55da0b175dcba8 Reviewed-on: https://code.wireshark.org/review/11805 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-04Don't allow multiple registrations of a protocol in dissector tables.Michael Mann1-1/+1
The target here is the Decode As dialog where protocols have multiple registrations into a dissector table and that shows up as multiple entries in the Decode As dialog list with the same name so users are unsure which "dissector" they are choosing. The "default" behavior (done in this commit) is to not allow duplicates for a dissector table, whether its part of Decode As or not. It's just ENFORCED for Decode As. Bug: 3949 Change-Id: Ibe14fa61aaeca0881f9cc39b78799e314b5e8127 Reviewed-on: https://code.wireshark.org/review/11405 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-05bacapp: attempt to fix windows buildPeter Wu1-1/+1
Reported by Graham: packet-bacapp.c(5299) : warning C4146: unary minus operator applied to unsigned type, result still unsigned Regression in v1.99.10rc0-330-g71ec57a ("bacapp: fix -Wshift-negative-value"). Change-Id: Ia3ea3acad3afdf7b8a449224c815ea45d7fdbc2b Reviewed-on: https://code.wireshark.org/review/10785 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2015-10-04bacapp: fix -Wshift-negative-valuePeter Wu1-2/+2
Shifting a negative signed value is undefined. Found by Clang. Change-Id: If58d7b82899859892d8c58d627e98a8a902dd7fd Reviewed-on: https://code.wireshark.org/review/10780 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2015-09-02Eliminate proto_tree_add_text from some dissectors.Michael Mann1-21/+37
Change-Id: If617016f588bbf940f37699e27559dc5c59cf508 Reviewed-on: https://code.wireshark.org/review/10349 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-08-16Conversion of random proto_tree_add_text calls.Michael Mann1-12/+10
Change-Id: I6505ce34de84bfe46d5bc7b4d6a3c6044f3fb4b5 Reviewed-on: https://code.wireshark.org/review/10041 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-03Call reassembly_table_destroy for some dissectorsPeter Wu1-0/+7
This patch adds reassembly_table_destroy calls as cleanup function for dissectors which have a simple init routine that just calls reassembly_table_init (comments are ignored). The changes were automatically generated using https://git.lekensteyn.nl/peter/wireshark-notes/diff/one-off/cleanup-rewrite.py?id=4cc0aec05dc67a51926a045e1955b7a956757b5e (with the if and assignment parsers disabled). The only difference from the autogenerated output is that the XXX comments from the init routines in smb-pipe and tds dissectors are kept. Change-Id: I64aedf7189877247282b30b0e0f83757be6199e7 Reviewed-on: https://code.wireshark.org/review/9222 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-06-27bacapp: cleanup and remove some add_textEvan Huus1-69/+71
Change-Id: I991269db9c2705a4ac41a576000a612aa6de2242 Reviewed-on: https://code.wireshark.org/review/9186 Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Evan Huus <eapache@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-04-15Replcae deprecated API tvb_length with tvb_reported_length or tvb_capturedAndersBroman1-8/+8
length. Change-Id: Id42f3409a32e202528d350f7afde7376e411fc51 Reviewed-on: https://code.wireshark.org/review/8076 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-18Update some comments to reflect reality.Guy Harris1-1/+1
Get rid of references to ep_ and se_ allocation in code that now uses wmem allocation instead. Fix API documentation of conversation_table.h routines to reflect that as well - some APIs changed to pass wmem scopes. Also, zbee_sec_key_hash() now takes the output buffer as an argument and just returns it, and nobody actually uses the return value, so change it to return void. Change-Id: Ife1ec675a9322fd0f0be306a9d639ec17aad1c7a Reviewed-on: https://code.wireshark.org/review/6636 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-07tvb_bytes_to_ep_str -> tvb_bytes_to_strMichael Mann1-2/+2
Change-Id: I79c613cbdd8dc939dd4c29ebc477fb6eefd5bfc4 Reviewed-on: https://code.wireshark.org/review/6371 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-04BACAPP: fix empty paragraph passed to '@param' command [-Wdocumentation]Alexis La Goutte1-1/+1
Change-Id: Ibef3cee6930dea08fc7a87635c48de609d3d4015 Reviewed-on: https://code.wireshark.org/review/6299 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-22Fix unknown command tag name [-Wdocumentation-unknown-command]Alexis La Goutte1-1/+1
Change-Id: I6c2564a86e13d9321001856ba1f51681a9f20976 Reviewed-on: https://code.wireshark.org/review/5979 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-3/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-12-04BACnet: fix dissection of exception-schedule property.Steve Karg1-13/+4
The exception schedule special-event disection already used matched open-close tags and only needed to check for an unmatched close tag to exit when used with ReadPropertyMultiple service. Bug: 10691 Change-Id: I54f2f6f3f470138a6a88f84c62fd15b07ea74c37 Reviewed-on: https://code.wireshark.org/review/5593 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-11-11BACAPP: fix dissection of event parameters for event notifications of ↵desolat1-0/+20
Event_Type Change_of_Status_Flags Implementation for this event parameter type was missing Bug: 9626 Change-Id: Iea0bc819858bbf5660d97cfd0c418a963ac149fb Reviewed-on: https://code.wireshark.org/review/5228 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-11-08BACAPP: fix dissection of event parameters for event notifications of ↵desolat1-0/+21
Event_Type Change_of_Characterstring Implementation for this event parameter type was missing Bug: 9625 Change-Id: I575d387ec4764fa1ecd365624d13e3f41e2473c6 Reviewed-on: https://code.wireshark.org/review/5189 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-10-09[BACnet][trivial] change strings as per Bug 9640Anish Bhatt1-2/+2
Change-Id: I542b5a96bcff6c779359b80ddce513524852272c Reviewed-on: https://code.wireshark.org/review/4572 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-10-08[bacnet] update vendors list, fix whitespace issues, all generated via scriptAnish Bhatt1-23/+24
Change-Id: Ieb4b169dfcf5e89b7b2a2cb90b6572a3d973d744 Reviewed-on: https://code.wireshark.org/review/4519 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-10-07[bacnet] update vendor listAnish Bhatt1-0/+80
Change-Id: I6b7bd3b3a110b8d393cd849c12890fff17446e54 Reviewed-on: https://code.wireshark.org/review/4515 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-07-06Squelch some compiler warnings.Guy Harris1-2/+7
Change-Id: Ie39c7b0c1fef8f862cec016a3a1a5bd1451a3df2 Reviewed-on: https://code.wireshark.org/review/2905 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-22Get rid of some unused variables.Guy Harris1-1/+0
Change-Id: I2a806af639e5f0519ba93b0048ec7a4624fa33fc Reviewed-on: https://code.wireshark.org/review/2567 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-22convert to proto_tree_add_subtree[_format]Michael Mann1-192/+116
Change-Id: Ib60ca75b7da8cfa21cfe2999c9b9448a02c332df Reviewed-on: https://code.wireshark.org/review/2560 Tested-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Use address_to_str(NULL, ...) for strings allocated outside dissectors.Guy Harris1-8/+32
ep_address_to_str() doesn't crash if called outside packet scope, but it's still not correct to use outside packet scope. Use address_to_str(NULL, ...) to allocate those strings, and then explicitly free them when we're done; exceptions don't get thrown between the allocate and free, so there's no risk of a leak. Change-Id: Iea2af93b0757e648d399e2ba64249224eb7e9e3c Reviewed-on: https://code.wireshark.org/review/2438 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-19Revert "Fixup: ep_address_to_str -> address_to_str"Michael Mann1-8/+8
Most (all?) of these functions are being called within GUI, so they can't have packet_scope, which is why they weren't already converted (I made this mistake once already) This reverts commit 7fea55a0541bcc5059f767970b6f6291f81d7b9c. Change-Id: I4bf29b206e5e1f5daefcec131309a8f6e78e1eb1 Reviewed-on: https://code.wireshark.org/review/2428 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-8/+8
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: ep_address_to_str -> address_to_strDario Lombardo1-8/+8
Change-Id: Id49ba07e32a71357b50b32de7cecfd80e412d508 Reviewed-on: https://code.wireshark.org/review/2379 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-8/+8
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-18Fixup: tvb_get_string(z) -> tvb_get_string(z)_encDario Lombardo1-2/+2
Change-Id: I63a3704effe3fcab01a193dc39b6a22e9f1cf3fe Reviewed-on: https://code.wireshark.org/review/2376 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-06Partly revert fdeed480bf89a1f43f7b3d4be67fa0e4333f7120Pascal Quantin1-8/+8
wmem_packet_scope() cannot be used outside of a packet treatment Change-Id: I6e545bbb51f325b366288f17358f9d2347a7d7c4 Reviewed-on: https://code.wireshark.org/review/977 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-06Convert ep_address_to_str -> address_to_str(wmem_packet_scope, ...) for all ↵Michael Mann1-8/+8
dissectors Change-Id: I7489e2fb3a1f2630ca17b0a5fe1aa873992f1061 Reviewed-on: https://code.wireshark.org/review/975 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-23Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=54416
2013-12-23Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=54412
2013-12-22Get rid of a set-but-unused variable.Guy Harris1-2/+1
svn path=/trunk/; revision=54355
2013-12-22Add UCS-4 support, and use it.Guy Harris1-82/+2
Shuffle the character ENC_ values around a bit, keeping the Unicode encodings together, moving the Windows code pages (only one for now) after the ISO 8859 encodings, and putting "I can't believe it's not ASCII!" at the end. Fix some comment typoes, and update another comment, while we're at it. svn path=/trunk/; revision=54351
2013-12-19Rename a couple of to_str functions to have ep_ in the name. This makes itEvan Huus1-2/+2
obvious that the returned string is ephemeral, and opens up the original names in the API for versions that take a wmem pool (and thus can work in any scope). svn path=/trunk/; revision=54249
2013-12-13Make sure all unused bits are 0 in bacapp, fixes uninitialized memory found byEvan Huus1-0/+1
valgrind. svn path=/trunk/; revision=54077
2013-12-13Note that apparently some BACnet implementations misuse the "ANSI X3.4"Guy Harris1-1/+3
encoding for ISO 8859-1; this means that those strings won't be correctly interpreted if they're interpreted as UTF-8. svn path=/trunk/; revision=54069
2013-12-08It's ISO 8859-1, not "ISO 18859-1", at least according to ANSI/ASHRAEGuy Harris1-21/+22
Standard 135-2004. Use tvb_get_string_enc() wherever possible. svn path=/trunk/; revision=53840
2013-11-23Remove old (2009) and no-longer-necessary compatibility macro.Evan Huus1-8/+8
svn path=/trunk/; revision=53527
2013-11-20Fix Bug #9457 Update BACnet vendor listJakub Zawadzki1-2/+12
Based on attachment #12139 (diff for adding the table) by rtsking117, but keep original formatting and encoding (ASCII). svn path=/trunk/; revision=53457
2013-11-09Include <epan/to_str.h> only when needed.Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53189
2013-10-23#if 0 numerous "unused const variables" (mostly value-string-arrays);Bill Meier1-2/+6
Also; fix a few "set but not used" warnings. svn path=/trunk/; revision=52780
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 05:57:59 +0000