aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-ax25.c
AgeCommit message (Collapse)AuthorFilesLines
2015-03-01Use COPY_ADDRESS_SHALLOW instead of duplicating TVB_SET_ADDRESS and ↵Michael Mann1-2/+2
SET_ADDRESS calls for the same address. Change-Id: I0c9cc5d574fdd73ecf1f8b32dbbf0ddb2b885116 Reviewed-on: https://code.wireshark.org/review/7437 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-09Remove proto_tree_add_ax25Michael Mann1-11/+5
There isn't a legitimate use for the API, all cases can be covered with proto_tree_add_item. As a bonus, a few more tvb_get_ptr calls can be removed. Change-Id: I3bb86ba8f05ef3363407bcfe9b059ee27ebc135d Reviewed-on: https://code.wireshark.org/review/6429 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-07SET_ADDRESS -> TVB_SET_ADDRESS to "hide" some of the tvb_get_ptr use.Michael Mann1-5/+5
Not all changes were able to remove their corresponding tvb_get_ptr, because there are other API dependent on the (tvb_get)pointer, but future iterations optimizing those other APIs will then be able to remove it. Change-Id: Id7cefd440b81834de1d1aace7cd0789b1c871a22 Reviewed-on: https://code.wireshark.org/review/6358 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-21Replace ax25_to_str and get_ax25_name with address_to_str.Michael Mann1-6/+3
Change-Id: I74ddb6fc629ef32b217dede7a3ba652cbbf5ab12 Reviewed-on: https://code.wireshark.org/review/5932 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-5/+1
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-09-30Add editor modelines; Adjust whitespace; Remove boilerplate commentsBill Meier1-0/+12
Change-Id: I1f5f83ed441f6009125cf2cbe5023af04986898a Reviewed-on: https://code.wireshark.org/review/4392 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-11-29Avoid including <wiretap/wtap.h> in dissectors.Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53655
2013-11-09Include <epan/to_str.h> only when needed.Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53189
2013-10-27Have X.25 dissector pass boolean q_bit_set value through dissector data ↵Michael Mann1-5/+0
rather than pinfo->private_data. Other "related" dissectors weren't manipulating pinfo->private_data, so it doesn't make sense for them to bother saving/restore it (now that q_bit_set isn't being used) svn path=/trunk/; revision=52894
2013-09-12Convert a few dissectors from emem to wmem APIPascal Quantin1-2/+2
svn path=/trunk/; revision=51983
2013-08-05Keep result of [new_]register_dissector in some dissectors.Jakub Zawadzki1-6/+5
svn path=/trunk/; revision=51156
2013-03-13- [-Wmissing-prototypes]Anders Broman1-1/+4
- explicit casts. svn path=/trunk/; revision=48282
2013-01-29Remove some unneeded parens in hf[] entries;Bill Meier1-8/+8
svn path=/trunk/; revision=47340
2012-12-21Constify some character pointer variables to avoid warnings aboutGuy Harris1-1/+1
strings being assigned to them. svn path=/trunk/; revision=46653
2012-10-22Cleanup:Bill Meier1-86/+70
- Ethereal --> Wireshark; - gerald@ethereal.com --> gerald@wireshark.org; - update FSF address; - remove unneeded #includes; - Fix ENC args for proto_tree_add_item() & etc; - simplify/remove proto_reg_handoff...() as appropriate; - remove some boilerplate comments; - move proto_register...() and proto_reg_handoff...() to the end of the file as per convention; - remove some unneeded initializers. - simplify some code; - replace "" in hf[] blurb by NULL. svn path=/trunk/; revision=45728
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-09-04Use libwireshark's xDLC handling functions and macros to process theGuy Harris1-62/+44
control field. This means processing the AX.25 header data in one pass. The field after the control field is the "protocol identifier" field, not the "packet identifier" field. svn path=/trunk/; revision=44772
2012-08-03Newer version of the AX.25 spec.Guy Harris1-0/+3
svn path=/trunk/; revision=44236
2012-08-03Move the list of AX.25 protocol IDs to epan/ax25_pids.h. Use it inGuy Harris1-80/+21
packet-ax25.c and packet-arp.c. Add an "ax25.pid" dissector table for those protocol IDs, use it in the AX.25 dissector, and have dissectors register in that table with their protocol IDs. Get rid of some unneeded includes. Clean up some "AX25"s in user-visible strings - say "AX.25" instead. Clean up some indentation. svn path=/trunk/; revision=44235
2012-08-03Make the protocol ID field an integral field with a value_string table;Guy Harris1-124/+70
use that table for setting the column as well. dissect_xdlc_control() sets the Info column; don't set it ourselves (dissect_xdlc_control() will overwrite it if called). That means we should always call dissect_xdlc_control(), regardless of whether we're building a protocol tree or not. Just get rid of the test for that. Append the protocol ID, if present, to the column. svn path=/trunk/; revision=44234
2012-08-02From Richard Stearn: AX.25 "No layer 3" support.Guy Harris1-1/+1
Also, [at]ify his e-mail address, and list packet-ax25.c before the packet-ax25-XXX.c dissectors in the file lists. svn path=/trunk/; revision=44228
2012-08-02From Richard Stearn: Rose (X.25 Packet Layer Protocol atop AX.25'sGuy Harris1-3/+3
link-layer protocol) support. Rename rose_handle to x25_handle, as it's not a handle for a protocol named "Rose" or "ROSE", it's a handle for X.25's Packet Layer Protocol (which we just call "x.25"). svn path=/trunk/; revision=44226
2012-08-02Clean up indentation.Guy Harris1-36/+24
Get rid of capture_XXX routines that just bump ld->other. *Do* bump ld->arp for AX.25 ARP packets. Note that, as there's IP-over-NetROM, capture_netrom() should check for it. svn path=/trunk/; revision=44225
2012-08-02From Richard Stearn: Flexnet support.Guy Harris1-20/+3
Also, get rid of check_col() calls and unused preferences, and use col_add_fstr() where appropriate. Fix up some indentation. svn path=/trunk/; revision=44222
2012-08-02Don't use dissector_add(): it's long since deprecated.Jeff Morriss1-2/+2
svn path=/trunk/; revision=44220
2012-08-02From Richard Stearn: AX.25 NetROM support.Guy Harris1-2/+3
Also add packet-ax25.c to the CMake list. svn path=/trunk/; revision=44217
2012-08-02Fix:Jörg Mayer1-40/+40
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-ax25.c:164:7: error: variable ‘v2cmdresp’ set but not used [-Werror=unused-but-set-variable] /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-ax25.c: In function ‘proto_register_ax25’: /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-ax25.c:398:12: error: variable ‘ax25_module’ set but not used [-Werror=unused-but-set-variable] svn path=/trunk/; revision=44214
2012-08-02From Richard Stearn: IP-over-AX.25 and AX.25 ARP.Guy Harris1-3/+3
svn path=/trunk/; revision=44212
2012-08-02From Richard Stearn: support for AX.25, including support forGuy Harris1-0/+630
LINKTYPE_AX25. svn path=/trunk/; revision=44211
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-21 08:24:24 +0000