aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-at.c
AgeCommit message (Collapse)AuthorFilesLines
2021-07-27Change some `wmem_packet_scope()` to `pinfo->pool`David Perry1-50/+50
2021-04-30Cast away the return value of g_strlcpy() and g_strlcat().Guy Harris1-1/+1
Most of the time, the return value tells us nothing useful, as we've already decided that we're perfectly willing to live with string truncation. Hopefully this keeps Coverity from whining that those routines could return an error code (NARRATOR: They don't) and thus that we're ignoring the possibility of failure (as indicated, we've already decided that we can live with string truncation, so truncation is *NOT* a failure).
2020-10-27AT: Handle response without leading \r\nStig Bjørlykke1-1/+1
The AT response may not contain a leading \r\n, so avoid checking for this to determine if it's a response. This characters will be removed as a part of white space removal anyway.
2020-08-29Fix some spelling errors in dissector strings.Martin Mathieson1-3/+3
A first batch of spelling errors, detected using a script that uses pyspellcheck and a Wireshark-specific dictionary file.
2020-04-05at: remove _U_ for a parameter which is usedMartin Kaiser1-1/+1
This fixes a -Wused-but-marked-unused compiler warning. Change-Id: I85d92954821feda80f1189a0e1b2c2071a25610a Reviewed-on: https://code.wireshark.org/review/36702 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-10-14AT: Add ZUSIM commandDarien Spencer1-0/+40
Change-Id: I691e8aa2277866f49bf93b33668b69b4662f6d75 Reviewed-on: https://code.wireshark.org/review/34774 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2019-07-26HTTPS (almost) everywhere.Guy Harris1-1/+1
Change all wireshark.org URLs to use https. Fix some broken links while we're at it. Change-Id: I161bf8eeca43b8027605acea666032da86f5ea1c Reviewed-on: https://code.wireshark.org/review/34089 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-13AT: Remove copy-pasted commentDarien Spencer1-2/+0
Comment is about CME error, should be in ZPAS dissection func. Change-Id: Iad2bc3de564374b23ca60053d227e02219c2a8c4 Reviewed-on: https://code.wireshark.org/review/33926 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2019-07-13Get rid of unused variable.Guy Harris1-8/+0
It's filled in, and modified, but never used after that. Change-Id: Id5e1e9e5bc3223b04bd77f94117388ec8aa274d6 Reviewed-on: https://code.wireshark.org/review/33922 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot Reviewed-by: Guy Harris <guy@alum.mit.edu>
2019-07-12Fix Wpointer-sign warnings.Anders Broman1-16/+11
Change-Id: I1ac6cfecf2ff4b12f75ed0214dc40983d3db3bc8 Reviewed-on: https://code.wireshark.org/review/33906 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-05-17AT: Add ZPAS CommandDarien Spencer1-1/+47
Change-Id: I557830fc960095359bebd05574890c5b5d51d3c7 Reviewed-on: https://code.wireshark.org/review/32997 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2019-04-04epan: Convert our PROTO_ITEM_ macros to inline functions.Gerald Combs1-3/+3
Convert our various PROTO_ITEM_ macros to inline functions and document them. Change-Id: I070b15d4f70d2189217a177ee8ba2740be36327c Reviewed-on: https://code.wireshark.org/review/32706 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-12-05Fix some spelling errors found by Lintian.Gerald Combs1-2/+2
Change-Id: If6fc3aab7ad4fc634567121f7b9541bc6f6c5766 Reviewed-on: https://code.wireshark.org/review/30926 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-12AT: Add CSUPI commandDarien Spencer1-0/+8
Change-Id: I501bd0e00a20b39e4c53bdd7e5e2b9b3c5234469 Reviewed-on: https://code.wireshark.org/review/29635 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-12AT: Fix rejection valuesDarien Spencer1-2/+2
Dissect functions for CNUM/VTS were returning TRUE for all wrong role/type combinations instead of FALSE ( = Rejecting the parameter ) Change-Id: I1aae5b76db83cef6b59f5244c05a67b2110f8969 Reviewed-on: https://code.wireshark.org/review/29634 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-08AT: Add CMUX commandDarien Spencer1-0/+145
Change-Id: I35f53f15a35d6e13cac57ebb42c35c62b43cc32f Reviewed-on: https://code.wireshark.org/review/29490 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-09-08AT: Fix CSQ checking for wrong actionDarien Spencer1-1/+1
Should allow ACTION_SIMPLY instead of ACTION Change-Id: Ia56ee3e17fcc8a36bb41ca38200d19fca689f94b Reviewed-on: https://code.wireshark.org/review/29489 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-09-08AT: Add GMI, GMM, GMR commandsDarien Spencer1-0/+89
Counterparts of CGMI, CGMM, CGMR Change-Id: Icc99f48816fa421c3fbb681ab443b2b56457dd00 Reviewed-on: https://code.wireshark.org/review/29463 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-06AT: Fix dissector function return typesStig Bjørlykke1-29/+29
Change to return gboolean for dissector functions returning TRUE or FALSE. Change-Id: I418f765253326cd1153b82bd6af042c36cbfc2d4 Reviewed-on: https://code.wireshark.org/review/29446 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2018-09-06AT: Add CGMI and CGMR commandStig Bjørlykke1-0/+60
Change-Id: Ifc4f02fcd0def6280a62c0485389a5ca5a2c98d4 Reviewed-on: https://code.wireshark.org/review/29443 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-09-03AT: Add CSCS commandDarien Spencer1-0/+34
Change-Id: Idb4373d4a3bcdbcac99f1688d8a517bb1fbd0ffd Reviewed-on: https://code.wireshark.org/review/29402 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-26AT: Add CPIN commandDarien Spencer1-0/+74
Change-Id: Ib92ceabf9699da0ee202a086d1a24464e552ebbd Reviewed-on: https://code.wireshark.org/review/29279 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-26AT: Correct dissection func for +CLACDarien Spencer1-1/+1
Change-Id: I2efc1151ce27138a4360c7dba75d916ecb8dc270 Reviewed-on: https://code.wireshark.org/review/29284 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-24AT: Add CSQ commandDarien Spencer1-0/+106
Change-Id: I8e795710b04f9421e9b847f800f35552af46fa67 Reviewed-on: https://code.wireshark.org/review/29258 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-24AT: Clarify that a DCE is a ModemDarien Spencer1-3/+3
Change-Id: I0216a67bc5a99877efc972d21e777c97c46546f5 Reviewed-on: https://code.wireshark.org/review/29267 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-21AT: Fix suffix length checks, add no suffix caseDarien Spencer1-3/+11
Change-Id: I20a7e52635cf95ea1b5d1c85cd0ae6e8619ebff8 Reviewed-on: https://code.wireshark.org/review/29189 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-19AT: Add CLAC commandDarien Spencer1-0/+7
Change-Id: I84dbc146fe4300e22dfed21572b97e57b449af54 Reviewed-on: https://code.wireshark.org/review/29186 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-18AT: Add CGSN/GSN CommandsDarien Spencer1-0/+14
Change-Id: Ie383c0de07e4114f00e6c8833b6c18fcbaa4a07f Reviewed-on: https://code.wireshark.org/review/29185 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-17AT: Reorder commands dissection functionsDarien Spencer1-240/+239
Now in alphabetical order Change-Id: I9c572e04e422cc595c66681ff77cd37a944383b9 Reviewed-on: https://code.wireshark.org/review/29171 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-16AT: Reorder commands dictionaryDarien Spencer1-6/+6
Now in alphabetical order Change-Id: I28d863fc176518a2c26c417257f657f9d888ceb7 Reviewed-on: https://code.wireshark.org/review/29156 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-16AT: Add CFUN commandDarien Spencer1-0/+92
Change-Id: Ia2b69fa6c72a12ace5b27dc868c7853c2f8d7c52 Reviewed-on: https://code.wireshark.org/review/29151 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-11AT: Add CPMS commandDarien Spencer1-0/+128
Change-Id: Idb4dd32849d1d1c64eab1c5f58e5b268aff43b04 Reviewed-on: https://code.wireshark.org/review/29006 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-11AT: Add ^CIMI commandDarien Spencer1-0/+1
AT^CIMI is an alternative form for AT+CIMI for some modems Change-Id: Id64fb4e0d76396400aa69fceeadba3a87ddf68e1 Reviewed-on: https://code.wireshark.org/review/29072 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-07AT: Allow more CMEE command typesDarien Spencer1-2/+5
Code was only allowing actions, while 'test', 'read' ,'action simply' and 'response' are also possible Change-Id: Iee84dd77912debe96a06f0b7d6b3e1f15527ce3b Reviewed-on: https://code.wireshark.org/review/28997 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-08-05AT: Fix check for numeric CME errorsDarien Spencer1-2/+4
Allow whitespaces in numeric error codes. Change-Id: Id9baa2b8d90519f83ecba10f9cc479e15a932e3d Reviewed-on: https://code.wireshark.org/review/28976 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-05AT: Add CIMI commandDarien Spencer1-22/+53
Change-Id: I7a03add8b48d0f360fbe5434fef866461804c2f3 Reviewed-on: https://code.wireshark.org/review/28940 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2018-08-05AT: fix check for non-numeric CME errorsPeter Wu1-5/+2
Fix the digit check, testing a pointer as character is an error. Change-Id: I1ce2898dd1cca0b61bb2da342c81bc648fdb1cf2 Fixes: v2.9.0rc0-1356-g51c6fde9c7 ("AT: Distinguish between numeric and textual CME errors") Reviewed-on: https://code.wireshark.org/review/28962 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-05AT: Add CSIM commandDarien Spencer1-0/+112
Parse both commands and responses, including a call to GSM SIM dissector Change-Id: I39624a1a088066aae6eb1e6fd61d4f73821b2345 Reviewed-on: https://code.wireshark.org/review/28959 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-04AT: Fix CME Error descriptionDarien Spencer1-1/+1
Leftover description form the BT-HFP dissector was classifying the DTE as an Audio Gateway, which isn't always the case. Change-Id: If6f916026bce00dc8783d95f48e449ffa9951d37 Reviewed-on: https://code.wireshark.org/review/28960 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-04AT: Allow test command for AT+CGMMDarien Spencer1-1/+1
Change-Id: Ifbd6cb4dcfc4dee9b174eca60aaaac9de8968303 Reviewed-on: https://code.wireshark.org/review/28950 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-04AT: Distinguish between numeric and textual CME errorsDarien Spencer1-1/+20
Change-Id: Ibf57da87f0ecd3a25461b333883ae8f84b3b4e31 Reviewed-on: https://code.wireshark.org/review/28951 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-08-04at: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-3/+3
Change-Id: Ibe42807cfbf3ed57791d4f4beb8e95cc71ba39f4 Reviewed-on: https://code.wireshark.org/review/28942 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Darien Spencer <cusneud@mail.com> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2018-08-01AT: Dissect commandsDarien Spencer1-29/+1672
This commit introduces dissection of the different parts of the command, showing of the command direction and origin entity, generic dissection of 'unsupported' commands, detailed dissection of several 'supported' commands and aggregated commands dissection. Most of the code has been taken from BT-HFP (A protocol of AT commands over bluetooth). Change-Id: I3516ec9c28581df8ef9c0c37f9b6ee9ec0c55938 Reviewed-on: https://code.wireshark.org/review/28699 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-06-28AT: Allow padding in heuristic checkDarien Spencer1-11/+42
Bug: 14882 Change-Id: I0aa26d2ae898d47e0e33794f95e9c464cf5ec6f1 Reviewed-on: https://code.wireshark.org/review/28296 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman <a.broman58@gmail.com>
2018-02-12dissectors: use SPDX identifiers.Dario Lombardo1-13/+1
Change-Id: I92c94448e6641716d03158a5f332c8b53709423a Reviewed-on: https://code.wireshark.org/review/25756 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-01-30Have format_text_wsp use wmem allocated memory.Michael Mann1-1/+1
format_text_wsp is fed into by tvb_format_text_wsp and tvb_format_stringzpad_wsp so those functions need to add a wmem allocated parameter as well. Most of the changes came from tvb_format_text_wsp and tvb_format_stringzpad_wsp being changed more so than format_text_wsp. Change-Id: I52214ca107016f0e96371a9a8430aa89336f91d7 Reviewed-on: https://code.wireshark.org/review/19851 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-02AT: fix heuristic checkPascal Quantin1-7/+6
It should loop on captured data, not reported one While we are at it, let's call tvb_format_text_wsp() only once Change-Id: If6805a91d8e5dcf641e682b453522d88cbc2df6c Reviewed-on: https://code.wireshark.org/review/15699 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-01at: remove an unnecessary if (tree) checkMartin Kaiser1-9/+8
Change-Id: I2e7805edd3312b9e8dd4540c60eca195c0f36445 Reviewed-on: https://code.wireshark.org/review/15680 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-03-28Fix some warnings/errors of typeJoerg Mayer1-1/+1
git/epan/dissectors/packet-a21.c:478:25: error: 'item' was marked unused but was used [-Werror,-Wused-but-marked-unused] proto_item_append_text(item, "%s", val_to_str_const(event_id, a21_event_vals, "Unknown")); ^ Added manual change id because file-jpeg.c forced the use of commit -n Change-Id: Iffff53d6253758c8454d9583f0a11f317c8390cb Fix warnings/errors of type: git/epan/dissectors/packet-ax25-kiss.c:205:52: error: 'pseudo_header' was marked unused but was used [-Werror,-Wused-but-marked-unused] return capture_ax25( pd, l_offset, len, cpinfo, pseudo_header ); Fix checkhf warnings: Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_address_netswitch Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_address_subswitch Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_poll_reply_trailer Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_rdm_universe Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_tod_data_universe Change-Id: Id1fa12afb97a8e9cd4ed0ea25351c3b2639c930e Reviewed-on: https://code.wireshark.org/review/14667 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-1/+1
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-15 02:56:32 +0000