Age | Commit message (Collapse) | Author | Files | Lines |
|
All caught by cppcheck. The two (semi)-interesting bugs are:
- in asn1/atn-cpdlc/packet-atn-cpdlc-template.c where the break statement should
have been inside the brace, causing potential control-flow weirdness with
exceptions
- in epan/dissectors/packet-ieee80211.c where the bounds check for tag_len did
not match the expert info given
Change-Id: Ie173fb8d917aabb9b4571435d671d6f16e1c7569
Reviewed-on: https://code.wireshark.org/review/1793
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
|
|
understandable.
Change-Id: I1948eeaf5fa5aa4a5ccd0f81be894f655907a4dc
Reviewed-on: https://code.wireshark.org/review/1570
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Evan Huus <eapache@gmail.com>
|
|
Sample file with traffic is the same as for CAT021 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9953). Apply filter "asterix.category == 23" to see only CAT023 packets.
A small change in actual dissecting code was also needed because of strange item I023/101. The first FX bit is in the second byte and then grows only for a byte.
Change-Id: I3f80e6e46b642efc6f2e19e6f931cdef1c39495a
Reviewed-on: https://code.wireshark.org/review/993
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
It was found in https://code.wireshark.org/review/#/c/972/ and only commented out.
The bug is now fixed, the variable is used.
Change-Id: I0361b269a06f45f4d36b8bc97c3623618cb5f859
Reviewed-on: https://code.wireshark.org/review/976
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
|
|
Change-Id: I07125f1779063527f24d9195a9999cef4c8fe343
Reviewed-on: https://code.wireshark.org/review/972
Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
|
|
Change-Id: If72685f41cd32854d6c0c04716ee640196431f87
Reviewed-on: https://code.wireshark.org/review/961
Reviewed-by: Michael Mann <mmann78@netscape.net>
|
|
with wrong units.
Change-Id: I716dfeb16b049544e691dcdf75c488758d9e1fa0
Reviewed-on: https://code.wireshark.org/review/707
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
|
|
(Using sed : sed -i '/^ \* \$Id\$/,+1 d')
Fix manually some typo (in export_object_dicom.c and crc16-plain.c)
Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8
Reviewed-on: https://code.wireshark.org/review/497
Reviewed-by: Anders Broman <a.broman58@gmail.com>
|
|
Change-Id: Ia03a1cd4590aceda30ead4aa93ad413d90c6aea6
Reviewed-on: https://code.wireshark.org/review/372
Reviewed-by: Bill Meier <wmeier@newsguy.com>
Tested-by: Bill Meier <wmeier@newsguy.com>
|
|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9697
Architectural support for multiple version of the same Asterix categories.
Includes implementation of CAT064 v.0.17.
svn path=/trunk/; revision=54987
|
|
dissect all elements of category 48 messages
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9629
svn path=/trunk/; revision=54680
|
|
rename RE field len to make it generic for all categories
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9624
svn path=/trunk/; revision=54679
|
|
it's enough to have them at the end of the file
svn path=/trunk/; revision=54665
|
|
Added dissection capabilities for ASTERIX Category 062 Reserved
Expansion Field.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9624
svn path=/trunk/; revision=54664
|
|
svn path=/trunk/; revision=54358
|
|
svn path=/trunk/; revision=54135
|
|
svn path=/trunk/; revision=52950
|
|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9347 :
Asterix dissector had two #if 0 ... #endif blocks because it obviously did not
compile on some systems.
Blocks were created because of mistyped variable names and variable not used
warning/error.
The errors were corrected.
svn path=/trunk/; revision=52949
|
|
Also; fix a few "set but not used" warnings.
svn path=/trunk/; revision=52780
|
|
svn path=/trunk/; revision=52767
|
|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9239
Add dissection of Asterix category 008.
svn path=/trunk/; revision=52496
|
|
(don't create new dissector handle if we can use already existing one)
svn path=/trunk/; revision=51159
|
|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8994
Adjusts field lengths to display values properly.
svn path=/trunk/; revision=51025
|
|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8926 :
A better fix for this bug (as compared to r50532): this version takes into
account the scaling factors.
svn path=/trunk/; revision=50732
|
|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8926 :
The dissector defines some one-byte fields as UFLOAT. Defining them as UINT
fixes the decoding error for CAT48 version 1.21.
svn path=/trunk/; revision=50532
|
|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8886
Fix an error in the scaling factor of field I062/380 subfield #28 in the Asterix
dissector.
svn path=/trunk/; revision=50424
|
|
a 64-bit unsigned integer using G_GUINT64_CONSTANT().
svn path=/trunk/; revision=50289
|
|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8737
Add dissection of Category 009 to the ASTERIX dissector.
svn path=/trunk/; revision=49734
|
|
Error: the blurb for hf_048_030_WE ("asterix.048_030_WE") matches the field name in epan/dissectors/packet-asterix.c
Also remove a few blurbs which aren't exact matches but are basically the same.
svn path=/trunk/; revision=49468
|
|
svn path=/trunk/; revision=49461
|
|
svn path=/trunk/; revision=49460
|
|
number of compiler warnings for systems where floats are 32 bits, but
floating-point literals default to 64-bit doubles.
svn path=/trunk/; revision=49459
|
|
lines to make it obvious where the 32-bit cast is needed, since it's not
at all obvious to me...
svn path=/trunk/; revision=49458
|
|
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8579
Dissector for ASTERIX (a radar data and air traffic controller protocol).
svn path=/trunk/; revision=49457
|