aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-arp.c
AgeCommit message (Collapse)AuthorFilesLines
2014-06-24Restore correct tree assignment.Michael Mann1-1/+1
Change-Id: Id06bd486114a80fb899f8dc148d48928e99e775e Reviewed-on: https://code.wireshark.org/review/2602 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-22Get rid of set-but-not-used variable.Guy Harris1-2/+1
Change-Id: Ic0f2c79b4bd9fc737bf33ef64512f4142d74de6b Reviewed-on: https://code.wireshark.org/review/2568 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-06-22convert to proto_tree_add_subtree[_format]Michael Mann1-10/+10
Change-Id: Ib60ca75b7da8cfa21cfe2999c9b9448a02c332df Reviewed-on: https://code.wireshark.org/review/2560 Tested-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-19Rename a couple of to_str functions to have ep_ in the name. This makes itEvan Huus1-12/+12
obvious that the returned string is ephemeral, and opens up the original names in the API for versions that take a wmem pool (and thus can work in any scope). svn path=/trunk/; revision=54249
2013-11-23Create the ability to have packet scoped "proto" data. Bug 9470 ↵Michael Mann1-6/+6
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470) I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do. The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As. All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data. svn path=/trunk/; revision=53520
2013-10-13Minor whitespace, formatting & etc changes.Bill Meier1-201/+199
svn path=/trunk/; revision=52588
2013-09-29Convert several proto_tree_add_bytes_format calls to ↵Michael Mann1-4/+4
proto_tree_add_bytes_format_value. svn path=/trunk/; revision=52272
2013-09-12More wmem.Evan Huus1-6/+6
svn path=/trunk/; revision=51968
2013-09-09expert_add_info_format_text -> expert_add_info_formatMichael Mann1-2/+2
svn path=/trunk/; revision=51852
2013-08-05Keep result of [new_]register_dissector in some dissectors.Jakub Zawadzki1-6/+3
svn path=/trunk/; revision=51156
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-65/+55
This leaves just the Pidl dissectors remaining for removal of check_col() in the dissectors directory. A small handful of check_col() calls remain outside of the dissectors. svn path=/trunk/; revision=49941
2013-05-24first batch of dissectors to use the new expert info API.Michael Mann1-20/+18
svn path=/trunk/; revision=49560
2013-05-12Add the posibillity to use a key for per-packet-data.Anders Broman1-6/+6
svn path=/trunk/; revision=49259
2013-04-22Don't report duplicate use of IP address twice when dissecting aMartin Mathieson1-1/+2
gratuitous ARP request. svn path=/trunk/; revision=48962
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-3/+3
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-13- [-Wmissing-prototypes]Anders Broman1-9/+12
- explicit casts. svn path=/trunk/; revision=48282
2012-10-14convert proto_tree_add_text to proto_tree_add_item and ↵Michael Mann1-7/+2
expert_add_info_format for packet-dhcpv6.c and packet-dhcp-failover.c "Refactor" value_string in ARP dissector svn path=/trunk/; revision=45535
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-08-04Add a fall-through comment to appease Coverity and resolve CID 714131: ↵Chris Maynard1-2/+1
Missing break in switch. svn path=/trunk/; revision=44264
2012-08-03Move the list of AX.25 protocol IDs to epan/ax25_pids.h. Use it inGuy Harris1-1/+2
packet-ax25.c and packet-arp.c. Add an "ax25.pid" dissector table for those protocol IDs, use it in the AX.25 dissector, and have dissectors register in that table with their protocol IDs. Get rid of some unneeded includes. Clean up some "AX25"s in user-visible strings - say "AX.25" instead. Clean up some indentation. svn path=/trunk/; revision=44235
2012-08-02Fix:Jörg Mayer1-3/+3
/home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-arp.c:1239:42: error: variable ‘tha_val’ set but not used [-Werror=unused-but-set-variable] /home/jmayer/work/wireshark/svn/trunk/epan/dissectors/packet-arp.c:1239:22: error: variable ‘sha_val’ set but not used [-Werror=unused-but-set-variable] svn path=/trunk/; revision=44213
2012-08-02From Richard Stearn: IP-over-AX.25 and AX.25 ARP.Guy Harris1-1/+225
svn path=/trunk/; revision=44212
2012-05-29From Deepti Ragha:Anders Broman1-3/+429
Additions to the ARP dissector as per the IANA specifications for ARP https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7216 svn path=/trunk/; revision=42895
2012-04-23Do indentation cleanup (e.g., 4-space tabs => spaces)Bill Meier1-137/+144
Reformat a few long lines. svn path=/trunk/; revision=42213
2012-02-08Fix reporting of duplicate IP addresses by creating a hash table ofMartin Mathieson1-60/+115
results when first visited. svn path=/trunk/; revision=40928
2011-11-13As we're no longer checking whether we're constructing the Info column,Guy Harris1-8/+2
we can't bail out early on dissection merely because we're not constructing the protocol tree, as that would mean we wouldn't construct the Info column unless we're constructing a protocol tree. Clean up indentation. svn path=/trunk/; revision=39821
2011-09-26Get rid of check_col, while at it set ENC.Anders Broman1-130/+119
svn path=/trunk/; revision=39146
2011-04-12Added a FALLTHRU comment to avoid a missing break warning.Stig Bjørlykke1-0/+1
Coverity 437. svn path=/trunk/; revision=36605
2011-02-11Rename arphrdaddr_to_str() to tvb_arphrdaddr_to_str() and make it take a ↵Jeff Morriss1-11/+9
pointer a TVB and an offset instead of (generally) a pointer into a TVB. svn path=/trunk/; revision=35913
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-5/+5
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-08-23The ARP hardware type and operation code are listed with the IANA in decimal ↵Stephen Fisher1-2/+2
notation, not hex. svn path=/trunk/; revision=33898
2010-07-18Added some ARP options from RFC 5494.Stig Bjørlykke1-0/+11
svn path=/trunk/; revision=33568
2009-12-10Generated fields should not highlight any bytes in the packet bytes pane.Stephen Fisher1-1/+1
This is especially true in this case because the indication that an arp packet is gratuitous is determined with the following code, which checks multiple fields: if (((ar_op == ARPOP_REQUEST) || (ar_op == ARPOP_REPLY)) && (memcmp(spa_val, tpa_val, ar_pln) == 0)) is_gratuitous = TRUE; else is_gratuitous = FALSE; svn path=/trunk/; revision=31229
2009-08-09Don't guard col_clear with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29344
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-05-21Add filterable generated item arp.isgratuitous. InspiredJörg Mayer1-34/+43
by question on wireshark-users ML by wireshark.20090520@tozer.org.uk svn path=/trunk/; revision=28436
2009-05-08The convention is to use TFS(...) when specifying a true_false_string with ↵Bill Meier1-5/+5
an FT_BOOLEAN field; Also: use the global true_false_string tfs_yes_no in place of a static local string. svn path=/trunk/; revision=28320
2009-03-29Define certain fcns as static (if not used externally).Bill Meier1-326/+326
Also: whiule we're at it: - fix hf[] blurbs as appropriate to use NULL; - fix some indentation svn path=/trunk/; revision=27890
2009-02-06#include <conversation.h> not req'd ....Bill Meier1-1/+0
svn path=/trunk/; revision=27389
2008-12-27Update ARP hardware types from http://www.iana.org/assignments/arp-parameters/Jaap Keuter1-0/+8
svn path=/trunk/; revision=27120
2008-12-19Back out r27047 and r27053.Gerald Combs1-0/+2
svn path=/trunk/; revision=27062
2008-12-18Update calls to proto_tree_add_bytes_format to reflect r27047.Gerald Combs1-2/+0
svn path=/trunk/; revision=27053
2008-05-30A MAC address is a sequence of 6 8-bit unsigned values (guint8), not aGuy Harris1-1/+1
sequence of 6 ASCII characters (gchar). svn path=/trunk/; revision=25395
2008-01-02Also show duplicate IP address in info column.Martin Mathieson1-8/+31
svn path=/trunk/; revision=23983
2007-12-20Fix some casts.Gerald Combs1-4/+4
svn path=/trunk/; revision=23930
2007-12-19Report duplicate IP addresses based on observed ARP requests & responses.Martin Mathieson1-13/+176
Turned on by default (otherwise no-one will find it). svn path=/trunk/; revision=23923
2007-04-14fix MacOSX gcc-3.3 warnings about unused tfs/value_string variablesSebastien Tandel1-1/+0
most have been tagged unused (few have been deleted if dissector has not been modified since a long time) move packet-ssl-utils.c to DISSECTOR_SRC svn path=/trunk/; revision=21431
2007-03-23fix some more warningsUlf Lamping1-1/+1
svn path=/trunk/; revision=21143
2007-03-11Fix bug 552:Jeff Morriss1-7/+9
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=552 by enforcing that header fields have names of length > 0. This should fix the display of those fields and also make them filterable (which was the subject of the bug). Abbreviations are (still) optional: if they are empty then the field is not filterable. Update README.developer with this information. Add header field names in several dissectors where they were missing. In packet-arp.c give "packet-storm-detected" a name (as above) but also set it as _GENERATED. Also remove trailing white space from all the files checked in. svn path=/trunk/; revision=21018
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-28 23:39:06 +0000