aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-arinc615a.c
AgeCommit message (Collapse)AuthorFilesLines
2022-06-16a615a: don't parse exception timer if A1Jeremy McCormick1-3/+25
Trying to parse LUS and LNS files if the protocol version was "A1" led to them being marked as a malformed packets. THis is because protocol version A1 LUS and LNS files do not have the exception timer field. So to fix it, we check if the protocol version is not A1, and only if it isn't do we try to parse the exception timer field.
2022-02-07More descriptive names for some heuristic dissectorsDavid Perry1-1/+1
2021-09-16ptvcursor: add explicit memory scopeEvan Huus1-2/+2
I was hoping to avoid this, since the ptvcursor should already be implicitly scoped to the tree it is working on. But there are a bunch of call sites where the passed tree can be NULL (?) and a few places where the tree is explicitly set/reset after creation, so requiring an explicit scope is safer. Avoids global memory pools in favour of ones the compiler can verify.
2021-07-21First pass pinfo->pool conversion, part 2Evan Huus1-1/+1
Automated find/replace of wmem_packet_scope() with pinfo->pool in all files where it didn't cause a build failure.
2021-03-25Add FIND dissectorRoman-Koshelev1-0/+85
2021-02-18arinc615a: Avoid calling g_str_has_suffix(NULL, ...).Darius Davis1-0/+3
Testing with tftpConversationError.pcapng attached to issue 10305 revealed this warning on the console: GLib-CRITICAL **: 16:47:08.092: g_str_has_suffix: assertion 'str != NULL' failed The cause is that the filename retrieved from the tftpinfo struct could potentially be NULL when dissect_a615a_heur is called, for instance if the TFTP RRQ/WRQ was not captured or not associated with the same conversation as the DATA packet. It's interesting that this condition arises from this capture file... Perhaps the conversation tracking is amiss? To be investigated. Without knowing the filename, there appears to be no way to meaningfully dissect the protocol beyond just dissecting just the file length and the protocol version; For simplicity, I opted to maintain the present behavior and have the heuristic test fail if the filename is not known.
2020-09-13A615a: Fix spelling.Gerald Combs1-5/+5
Fix I: libwireshark0: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libwireshark.so.0.0.0 Ammendment Amendment found by lintian.
2020-08-22Add Arinc 615A dissectorRoman-Koshelev1-0/+399
Bug: 16767 Change-Id: I70a6672d46ac1ea6e495759a47a13b0b8b0c9f33 Signed-off-by: Roman-Koshelev <roman.koshelev@bk.ru> Reviewed-on: https://code.wireshark.org/review/38112 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Pascal Quantin <pascal@wireshark.org>