aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-ansi_a.c
AgeCommit message (Collapse)AuthorFilesLines
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-7/+7
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-06-07tvb_new_subset -> tvb_new_subset_length when length parameters are equal.Michael Mann1-4/+4
tvb_new_subset -> tvb_new_subset_remaining it appears that's what the intention is. Change-Id: I2334bbf3f10475b3c22391392fc8b6864454de2d Reviewed-on: https://code.wireshark.org/review/1999 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-03Fix Bug 9920 Buildbot crash due to SDP/RTP mismatchHadriel Kaplan1-21/+5
For details see comments in Bug 9920. The executive summary: Bug 9920 is a crash caused by a couple of issues: 1) The memory ownership model for the rtp_dyn_payload hashtable is split: SDP creates the rtp_dyn_payload hashtable, but RTP can free it. Since there isn't *one* pointer to the hashtable, RTP freeing it means SDP has a dangling pointer. 2) Either the SDP dissector shouldn't be creating two separate, unique hashtables for multiple media channels of the same addr:port, or RTP shouldn't be free'ing the previous one. Change-Id: I436e67de6882f84aa82dcbdfe60bf313fe4fd99c Reviewed-on: https://code.wireshark.org/review/918 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-29Tighten the NO_MORE_DATA_CHECK macrosEvan Huus1-1/+1
We should return if we've already somehow overflowed the apparent length, not just if we've hit it dead on. Fixes bug #9932 and probably others. Change-Id: I2719c3bd38f03e18ea557df962ee4a1beb64c2e8 Reviewed-on: https://code.wireshark.org/review/862 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-01-23Use tvb_memdup(), not tvb_get_string(), when copying octets (such asGuy Harris1-9/+9
octets within a BCD number). Use tvb_get_string_enc() rather than tvb_get_string(). svn path=/trunk/; revision=54919
2014-01-09Revert "from me" changes of r54676. Checks for NULL were functional logic, ↵Michael Mann1-7/+24
not trying to NULL protect proto_item_append_text. svn path=/trunk/; revision=54681
2014-01-09Mark an unused parameter as such.Guy Harris1-1/+1
svn path=/trunk/; revision=54677
2014-01-09Remove some global variables. Bug 9471 ↵Michael Mann1-540/+480
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9471) From Michael Lum From me: Remove a few proto_item* NULL checks because it's done by the underlying function. svn path=/trunk/; revision=54676
2013-12-23Fix Dead Store (Dead assignement/Dead increment) warning found by ClangAlexis La Goutte1-7/+0
svn path=/trunk/; revision=54414
2013-12-21Add missing includesJakub Zawadzki1-0/+1
svn path=/trunk/; revision=54332
2013-12-21Move base64_to_tvb() to tvbuff_base64.cJakub Zawadzki1-1/+0
svn path=/trunk/; revision=54325
2013-12-19Exposing a couple of more constant arrays for ANSI-637. Bug 9471 ↵Michael Mann1-2/+2
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9471) From Michael Lum svn path=/trunk/; revision=54241
2013-12-18Presumably ansi_tsb58_language_ind_vals shouldn't be static (since it's ↵Jeff Morriss1-1/+1
listed in the header file). svn path=/trunk/; revision=54206
2013-12-18ANSI A-interface improvements. Bug 9471 ↵Michael Mann1-1284/+977
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9471) From Michael Lum svn path=/trunk/; revision=54205
2013-12-17Do not modify the bytes given to proto_tree_add_uint_format_value() in case ↵Pascal Quantin1-8/+8
there is a mask present in hf definition. Otherwise the bits displayed in the tree are not the right ones. svn path=/trunk/; revision=54179
2013-12-17Fix a crash when calling try_val_to_str_ext()Pascal Quantin1-4/+4
svn path=/trunk/; revision=54177
2013-12-17Fix the offset when dissecting a Signal reserved fieldPascal Quantin1-1/+1
svn path=/trunk/; revision=54174
2013-12-16Intialise a variable to avoid a (bogus) warning with my version of gccMartin Mathieson1-1/+1
svn path=/trunk/; revision=54163
2013-12-16Get rid of unused variable.Guy Harris1-2/+2
svn path=/trunk/; revision=54160
2013-12-16Fix typo in formatting string (%%s should be %s).Guy Harris1-2/+2
Mark unused argument as such. svn path=/trunk/; revision=54159
2013-12-16ANSI A-interface enhancements. Bug 9471 ↵Michael Mann1-4613/+5512
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9471) From Michael Lum: 1. Allow mobile ID and service option to be shown in the INFO line for various messages. 2. proto_tree_add_text -> proto_tree_add_item conversions. From me: 1. Even more proto_tree_add_text -> proto_tree_add_item conversions. svn path=/trunk/; revision=54157
2013-11-12Add "rtp handle protection" inside ↵Michael Mann1-4/+1
srtp_add_address/rtp_add_address/bluetooth_add_address so dissectors calling it don't need to find "rtp" just for the handle check. svn path=/trunk/; revision=53288
2013-11-10Add missing includes in order to remove exceptions.h from proto.h (next commit).Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=53230
2013-10-27Remove use of pinfo->private_data and just pass the data around through ↵Michael Mann1-119/+109
function parameters Remove g_pinfo from packet-ansi_637.c and add packet_info* as a function parameter while we're at it. svn path=/trunk/; revision=52883
2013-10-13Minor whitespace, formatting & etc changes.Bill Meier1-3/+3
svn path=/trunk/; revision=52588
2013-09-30Convert some proto_tree_add_string_format calls to something more appropriate.Michael Mann1-2/+2
There seem to be several cases of proto_tree_add_string_format where a "string" value/filter doesn't really make sense because it's always empty, and is just being used as a "filterable subtree header (placeholder)". They appear to be more for "presense" than "value" and should probably be FT_NONE, although I'd almost argue for removing the filter in favor of proto_tree_add_text. svn path=/trunk/; revision=52296
2013-09-22emem -> wmem conversion:Pascal Quantin1-9/+9
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-09-03Fix "Tones off" value typo introduced in r51613Pascal Quantin1-12/+12
svn path=/trunk/; revision=51729
2013-08-31According to X.S0059 specification, when using FemtoInterfaceMsg Body the ↵Pascal Quantin1-2/+6
Information Elements for the Complete Layer 3 Information message shall not be included svn path=/trunk/; revision=51614
2013-08-31Fix (for real) https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9068 :Pascal Quantin1-2/+130
Add dissection of Signal and Call Waiting Indicator IEs when present in MS Information Records IE svn path=/trunk/; revision=51613
2013-08-31From Jon Carmicheal via ↵Pascal Quantin1-0/+5
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9068 : BSMAP: add dissection of Signal IE when present in MS Information Records IE svn path=/trunk/; revision=51611
2013-08-19Do not use ephemeral memory when adding a new data sourcePascal Quantin1-1/+1
svn path=/trunk/; revision=51423
2013-08-07Fix dissection of FemtoInterfaceMsg media type when it includes a mandatory ↵Pascal Quantin1-11/+30
LV or V IE svn path=/trunk/; revision=51193
2013-07-30Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8883 :Pascal Quantin1-85/+140
Add support for FemtoInterfaceMsg media type svn path=/trunk/; revision=51040
2013-07-03expert_add_info + proto_tree_add_text = proto_tree_add_expert, where applicableMichael Mann1-4/+2
svn path=/trunk/; revision=50337
2013-05-25Batch of filterable expert_infos.Michael Mann1-1/+11
svn path=/trunk/; revision=49581
2013-03-29Rename value string (and similar) functions to use a consistent pattern. ThisEvan Huus1-7/+7
was done using textual search+replace, not anything syntax-aware, so presumably it got most comments as well (except where there were typos). Use a consistent coding style, and make proper use of the WS_DLL_* defines. Group the functions appropriately in the header. I ended up getting rid of most of the explanatory comments since many of them duplicated what was in the value_string.c file (and were out of sync with the recent updates I made to those in r48633). Presumably most of the comments should be in the .h file not the .c file, but there's enough churn ahead that it's not worth fixing yet. Part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8467 svn path=/trunk/; revision=48634
2013-03-19From beroset:Anders Broman1-7/+7
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48428
2013-03-13- [-Wmissing-prototypes]Anders Broman1-2/+1
- explicit casts. svn path=/trunk/; revision=48282
2013-03-12svn path=/trunk/; revision=48272Anders Broman1-3/+6
2013-02-03#if 0 unused hf[] entries & etc.Bill Meier1-0/+4
Note: All (or almost all) unused hf[] entries in non-generated Wireshark dissectors have been #if 0'd (or commented) out. (This applies only to 'static hf_...' vars). A number of (non-generated) dissector files with *missing* hf[] entries still need to be fixed. svn path=/trunk/; revision=47459
2013-01-31Comment out unused hf[] entries & etc.Bill Meier1-1/+3
(found by checkhf) svn path=/trunk/; revision=47389
2012-11-29Make all enum_val_t's const.Jeff Morriss1-1/+1
svn path=/trunk/; revision=46292
2012-10-11Change 'for (i=1; i<=n;...' to 'for (i=0; i<n; ...)'Bill Meier1-4/+3
Done on general principles altho upon inspection none of the cases changed would have actually resulted in an infinite loop. svn path=/trunk/; revision=45478
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-08-19use session allocated memory for rtp_add_address/srtp_add_address hash tablesMichael Mann1-18/+7
svn path=/trunk/; revision=44571
2012-07-07From Evan Huus: fix "Unused variable in packet-ansi_a.c"Bill Meier1-2/+4
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7447 svn path=/trunk/; revision=43598
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-05-19Fix some "warning: Value stored to '...' is never read" clang scan-build ↵Bill Meier1-3/+0
warnings. Also; Do some whitespace cleanup in a few cases. svn path=/trunk/; revision=42715
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-24 12:00:35 +0000