aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-aim-messaging.c
AgeCommit message (Collapse)AuthorFilesLines
2015-05-25Remove proto_tree_add_text from AIM dissectors.Michael Mann1-29/+34
Change-Id: Ic7385d0555d72aa8ea2b9beb284ca1f6a115b174 Reviewed-on: https://code.wireshark.org/review/8616 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-04-14Change deprecated API tvb_length -> tvb_reported_lengthAndersBroman1-3/+3
Change-Id: I14577dccaed5aa5ed85e94b6810a94b4c8b2e437 Reviewed-on: https://code.wireshark.org/review/8059 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-03-03Eliminate e_uuid_t in favor of e_guid_t.Guy Harris1-26/+26
That eliminates a redundant and confusing data type, and avoids issues with one piece of code using e_uuid_t but wanting to use routines expecting an e_guid_t. Change-Id: I95e172d46d342ab40f6254300ecbd2a0530cde60 Reviewed-on: https://code.wireshark.org/review/7506 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-12-22First batch of unincludes. Last attempt...Martin Mathieson1-1/+0
Change-Id: I3681462aeb98ca62ed3ec5eb226b2553317391a9 Reviewed-on: https://code.wireshark.org/review/5997 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-2/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-11-29Use proto_tree_add_bitmask for groups of proto_tree_add_boolean.Michael Mann1-11/+8
Part 1 of many Change-Id: I77a5789ac23388e6a5f8098dc398592f39638124 Reviewed-on: https://code.wireshark.org/review/5532 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-11-02Eliminate proto_tree_add_text from several dissectors.Michael Mann1-6/+3
Change-Id: I6d3125f15d268edd47ef74dd655eb86cb25ee52d Reviewed-on: https://code.wireshark.org/review/5047 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-10-03packet-aim-messaging.c: Add editor modelines; reformat various (including ↵Bill Meier1-105/+176
hf[] entries). Change-Id: Ie5973a717a80ba75b82e817cb9e30c3529afbb0c Reviewed-on: https://code.wireshark.org/review/4441 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-06-19Revert "Fixup: tvb_* -> tvb_captured"Michael Mann1-3/+3
https://www.wireshark.org/lists/wireshark-dev/201406/msg00131.html This reverts commit 246fe2ca4c67d8c98caa84e2f57694f6322e2f96. Change-Id: Ib24bae0198c13a84bd7f731bf4af921212109a8f Reviewed-on: https://code.wireshark.org/review/2430 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-06-18Fixup: tvb_* -> tvb_capturedDario Lombardo1-3/+3
Change-Id: I9209c1271967405c34c1b6fa43e1726a4d3a5a3f Reviewed-on: https://code.wireshark.org/review/2377 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-04-09Don't use tvb_get_nstringz0(), use tvb_get_string_enc().Guy Harris1-3/+2
Change-Id: I8e654fa857fca6713198e3d20f2a14a0a444e935 Reviewed-on: https://code.wireshark.org/review/1037 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-01-22At least according toGuy Harris1-1/+1
http://web.archive.org/web/20080308233204/http://dev.aol.com/aim/oscar/#SNAC "In general strings are not NULL terminated and are encoded using UTF8." It also says Authentication Over the years, the AIM backend has supported several different methods for authentication. ... When a client collects the loginId and password for the user it should not normalize them in any manner. It also should not prevent the user from entering certain characters as the AIM name space is constantly changing. For example, currently the AIM name space is ASCII based, but in the future that may change. In general, the client should not perform input checking and instead allow the backend to reject bad values. which also suggests not assuming ASCII. So use ENC_UTF_8 in most cases. For actual messages, it says: An IM can be encoded in the following different forms: Name Value Notes ASCII 0 ANSI ASCII -- ISO 646 UNICODE 2 ISO 10646.USC-2 Unicode LATIN_1 3 ISO 8859-1 so, if that's the case, the dissector should choose beween ENC_ASCII|ENC_NA, ENC_UCS_2|ENC_appropriate_ENDIAN, and ENC_ISO_8859_1|ENC_NA. Use tvb_get_string_enc() with an encoding rather than tvb_get_string(). svn path=/trunk/; revision=54908
2013-09-22emem -> wmem conversion:Pascal Quantin1-1/+1
- ep_tvb_get_bits() -> wmem_packet_tvb_get_bits() - tvb_g_memdup()/ep_tvb_memdup() -> tvb_memdup() - tvb_fake_unicode()/tvb_get_ephemeral_faked_unicode() -> tvb_get_faked_unicode() - tvb_get_g_string()/tvb_get_ephemeral_string()/tvb_get_seasonal_string() -> tvb_get_string() - tvb_get_g_unicode_string()/tvb_get_ephemeral_unicode_string() -> tvb_get_unicode_string() - tvb_get_ephemeral_string_enc() -> tvb_get_string_enc() - update docs accordingly svn path=/trunk/; revision=52172
2013-03-13- [-Wmissing-prototypes]Anders Broman1-0/+4
- explicit casts. svn path=/trunk/; revision=48282
2013-01-31Comment out unused hf[] entries & etc.Bill Meier1-1/+3
(found by checkhf) svn path=/trunk/; revision=47389
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-3/+1
svn path=/trunk/; revision=45017
2012-06-28Update FSF address - part II.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43538
2012-05-19Fix some "warning: Value stored to '...' is never read" clang scan-build ↵Bill Meier1-5/+6
warnings. Also; Do some whitespace cleanup in a few cases. svn path=/trunk/; revision=42715
2011-10-11Fix benign bugs wherein proto_tree_add_uint() was intended instead of ↵Bill Meier1-1/+1
proto_tree_add_item(); (Replaces changes made in SVN #39351). svn path=/trunk/; revision=39361
2011-10-10 Fix benign bugs in some proto_tree_add_item() 'encoding' args;Bill Meier1-1/+1
svn path=/trunk/; revision=39351
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-6/+6
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39260
2011-05-27Treat TVBs as opaque: use the accessor functions instead of accessing the fieldsJeff Morriss1-43/+43
directly. svn path=/trunk/; revision=37420
2011-05-16Fix endian issues, especially w/endian arg to proto_tree_add_item().Chris Maynard1-31/+31
Should fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5464. svn path=/trunk/; revision=37188
2011-04-27From Yaniv Kaul: some 'set but not used' compilation fixes;Bill Meier1-18/+19
From me: - Remove unneeded #include <stdlib.h> and <ctype.h>; - Indentation cleanup. svn path=/trunk/; revision=36890
2010-10-07(Minor) Rename a few variables in the global namespace to be a bit more unique;Bill Meier1-12/+12
Also: rename additional (static) variables to be consistent with the above renames. svn path=/trunk/; revision=34412
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
2010-03-03remove check_colAnders Broman1-6/+4
svn path=/trunk/; revision=32089
2009-09-17From Gregor Jasny via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3921 :Jeff Morriss1-43/+113
Improved AIM protocol dissector: * Decodes more values acording to official Oscar spec * Renamed clientautoresp to client_err (as written in spec) * Fix decoding orror on rendezvous channel * Other small improvements svn path=/trunk/; revision=29953
2009-08-16Switch a bunch of dissectors over to using tvb_new_subset_remaining()Kovarththanan Rajaratnam1-2/+2
svn path=/trunk/; revision=29446
2009-07-07Changed flags_set_truth -> tfs_set_notsetStig Bjørlykke1-3/+3
svn path=/trunk/; revision=28989
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-27/+27
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-02-28From Alex Turbov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3291 :Jeff Morriss1-34/+28
SNAC(4,2) actually have uint32_t type of last field and its mean time in milliseconds svn path=/trunk/; revision=27566
2008-12-30From Gregor Jasny:Jaap Keuter1-4/+10
The dissect_aim_tlv_value_extended_data function does not work for iChat generated rendezvous data. So I switched back to the generic value display. Added another Rendezvous TLV name. svn path=/trunk/; revision=27138
2008-11-20From Gregor Jasny:Jaap Keuter1-0/+42
I've extended the AIM dissector with the information available from http://dev.aol.com/aim/oscar . I've verified most of the additions by sniffing my iChat (OSX 10.4) data traffic. svn path=/trunk/; revision=26813
2007-08-30From Chris Maynard:Anders Broman1-28/+28
Incorrect display filter field naming convention. svn path=/trunk/; revision=22742
2007-04-14fix MacOSX gcc-3.3 warnings about unused tfs/value_string variablesSebastien Tandel1-1/+1
most have been tagged unused (few have been deleted if dissector has not been modified since a long time) move packet-ssl-utils.c to DISSECTOR_SRC svn path=/trunk/; revision=21431
2007-03-24From Sebastien Tandel:Stephen Fisher1-6/+9
Fixes for warnings svn path=/trunk/; revision=21164
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-3/+3
svn path=/trunk/; revision=18196
2006-05-15From Jelmer Vernooij:Anders Broman1-1/+15
Add proper dissection for the Ack message in OSCAR's Messaging SNAC family. svn path=/trunk/; revision=18153
2005-08-28fix value_string terminationRonnie Sahlberg1-3/+3
svn path=/trunk/; revision=15574
2005-08-10rename ep_tvb_get_string() to tvb_get_ephemeral_string() asnd update the ↵Ronnie Sahlberg1-1/+1
documentation in README.developer svn path=/trunk/; revision=15270
2005-08-02Fix more "no previous declaration" warningsJörg Mayer1-2/+2
svn path=/trunk/; revision=15169
2005-07-24convert some uses of tvb_get_string() to ep_tvb_get_string()Ronnie Sahlberg1-1/+1
there was at least one obvious memleak in one of the uses of tvb_get_string() svn path=/trunk/; revision=15027
2005-07-13From Ilya Konstantinov :Anders Broman1-1/+2
fixes a tiny bug which caused the boolean fields not to refer to the same offset as their parent. svn path=/trunk/; revision=14914
2005-07-13From Ilya Konstantinov :Anders Broman1-4/+281
A patch to the AIM dissector to support Client Auto Response messages. I still don't know the meaning of all the fields as they weren't all mapped but this patch decodes all the important ones. svn path=/trunk/; revision=14911
2005-01-17If a given TLV type isn't found in an aim_tlv table, just use "Unknown"Guy Harris1-3/+3
as the description - some aim_tlv tables have NULL in the end-of-table entry. For those that don't, replace "Unknown" with NULL; "Unknown" is now redundant. svn path=/trunk/; revision=13084
2004-09-23From Jelmer Vernooij:Guy Harris1-12/+82
- Dissect ICQ TLV values - Dissect channel 1 and channel 2 messages correctly in Oscar (required for dissecting direct connections) svn path=/trunk/; revision=12072
2004-09-22From Jelmer Vernooij:Guy Harris1-5/+1
- Dissect the DC (Direct Connection) info structure - Dissect the complete buddy icon family (you can now save buddy icons as .JPG's/.PNG's directly from the capture using the "Export selected bytes..." option!) - Add a function that dissects a sequence of TLV's instead of having while() loops all over the place. svn path=/trunk/; revision=12063
2004-09-21From Jelmer Vernooij:Guy Harris1-203/+173
Remove some code duplication from the Oscar dissector (reduces the number of lines by 500) by providing a custom registration function for oscar families (aim_init_family). This also fixes a number of issues with column names. Add minor updates such as adding support for the Capability Info TLV on users. svn path=/trunk/; revision=12060
generated by cgit v1.2.3 (git 2.25.1) at 2024-08-25 01:57:43 +0000