aboutsummaryrefslogtreecommitdiffstats
path: root/epan/dissectors/packet-agentx.c
AgeCommit message (Collapse)AuthorFilesLines
2013-03-12svn path=/trunk/; revision=48272Anders Broman1-0/+1
2013-01-31Comment out unused hf[] entries & etc.Bill Meier1-1/+3
(found by checkhf) svn path=/trunk/; revision=47389
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45017
2012-08-10Use val_to_str_const() where appropriate;Bill Meier1-50/+52
Also (for a few files): - create/use some extended value strings; - remove unneeded #include files; - remove unneeded variable initialization; - re-order fcns slightly so prefs_reg_handoff...() at end, etc svn path=/trunk/; revision=44438
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-04-09Add missing const attribute to some char *Jakub Zawadzki1-2/+2
Fix some "assignment discards qualifiers from pointer target type", etc svn path=/trunk/; revision=41993
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-15Convert proto_tree_add_item() 'encoding' arg for field types FT_STRING, ↵Bill Meier1-1/+1
FT_STRINGZ, FT_UINT_STRING as follows: 1. If there's no character encoding (ENC_ASCII, ...) specified then use ENC_ASCII. 2. For all but FT_UINT_STRING, always use ENC_NA (replacing any existing True/1/FALSE/0 /ENC_BIG_ENDIAN/ENC_LITTLE_ENDIAN). svn path=/trunk/; revision=39426
2011-09-22Use ENC_ values in proto_tree_add_item() calls.Guy Harris1-44/+46
In the AgentX dissector, make the "flags" arguments guint8, to match what's passed in. In the AIM dissector, use val_to_str() in col_add_str() calls - it gives the same result if there's a match, and puts a note in the Info column if there isn't, and is less complicated. In the AJP13 dissector: update the URL for the protocol documentation; add #defines for message types, and use them; for "enumerated data type" fields, make the fields numerical rather than strings and give them the value_string tables; get rid of col_check() calls; make a Boolean item an FT_BOOLEAN. svn path=/trunk/; revision=39085
2011-04-21Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-9/+19
svn path=/trunk/; revision=36769
2011-04-21Fix Dead Store (Dead nested assignment) Warning found by Clang Alexis La Goutte1-1/+1
svn path=/trunk/; revision=36752
2011-03-17From Jakub Zawadzki: Simpler patch to resolve bug 5755 to properly display allChris Maynard1-3/+1
strings in dissect_octet_string() without having to allocate extra memory. svn path=/trunk/; revision=36207
2011-03-16From Fulko Hew via bug 5755: Fix dissect_octet_string() so it properly displaysChris Maynard1-7/+3
strings of any length. svn path=/trunk/; revision=36199
2011-02-23From Fulko Hew via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5709 :Jeff Morriss1-1/+2
When Wireshark receives an AgentX Ping-PDU that contains a zero length 'context' identifier it emits the following warning: 14:30:20 Warn Dissector bug, protocol AgentX, in packet 1066: tvbuff.c:2571: failed assertion "bufsize != 0" The attached patch prevents the warning message from appearing under that circumstance. Note: This patch will also prevent the warning under all other conditions where a zero length string is specified anywhere in the protocol dissector. svn path=/trunk/; revision=36034
2011-02-13From Fulko Hew:Jaap Keuter1-0/+2
The 'upper bound field is not being displayed in Register and Unregister PDU's. svn path=/trunk/; revision=35943
2011-01-12From Fulko Hew:Jaap Keuter1-20/+31
Improved the decoding of OID search ranges in AgentX dissector: 1/ OID highlighting on first OID of a range was too long. The code incorrectly used the length of the printable string instead of the length of the source data. 2/ Added bitwise dissection of the 'include' field of an OID decoding. 3/ Added corrected 'start/end' range information to SearchRange decoding to discriminate between an 'end' indicator (old way) and the new way that shows both an inclusive/exclusive indicator as well as a start/end range indicator. (applicable to getnext/getbulk requests). svn path=/trunk/; revision=35500
2010-12-20Rename the routines that handle dissector tables with unsigned integerGuy Harris1-2/+2
keys to have _uint in their names, to match the routines that handle dissector tables with string keys. (Using _port can confuse people into thinking they're intended solely for use with TCP/UDP/etc. ports when, in fact, they work better for things such as Ethernet types, where the binding of particular values to particular protocols are a lot stronger.) svn path=/trunk/; revision=35224
2010-12-07From Fulko Hew via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5438 :Jeff Morriss1-79/+141
Various fixes for AgentX protocol decoding: 1/ Fixed the decode of get & getnext PDU to correctly iterate over range lists. 2/ Re-adjust PDU header highlighting to hightlight all 20 octets instead of only the first 4. 3/ Altered the decode hierarchy so that PDU bodys are no longer a sub-component of the PDU header, but is now at the same level as the header. 4/ Corrected the highlighted length of decoded OIDs. 5/ Added bitwise decoding of the PDU 'flag' octet. From me: - Remove unnecessary includes. - Some indentation/white space cleanup. - Remove (new) duplicate blurbs svn path=/trunk/; revision=35141
2010-11-03From Fulko Hew:Jaap Keuter1-2/+1
According to RFC 2741 section 6.2.1 the Open-PDU can have an o.id field containing a 'null' identifier. The dissector currently does not handle it and causes other (misleading) error messages to appear on the decode window. svn path=/trunk/; revision=34765
2010-11-03From Fulko Hew:Jaap Keuter1-1/+1
The hex field highlighting when the 'PDU Header' sub-tree is selected highlights 5 octets rather than the correct 4 (only) octets. svn path=/trunk/; revision=34762
2010-10-01Changing the flag bitmasks to their proper values (see ↵Sake Blok1-5/+5
http://www.faqs.org/rfcs/rfc2741.html). This fixes part of bug 5269. svn path=/trunk/; revision=34316
2010-05-10Indentation & whitespace cleanup (including: "4 space tabs" ==> spaces)Bill Meier1-306/+306
svn path=/trunk/; revision=32735
2010-04-03Remove unneeded #include <stdio.h>Bill Meier1-1/+0
svn path=/trunk/; revision=32367
2010-03-03remove check_colAnders Broman1-3/+2
svn path=/trunk/; revision=32089
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-18/+18
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-05-01From Reinhard Speyerer:Jaap Keuter1-2/+2
This patch fixes several misspellings/typos in Wireshark SVN revision 28201. svn path=/trunk/; revision=28207
2009-02-22Incorporate plugin dissector into build in collection.Jaap Keuter1-0/+1111
svn path=/trunk/; revision=27506
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 23:04:12 +0000